cleanup work

querydsl/src/main/java/org/baeldung/dao/PersonDao.java

@@ -1,11 +1,10 @@
 package org.baeldung.dao;
 
-import org.baeldung.entity.Person;
-
-import javax.persistence.Tuple;
 import java.util.List;
 import java.util.Map;
 
+import org.baeldung.entity.Person;
+
 public interface PersonDao {
 
     public Person save(Person person);

querydsl/src/main/java/org/baeldung/dao/PersonDaoImpl.java

@@ -1,18 +1,17 @@
 package org.baeldung.dao;
 
-import com.mysema.query.group.GroupBy;
-import com.mysema.query.jpa.impl.JPAQuery;
-import com.mysema.query.jpa.impl.JPAQueryFactory;
+import java.util.List;
+import java.util.Map;
+
+import javax.persistence.EntityManager;
+import javax.persistence.PersistenceContext;
+
 import org.baeldung.entity.Person;
 import org.baeldung.entity.QPerson;
 import org.springframework.stereotype.Repository;
 
-import javax.inject.Provider;
-import javax.persistence.EntityManager;
-import javax.persistence.PersistenceContext;
-import javax.persistence.Tuple;
-import java.util.List;
-import java.util.Map;
+import com.mysema.query.group.GroupBy;
+import com.mysema.query.jpa.impl.JPAQuery;
 
 @Repository
 public class PersonDaoImpl implements PersonDao {
@@ -20,49 +19,48 @@ public class PersonDaoImpl implements PersonDao {
     @PersistenceContext
     private EntityManager em;
 
-    public Person save(Person person) {
+    @Override
+    public Person save(final Person person) {
         em.persist(person);
         return person;
     }
 
     @Override
-    public List<Person> findPersonsByFirstnameQueryDSL(String firstname) {
-        JPAQuery query = new JPAQuery(em);
-        QPerson person = QPerson.person;
+    public List<Person> findPersonsByFirstnameQueryDSL(final String firstname) {
+        final JPAQuery query = new JPAQuery(em);
+        final QPerson person = QPerson.person;
 
         return query.from(person).where(person.firstname.eq(firstname)).list(person);
     }
 
     @Override
-    public List<Person> findPersonsByFirstnameAndSurnameQueryDSL(String firstname, String surname) {
-        JPAQuery query = new JPAQuery(em);
-        QPerson person = QPerson.person;
+    public List<Person> findPersonsByFirstnameAndSurnameQueryDSL(final String firstname, final String surname) {
+        final JPAQuery query = new JPAQuery(em);
+        final QPerson person = QPerson.person;
 
-        return query.from(person).where(person.firstname.eq(firstname).and(
-                person.surname.eq(surname))).list(person);
+        return query.from(person).where(person.firstname.eq(firstname).and(person.surname.eq(surname))).list(person);
     }
 
     @Override
-    public List<Person> findPersonsByFirstnameInDescendingOrderQueryDSL(String firstname) {
-        JPAQuery query = new JPAQuery(em);
-        QPerson person = QPerson.person;
+    public List<Person> findPersonsByFirstnameInDescendingOrderQueryDSL(final String firstname) {
+        final JPAQuery query = new JPAQuery(em);
+        final QPerson person = QPerson.person;
 
-        return query.from(person).where(person.firstname.eq(firstname)).orderBy(
-                person.surname.desc()).list(person);
+        return query.from(person).where(person.firstname.eq(firstname)).orderBy(person.surname.desc()).list(person);
     }
 
     @Override
     public int findMaxAge() {
-        JPAQuery query = new JPAQuery(em);
-        QPerson person = QPerson.person;
+        final JPAQuery query = new JPAQuery(em);
+        final QPerson person = QPerson.person;
 
         return query.from(person).list(person.age.max()).get(0);
     }
 
     @Override
     public Map<String, Integer> findMaxAgeByName() {
-        JPAQuery query = new JPAQuery(em);
-        QPerson person = QPerson.person;
+        final JPAQuery query = new JPAQuery(em);
+        final QPerson person = QPerson.person;
 
         return query.from(person).transform(GroupBy.groupBy(person.firstname).as(GroupBy.max(person.age)));
     }

querydsl/src/main/java/org/baeldung/entity/Person.java

@@ -1,6 +1,10 @@
 package org.baeldung.entity;
 
-import javax.persistence.*;
+import javax.persistence.Column;
+import javax.persistence.Entity;
+import javax.persistence.GeneratedValue;
+import javax.persistence.GenerationType;
+import javax.persistence.Id;
 
 @Entity
 public class Person {
@@ -21,12 +25,12 @@ public class Person {
     Person() {
     }
 
-    public Person(String firstname, String surname) {
+    public Person(final String firstname, final String surname) {
         this.firstname = firstname;
         this.surname = surname;
     }
 
-    public Person(String firstname, String surname, int age) {
+    public Person(final String firstname, final String surname, final int age) {
         this(firstname, surname);
         this.age = age;
     }
@@ -35,7 +39,7 @@ public class Person {
         return id;
     }
 
-    public void setId(Long id) {
+    public void setId(final Long id) {
         this.id = id;
     }
 
@@ -43,7 +47,7 @@ public class Person {
         return firstname;
     }
 
-    public void setFirstname(String firstname) {
+    public void setFirstname(final String firstname) {
         this.firstname = firstname;
     }
 
@@ -51,7 +55,7 @@ public class Person {
         return surname;
     }
 
-    public void setSurname(String surname) {
+    public void setSurname(final String surname) {
         this.surname = surname;
     }
 
@@ -59,7 +63,7 @@ public class Person {
         return age;
     }
 
-    public void setAge(int age) {
+    public void setAge(final int age) {
         this.age = age;
     }
 }