From efaf789e71e2083bfdb9b0467536569da425ac86 Mon Sep 17 00:00:00 2001 From: Alex Golub Date: Wed, 20 Apr 2022 13:58:33 +0300 Subject: [PATCH] JUnit5 test classes and methods should have default package visibility --- .../java/com/baeldung/ExceptionUnitTest.java | 12 ++++++------ .../src/test/java/com/baeldung/LiveTest.java | 18 +++++++++--------- .../migration/junit5/AssumptionUnitTest.java | 16 +++++++--------- 3 files changed, 22 insertions(+), 24 deletions(-) diff --git a/testing-modules/junit-5-basics/src/test/java/com/baeldung/ExceptionUnitTest.java b/testing-modules/junit-5-basics/src/test/java/com/baeldung/ExceptionUnitTest.java index 440c3e40ab..7b7c11ccad 100644 --- a/testing-modules/junit-5-basics/src/test/java/com/baeldung/ExceptionUnitTest.java +++ b/testing-modules/junit-5-basics/src/test/java/com/baeldung/ExceptionUnitTest.java @@ -1,16 +1,16 @@ package com.baeldung; -import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.jupiter.api.Assertions.assertThrows; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.function.Executable; import java.util.ConcurrentModificationException; import java.util.HashMap; import java.util.Map; -import org.junit.jupiter.api.Test; -import org.junit.jupiter.api.function.Executable; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; -public class ExceptionUnitTest { +class ExceptionUnitTest { @Test void shouldThrowException() { @@ -29,7 +29,7 @@ public class ExceptionUnitTest { } @Test - public void whenModifyMapDuringIteration_thenThrowExecption() { + void whenModifyMapDuringIteration_thenThrowExecption() { Map hashmap = new HashMap<>(); hashmap.put(1, "One"); hashmap.put(2, "Two"); diff --git a/testing-modules/junit-5-basics/src/test/java/com/baeldung/LiveTest.java b/testing-modules/junit-5-basics/src/test/java/com/baeldung/LiveTest.java index c23eeb5afa..524ea58328 100644 --- a/testing-modules/junit-5-basics/src/test/java/com/baeldung/LiveTest.java +++ b/testing-modules/junit-5-basics/src/test/java/com/baeldung/LiveTest.java @@ -1,28 +1,28 @@ package com.baeldung; -import static org.junit.jupiter.api.Assertions.assertEquals; +import org.junit.jupiter.api.DynamicTest; +import org.junit.jupiter.api.TestFactory; import java.util.ArrayList; import java.util.Arrays; import java.util.List; import java.util.stream.Stream; -import org.junit.jupiter.api.DynamicTest; -import org.junit.jupiter.api.TestFactory; +import static org.junit.jupiter.api.Assertions.assertEquals; -public class LiveTest { +class LiveTest { private List in = new ArrayList<>(Arrays.asList("Hello", "Yes", "No")); private List out = new ArrayList<>(Arrays.asList("Cześć", "Tak", "Nie")); @TestFactory - public Stream translateDynamicTestsFromStream() { + Stream translateDynamicTestsFromStream() { return in.stream() - .map(word -> DynamicTest.dynamicTest("Test translate " + word, () -> { - int id = in.indexOf(word); - assertEquals(out.get(id), translate(word)); - })); + .map(word -> DynamicTest.dynamicTest("Test translate " + word, () -> { + int id = in.indexOf(word); + assertEquals(out.get(id), translate(word)); + })); } private String translate(String word) { diff --git a/testing-modules/junit-5-basics/src/test/java/com/baeldung/migration/junit5/AssumptionUnitTest.java b/testing-modules/junit-5-basics/src/test/java/com/baeldung/migration/junit5/AssumptionUnitTest.java index 80201a3f44..c1eba0d557 100644 --- a/testing-modules/junit-5-basics/src/test/java/com/baeldung/migration/junit5/AssumptionUnitTest.java +++ b/testing-modules/junit-5-basics/src/test/java/com/baeldung/migration/junit5/AssumptionUnitTest.java @@ -1,28 +1,26 @@ package com.baeldung.migration.junit5; -import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.jupiter.api.Assumptions.assumeFalse; -import static org.junit.jupiter.api.Assumptions.assumeTrue; -import static org.junit.jupiter.api.Assumptions.assumingThat; - import org.junit.jupiter.api.Test; -public class AssumptionUnitTest { +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assumptions.*; + +class AssumptionUnitTest { @Test - public void trueAssumption() { + void trueAssumption() { assumeTrue(5 > 1, () -> "5 is greater the 1"); assertEquals(5 + 2, 7); } @Test - public void falseAssumption() { + void falseAssumption() { assumeFalse(5 < 1, () -> "5 is less then 1"); assertEquals(5 + 2, 7); } @Test - public void assumptionThat() { + void assumptionThat() { String someString = "Just a string"; assumingThat(someString.equals("Just a string"), () -> assertEquals(2 + 2, 4)); }