From faddb1d62cfdaefe1f948cf09c514144f2d099d9 Mon Sep 17 00:00:00 2001 From: MohamedHelmyKassab <137485958+MohamedHelmyKassab@users.noreply.github.com> Date: Wed, 18 Oct 2023 05:03:31 +0300 Subject: [PATCH] Update CenteringTextUnitTest.java (#15011) This commit aims to add new updates to the class "CenteringTextUnitTest" based on the review process recommendations. --- .../centertext/CenteringTextUnitTest.java | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/core-java-modules/core-java-string-operations-7/src/test/java/com/baeldung/centertext/CenteringTextUnitTest.java b/core-java-modules/core-java-string-operations-7/src/test/java/com/baeldung/centertext/CenteringTextUnitTest.java index ff53d8b3fa..a3f95b0181 100644 --- a/core-java-modules/core-java-string-operations-7/src/test/java/com/baeldung/centertext/CenteringTextUnitTest.java +++ b/core-java-modules/core-java-string-operations-7/src/test/java/com/baeldung/centertext/CenteringTextUnitTest.java @@ -3,6 +3,7 @@ package com.baeldung.centertext; import liquibase.repackaged.org.apache.commons.lang3.StringUtils; import org.junit.Assert; import org.junit.jupiter.api.Test; + import static org.junit.Assert.assertEquals; public class CenteringTextUnitTest { @@ -10,17 +11,16 @@ public class CenteringTextUnitTest { @Test public void givenTextAndTotalWidth_whenUsingStringFormat_thenTextIsCentered() { String text = "Centered Text"; - int totalWidth = 20; + int totalWidth = 15; int padding = (totalWidth - text.length()) / 2; String centeredText = String.format("%" + padding + "s%s%" + padding + "s", "", text, ""); - String expectedCenteredText = " Centered Text "; - Assert.assertEquals("Centered Text", expectedCenteredText, centeredText); + Assert.assertEquals(" Centered Text ", centeredText); } @Test public void givenTextAndTotalWidth_whenCenterUsingStringBuilder_thenTextIsCentered() { String text = "Centered Text"; - int width = 20; + int width = 15; int padding = (width - text.length()) / 2; StringBuilder centeredText = new StringBuilder(); for (int i = 0; i < padding; i++) { @@ -31,17 +31,15 @@ public class CenteringTextUnitTest { centeredText.append(" "); } String centeredTextString = centeredText.toString(); - String expectedCenteredText = " Centered Text "; - Assert.assertEquals("Centered Text", expectedCenteredText, centeredTextString); + Assert.assertEquals(" Centered Text ", centeredTextString); } @Test public void givenTextAndTotalWidth_whenUsingStringUtilsCenterMethod_thenTextIsCentered() { String text = "Centered Text"; - int width = 20; + int width = 15; String centeredText = StringUtils.center(text, width); - String expectedCenteredText = StringUtils.center("Centered Text", width); - assertEquals("Centered Text", expectedCenteredText, centeredText); + assertEquals(" Centered Text ", centeredText); } -} \ No newline at end of file +}