From d7d7c1ea54517e5aebd21db6829aa9332c4183a7 Mon Sep 17 00:00:00 2001 From: balasr3 Date: Sun, 21 Jan 2024 20:17:19 +0000 Subject: [PATCH] BAEL-7272: Fixed based on review comments --- .../controller/OrderController.java | 4 +- .../deserialization/model/OrderResponse.java | 55 +------------------ 2 files changed, 5 insertions(+), 54 deletions(-) diff --git a/spring-reactive-modules/spring-reactive-3/src/main/java/com/baeldung/custom/deserialization/controller/OrderController.java b/spring-reactive-modules/spring-reactive-3/src/main/java/com/baeldung/custom/deserialization/controller/OrderController.java index 1f6cfc1e22..20327333f1 100644 --- a/spring-reactive-modules/spring-reactive-3/src/main/java/com/baeldung/custom/deserialization/controller/OrderController.java +++ b/spring-reactive-modules/spring-reactive-3/src/main/java/com/baeldung/custom/deserialization/controller/OrderController.java @@ -23,13 +23,13 @@ public class OrderController { } @GetMapping(value = "v1/order/{id}", produces = MediaType.APPLICATION_JSON_VALUE) - public Mono searchOrderV1(@PathVariable(value = "id") int id) { + public final Mono searchOrderV1(@PathVariable(value = "id") int id) { return externalServiceV1.findById(id) .bodyToMono(OrderResponse.class); } @GetMapping(value = "v2/order/{id}", produces = MediaType.APPLICATION_JSON_VALUE) - public Mono searchOrderV2(@PathVariable(value = "id") int id) { + public final Mono searchOrderV2(@PathVariable(value = "id") int id) { return externalServiceV2.findById(id) .bodyToMono(OrderResponse.class); } diff --git a/spring-reactive-modules/spring-reactive-3/src/main/java/com/baeldung/custom/deserialization/model/OrderResponse.java b/spring-reactive-modules/spring-reactive-3/src/main/java/com/baeldung/custom/deserialization/model/OrderResponse.java index 8578acfa2a..18d45e7dba 100644 --- a/spring-reactive-modules/spring-reactive-3/src/main/java/com/baeldung/custom/deserialization/model/OrderResponse.java +++ b/spring-reactive-modules/spring-reactive-3/src/main/java/com/baeldung/custom/deserialization/model/OrderResponse.java @@ -4,22 +4,11 @@ import java.time.LocalDateTime; import java.util.List; import java.util.UUID; +import lombok.Data; + +@Data public class OrderResponse { - public OrderResponse(UUID orderId, LocalDateTime orderDateTime, List address, List orderNotes) { - this.orderId = orderId; - this.orderDateTime = orderDateTime; - this.address = address; - this.orderNotes = orderNotes; - } - - public OrderResponse() { - this.orderId = null; - this.orderDateTime = null; - this.address = null; - this.orderNotes = null; - } - private UUID orderId; private LocalDateTime orderDateTime; @@ -27,42 +16,4 @@ public class OrderResponse { private List address; private List orderNotes; - - public UUID getOrderId() { - return orderId; - } - - public void setOrderId(UUID orderId) { - this.orderId = orderId; - } - - public LocalDateTime getOrderDateTime() { - return orderDateTime; - } - - public void setOrderDate(LocalDateTime orderDateTime) { - this.orderDateTime = orderDateTime; - } - - public List getAddress() { - return address; - } - - public void setAddress(List address) { - this.address = address; - } - - public List getOrderNotes() { - return orderNotes; - } - - public void setOrderNotes(List orderNotes) { - this.orderNotes = orderNotes; - } - - @Override - public String toString() { - return "OrderResponse{" + "orderId=" + orderId + ", orderDateTime=" + orderDateTime + ", address=" + address + ", orderNotes=" + orderNotes + '}'; - } - }