From ee63f1c19d8b355e468b6c84a899bca0611880b6 Mon Sep 17 00:00:00 2001 From: Pedro Lopes Date: Fri, 5 Apr 2024 11:01:26 -0300 Subject: [PATCH] adding null checks for assertions. reducing total number of consumed messages (#15711) --- ...ManagingConsumerGroupsIntegrationTest.java | 21 ++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/spring-kafka-2/src/test/java/com/baeldung/spring/kafka/managingkafkaconsumergroups/ManagingConsumerGroupsIntegrationTest.java b/spring-kafka-2/src/test/java/com/baeldung/spring/kafka/managingkafkaconsumergroups/ManagingConsumerGroupsIntegrationTest.java index 6103fa884d..8fa07e4901 100644 --- a/spring-kafka-2/src/test/java/com/baeldung/spring/kafka/managingkafkaconsumergroups/ManagingConsumerGroupsIntegrationTest.java +++ b/spring-kafka-2/src/test/java/com/baeldung/spring/kafka/managingkafkaconsumergroups/ManagingConsumerGroupsIntegrationTest.java @@ -8,11 +8,13 @@ import org.springframework.kafka.config.KafkaListenerEndpointRegistry; import org.springframework.kafka.core.KafkaTemplate; import org.springframework.kafka.listener.MessageListenerContainer; import org.springframework.kafka.test.context.EmbeddedKafka; +import org.springframework.util.CollectionUtils; import java.util.Objects; import org.springframework.test.annotation.DirtiesContext; import org.springframework.test.annotation.DirtiesContext.ClassMode; import org.springframework.test.context.ActiveProfiles; +import java.util.Set; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertTrue; @@ -24,8 +26,8 @@ import static org.junit.jupiter.api.Assertions.assertTrue; public class ManagingConsumerGroupsIntegrationTest { private static final String CONSUMER_1_IDENTIFIER = "org.springframework.kafka.KafkaListenerEndpointContainer#1"; - private static final int TOTAL_PRODUCED_MESSAGES = 50000; - private static final int MESSAGE_WHERE_CONSUMER_1_LEAVES_GROUP = 10000; + private static final int TOTAL_PRODUCED_MESSAGES = 5000; + private static final int MESSAGE_WHERE_CONSUMER_1_LEAVES_GROUP = 10; @Autowired KafkaTemplate kafkaTemplate; @@ -57,11 +59,16 @@ public class ManagingConsumerGroupsIntegrationTest { } } while (currentMessage != TOTAL_PRODUCED_MESSAGES); Thread.sleep(2000); - if (consumerService.consumedPartitions != null - && consumerService.consumedPartitions.get("consumer-1") != null - && consumerService.consumedPartitions.get("consumer-0") != null) { - assertTrue(consumerService.consumedPartitions.get("consumer-1").size() >= 1); - assertTrue( consumerService.consumedPartitions.get("consumer-0").size() >= 1); + + Set partitionsConsumedBy1 = consumerService.consumedPartitions.get("consumer-1"); + Set partitionsConsumedBy0 = consumerService.consumedPartitions.get("consumer-0"); + + if (!CollectionUtils.isEmpty(partitionsConsumedBy0)) { + assertEquals(2, partitionsConsumedBy0.size()); + } + + if (!CollectionUtils.isEmpty(partitionsConsumedBy1)) { + assertEquals(1, partitionsConsumedBy1.size()); } } }