Apache/struts
1
0
Fork 0
mirror of https://github.com/apache/struts.git synced 2026-08-31 19:35:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

WW-3597 - XSS vulnerability in javatemplates plugin (thanks Gareth Faires)

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@1084872 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Maurizio Cucchiara
2011-03-24 08:11:57 +00:00
parent 38a856d9f3
commit 1736b56db7
8 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/FileHandler.java
+1 -1
View File
@@ -35,7 +35,7 @@ public class FileHandler extends AbstractTagHandler implements TagGenerator {
a.addDefaultToEmpty("name", params.get("name"))
.add("type", "file")
.addIfExists("size", params.get("size"))
.addIfExists("value", params.get("nameValue"), false)
.addIfExists("value", params.get("nameValue"))
.addIfTrue("disabled", params.get("disabled"))
.addIfExists("accept", params.get("accept"))
.addIfExists("tabindex", params.get("tabindex"))
plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/HiddenHandler.java
+1 -1
View File
@@ -34,7 +34,7 @@ public class HiddenHandler extends AbstractTagHandler implements TagGenerator {
a.addDefaultToEmpty("name", params.get("name"))
.add("type", "hidden")
.addIfExists("value", params.get("nameValue"), false)
.addIfExists("value", params.get("nameValue"))
.addIfTrue("disabled", params.get("disabled"))
.addIfExists("id", params.get("id"))
.addIfExists("class", params.get("cssClass"))
plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/PasswordHandler.java
+1 -1
View File
@@ -34,7 +34,7 @@ public class PasswordHandler extends AbstractTagHandler implements TagGenerator
Boolean showPassword = (Boolean) params.get("showPassword");
if (showPassword != null && showPassword)
attrs.addIfExists("value", params.get("nameValue"), false);
attrs.addIfExists("value", params.get("nameValue"));
attrs.addDefaultToEmpty("name", params.get("name"))
.add("type", "password")
plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/RadioHandler.java
+1 -1
View File
@@ -79,7 +79,7 @@ public class RadioHandler extends AbstractTagHandler implements TagGenerator {
a.add("type", "radio")
.addDefaultToEmpty("name", params.get("name"))
.addIfTrue("checked", checked)
.addIfExists("value", itemKeyStr, false)
.addIfExists("value", itemKeyStr)
.addIfTrue("disabled", params.get("disabled"))
.addIfExists("tabindex", params.get("tabindex"))
.addIfExists("id", id);
plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/ResetHandler.java
+1 -1
View File
@@ -37,7 +37,7 @@ public class ResetHandler extends AbstractTagHandler implements TagGenerator {
attrs.addDefaultToEmpty("name", params.get("name"))
.add("type", "reset")
.addIfExists("value", params.get("nameValue"), false)
.addIfExists("value", params.get("nameValue"))
.addIfExists("tabindex", params.get("tabindex"))
.addIfExists("id", params.get("id"))
.addIfExists("class", params.get("cssClass"))
plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/SelectHandler.java
+1 -1
View File
@@ -43,7 +43,7 @@ public class SelectHandler extends AbstractTagHandler implements TagGenerator {
a.addDefaultToEmpty("name", params.get("name"))
.addIfExists("size", params.get("size"))
.addIfExists("value", value, false)
.addIfExists("value", value)
.addIfTrue("disabled", params.get("disabled"))
.addIfTrue("readonly", params.get("readonly"))
.addIfTrue("multiple", params.get("multiple"))
plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/SubmitHandler.java
+3 -3
View File
@@ -38,7 +38,7 @@ public class SubmitHandler extends AbstractTagHandler implements TagGenerator {
if ("button".equals(type)) {
attrs.addIfExists("name", params.get("name"))
.add("type", "submit")
.addIfExists("value", params.get("nameValue"), false)
.addIfExists("value", params.get("nameValue"))
.addIfTrue("disabled", params.get("disabled"))
.addIfExists("tabindex", params.get("tabindex"))
.addIfExists("id", params.get("id"))
@@ -47,7 +47,7 @@ public class SubmitHandler extends AbstractTagHandler implements TagGenerator {
start("button", attrs);
} else if ("image".equals(type)) {
attrs.addIfExists("src", params.get("src"), false)
attrs.addIfExists("src", params.get("src"))
.add("type", "image")
.addIfExists("alt", params.get("label"))
.addIfExists("id", params.get("id"))
@@ -57,7 +57,7 @@ public class SubmitHandler extends AbstractTagHandler implements TagGenerator {
} else {
attrs.addIfExists("name", params.get("name"))
.add("type", "submit")
.addIfExists("value", params.get("nameValue"), false)
.addIfExists("value", params.get("nameValue"))
.addIfTrue("disabled", params.get("disabled"))
.addIfExists("tabindex", params.get("tabindex"))
.addIfExists("id", params.get("id"))
plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/TextFieldHandler.java
+1 -1
View File
@@ -36,7 +36,7 @@ public class TextFieldHandler extends AbstractTagHandler implements TagGenerator
.addDefaultToEmpty("name", params.get("name"))
.addIfExists("size", params.get("size"))
.addIfExists("maxlength", params.get("maxlength"))
.addIfExists("value", params.get("nameValue"), false)
.addIfExists("value", params.get("nameValue"))
.addIfTrue("disabled", params.get("disabled"))
.addIfTrue("readonly", params.get("readonly"))
.addIfExists("tabindex", params.get("tabindex"))