Apache/struts
1
0
Fork 0
mirror of https://github.com/apache/struts.git synced 2026-08-07 07:37:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

WW-4945 Logs missing action invocation as WARN

Browse Source
This commit is contained in:
Lukasz Lenart
2021-01-02 18:44:55 +01:00
parent 213990944f
commit dcc53aebf9
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/main/java/org/apache/struts2/views/jsp/TagUtils.java
+7
View File
@@ -23,6 +23,8 @@ import com.opensymphony.xwork2.ActionInvocation;
import com.opensymphony.xwork2.config.ConfigurationException;
import com.opensymphony.xwork2.util.ValueStack;
import com.opensymphony.xwork2.util.ValueStackFactory;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.struts2.RequestUtils;
import org.apache.struts2.ServletActionContext;
import org.apache.struts2.dispatcher.ApplicationMap;
@@ -41,6 +43,8 @@ import java.util.Map;
public class TagUtils {
private static final Logger LOG = LogManager.getLogger(TagUtils.class);
public static ValueStack getStack(PageContext pageContext) {
HttpServletRequest req = (HttpServletRequest) pageContext.getRequest();
ValueStack stack = ServletActionContext.getValueStack(req);
@@ -88,6 +92,9 @@ public class TagUtils {
ActionInvocation invocation = context.getActionInvocation();
if (invocation == null) {
TagUtils.LOG.warn("ActionInvocation is null, tag has been executed out of the Action and this can lead " +
"to a security vulnerability, please read http://struts.apache.org/security/#never-expose-jsp-files-directly !");
ActionMapping mapping = mapper.getMapping(request,
Dispatcher.getInstance().getConfigurationManager());