Apache/struts
1
0
Fork 0
mirror of https://github.com/apache/struts.git synced 2026-08-07 07:37:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adds WARN to avoid using java.io.File

Browse Source
This commit is contained in:
Lukasz Lenart
2016-11-22 17:44:02 +01:00
parent 3fd909668a
commit e152c15f78
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/main/java/org/apache/struts2/conversion/UploadedFileConverter.java
+7
View File
@@ -20,6 +20,8 @@
package org.apache.struts2.conversion;
import com.opensymphony.xwork2.conversion.impl.DefaultTypeConverter;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.struts2.dispatcher.multipart.UploadedFile;
import java.io.File;
@@ -29,9 +31,14 @@ import java.util.Map;
public class UploadedFileConverter extends DefaultTypeConverter {
private static final Logger LOG = LogManager.getLogger(UploadedFileConverter.class);
@Override
public Object convertValue(Map<String, Object> context, Object target, Member member, String propertyName, Object value, Class toType) {
if (File.class.equals(toType)) {
LOG.warn("Converting {} into {}, consider switching to {} and do not access {} directly!",
File.class.getName(), UploadedFile.class.getName(), UploadedFile.class.getName(), File.class.getName());
if (value.getClass().isArray() && Array.getLength(value) == 1) {
Object obj = Array.get(value, 0);
if (obj instanceof UploadedFile) {