Commit Graph

2139 Commits

Author SHA1 Message Date
Musachy Barroso 7ebff0ee12 WW-2901 Set the default includeParams to "none" (is currently "get")
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@722957 13f79535-47bb-0310-9956-ffa450edef68
2008-12-03 16:24:56 +00:00
Musachy Barroso ae2f937761 WW-2580 Add filename argument to acceptFile method in FileUploadInterceptor. Unused overload of acceptFile was also removed.
Thanks to Jelmer Kuperus for the patch (applied with some modifications).

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@722956 13f79535-47bb-0310-9956-ffa450edef68
2008-12-03 16:23:43 +00:00
Musachy Barroso 2e82cb684c Update type of tag attribute "resultsLimit" for autocompleter
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@722904 13f79535-47bb-0310-9956-ffa450edef68
2008-12-03 14:34:23 +00:00
Musachy Barroso 6e131b75f3 WW-2902 Use real HttpSession in synchronized block
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@722576 13f79535-47bb-0310-9956-ffa450edef68
2008-12-02 19:13:26 +00:00
Wesley Wannemacher c8397a1188 incorporating Concurrency API. Per WW-2880, thanks for the patch Mathias Bogaert
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@722386 13f79535-47bb-0310-9956-ffa450edef68
2008-12-02 06:41:52 +00:00
Wesley Wannemacher aebc654a59 moving CSS class declaration to the UL tag to make styling more flexible. Per WW-2655
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@722375 13f79535-47bb-0310-9956-ffa450edef68
2008-12-02 05:19:57 +00:00
David Newton 4bc9f8f62d Updated URL component's default value documentation to reflect WW-2901 change; now "none".
I don't think I like this lack of cohesion in cases like this; if the default value is coming from a default configuration file then documenting it manually with @StrutsTagAttribute seems dangerous and potentially misleading.

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@722331 13f79535-47bb-0310-9956-ffa450edef68
2008-12-02 02:04:42 +00:00
David Newton 157eacdecd Includes test update; changing struts.properties requires non-intuitive test change :/
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@722328 13f79535-47bb-0310-9956-ffa450edef68
2008-12-02 01:56:24 +00:00
Musachy Barroso 768f3973c2 WW-2671 Add fieldName attribute to FieldErrorTag
Thanks to David Evans for the patch

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@722198 13f79535-47bb-0310-9956-ffa450edef68
2008-12-01 19:49:00 +00:00
Musachy Barroso 10e69d7d93 WW-255 Add escapeJavaScript attribute to propertyTag
Thanks to Jelmer Kuperus for patch.

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@722159 13f79535-47bb-0310-9956-ffa450edef68
2008-12-01 18:24:52 +00:00
Musachy Barroso 718fa71af1 WW-2625 Add allowCaching attribute to StreamResult
Thanks to Al Sutton for the patch.

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@722124 13f79535-47bb-0310-9956-ffa450edef68
2008-12-01 16:47:29 +00:00
Wesley Wannemacher fbaccd65ec changing MakeIterator to support Iterable instead of Collection
per WW-2887, thanks for the patch Mathias Bogaert

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@721947 13f79535-47bb-0310-9956-ffa450edef68
2008-12-01 02:25:47 +00:00
David Newton a3ee86862f Fix for WW-2889 Use StringBuilder instead of StringBuffer; UrlHelper:r720222 change.
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@721838 13f79535-47bb-0310-9956-ffa450edef68
2008-11-30 16:04:46 +00:00
Musachy Barroso 9407fe5e30 WW-2226 resultsLimit attribute set to -1 in autocompleter tag is ignored. Set the type of resultsLimit to Integer
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@720918 13f79535-47bb-0310-9956-ffa450edef68
2008-11-26 17:06:40 +00:00
Musachy Barroso 5ecfccb0ed WW-2891 Replace deprecated operators in FreeMarker (just ?exists on this commit)
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@720258 13f79535-47bb-0310-9956-ffa450edef68
2008-11-24 19:05:16 +00:00
Musachy Barroso f6bba24d44 WW-2888 Cleanup of FileUploadInterceptor (added some generics and use XWork's text parsing)
Some unboxing also removed

Thanks to Mathias Bogaert for patch

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@720232 13f79535-47bb-0310-9956-ffa450edef68
2008-11-24 17:12:58 +00:00
Musachy Barroso 4f46d2abb2 WW-2889 Use StringBuilder instead of StringBuffer
Thanks to Mathias Bogaert for patch

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@720222 13f79535-47bb-0310-9956-ffa450edef68
2008-11-24 16:41:07 +00:00
Nils-Helge Garli 5397257cfb WW-2846 Nested params should now work properly in portlets
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@719714 13f79535-47bb-0310-9956-ffa450edef68
2008-11-21 21:09:13 +00:00
Nils-Helge Garli ad49562c48 WW-2783 Evaluate anchor. Fix suggested by Ralf Fischer.
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@719704 13f79535-47bb-0310-9956-ffa450edef68
2008-11-21 20:37:49 +00:00
Musachy Barroso dbedc4fae4 WW-2882 Make fields protected
Thanks to Mathias Bogaert for patch

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@719672 13f79535-47bb-0310-9956-ffa450edef68
2008-11-21 18:57:55 +00:00
Musachy Barroso 9fb18e8c0e WW-2879 Use Concurrent API in FreemarkerTemplateEngine
thanks to Mathias Bogaert for the patch

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@719643 13f79535-47bb-0310-9956-ffa450edef68
2008-11-21 17:13:32 +00:00
Musachy Barroso e135288df6 WW-2610 dont set "style" attribute, if there are field errors and cssClass was set. Tests added.
Thanks to Gabriel Belingueres for the patch

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@719021 13f79535-47bb-0310-9956-ffa450edef68
2008-11-19 18:47:34 +00:00
Musachy Barroso 6199a40267 WW-2071 UIBean.end does not fail when an exception happens. Throw a runtime exception, instead of just logging it
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@718748 13f79535-47bb-0310-9956-ffa450edef68
2008-11-18 22:43:53 +00:00
Musachy Barroso 7ea81313d0 WW-2246 always wrap the writer passed to FreeMarker to prevent exception when using custom tags
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@718652 13f79535-47bb-0310-9956-ffa450edef68
2008-11-18 17:04:01 +00:00
Musachy Barroso f7a7d62a87 Fix for FTL use (output was empty)
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@718354 13f79535-47bb-0310-9956-ffa450edef68
2008-11-17 20:06:38 +00:00
Nils-Helge Garli 96683b99fc Reverting change
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@701674 13f79535-47bb-0310-9956-ffa450edef68
2008-10-04 17:14:20 +00:00
Nils-Helge Garli bccea9737c Trying different things to fix bamboo error
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@701671 13f79535-47bb-0310-9956-ffa450edef68
2008-10-04 17:04:36 +00:00
Nils-Helge Garli 7ba66cfd4c Touching file to trigger build
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@701661 13f79535-47bb-0310-9956-ffa450edef68
2008-10-04 16:25:01 +00:00
David Newton 2cf1f83121 Backing out premature change :(
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@692670 13f79535-47bb-0310-9956-ffa450edef68
2008-09-06 15:47:06 +00:00
David Newton f537d7b33b Changed includeParams default to "none".
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@692662 13f79535-47bb-0310-9956-ffa450edef68
2008-09-06 15:27:21 +00:00
David Newton 3ea1503324 Added check for element's existence when adding error class to field label; it was broken when an element used "simple" theme. Gotta change some client-side validation stuff.
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@692578 13f79535-47bb-0310-9956-ffa450edef68
2008-09-05 23:30:16 +00:00
Nils-Helge Garli 502d7f3987 Doesn't work right now
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@691544 13f79535-47bb-0310-9956-ffa450edef68
2008-09-03 08:38:49 +00:00
Musachy Barroso 1f1c996eb1 WW-2779 Directory traversal vulnerability while serving static content
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@688095 13f79535-47bb-0310-9956-ffa450edef68
2008-08-22 15:22:56 +00:00
René Gielen 3a08768f32 Javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@687847 13f79535-47bb-0310-9956-ffa450edef68
2008-08-21 20:16:02 +00:00
Musachy Barroso b8c94a58b9 Add content loader test
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@687805 13f79535-47bb-0310-9956-ffa450edef68
2008-08-21 17:11:37 +00:00
Musachy Barroso b2c5190d52 Add content loader test
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@687804 13f79535-47bb-0310-9956-ffa450edef68
2008-08-21 17:11:16 +00:00
Musachy Barroso 04fcefa44b WW-2779 Directory traversal vulnerability while serving static content
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@687425 13f79535-47bb-0310-9956-ffa450edef68
2008-08-20 18:59:01 +00:00
Musachy Barroso e40a8e540b WW-2381 Destroy method of Interceptor is never called by Struts
Patch provided by Décio Heinzelmann Luckow

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@686328 13f79535-47bb-0310-9956-ffa450edef68
2008-08-15 19:19:07 +00:00
David Newton dcf5d45fde Minor JavaDoc change; the perils of ^V. Or Cmd-V for those of us with Macs.
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@684566 13f79535-47bb-0310-9956-ffa450edef68
2008-08-10 18:19:28 +00:00
Musachy Barroso dea5b76acc Organize imports (bamboo failing on one of them that is not used)
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@682419 13f79535-47bb-0310-9956-ffa450edef68
2008-08-04 15:23:34 +00:00
Musachy Barroso 73df90c49f XW-641 XWork ParameterInterceptors bypass (OGNL statement execution)
Update tests

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@682411 13f79535-47bb-0310-9956-ffa450edef68
2008-08-04 14:55:30 +00:00
Musachy Barroso 9e5c40482e Fix example (and build)
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@682390 13f79535-47bb-0310-9956-ffa450edef68
2008-08-04 13:51:06 +00:00
Musachy Barroso 68d84d684d Add some integration tests
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@681928 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 02:34:11 +00:00
Donald J. Brown 18724a34cb Making the base url of the integration tests configurable
git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@681695 13f79535-47bb-0310-9956-ffa450edef68
2008-08-01 13:56:28 +00:00
Musachy Barroso 4db454df70 WW-1677 <s:submit type="button" does not render the enclosed content inside properly
${parameters.body} is not only the body of the tag but also the html opening of the tag, so it cannot be escaped

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@681101 13f79535-47bb-0310-9956-ffa450edef68
2008-07-30 16:06:15 +00:00
Musachy Barroso b57ec7454a WW-1677 <s:submit type="button" does not render the enclosed content inside properly
${parameters.body} is not only the body of the tag but also the html opening of the tag, so it cannot be escaped

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@680739 13f79535-47bb-0310-9956-ffa450edef68
2008-07-29 15:39:34 +00:00
Donald J. Brown 3d0cd93746 Adding a few functional tests and test runs against multiple servers using my new maven-itblast-plugin
WW-2471


git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@680707 13f79535-47bb-0310-9956-ffa450edef68
2008-07-29 14:17:17 +00:00
Donald J. Brown 32683d3acd Updating to latest struts annotations to fix invalid tld issue
WW-2740


git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@680693 13f79535-47bb-0310-9956-ffa450edef68
2008-07-29 13:38:35 +00:00
Donald J. Brown 6070c4ff6d Better handle ;jsessionid in rest plugin
WW-2328


git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@680686 13f79535-47bb-0310-9956-ffa450edef68
2008-07-29 12:53:18 +00:00
Musachy Barroso abef0ef66f WW-2231 autocompleter: bug in autocompleter.ftl at disabled="false"
I also checked core tags and they are good.

git-svn-id: https://svn.apache.org/repos/asf/struts/struts2/trunk@678836 13f79535-47bb-0310-9956-ffa450edef68
2008-07-22 18:00:30 +00:00