mirror of
https://github.com/apache/struts.git
synced 2026-08-31 19:35:40 +00:00
Compare commits
10 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
 Lukasz Lenart
|
6d8cf56977 | ||
|
Lukasz Lenart
|
7b7d3ca0e1 | ||
|
Lukasz Lenart
|
3292152f8c | ||
|
Lukasz Lenart
|
28498a807d | ||
|
Yasser Zamani
|
2d6f1bc0a6 | ||
|
Lukasz Lenart
|
36e4e7410e | ||
|
Lukasz Lenart
|
e903739624 | ||
|
Lukasz Lenart
|
a85328e74e | ||
|
Lukasz Lenart
|
c3deb39237 | ||
|
Lukasz Lenart
|
483a0c8d01 |
@@ -3,50 +3,14 @@ notifications:
|
||||
commits: commits@struts.apache.org
|
||||
# Send all issue emails (new, closed, comments) to issues@
|
||||
issues: issues@struts.apache.org
|
||||
# Send new/closed PR notifications to commits@
|
||||
pullrequests_status: notifications@struts.apache.org
|
||||
# Send new/closed PR notifications to dev@
|
||||
pullrequests_status: dev@struts.apache.org
|
||||
# Send individual PR comments/reviews to issues@
|
||||
pullrequests_comment: notifications@struts.apache.org
|
||||
pullrequests_comment: issues@struts.apache.org
|
||||
# Link opened PRs with JIRA
|
||||
jira_options: link label worklog
|
||||
|
||||
github:
|
||||
description: "Apache Struts is a free, open-source, MVC framework for creating elegant, modern Java web applications"
|
||||
homepage: https://struts.apache.org/
|
||||
del_branch_on_merge: true
|
||||
protected_branches:
|
||||
main:
|
||||
# contexts are the names of checks that must pass.
|
||||
required_status_checks:
|
||||
contexts:
|
||||
- "Build and Test (JDK 17)"
|
||||
required_pull_request_reviews:
|
||||
# it does not work because our github teams are private/secret, see INFRA-25666
|
||||
require_code_owner_reviews: false
|
||||
required_approving_review_count: 0
|
||||
support/struts-6-x-x:
|
||||
# contexts are the names of checks that must pass.
|
||||
required_status_checks:
|
||||
contexts:
|
||||
- "Build and Test (8)"
|
||||
required_pull_request_reviews:
|
||||
# it does not work because our github teams are private/secret, see INFRA-25666
|
||||
require_code_owner_reviews: false
|
||||
required_approving_review_count: 0
|
||||
support/release-6-*:
|
||||
# contexts are the names of checks that must pass.
|
||||
required_status_checks:
|
||||
contexts:
|
||||
- "Build and Test (8)"
|
||||
required_pull_request_reviews:
|
||||
# it does not work because our github teams are private/secret, see INFRA-25666
|
||||
require_code_owner_reviews: false
|
||||
required_approving_review_count: 0
|
||||
pull_requests:
|
||||
# allow auto-merge
|
||||
allow_auto_merge: true
|
||||
# auto-delete head branches after being merged
|
||||
del_branch_on_merge: true
|
||||
autolink_jira:
|
||||
- WW
|
||||
dependabot_alerts: true
|
||||
dependabot_updates: true
|
||||
master: { }
|
||||
|
||||
@@ -1,25 +0,0 @@
|
||||
{
|
||||
"permissions": {
|
||||
"allow": [
|
||||
"WebSearch",
|
||||
"WebFetch(domain:struts.apache.org)",
|
||||
"WebFetch(domain:github.com)",
|
||||
"WebFetch(domain:raw.githubusercontent.com)",
|
||||
"WebFetch(domain:issues.apache.org)",
|
||||
"WebFetch(domain:freemarker.apache.org)",
|
||||
"Bash(mvn:*)",
|
||||
"Bash(git branch:*)",
|
||||
"Bash(git add:*)",
|
||||
"Bash(git commit:*)",
|
||||
"Bash(git push:*)",
|
||||
"Bash(git checkout:*)",
|
||||
"Bash(git log:*)",
|
||||
"Bash(gh pr view:*)",
|
||||
"Bash(gh pr diff:*)",
|
||||
"Bash(gh pr create:*)",
|
||||
"mcp__jetbrains"
|
||||
],
|
||||
"deny": [],
|
||||
"ask": []
|
||||
}
|
||||
}
|
||||
@@ -1,190 +0,0 @@
|
||||
---
|
||||
name: creating-release-vote-mail
|
||||
description: Use when opening the formal release vote for a Struts release candidate on any maintenance line (6.x, 7.x) - composing and drafting the [VOTE] Apache Struts X.Y.Z mail to dev@ once the Version Notes page, GitHub release and staged artifacts are published.
|
||||
---
|
||||
|
||||
# Creating a Release Vote Mail
|
||||
|
||||
## Overview
|
||||
|
||||
The `[VOTE]` mail opens the formal release vote. It is four links wrapped in frozen ASF
|
||||
boilerplate, around a plain-text rendering of the release's Version Notes page.
|
||||
|
||||
**Core principle:** the mail is a *rendering* of the page, not a second account of the release.
|
||||
|
||||
**This is the step after `creating-version-notes`.** That skill produces the page, the GitHub
|
||||
release and the `[TEST]` announcement; this one consumes all three. If they do not exist yet,
|
||||
you are in the wrong skill. `releasing-struts` holds the surrounding phases and what happens
|
||||
once the vote passes.
|
||||
|
||||
[`vote-mail-template.md`](vote-mail-template.md) is the source of truth for the artifact.
|
||||
|
||||
## The mail is exactly these parts, in this order
|
||||
|
||||
1. The two-sentence opener
|
||||
2. The page's `Breaking changes`, `Deprecations` and `Rejected requests`, where present
|
||||
3. The page's issue-type sections, in page order
|
||||
4. The four link lines
|
||||
5. The vote boilerplate
|
||||
6. The sign-off
|
||||
|
||||
**A part not on this list is not in the mail, and one mail is produced, not two.** Every
|
||||
section is the page's content; the opener is the only prose you write.
|
||||
|
||||
The pull here is toward helpfulness — an upgrade-notes section derived from the fix commits, a
|
||||
summary of what changed for integrators, a companion note to a subset of recipients. All of it
|
||||
is real work that belongs somewhere else. A vote is a judgement on the staged artifacts, and
|
||||
the page is what describes them.
|
||||
|
||||
## The vote carries no security information
|
||||
|
||||
No severity, no CVE, no S2-XXX, no bulletin link, no attack description, no reporter or
|
||||
coordination detail. **That disclosure happens after the vote passes and the version is
|
||||
released.**
|
||||
|
||||
**The restriction is on the vote, not on the audience.** Routing advisory detail through
|
||||
`private@`, a Cc, an attachment or a companion mail is the same violation as putting it in the
|
||||
body — a second mail sent to open the vote is part of the vote. "The recipients already hold
|
||||
this information" is not an exemption; the vote is simply not the vehicle.
|
||||
|
||||
Neutral ticket summaries carried from the page are not security information. Keep them exactly
|
||||
as the page has them, including where the page truncates one at a clause boundary.
|
||||
|
||||
**REQUIRED BACKGROUND:** `creating-security-bulletins` governs what may be said, and when.
|
||||
|
||||
## Recipients
|
||||
|
||||
```
|
||||
To: dev@struts.apache.org
|
||||
Bcc: private@struts.apache.org
|
||||
```
|
||||
|
||||
**`user@struts.apache.org` must not appear in any header — not To, not Cc, not Bcc.** The
|
||||
`[TEST]` mail one step earlier goes to `dev@` and `user@`, which is right for it: it asks
|
||||
people to test. This mail asks people to *vote*, and a vote invitation on the user list
|
||||
solicits votes that are not binding and scatters the tally across two lists.
|
||||
|
||||
Cc is not a compromise. If a release manager asks you to include the user list, the answer is
|
||||
that the `[TEST]` mail already did.
|
||||
|
||||
**`private@` is on the mail for reach, not for confidentiality.** Not every PMC member follows
|
||||
`dev@`, and PMC votes are the binding ones, so `private@` is what guarantees the binding voters
|
||||
see the call. Nothing goes there that could not go to `dev@` — its presence is a delivery
|
||||
decision, and it is not an exemption from the rule above.
|
||||
|
||||
It goes on **Bcc, not Cc**: on the 7.1.1 and 6.8.0 votes it was on Cc, and reply-all `+1`s
|
||||
landed on the private PMC list. Bcc gives the same reach while keeping the tally in one thread
|
||||
on `dev@`.
|
||||
|
||||
Subject is exactly `[VOTE] Apache Struts X.Y.Z`.
|
||||
|
||||
## Draft it, do not send it
|
||||
|
||||
Create a Gmail draft with To, Bcc, Subject and body set, and write the same body to a file whose
|
||||
path you hand over. **Never send.**
|
||||
|
||||
| Rationalization | Reality |
|
||||
|---|---|
|
||||
| "The release manager authorised whatever I produce" | Authorisation to compose is not authorisation to transmit. |
|
||||
| "Every fact is verified; review would catch nothing" | Sending is not a quality gate, it is a commitment. Verification does not confer it. |
|
||||
| "A draft doesn't open the vote, which defeats the request" | Correct, and that is the right outcome when the release manager is not there to send it. |
|
||||
| "The 72-hour clock is the reason for the hurry" | A vote opened on the wrong artifacts costs far more than the hours saved. |
|
||||
|
||||
Sending opens a binding vote on a permanently archived public list and commits the PMC to the
|
||||
artifacts as staged.
|
||||
|
||||
### The mail must be text/plain, and no tool argument achieves that
|
||||
|
||||
An ASF list mail carries **one `text/plain` part and nothing else**. A `text/html` part is a
|
||||
delivery failure, not a cosmetic one — `announce@apache.org` rejects it permanently:
|
||||
|
||||
```
|
||||
ezmlm-reject: fatal: Sorry, a message part has an unacceptable MIME Content-Type: 'text/html' (#5.2.3)
|
||||
```
|
||||
|
||||
**A draft created through the Gmail tool is an HTML draft, whatever you pass it.** Gmail
|
||||
synthesises a `text/html` alternative when the draft is sent, linkifies every URL into
|
||||
`<a href>`, and reflows the plain part:
|
||||
|
||||
| Body passed as | What is actually sent |
|
||||
|---|---|
|
||||
| `body` only | `multipart/alternative` — the HTML part is generated for you |
|
||||
| `htmlBody` only | HTML-only, no plain part at all |
|
||||
| both | Same, plus the plain part's visible text becomes the wrapped URL |
|
||||
|
||||
Gmail's linkifier also rewrites URLs server-side, so link lines can arrive as
|
||||
`https://www.google.com/url?q=...&source=gmail&ust=...`.
|
||||
|
||||
**Do not rely on a bounce to catch this.** On the 2026-08-14 advisory run the same message was
|
||||
rejected by `announce@apache.org` and accepted by `user@struts.apache.org` — the HTML mail
|
||||
reached one list and not the other, from a single send.
|
||||
|
||||
So the deliverable is three things, and it is incomplete without any of them:
|
||||
|
||||
1. A Gmail draft with To, Bcc, Subject and `body`. **Never `htmlBody`.**
|
||||
2. The identical body written to a file, whose path you hand over.
|
||||
3. In your handover, the sending instruction: **switch the compose window to plain-text mode**
|
||||
(⋮ → *Plain text mode*), then select-all and paste the file over the body.
|
||||
|
||||
Step 3 is what actually produces the plain-text mail; steps 1 and 2 only make it one paste
|
||||
instead of four hand-edited URLs. Hard-wrap the file at 72 columns — a paste into plain-text
|
||||
mode keeps the wrapping the file has, and Gmail reflows anything longer.
|
||||
|
||||
**Say which identity to send from: `@apache.org`.** The Gmail account's default sender is a
|
||||
personal address, and a vote arriving in the `dev@` archive from one reads as an outsider
|
||||
calling a PMC vote. Some ASF lists refuse it outright — `announcements@struts.apache.org`
|
||||
answers *"Must be sent from an @apache.org address."*
|
||||
|
||||
**Never re-run the draft-update tool on a draft whose links have already been fixed by hand** —
|
||||
it re-mangles them. A draft the release manager has corrected is finished; leave it alone.
|
||||
|
||||
## The boilerplate is frozen
|
||||
|
||||
Everything from `Once you have had a chance to review the test build` to the sign-off is
|
||||
byte-identical to the template. **Inserting a paragraph between existing ones is an edit** —
|
||||
that is how it actually gets broken, not by rewording.
|
||||
|
||||
If something about this release needs explaining to voters, it belongs in the opener, above
|
||||
the vote call. The vote call itself says the same thing every release, which is what lets a
|
||||
voter skim to the checkboxes.
|
||||
|
||||
## What this skill does not restate
|
||||
|
||||
Cross-references, not copies:
|
||||
|
||||
- `creating-version-notes` — the page, the GitHub release, the `[TEST]` mail, and what belongs
|
||||
on them. The issue list, Breaking changes wording and ticket reconciliation are settled
|
||||
there; render what the page says.
|
||||
- `creating-security-bulletins` — what may be said about an unpublished advisory.
|
||||
|
||||
Before drafting, confirm all four links resolve and the GitHub release is still a prerelease.
|
||||
A vote opened on a 404 burns the window before anyone can test.
|
||||
|
||||
## Red Flags — STOP
|
||||
|
||||
- Any part in the mail that is not on the six-item list
|
||||
- A second mail produced alongside the vote
|
||||
- Severity, CVE, S2-XXX, bulletin link or reporter detail anywhere, on any channel
|
||||
- `user@struts.apache.org` in any header, including Cc
|
||||
- Sending rather than drafting
|
||||
- `htmlBody` passed to the draft tool, for any reason
|
||||
- A draft handed over without the plain-text-mode instruction and the body file
|
||||
- A new paragraph inserted into the vote boilerplate
|
||||
- A quality checkbox arriving pre-ticked
|
||||
- An opening sentence carried over from the previous release
|
||||
- Re-running the draft-update tool on a draft whose links were already fixed by hand
|
||||
|
||||
## Common Mistakes
|
||||
|
||||
| Mistake | Reality |
|
||||
|---|---|
|
||||
| "Voters can't judge fixes they can't see" | They can open the restricted bulletins themselves. The vote is not the disclosure channel. |
|
||||
| "It's only going to private@, so nothing leaks" | The rule is about the vote, not the audience. A companion mail is part of the vote. |
|
||||
| "private@ is on the mail already, so it's a channel I can use" | It is there so binding voters see the call, not to carry anything `dev@` cannot. |
|
||||
| "Cc'ing user@ keeps the vote on dev@ and still informs them" | The `[TEST]` mail informed them. Cc splits the tally. |
|
||||
| "I verified everything, so I can send" | Verification earns a draft. Sending is the release manager's keystroke. |
|
||||
| "I'm adding to the boilerplate, not changing it" | Insertion is editing. The vote call is byte-frozen. |
|
||||
| "The release notes leave out what integrators need" | Then the page needs fixing. The mail renders the page. |
|
||||
| "Last release's opening sentence fits" | It described last release. Write the one this list supports. |
|
||||
| "I passed `body`, not `htmlBody`, so it's plain text" | Gmail generates the HTML part itself. The format is set in the compose window. |
|
||||
| "It went through last time, so HTML is tolerated" | Lists differ. One accepted the same message the other rejected. |
|
||||
@@ -1,152 +0,0 @@
|
||||
# Release Vote Mail Template
|
||||
|
||||
The canonical skeleton for the `[VOTE] Apache Struts X.Y.Z` mail that opens a release vote.
|
||||
Companion to [`SKILL.md`](SKILL.md), which covers *how* to fill the slots; this file covers
|
||||
*what the mail contains*.
|
||||
|
||||
**This file is the source of truth.** Start every vote mail from the skeleton below.
|
||||
|
||||
## Slots
|
||||
|
||||
| Slot | What goes in it |
|
||||
|---|---|
|
||||
| `<X.Y.Z>` | The release being voted on, dotted — subject, opening sentence, Version Notes URL, dist path |
|
||||
| `<X_Y_Z>` | The same version underscored, for the `STRUTS_` git tag only |
|
||||
| `<SHAPE SENTENCE>` | See below — authored per release |
|
||||
| Page sections | Breaking changes, Deprecations, Rejected requests, and the issue-type sections, copied from the Version Notes page. Omit any the page omits. |
|
||||
|
||||
**Where the page introduces a section with a sentence of its own, that sentence comes with it.**
|
||||
The skeleton below shows sections as bare lists, but `Rejected requests` on the 7.3.0 page opens
|
||||
with *"Two long-standing requests were closed as Won't Do in this cycle. They are listed here so
|
||||
the decision is visible rather than silent."* Without it the section reads as two unexplained
|
||||
ticket ids.
|
||||
|
||||
## The shape sentence is authored per release
|
||||
|
||||
The opener is two sentences. The first is fixed. The second describes the *shape* of the issue
|
||||
list — how the release is composed — and is written from the list in front of you.
|
||||
|
||||
| The page has | Second sentence |
|
||||
|---|---|
|
||||
| No Breaking changes | `With this release the following issues were addressed:` |
|
||||
| Breaking changes | `This release contains <what>:` |
|
||||
|
||||
**Do not reuse a previous release's wording.** 7.2.1's *"a few minor breaking changes plus some
|
||||
bug fixes. Also a lot of dependencies have been updated"* describes 7.2.1. Applied to 7.3.0 —
|
||||
seven breaking changes, one dependency bump — both halves are false.
|
||||
|
||||
Name no individual ticket here. The list below is the detail.
|
||||
|
||||
## Skeleton
|
||||
|
||||
```
|
||||
Subject: [VOTE] Apache Struts <X.Y.Z>
|
||||
To: dev@struts.apache.org
|
||||
Bcc: private@struts.apache.org
|
||||
|
||||
The Apache Struts <X.Y.Z> test build is available. <SHAPE SENTENCE>
|
||||
|
||||
Breaking changes
|
||||
|
||||
- <page item, verbatim, ending [WW-XXXX].>
|
||||
|
||||
Deprecations
|
||||
|
||||
- <page item, verbatim, ending [WW-XXXX].>
|
||||
|
||||
Rejected requests
|
||||
|
||||
[WW-XXXX] - <page item, verbatim>
|
||||
|
||||
Bug
|
||||
[WW-XXXX] - <summary>
|
||||
|
||||
New Feature
|
||||
[WW-XXXX] - <summary>
|
||||
|
||||
Improvement
|
||||
[WW-XXXX] - <summary>
|
||||
|
||||
Task
|
||||
[WW-XXXX] - <summary>
|
||||
|
||||
Dependency
|
||||
[WW-XXXX] - <summary>
|
||||
|
||||
Release notes:
|
||||
* https://cwiki.apache.org/confluence/display/WW/Version+Notes+<X.Y.Z>
|
||||
|
||||
Github release
|
||||
* https://github.com/apache/struts/releases/tag/STRUTS_<X_Y_Z>
|
||||
|
||||
Distribution:
|
||||
* https://dist.apache.org/repos/dist/dev/struts/<X.Y.Z>/
|
||||
|
||||
Maven 2 staging repository:
|
||||
* https://repository.apache.org/content/groups/staging/
|
||||
|
||||
Once you have had a chance to review the test build, please respond
|
||||
with a vote on its quality:
|
||||
|
||||
[ ] Leave at test build
|
||||
[ ] Alpha
|
||||
[ ] Beta
|
||||
[ ] General Availability (GA)
|
||||
|
||||
Everyone who has tested the build is invited to vote. Votes by PMC
|
||||
members are considered binding. A vote passes if there are at least
|
||||
three binding +1s and more +1s than -1s.
|
||||
|
||||
The vote will remain open for at least 72 hours, longer upon request.
|
||||
A vote can be amended at any time to upgrade or downgrade the quality
|
||||
of the release based on future experience. If an initial vote
|
||||
designates the build as "Beta", the release will be submitted for
|
||||
mirroring and announced to the user list. Once released as a public
|
||||
beta, subsequent quality votes on a build may be held on the user
|
||||
list.
|
||||
|
||||
As always, the act of voting carries certain obligations. A binding
|
||||
vote not only states an opinion, but means that the voter is agreeing
|
||||
to help do the work.
|
||||
|
||||
On behalf of the Apache Struts project
|
||||
Łukasz
|
||||
```
|
||||
|
||||
Hard-wrap the body at 72 columns, continuation lines unindented, so the list stays legible in
|
||||
the ASF archives and in quoted replies. Gmail reflows the wrap, rewrites the link lines, and
|
||||
adds a `text/html` part that ASF lists reject — see *The mail must be text/plain* in
|
||||
[`SKILL.md`](SKILL.md) for why the body also has to be handed over as a file, and what the
|
||||
release manager has to do in the compose window before sending.
|
||||
|
||||
## Frozen text
|
||||
|
||||
Everything from `Once you have had a chance to review the test build` to the sign-off is
|
||||
byte-frozen. It is the vote call itself: the options voters tick, the binding threshold, the
|
||||
72-hour minimum, and what a binding vote commits the voter to.
|
||||
|
||||
Details that look like defects and are kept:
|
||||
|
||||
| Detail | Why |
|
||||
|---|---|
|
||||
| `Github release` has no trailing colon | Every archived Struts vote mail reads this way |
|
||||
| All four checkboxes empty | The release manager's `+1 (binding)` is a separate reply |
|
||||
|
||||
The staging URL is `content/groups/staging/`, matching the Version Notes page and the `[TEST]`
|
||||
mail. The group repo also resolves released transitive dependencies, which the bare staging
|
||||
repository does not.
|
||||
|
||||
## Pre-draft checklist
|
||||
|
||||
- [ ] All four links resolve; the GitHub release is still flagged pre-release
|
||||
- [ ] Ticket ids in the mail match the page's exactly, both directions
|
||||
- [ ] Boilerplate byte-identical to the frozen text above
|
||||
- [ ] `To: dev@` only; `user@` absent from every header; `Bcc: private@` present
|
||||
- [ ] Subject is exactly `[VOTE] Apache Struts X.Y.Z`
|
||||
- [ ] All four checkboxes empty
|
||||
- [ ] No severity, CVE, S2-XXX, bulletin link or reporter detail anywhere
|
||||
- [ ] Exactly one mail
|
||||
- [ ] Body also saved to a file and its path handed over, so the mangled links and wrap can be
|
||||
fixed with one paste
|
||||
- [ ] `htmlBody` not passed to the draft tool
|
||||
- [ ] Handover states: plain-text mode on, paste the file, send from the `@apache.org` identity
|
||||
@@ -1,300 +0,0 @@
|
||||
---
|
||||
name: creating-security-bulletins
|
||||
description: Use when drafting, updating, or reviewing an S2-XXX security bulletin on the Struts cwiki, when preparing bulletin text ahead of a CVE request, when publishing a bulletin and announcing it to the ASF lists, or when deciding how much detail about a fixed vulnerability is safe to publish.
|
||||
---
|
||||
|
||||
# Creating Security Bulletins
|
||||
|
||||
## Overview
|
||||
|
||||
An S2-XXX bulletin exists to tell an operator **what to upgrade and why** — not to explain the defect. Every sentence that helps a defender must be weighed against how much it helps someone building an exploit.
|
||||
|
||||
**Core principle:** every field is either traced to source you read this session, or a visible placeholder. Never a plausible guess.
|
||||
|
||||
**Process authority:** [`SECURITY.md`](../../../SECURITY.md) governs disclosure. This skill governs *what the page says and how it is written*.
|
||||
|
||||
**REQUIRED BACKGROUND:** the claims you put in a bulletin come from triage. Use `triaging-security-reports` to establish them before writing.
|
||||
|
||||
## The Iron Rule
|
||||
|
||||
```
|
||||
NO FIELD IN A BULLETIN WITHOUT A SOURCE YOU READ THIS SESSION,
|
||||
OR A VISIBLE PLACEHOLDER.
|
||||
```
|
||||
|
||||
Applies to the severity rating, the affected versions, and above all the Workaround. "There is no workaround" is a factual claim about absence — the hardest kind to get right, and the most common thing to assert without checking.
|
||||
|
||||
## Page structure
|
||||
|
||||
Sections in order, matching the existing published bulletins:
|
||||
|
||||
`Summary` (in an `excerpt` macro) → field table → `Problem` → `Solution` → `Backward compatibility` → `Workaround`
|
||||
|
||||
Field table rows, in order:
|
||||
|
||||
| Row | Content |
|
||||
|---|---|
|
||||
| Who should read this | Usually `All Struts 2 developers and users`; narrow it only when exposure is genuinely conditional |
|
||||
| Impact of vulnerability | A short impact phrase, not a paragraph — *Remote Code Execution*, *Denial of service*, *Disclosure of Data, Denial of Service, Server Side Request Forgery*. Hedging is accepted where warranted (*Possible Remote Code Execution vulnerability*) |
|
||||
| Maximum security rating | Low / Moderate / Important / Critical — see the rating scale below |
|
||||
| Recommendation | `Upgrade to Struts X.Y.Z at least`. Name **every** maintenance line that carries the fix (`Upgrade to Struts 6.8.0 or 7.1.1 at least`), and add the required action where upgrading alone is not enough (`… and use Action File Upload Interceptor`) |
|
||||
| Affected Software | Officially released versions only (see below); bullet one range per maintenance line, linking the EOL announcement for end-of-life ranges |
|
||||
| Reporters | Credit the reporter — they earned it, and it costs nothing. Include their organisation where they gave one (`Steven Seeley of Source Incite`); obfuscate any email (`pwntester at github dot com`) |
|
||||
| CVE Identifier | Placeholder until assigned (see below) |
|
||||
|
||||
**Match the house voice — from the *recent* bulletins only.** Read the two or three most recently published ones before writing. They are far terser than a triage write-up: `Problem` is one to three sentences, and every affected feature is **linked to its page on struts.apache.org** so an operator can go straight to the documentation. Where a bulletin resembles an earlier one, the Summary says so and links it.
|
||||
|
||||
**Do not take the older bulletins as a precedent for how much to disclose.** Earlier advisories explained causes and mitigations in far more detail, and that detail was used to build working exploits. The project deliberately stopped. An old bulletin naming the exact construct that triggers the flaw is evidence of the practice this skill exists to prevent, not licence to repeat it — mine them for structure and tone, never for depth.
|
||||
|
||||
## Affected Software: released versions only
|
||||
|
||||
**List only versions that passed a PMC release vote.** A build that was cut, failed its test period, and was superseded never reached users as a release — listing it implies an official artifact was vulnerable and drags a phantom version into every downstream CVE record and scanner database.
|
||||
|
||||
Verify before writing. Do not infer the range from the tags in git: a tag exists for builds that were never voted through. Ask, or check the release announcements.
|
||||
|
||||
**Deriving the lower bound** — one method, both bounds:
|
||||
|
||||
1. Find when the vulnerable code entered, with `git log -S'<the vulnerable construct>' -- <path>`. Do not assume it arrived with the feature that made it reachable; a defect often predates the control that was supposed to bound it.
|
||||
2. Map that commit to the first *release* containing it.
|
||||
3. If step 2 can't be settled from what you have, write a visible placeholder naming what must be confirmed — never a guessed version number.
|
||||
|
||||
## The rating scale is published — apply it, don't invent one
|
||||
|
||||
The definitions live on **[Security Bulletins](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61758)** (page `61758`), and they answer one question: *how worried should I be about this vulnerability?*
|
||||
|
||||
**That page is the only authority.** The four-level naming was introduced comparatively recently, so bulletins published before it use other wording and inconsistent capitalisation. Never infer the vocabulary or calibrate a rating from an older bulletin — match a definition on page `61758`, and take comparisons only from advisories published since the scale existed.
|
||||
|
||||
| Rating | Applies when |
|
||||
|---|---|
|
||||
| **Critical** | A remote attacker can get Struts to execute arbitrary code — exploitable automatically, regardless of whether the developer followed the Security Guide |
|
||||
| **Important** | Compromise of the application's **data or availability**; also easy RCE that depends on the developer having mistreated user input |
|
||||
| **Moderate** | There is **significant mitigation**: the flaw does not affect likely configurations, or the configuration is not widely used, or the attacker must be authenticated |
|
||||
| **Low** | Everything else — believed **extremely hard to exploit**, or the exploit yields minimal consequences |
|
||||
|
||||
Two traps in applying it:
|
||||
|
||||
- **Low is not "narrow".** A flaw that is trivial to trigger and causes real damage is not Low merely because a setting gates it. Reserve Low for hard-to-exploit *or* minimal-consequence.
|
||||
- **The Moderate clause is "not widely used", not "opt-in".** A gate only mitigates if few deployments pass through it. S2-068 needed file upload enabled and was still rated **Important**, because file upload is ordinary. Ask how many real deployments the precondition actually excludes.
|
||||
- **Availability counts as Important.** Denial of service is not automatically a lesser class — S2-068 was disk exhaustion, rated Important. It drops to Moderate only where a mitigation clause genuinely applies.
|
||||
|
||||
**Exploitation status belongs on the page, not in the rating.** The scale measures the flaw itself, so it has no slot for "a public reproduction already exists." When a defect was disclosed publicly before the fix shipped, or a working reproduction is already public, say so in plain words — downstream consumers are told by their own regulators to prioritise on real risk and active exploitation, not on a severity class alone. It costs nothing: the reproduction is already out.
|
||||
|
||||
## CVE placeholder
|
||||
|
||||
CVEs are requested **after** the fixed release is out and accepted. Until then the row carries a placeholder that cannot be mistaken for a real identifier:
|
||||
|
||||
```
|
||||
CVE-YYYY-NNNNN (to be assigned before publication)
|
||||
```
|
||||
|
||||
Never leave a cloned page's real CVE in place. Never invent a well-formed-looking number.
|
||||
|
||||
One CVE per independently fixable issue — separate fixes get separate bulletins and separate CVEs, per [CNA rules 4.1.10](https://www.cve.org/ResourcesSupport/AllResources/CNARules).
|
||||
|
||||
## The disclosure budget
|
||||
|
||||
**The budget covers every prose section — `Problem`, `Backward compatibility`, and `Workaround` alike.** `Problem` is the section authors guard; `Backward compatibility` is the one that leaks, because describing what changed about the fixed behaviour describes the defect. A note saying which inputs are handled differently now points straight at the code path that was rewritten. Apply the table below to all three sections, and write the BC note in terms of what an application might *observe*, never what the fix altered internally.
|
||||
|
||||
Write the shortest true description that lets an operator judge whether they are exposed. One to three sentences, as in the published bulletins.
|
||||
|
||||
| Safe to publish | Never publish before the fix is out |
|
||||
|---|---|
|
||||
| Impact categories and consequence | Class, method, or field names |
|
||||
| The component in plain words, linked to its documentation | `file:line` references |
|
||||
| Whether a configured control fails to apply | Commit hashes, PR or Jira numbers |
|
||||
| That state is shared / input is unvalidated | The triggering request shape or payload |
|
||||
| Which released versions are affected | Reproduction steps, PoC, timing conditions |
|
||||
|
||||
**Write for an operator, not a reviewer.** S2-068 describes an exploited disk-exhaustion bug in one sentence — *"If support for file upload is enabled, file leak in multipart request processing causes disk exhaustion."* That is the register: the feature, the failure, the consequence. Naming the class turns a bulletin into a starting point.
|
||||
|
||||
## State who is *not* affected
|
||||
|
||||
An operator's first question is "does this reach me?" Answer it on the page, or every reader has to assume it does.
|
||||
|
||||
The house form is **one sentence, linked to the feature's documentation** — S2-067 does it in a single line:
|
||||
|
||||
> **Note**: applications not using [FileUploadInterceptor](https://struts.apache.org/core-developers/file-upload-interceptor) are safe.
|
||||
|
||||
or folded into the opening clause, as S2-068 does with *"If support for file upload is enabled, …"*. Say it whenever exposure is conditional — an optional plugin the application chooses to ship, a setting that must be switched on, an endpoint that must be mapped, or an unaffected sibling path that lets a reader stop reading. Add "earlier releases are not affected" when there is a clean prior baseline.
|
||||
|
||||
Keep it at the level of a deployment decision ("uses the plugin", "exposes such an endpoint"), not a code path. Scoping *reduces* net disclosure: it shrinks the population that has to care, and it costs an attacker nothing they could not learn from the dependency list.
|
||||
|
||||
## Fix provenance
|
||||
|
||||
A bulletin promises a fixed release and describes post-fix behaviour as settled fact. Both claims rest on a specific change.
|
||||
|
||||
**Record which commit or PR each behavioural claim rests on**, in the version comment or your notes — not on the page.
|
||||
|
||||
**Confirm that change is merged into the release branch before publishing.** A patch under private review may be revised or dropped; a bulletin describing behaviour that never shipped is worse than a late bulletin. Bulletins are routinely drafted while the fix is still embargoed and unmerged — that is normal, and it is exactly why the merge state must be re-checked at publication time rather than at drafting time.
|
||||
|
||||
**Derive BC notes from the fix diff, not from its commit message.** A commit summary that calls the behaviour unchanged can still carry an observable difference its author did not think worth mentioning. Read the diff.
|
||||
|
||||
**`Backward compatibility` is also where a breaking upgrade is announced**, and the announcement has to be blunt. S2-067 told users the fix was *not* backward compatible, that they had to rewrite their actions onto a new mechanism, and that staying on the old one left them vulnerable. Where the fix is transparent, the house sentence is simply *"This change is backward compatible."*
|
||||
|
||||
## Workaround: verify or say nothing
|
||||
|
||||
Three valid outcomes, in order of preference:
|
||||
|
||||
1. **A verified configuration or operational change.** Trace it in source and confirm it actually removes reachability. Give the change, not the mechanism. It need not be a Struts setting — S2-068 offers a sized or dedicated temp volume, and pointing at the relevant section of the Security Guide is a legitimate workaround in itself.
|
||||
2. **Upgrade only** — when you checked and found nothing.
|
||||
3. **Verified absence.** The house value is a bare `n/a` (S2-066, S2-067); spell it out when the reason is worth stating.
|
||||
|
||||
Never ship a workaround you reasoned about but did not confirm. A wrong workaround leaves operators believing they are protected and discredits every other field on the page.
|
||||
|
||||
**The tension to decide deliberately:** a workaround usually reveals which path is affected. That is often the right trade — it is why the bulletin exists — but it is a decision to make and surface, not one to make silently. Say which way you went and why.
|
||||
|
||||
## Re-read the page immediately before you write to it
|
||||
|
||||
Bulletins are drafted by more than one person, often within the same hour. Content you read earlier may have moved on — a backport range added, a placeholder resolved, a section rewritten.
|
||||
|
||||
**Fetch the current version immediately before every write, and compare the returned version number against the one you read.** If it advanced, re-read, merge your change onto the newer content, and write that. Writing from a stale copy silently discards someone else's work with no warning and no conflict error.
|
||||
|
||||
After writing, diff your new version against the one you meant to build on. The diff should show only your intended change. If it shows deletions you did not intend, restore from history and redo the edit on top.
|
||||
|
||||
## Restrictions
|
||||
|
||||
Bulletins stay restricted until the coordinated publication date.
|
||||
|
||||
**Check restrictions before the edit and again after.** An API update should not disturb them, but "should not" is not verification, and an accidentally public pre-release bulletin is an unrecoverable disclosure.
|
||||
|
||||
Expected on the Struts wiki: read and update limited to the author plus `struts-committers`.
|
||||
|
||||
Publication is clearing them **completely** — read *and* update, both empty, matching every
|
||||
already-published bulletin. Verify with an unauthenticated fetch of the public URL, not with the
|
||||
API's response: the tool reporting success is not the page being readable.
|
||||
|
||||
## Announcing it: press the button on the CVE record
|
||||
|
||||
Once the page is public the advisory goes out **from the CVE record**, not from a mailbox.
|
||||
Every record on `cveprocess.apache.org` carries an *OSS/ASF Emails* tab —
|
||||
`https://cveprocess.apache.org/cve5/CVE-YYYY-NNNNN#email` — holding two finished mails, one
|
||||
for `oss-security` and one for the ASF lists, generated from the record's own affected
|
||||
ranges, description, credit and references. A single **`Send these Emails`** button sits at
|
||||
the foot of the tab, and both mails point at it — *"Use the button below to send these
|
||||
mails, or copy, paste, and send the email yourself."*
|
||||
|
||||
The send is four steps, in order:
|
||||
|
||||
1. **Set `userslist` to `user@struts.apache.org`** — the field is in the *Editor* tab, or as
|
||||
`CNA_private.userslist` on the *Source* tab, which accepts the record as raw JSON. It is
|
||||
labelled *"This is your project list such as users@ where you also want security
|
||||
announcement emails go to"*, and it is what puts the Struts user list on the ASF mail.
|
||||
2. **`SAVE`.** The mails are regenerated from the saved record, not from the form.
|
||||
3. **Re-read both mails on the *OSS/ASF Emails* tab.** They are the deliverable — read them
|
||||
as closely as you read the bulletin.
|
||||
4. **Press `Send these Emails`.**
|
||||
|
||||
**Take the subject the tool generates, unedited** — `CVE-YYYY-NNNNN: Apache Struts: <title>`.
|
||||
No `[ANN]` prefix: that prefix belongs to *release* announcements, and ASF CVE reports do not
|
||||
carry it. No `- S2-XXX` suffix either; the bulletin reaches readers as a `References:` line.
|
||||
|
||||
**Why the button rather than a mailbox.** Mail sent through the tool is moderated
|
||||
automatically, while the same text from a personal account waits for a human moderator. It
|
||||
also cannot get the `text/plain` contract or the sender identity wrong — which is the entire
|
||||
class of failure below.
|
||||
|
||||
Both points are sebb's, on the S2-073 announcement thread, 2026-08-14.
|
||||
|
||||
**Expect a delay either way, and do not read it as a failed send.** The tab warns that
|
||||
*"ASF announcement mailing lists are moderated. It may take some hours/days before your
|
||||
email will be published."* Silence on the archives an hour later is moderation, not a
|
||||
bounce.
|
||||
|
||||
### The failure this replaces
|
||||
|
||||
On 2026-08-14 all five advisories were sent by hand from Gmail. Every one failed at least
|
||||
once:
|
||||
|
||||
| Send | Outcome |
|
||||
|---|---|
|
||||
| S2-070, from the personal Gmail identity | Bounced — `Must be sent from an @apache.org address.` |
|
||||
| S2-071…074, to `user@` with `announce@` in Cc/Bcc | Bounced — `unacceptable MIME Content-Type: 'text/html' (#5.2.3)` |
|
||||
| The re-sends, to `announce@` alone | Delivered, subjects hand-prefixed `[ANN] ` |
|
||||
|
||||
The *bodies* were already the tool's generated text. Only the **sending** was hand-rolled,
|
||||
and every one of those failures came from the sending. `CNA_private.emailed` on those
|
||||
records is still `null`.
|
||||
|
||||
**A bounce is not a reliable alarm.** That morning one HTML send was rejected by
|
||||
`announce@apache.org` and *accepted* by `user@struts.apache.org`. The HTML advisory reached
|
||||
the user list. A partial failure looks like success in the Sent folder.
|
||||
|
||||
### If the button is genuinely unavailable
|
||||
|
||||
Only when the button itself fails — it errors, or the record will not save. Moderation delay
|
||||
is not unavailability. Then the mail is three things and is incomplete without any:
|
||||
|
||||
1. A draft with To, Bcc, Subject and `body`. **Never `htmlBody`** — and passing `body` alone
|
||||
does not make the mail plain text; Gmail generates the HTML part itself on send.
|
||||
2. The identical body in a file, whose path you hand over, hard-wrapped at 72 columns.
|
||||
3. The sending instruction in your handover: **plain-text mode on** (⋮ → *Plain text mode*),
|
||||
paste the file over the body, send from the `@apache.org` identity.
|
||||
|
||||
Copy the recipients and subject off the tool's tab rather than composing them. The
|
||||
`oss-security` copy is a separate mail with **no Cc and no Bcc** — not the ASF mail with an
|
||||
extra recipient — and `announcements@struts.apache.org` accepts only `@apache.org` senders.
|
||||
|
||||
## Start from the template, never from a previous bulletin
|
||||
|
||||
**[`bulletin-template.md`](bulletin-template.md)** — the field reference, per-section guidance, pre-publication checklist, and a storage-format skeleton ready to POST to the Confluence API. **It is the source of truth.**
|
||||
|
||||
A rendered copy exists on the wiki as a restricted child of *Security Bulletins* for authors who prefer to copy a page; when the two disagree, fix the wiki page from the file. Whichever route you take, confirm the new page carries the same restrictions before typing anything into it, and give the `excerpt` macro a fresh `ac:macro-id` — a copied page inherits the template's, and two bulletins must not share one.
|
||||
|
||||
**If you inherit a page cloned from a previous bulletin instead**, assume every field is inherited and wrong until you have replaced it. The residue that survives a careless edit:
|
||||
|
||||
- The previous bulletin's real CVE identifier
|
||||
- Its affected versions, rating, and reporter credit
|
||||
- Its workaround — describing a mitigation for an unrelated defect
|
||||
- The `excerpt` macro's `ac:macro-id`, now **duplicated across two pages** — generate a fresh UUID
|
||||
|
||||
Read the whole page and rewrite it; do not patch the fields you happen to notice.
|
||||
|
||||
## Red Flags — STOP
|
||||
|
||||
- About to write a Workaround you have not traced in source
|
||||
- About to write "no workaround exists" without having looked
|
||||
- Affected Software copied from a git tag list rather than confirmed releases
|
||||
- A CVE number on the page that you did not receive from the CVE assignment process
|
||||
- Naming a class, method, or file in `Problem` "because it's already public in the PR"
|
||||
- Copying the disclosure depth of an older bulletin — that depth is the reason this budget exists
|
||||
- Calibrating a rating against a bulletin published before the four-level scale existed
|
||||
- Guarding `Problem` carefully and then describing the fix's internals in `Backward compatibility`
|
||||
- Writing a BC note from the fix's commit message without reading the diff
|
||||
- Publishing while the fix is still unmerged, or without re-checking that it landed
|
||||
- No statement of who is *not* affected, when exposure depends on a plugin or an opt-in setting
|
||||
- Writing a page from content you read earlier in the session without re-fetching it first
|
||||
- Publishing without re-checking restrictions
|
||||
- Treating an API success as proof the page is publicly readable
|
||||
- `htmlBody` passed to the draft tool, for any reason
|
||||
- An advisory sent from a mailbox while the record's `Send these Emails` button is available
|
||||
- `Send these Emails` pressed before `userslist` is set to `user@struts.apache.org` and saved
|
||||
- `[ANN]`, an S2-XXX suffix, or any other hand-edit to the subject the tool generated
|
||||
- A draft handed over without the plain-text-mode instruction and the body file
|
||||
- A severity rating chosen by feel, or by reachability alone, without checking it against the published scale
|
||||
- Rating something Low because the feature is opt-in — opt-in is the definition of Moderate
|
||||
|
||||
## Common Mistakes
|
||||
|
||||
| Mistake | Reality |
|
||||
|---|---|
|
||||
| "The PR is public, so detail costs nothing" | A bulletin is indexed, permanent, and read by people who never see the PR. Aggregation is the harm. |
|
||||
| "An older bulletin explained the cause in detail" | Those explanations were used to build exploits. The practice was stopped deliberately — don't restore it. |
|
||||
| "An older bulletin rated something like this X" | The rating scale postdates it. Match a definition on page 61758 instead. |
|
||||
| "Listing the failed build is more honest" | It is less accurate. That build was never a release; listing it misdirects every downstream consumer. |
|
||||
| "Disabling the feature is an obvious workaround" | Obvious ≠ verified. Confirm the feature is genuinely on the only reachable path. |
|
||||
| "The rating is roughly right" | Ratings drive upgrade urgency. Read the published definitions and match one, don't approximate. |
|
||||
| "It needs an opt-in feature, so it's Low" | That is the Moderate mitigation clause. Low means hard to exploit or minimal consequence. |
|
||||
| "Restrictions were set when the page was created" | Verify after every edit. The cost of being wrong once is total. |
|
||||
| "I'll fill in the CVE later" | Only if the placeholder is unmistakable. A blank or a stale number ships as fact. |
|
||||
| "The BC note is just a compatibility courtesy" | It describes what the fix changed, which describes the defect. Same budget as `Problem`. |
|
||||
| "The commit message says behaviour is unchanged" | Commit summaries understate. Read the diff and decide for yourself. |
|
||||
| "Naming the plugin narrows it for an attacker too" | They can read your dependency list. Scoping spares every operator who isn't exposed. |
|
||||
| "The patch is reviewed, so the release will contain it" | Reviewed is not merged. Re-check at publication, not at drafting. |
|
||||
| "Copying the last bulletin is quicker than the template" | It is how another advisory's CVE ships on your page. Copy the template. |
|
||||
| "I read the page a few minutes ago" | Someone else may have written to it since. Re-fetch, then write. There is no conflict warning. |
|
||||
| "I passed `body`, not `htmlBody`, so it's plain text" | Gmail generates the HTML part itself on send. The format is decided in the compose window. |
|
||||
| "It reached the lists, so the format was fine" | One list accepted the same message another rejected. Check every recipient, not the Sent folder. |
|
||||
| "I copied the tool's text, so the mail is fine" | The text was never what failed. Sending by hand is. Press the button. |
|
||||
| "The tool doesn't mail `user@`, so I'll send it myself" | It does once `userslist` says so. One field on the record, not a parallel process. |
|
||||
| "`[ANN]` marks it as an announcement" | ASF CVE reports don't carry it. The tool's subject *is* the subject. |
|
||||
| "Sending it myself is quicker than pressing the button" | It is slower end to end: a personal-account mail waits for a human moderator, the tool's does not. |
|
||||
@@ -1,154 +0,0 @@
|
||||
# Security Bulletin Template
|
||||
|
||||
The canonical skeleton and per-field guidance for an S2-XXX security bulletin.
|
||||
Companion to [`SKILL.md`](SKILL.md), which covers *how* to establish the facts that
|
||||
go in these fields; this file covers *what the page contains*.
|
||||
|
||||
A rendered copy lives on the Struts wiki as a restricted child of
|
||||
[Security Bulletins](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61758)
|
||||
for authors who prefer to copy a page. **This file is the source of truth** — when the
|
||||
two disagree, fix the wiki page from here.
|
||||
|
||||
**Draft bulletins stay restricted** (read and update limited to the author plus
|
||||
`struts-committers`) until the coordinated publication date. Check restrictions before
|
||||
an edit and again after it: an accidentally public pre-release bulletin is an
|
||||
unrecoverable disclosure.
|
||||
|
||||
## Fields
|
||||
|
||||
| Row | What goes in it |
|
||||
|---|---|
|
||||
| Who should read this | Usually `All Struts 2 developers and users`. Narrow it only when exposure is genuinely conditional. |
|
||||
| Impact of vulnerability | A short impact phrase, not a paragraph — `Remote Code Execution`, `Denial of service`. Hedge where warranted (`Possible Remote Code Execution vulnerability`). |
|
||||
| Maximum security rating | `Low` / `Moderate` / `Important` / `Critical`, matching a definition on the [Security Bulletins](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61758) page. That page is the only authority — the four-level naming postdates many older bulletins, so never calibrate against one. |
|
||||
| Recommendation | `Upgrade to Struts X.Y.Z at least`. Name **every** maintenance line carrying the fix, and add the required action where upgrading alone is not enough. |
|
||||
| Affected Software | Officially released versions only. One bullet per maintenance line; link the EOL announcement for end-of-life ranges. |
|
||||
| Reporters | Credit the reporter. Include their organisation where they gave one; obfuscate any email address. |
|
||||
| CVE Identifier | `CVE-YYYY-NNNNN (to be assigned before publication)` until the real identifier arrives. One CVE per independently fixable issue. |
|
||||
|
||||
### Affected Software
|
||||
|
||||
List only versions that passed a PMC release vote. A build that was cut, failed its
|
||||
test period and was superseded never reached users — listing it implies an official
|
||||
artifact was vulnerable and drags a phantom version into every downstream CVE record
|
||||
and scanner database. Do not read the range off git tags; tags exist for builds that
|
||||
were never voted through.
|
||||
|
||||
To find the lower bound: locate when the vulnerable construct entered with
|
||||
`git log -S`, then map that commit to the first release containing it. A defect often
|
||||
predates the control that was supposed to bound it, so do not assume it arrived with
|
||||
the feature that made it reachable. If the mapping cannot be settled, write a visible
|
||||
placeholder naming what must be confirmed — never a guessed version number.
|
||||
|
||||
## Problem
|
||||
|
||||
One to three sentences. Write for an operator, not a reviewer: the feature, the
|
||||
failure, the consequence.
|
||||
|
||||
| Safe to publish | Never publish before the fix is out |
|
||||
|---|---|
|
||||
| Impact categories and consequence | Class, method, or field names |
|
||||
| The component in plain words, linked to its documentation | `file:line` references |
|
||||
| Whether a configured control fails to apply | Commit hashes, PR or Jira numbers |
|
||||
| That state is shared / input is unvalidated | The triggering request shape or payload |
|
||||
| Which released versions are affected | Reproduction steps, PoC, timing conditions |
|
||||
|
||||
Older bulletins explained causes and mitigations in far more detail, and that detail
|
||||
was used to build working exploits. The project deliberately stopped. **Mine the
|
||||
archive for structure and tone, never for depth.**
|
||||
|
||||
**Then say who is not affected.** An operator's first question is "does this reach
|
||||
me?" — answer it, or every reader must assume it does. One sentence, linked to the
|
||||
feature's documentation, either as a trailing note or folded into the opening clause.
|
||||
Name the optional plugin, the setting that must be switched on, the endpoint that must
|
||||
be mapped, or the unaffected sibling path. Add "earlier releases are not affected"
|
||||
where there is a clean prior baseline.
|
||||
|
||||
Keep it at the level of a deployment decision, not a code path. Scoping *reduces* net
|
||||
disclosure: it shrinks the population that has to care, and costs an attacker nothing
|
||||
they could not read off a dependency list.
|
||||
|
||||
## Solution
|
||||
|
||||
`Upgrade to Struts X.Y.Z at least.` Repeat for each maintenance line, and link the
|
||||
migration guide where the fix requires one.
|
||||
|
||||
## Backward compatibility
|
||||
|
||||
**Subject to the same disclosure budget as Problem.** This is the section that leaks:
|
||||
describing what changed about the fixed behaviour describes the defect. Write it in
|
||||
terms of what an application might *observe*, never what the fix altered internally,
|
||||
and derive it from the fix diff rather than the commit message — a summary calling the
|
||||
behaviour unchanged can still carry an observable difference.
|
||||
|
||||
It is also where a **breaking** upgrade is announced, and that announcement has to be
|
||||
blunt: what must be rewritten, and what staying put costs. Where the fix is
|
||||
transparent, the house sentence is simply `This change is backward compatible.`
|
||||
|
||||
## Workaround
|
||||
|
||||
Three valid outcomes, in order of preference:
|
||||
|
||||
1. **A verified configuration or operational change** — traced in source and confirmed
|
||||
to remove reachability. Give the change, not the mechanism. It need not be a Struts
|
||||
setting; container and reverse-proxy limits count, as does pointing at the relevant
|
||||
section of the Security Guide.
|
||||
2. **Upgrade only**, when you checked and found nothing.
|
||||
3. **Verified absence.** The house value is a bare `n/a`; spell it out when the reason
|
||||
is worth stating.
|
||||
|
||||
Never ship a workaround you reasoned about but did not confirm — it leaves operators
|
||||
believing they are protected and discredits every other field on the page. "No
|
||||
workaround exists" is a claim about absence and needs checking too.
|
||||
|
||||
A workaround usually reveals which path is affected. That is often the right trade,
|
||||
but make it deliberately and record which way you went.
|
||||
|
||||
## Before publishing
|
||||
|
||||
- [ ] Every placeholder is replaced, and no guidance text survives on the page.
|
||||
- [ ] The CVE identifier is real, not the placeholder.
|
||||
- [ ] Affected Software lists voted releases only, and covers every maintenance line.
|
||||
- [ ] The rating matches a published definition rather than an approximation.
|
||||
- [ ] The workaround was verified in source, or its absence was.
|
||||
- [ ] Problem, Backward compatibility and Workaround name no class, file, commit, PR
|
||||
or payload.
|
||||
- [ ] The fix is **merged** into the release branch — reviewed is not merged; re-check
|
||||
now, not at drafting time.
|
||||
- [ ] The fixed release is out and accepted.
|
||||
- [ ] Restrictions are lifted only at the coordinated publication moment.
|
||||
- [ ] The CVE record's `CNA_private.userslist` reads `user@struts.apache.org` and is saved,
|
||||
so `Send these Emails` on the *OSS/ASF Emails* tab reaches the Struts user list.
|
||||
|
||||
## Storage-format skeleton
|
||||
|
||||
Ready to POST to the Confluence API. Give the `excerpt` macro a **fresh**
|
||||
`ac:macro-id` each time — two bulletins must not share one.
|
||||
|
||||
```xml
|
||||
<h2>Summary</h2>
|
||||
<ac:structured-macro ac:name="excerpt" ac:schema-version="1">
|
||||
<ac:parameter ac:name="atlassian-macro-output-type">BLOCK</ac:parameter>
|
||||
<ac:rich-text-body><p>ONE-LINE DESCRIPTION OF THE DEFECT</p></ac:rich-text-body>
|
||||
</ac:structured-macro>
|
||||
<p class="auto-cursor-target"><br/></p>
|
||||
<table class="wrapped"><colgroup><col/><col/></colgroup><tbody>
|
||||
<tr><th><p>Who should read this</p></th><td><p>All Struts 2 developers and users</p></td></tr>
|
||||
<tr><th><p>Impact of vulnerability</p></th><td><p>IMPACT PHRASE</p></td></tr>
|
||||
<tr><th><p>Maximum security rating</p></th><td><p>Low | Moderate | Important | Critical</p></td></tr>
|
||||
<tr><th><p>Recommendation</p></th><td><p>Upgrade to Struts X.Y.Z at least</p></td></tr>
|
||||
<tr><th><p>Affected Software</p></th><td><ul style="list-style-type: square;">
|
||||
<li>Struts A.B.C through Struts D.E.F</li></ul></td></tr>
|
||||
<tr><th><p>Reporters</p></th><td><p>REPORTER</p></td></tr>
|
||||
<tr><th><p>CVE Identifier</p></th><td><p>CVE-YYYY-NNNNN (to be assigned before publication)</p></td></tr>
|
||||
</tbody></table>
|
||||
<h2>Problem</h2>
|
||||
<p>WHAT THE DEFECT ALLOWS, IN OPERATOR TERMS.</p>
|
||||
<p>WHO IS NOT AFFECTED, AND WHY.</p>
|
||||
<h2>Solution</h2>
|
||||
<p>Upgrade to Struts X.Y.Z at least.</p>
|
||||
<h2>Backward compatibility</h2>
|
||||
<p>This change is backward compatible.</p>
|
||||
<h2>Workaround</h2>
|
||||
<p>WORKAROUND, OR A STATEMENT THAT NONE EXISTS.</p>
|
||||
```
|
||||
@@ -1,329 +0,0 @@
|
||||
---
|
||||
name: creating-version-notes
|
||||
description: Use when preparing, updating, or reviewing the release documentation for a Struts release or release candidate on any maintenance line (6.x, 7.x) - the Version Notes page on the cwiki, its Migration Guide entry, the GitHub release notes, and the test-build announcement mail.
|
||||
---
|
||||
|
||||
# Creating Version Notes
|
||||
|
||||
## Overview
|
||||
|
||||
A Version Notes page answers one question for a user deciding whether to upgrade: **what changed in this release, and what will break.** Almost all of it is a mechanical rendering of a JIRA fix version onto fixed boilerplate.
|
||||
|
||||
**Core principle:** the mechanical parts must be *derived*, never retyped; the two judgement parts — Breaking changes, and how a security fix is described — are the only places you author prose.
|
||||
|
||||
**One skill covers every maintenance line.** 6.x and 7.x pages share an identical structure. The line changes the data (version, prior page, JIRA ids), never the process.
|
||||
|
||||
**This is phase 3 of a seven-phase release.** `releasing-struts` holds the sequence, the gates and the mechanics either side of it; this skill owns the paperwork.
|
||||
|
||||
## The Iron Rule
|
||||
|
||||
```
|
||||
START FROM THE TEMPLATE. NEVER CLONE THE PREVIOUS VERSION NOTES PAGE.
|
||||
```
|
||||
|
||||
Cloning is how the published pages acquired their defects, and it fails differently every time:
|
||||
|
||||
| Page | Inherited defect |
|
||||
|---|---|
|
||||
| Version Notes 6.9.0 | Issue Detail links **"JIRA Release Notes 6.8.0"** — label and `version=` id both from 6.8.0 |
|
||||
| Version Notes 6.10.0 | Issue List links **"Struts 6.9.0 DONE"** — label names the previous release, against a `filter=` id different from the one the 6.9.0 page used |
|
||||
| Both series | Maven Dependency code macro carries `ac:name=""` instead of `ac:name="language"` |
|
||||
|
||||
Half-updated links are the signature failure: the number gets fixed and the label doesn't, or the reverse. They survive review because the link still works — it just points at, or claims to be, the wrong release.
|
||||
|
||||
**[`version-notes-template.md`](version-notes-template.md) is the source of truth**: field guidance, storage-format skeleton with those defects corrected, and the pre-publication checklist.
|
||||
|
||||
## Collect every input before writing
|
||||
|
||||
Each row is derived from a named source. A value you cannot source is a visible placeholder, never a guess.
|
||||
|
||||
| Input | Where it comes from |
|
||||
|---|---|
|
||||
| Version | The release being voted or announced |
|
||||
| Parent page | Always **Migration Guide** (page id `13981`) — every Version Notes page is a child of it |
|
||||
| Prior notes page title | The previous **released** version in the same series — see below |
|
||||
| JIRA version id | Numeric id behind `ReleaseNote.jspa?version=` — from the WW project's versions, **not** the version name |
|
||||
| DONE filter id | The saved JIRA filter for this release; a new release needs a new filter |
|
||||
| Issue list | `project = WW AND fixVersion = <version>`, grouped by type |
|
||||
| Breaking changes | Authored — see below |
|
||||
| Staging Repository block | An explicit decision — see below |
|
||||
|
||||
## The issue list
|
||||
|
||||
Group under `<h2>` per issue type, in this order, omitting any type with no issues:
|
||||
|
||||
**Bug → New Feature → Improvement → Task → Dependency**
|
||||
|
||||
Within a section, order by issue key ascending. Each entry is `[WW-XXXX] - <the JIRA summary verbatim>`.
|
||||
|
||||
**Reconcile against what actually merged.** The JIRA query is the starting point, not the answer. Three mismatches to check:
|
||||
|
||||
- A ticket resolved `Fixed` whose change did not make the release branch — it must not be listed as delivered.
|
||||
- A ticket resolved **`Won't Do`** or otherwise not `Fixed` — it belongs under `Rejected requests`, not in a type section and not dropped. Check the resolution, not just the status: both `Closed` and `Resolved` sit in the Done category.
|
||||
- Work that shipped under a ticket assigned to a different fix version — the notes under-report the release.
|
||||
|
||||
A ticket with no commit in the range is not automatically wrong. Check its **component** first: `IDEA Plugin`, `Example Applications` and similar live in other repositories and are still legitimately part of the release.
|
||||
|
||||
**Reconcile through the ticket's linked PR, reading the files it changed.** Do not grep commit subjects, and do not go looking for the class named in the ticket title: a title often names the *symptom* while the fix lives elsewhere. WW-5630 reads "Performance Issue SecurityMemberAccess" and was fixed in `ConfigParseUtil`; searching for the former concludes, wrongly, that the backport is missing. Squash-merges also rewrite hashes, so the merge commit id from the PR need not appear on the branch.
|
||||
|
||||
**Untick eted patch-level dependency bumps are not a gap.** Dependabot PRs for patch updates are merged directly and deliberately get no ticket, so they get no entry — there is nothing to link. Expect the pom to show a higher patch version than the ticket text says: 6.11.0 shipped jackson 2.22.1 while WW-5648 reads "2.21.4 to 2.22.0". That is correct, not an omission. Minor and major bumps do get a ticket and do get listed.
|
||||
|
||||
Where a ticket's summary was written for triage rather than for users, the page may carry a clearer summary — but then it is authored text, and the link must still resolve to that ticket.
|
||||
|
||||
## Only released versions belong in the chain
|
||||
|
||||
The prior-notes link forms a chain through the series, and it **skips versions that were cut but never released**. Version Notes 7.2.1 links back to 7.1.1, not to the withdrawn 7.2.0.
|
||||
|
||||
When a release is superseded before it ships, its content does not disappear — the successor absorbs it. 7.2.1 carries the Breaking changes for the whole 7.2.x cycle. Check what the predecessor covered before assuming your issue list is complete.
|
||||
|
||||
This is the same discipline `creating-security-bulletins` applies to Affected Software, for the same reason: naming a version that never reached users misdirects everyone downstream.
|
||||
|
||||
## Page section order
|
||||
|
||||
Beyond the boilerplate, sections appear in this order, each omitted when empty:
|
||||
|
||||
**Breaking changes → Deprecations → Rejected requests → Bug → New Feature → Improvement → Task → Dependency → Issue Detail → Issue List → Other resources**
|
||||
|
||||
The first three are authored; the issue-type sections are derived from JIRA.
|
||||
|
||||
## Breaking changes
|
||||
|
||||
Present only when the release has them — a maintenance release usually does not.
|
||||
|
||||
Each item is **one sentence plus its ticket link**:
|
||||
|
||||
```
|
||||
<what changed, in terms of what an application sees> [WW-XXXX].
|
||||
```
|
||||
|
||||
> Annotated wildcard actions are matched most-specific-first, so action selection can differ [WW-3784].
|
||||
|
||||
> `JSONInterceptor` uses a fresh reader and writer per request, so custom ones must not hold state between requests [WW-5650].
|
||||
|
||||
The sentence exists so a reader can judge **whether to open the ticket**, not so they can avoid opening it. The ticket carries the detail — API signatures, migration steps, the config that changes. Naming the affected type or setting is enough; enumerating what replaces it is the ticket's job.
|
||||
|
||||
Derive each item from the fix diff rather than the ticket title, and write only what you confirmed. A change you suspect is breaking but could not pin down is one to raise with the release manager, not to describe vaguely.
|
||||
|
||||
## Deprecations
|
||||
|
||||
Where a release deprecates public API, list it separately from Breaking changes — nothing stops working yet, so mixing the two overstates the upgrade cost. Same one-line shape, naming the replacement where there is one:
|
||||
|
||||
> `ConversionRule.COLLECTION` and the `Collection_` key prefix are deprecated; use `ConversionRule.ELEMENT` and `Element_` instead [WW-5656].
|
||||
|
||||
## Rejected requests
|
||||
|
||||
A ticket resolved **`Won't Do`** (or otherwise not `Fixed`) against this fix version is still news: someone asked for it and the project decided against it.
|
||||
|
||||
- **Do not put it in a type section.** Under Improvement or New Feature it reads as delivered.
|
||||
- **Do not silently drop it either.** The decision is the value.
|
||||
- List it under `Rejected requests`, saying it will not be implemented and, where the release manager gave one, the reason.
|
||||
|
||||
> [WW-2635] - Flash scope - will not be implemented; the proposed mechanism could introduce a security risk.
|
||||
|
||||
Note the JIRA-generated release notes linked from the page *will* still include these tickets under their type. Clearing the fix version in JIRA is the only way to change that, and is the release manager's call.
|
||||
|
||||
## Security fixes in a release
|
||||
|
||||
A release usually ships before its bulletin publishes and before a CVE exists. The Version Notes then list a **public, neutrally-framed** ticket for a defect whose advisory is still restricted.
|
||||
|
||||
- List the ticket as you would any other. It is already public; omitting it under-reports the release.
|
||||
- **Do not add security framing the bulletin has not published yet** — no severity, no attack description, no S2-XXX or CVE number that has not been assigned and published.
|
||||
- Once the bulletin is public, the notes may link it.
|
||||
|
||||
**Where the ticket's own summary describes the defect, list the neutral part of it.** "List the summary verbatim" assumes a neutrally-worded ticket, and security tickets often are not. WW-5643 reads *"StrutsJSONReader parse state shared across concurrent requests — maxDepth bypass and cross-request data leak"*; the page carried it up to "concurrent requests" and stopped. The trailing clause is the bulletin's job.
|
||||
|
||||
Truncate at the clause boundary — never paraphrase into something the ticket does not say, and never alter the ticket link. Then **tell the release manager which summaries you cut and why**: whether an already-public JIRA summary should be reproduced in full is their call, not yours, and it has to be made before the page goes up rather than edited afterwards.
|
||||
|
||||
**REQUIRED BACKGROUND:** where the wording of a security-relevant entry is in question, `creating-security-bulletins` governs what may be said and when.
|
||||
|
||||
## The Staging Repository block
|
||||
|
||||
**Include it.** The block points readers at ASF Nexus staging so they can test the artifacts before the vote closes, and it stays on the page afterwards.
|
||||
|
||||
Older 6.x pages (6.9.0, 6.10.0) lack it while the 7.x pages carry it. That is an artefact of cloning within each series, not a difference between the lines — 6.11.0 carries it.
|
||||
|
||||
## Link the new page from the Migration Guide
|
||||
|
||||
The page is not finished when it is created. **[Migration Guide](https://cwiki.apache.org/confluence/spaces/WW/pages/13981/Migration+Guide) (id `13981`) is both the parent page and the index**, and a Version Notes page that is not listed there is unreachable by anyone browsing.
|
||||
|
||||
Add an entry at the **top** of the list under the `<h2>` for the matching line — `Version Notes 7.x`, `Version Notes 6.x`, and so on. The lists are newest-first, and the entry is a page link carrying no body text:
|
||||
|
||||
```xml
|
||||
<li><ac:link><ri:page ri:content-title="Version Notes X.Y.Z"/></ac:link></li>
|
||||
```
|
||||
|
||||
**Update the section, not the whole page.** `confluence_update_page_section` on the exact heading replaces only that section's body; its boundary is the next `<h2>`, so the section body includes the `<h3>` migration-guide link that follows the list. Supply that `<h3>` and its paragraph in the replacement content or they are dropped.
|
||||
|
||||
**Verify against raw storage, not the diff.** A version diff of this page renders empty even for a real change, because the markdown view discards `ac:link` bodies. Fetch the new version with `convert_to_markdown=false` and confirm the new entry is present, the prior entries survive in order, and the trailing `<h3>` appears exactly once.
|
||||
|
||||
This applies to **every** section update, including ones on the Version Notes page itself — shortening `Breaking changes` carries the same risk of swallowing the `Deprecations` heading that follows it. After any section write, confirm the sections below it are still present exactly once. Where the page has no `ac:link` in it, the cheaper markdown fetch is enough to see the headings.
|
||||
|
||||
## Writing pages through the API
|
||||
|
||||
`content_file` is rejected for any path outside the repository — a scratchpad path fails as path traversal. Draft wherever you like, but **pass the body as inline `content`** when creating or updating a page.
|
||||
|
||||
The response carries the new version number. On a page you have just written, that number is its own check: a create followed by one update should report version 2, so anything higher means someone else wrote in between.
|
||||
|
||||
## The GitHub release notes
|
||||
|
||||
A release also has a GitHub release at the `STRUTS_X_Y_Z` tag, kept as a **pre-release** while the vote runs. GitHub's generated body is a starting point that needs two corrections before it is fit to publish.
|
||||
|
||||
### Name the previous tag yourself
|
||||
|
||||
**Never let GitHub choose the range.** It picks the previous tag by reachability, and Struts release branches get renamed and re-imported, so older tags are frequently *not* ancestors of the new one and the heuristic reaches too far back. For 6.11.0 it chose `STRUTS_6_8_0` and produced ~101 entries, 88 of which had already shipped in 6.9.0 and 6.10.0.
|
||||
|
||||
Generate the body with the previous release named explicitly, and it comes out right the first time:
|
||||
|
||||
```bash
|
||||
gh api -X POST repos/apache/struts/releases/generate-notes \
|
||||
-f tag_name=STRUTS_7_3_0 -f previous_tag_name=STRUTS_7_2_1 -q .body > generated.md
|
||||
```
|
||||
|
||||
Confirm the entry count is plausible against the real change set, which `git log` gives even across unrelated histories:
|
||||
|
||||
```bash
|
||||
git log --format='%h %s' STRUTS_7_2_1..STRUTS_7_3_0
|
||||
```
|
||||
|
||||
**If you inherit a body GitHub generated on its own**, check the `**Full Changelog**: .../compare/<PREVIOUS>...<THIS>` line first, and regenerate as above rather than pruning by hand. When pruning is unavoidable, drop `## New Contributors` too if the contribution it cites falls outside the range — but keep it when the contributors are genuinely new in this range.
|
||||
|
||||
### Split the entries
|
||||
|
||||
Two sections, `### Dependencies` nested under `## What's Changed`, before any `## New Contributors`:
|
||||
|
||||
| Entry | Section |
|
||||
|---|---|
|
||||
| Carries a `WW-XXXX` ticket — whoever authored it | `## What's Changed` |
|
||||
| A human PR that is not a dependency change (ci, chore, release prep) | `## What's Changed` |
|
||||
| A dependency bump with **no** ticket | `### Dependencies` |
|
||||
|
||||
**The discriminator is the ticket, not the author.** A Dependabot PR carrying a ticket stays in What's Changed, because a ticketed bump is release content and appears in the Version Notes Dependency section. A human PR that is purely a dependency change (`Removes unused jaxb-core dependency`) belongs under Dependencies. Both cases occur in the 6.9.0 release.
|
||||
|
||||
A PR that mixes a dependency change with something else — CVE-driven library updates *plus* a CI tweak — stays in What's Changed. Dependencies is for entries that are nothing but a bump.
|
||||
|
||||
Preserve the generated relative order within each section, and keep the entry lines byte-identical — they carry the author and PR links GitHub rendered. Split with a script rather than by retyping, then **prove nothing was lost**:
|
||||
|
||||
```bash
|
||||
diff <(grep '^\* ' generated.md | sort) <(grep '^\* ' new.md | sort)
|
||||
```
|
||||
|
||||
Empty output means the entry set is unchanged and only the grouping moved.
|
||||
|
||||
### Applying it
|
||||
|
||||
The release may or may not exist yet — check before assuming which command you need.
|
||||
|
||||
```bash
|
||||
# it exists (release cut earlier, or notes already generated):
|
||||
gh release view STRUTS_X_Y_Z --json body -q .body > original.md # keep, so it can be restored
|
||||
gh release edit STRUTS_X_Y_Z --prerelease --notes-file new.md
|
||||
|
||||
# it does not exist yet:
|
||||
gh release create STRUTS_X_Y_Z --title "Struts X.Y.Z" --prerelease --verify-tag --notes-file new.md
|
||||
```
|
||||
|
||||
Pass `--prerelease` either way, so a release still under vote is not silently promoted, and `--verify-tag` on create so a typo in the tag fails instead of creating one.
|
||||
|
||||
## The test-build announcement
|
||||
|
||||
Once the Version Notes page and the GitHub release are both up, the release manager announces the test build so people can exercise the staged artifacts during the vote. **Draft it last** — every link in it points at something the earlier steps produced.
|
||||
|
||||
Subject is `[TEST] Apache Struts X.Y.Z test build is ready`. Send it to **both** lists, Bcc the private one:
|
||||
|
||||
```
|
||||
To: dev@struts.apache.org, user@struts.apache.org
|
||||
Bcc: private@struts.apache.org
|
||||
```
|
||||
|
||||
Both audiences want it — committers to check the staged artifacts, users to test against their own applications — and a build announced to only one of them reaches half the people who could find a problem during the vote.
|
||||
|
||||
The body is fixed apart from four substitutions:
|
||||
|
||||
```
|
||||
Hello,
|
||||
|
||||
This is a minor release of Struts <LINE> which contains <WHAT>, and it
|
||||
shouldn't break your code<RISK>. Please take your time and test the bits
|
||||
- any help is appreciated. Please report any problems you will spot.
|
||||
|
||||
Here are the changes from the previous version:
|
||||
https://github.com/apache/struts/releases/tag/STRUTS_X_Y_Z
|
||||
|
||||
Staging Maven repo
|
||||
https://repository.apache.org/content/groups/staging/
|
||||
|
||||
Standalone artifacts
|
||||
https://dist.apache.org/repos/dist/dev/struts/X.Y.Z/
|
||||
|
||||
Release notes
|
||||
https://cwiki.apache.org/confluence/display/WW/Version+Notes+X.Y.Z
|
||||
|
||||
Kind regards
|
||||
--
|
||||
Łukasz
|
||||
```
|
||||
|
||||
| Slot | How to fill it |
|
||||
|---|---|
|
||||
| `<LINE>` | `6.x` or `7.x` |
|
||||
| `<WHAT>` | What the issue list actually contains — `mostly bug fixes` for 6.11.0, `a few improvements and bug fixes` for 7.3.0 |
|
||||
| `<RISK>` | Empty when the release has no Breaking changes; ` but it contains significant changes` when it does. 6.11.0 had none and said nothing; 7.3.0 had seven and said so |
|
||||
| Tag / paths | Tag underscored (`STRUTS_7_3_0`), dist path and page title dotted (`7.3.0`) |
|
||||
|
||||
Do not take the recipients from a previous announcement: 6.11.0 went to `dev@` alone and 7.3.0 to `user@` alone, and both were mistakes. Address every announcement to the two lists above.
|
||||
|
||||
Keep the security posture of the pages: the mail links the release notes, it does not summarise what is in them, so no severity, CVE or S2-XXX reaches it either.
|
||||
|
||||
**The vote is the next step, and it is a different mail.** Once the test build is announced, `creating-release-vote-mail` composes the `[VOTE] Apache Struts X.Y.Z` call — to `dev@` alone, rendered from the page this skill produced. Do not draft it from here: its recipients, subject and body all differ from the announcement above.
|
||||
|
||||
## Re-read the page immediately before you write to it
|
||||
|
||||
Confluence has no conflict warning. Fetch the current version immediately before every write and compare the version number against the one you read; if it advanced, re-read, merge onto the newer content, and write that.
|
||||
|
||||
After writing, diff against the version you meant to build on. The diff should show only your intended change.
|
||||
|
||||
## Red Flags — STOP
|
||||
|
||||
- Starting from a copy of the previous release's page
|
||||
- A version number or JIRA id typed rather than derived
|
||||
- A link whose label and its id name different releases
|
||||
- The prior-notes link pointing at a version that was cut but never released
|
||||
- Publishing the issue list straight from JIRA without reconciling against the release branch
|
||||
- Concluding a backport is missing from a commit-subject grep, or from the class named in the ticket title
|
||||
- Treating an untick eted patch dependency bump as a reconciliation gap
|
||||
- Dropping a `Won't Do` ticket, or listing it under Improvement or New Feature as though it shipped
|
||||
- A Breaking changes item that runs past one sentence, or restates what the ticket already explains
|
||||
- Reproducing a security ticket's summary in full when it names the bypass or the leak
|
||||
- Letting GitHub pick the previous tag instead of passing `previous_tag_name`
|
||||
- Regrouping release entries by retyping them instead of scripting the split and diffing the result
|
||||
- A severity, CVE, or S2-XXX reference on the page that has not been published
|
||||
- Breaking changes assembled by pasting ticket summaries
|
||||
- Creating the page without adding it to the Migration Guide index
|
||||
- Trusting an empty version diff on the Migration Guide as proof the edit landed
|
||||
- Publishing GitHub release notes without checking which tag the Full Changelog compares against
|
||||
- Splitting the GitHub sections by author instead of by whether the entry carries a ticket
|
||||
- Editing a GitHub release under vote without `--prerelease`
|
||||
- Writing from page content read earlier in the session without re-fetching
|
||||
|
||||
## Common Mistakes
|
||||
|
||||
| Mistake | Reality |
|
||||
|---|---|
|
||||
| "Copying last release's page is faster" | It is how "JIRA Release Notes 6.8.0" shipped on the 6.9.0 page. Copy the template. |
|
||||
| "I updated the link, it's fine" | Check the label too. Every observed defect is a half-updated link. |
|
||||
| "`version=` takes the version number" | It takes JIRA's numeric version id. Look it up. |
|
||||
| "The DONE filter can be reused" | A reused filter shows the previous release's issues under this release's heading. |
|
||||
| "JIRA is the release contents" | JIRA is the claim. The release branch is the fact. Reconcile. |
|
||||
| "No commit mentions the ticket, so it wasn't backported" | Read the linked PR's changed files. Titles name symptoms, and squash-merges rewrite hashes. |
|
||||
| "The pom version doesn't match the ticket, that's a gap" | Patch bumps ship untick eted by design. Only ticketed bumps get an entry. |
|
||||
| "The page is created, so the work is done" | It is invisible until listed on the Migration Guide. |
|
||||
| "The version diff is empty, so nothing changed" | The diff renders markdown, which drops `ac:link` bodies. Check raw storage. |
|
||||
| "GitHub generated the changelog, so the range is right" | It guesses the previous tag by reachability. Renamed branches make it reach too far back. Verify with `git log PREV..THIS`. |
|
||||
| "Dependabot authored it, so it goes under Dependencies" | Ticketed bumps stay in What's Changed. The ticket decides, not the author. |
|
||||
| "A Won't Do ticket isn't part of the release" | The decision is news. It goes under Rejected requests, not into a type section and not into the bin. |
|
||||
| "More detail in Breaking changes is safer" | One sentence plus the ticket link. The reader opens the ticket for detail; the page exists to tell them whether to. |
|
||||
| "The summary is public in JIRA, so I can repeat it" | Not when it names the bypass or the leak and the bulletin is unpublished. Truncate, and say you did. |
|
||||
| "GitHub will work out the previous tag" | Pass `previous_tag_name` and it is right the first time. |
|
||||
| "The fix is public, so I can describe the vulnerability" | The ticket being public does not publish the advisory. Neutral framing until the bulletin ships. |
|
||||
| "Breaking changes are the tickets typed as breaking" | They are the changes that break an application. Author them. |
|
||||
| "7.x needs different handling from 6.x" | Same structure, same process. Only the data differs. |
|
||||
@@ -1,152 +0,0 @@
|
||||
# Version Notes Template
|
||||
|
||||
The canonical skeleton and per-field guidance for a Struts **Version Notes X.Y.Z** page
|
||||
on the [Apache Struts 2 Wiki](https://cwiki.apache.org/confluence/spaces/WW) (space `WW`).
|
||||
Companion to [`SKILL.md`](SKILL.md), which covers *how* to establish the values;
|
||||
this file covers *what the page contains*.
|
||||
|
||||
**This file is the source of truth.** Start every page from the skeleton below, never
|
||||
from a copy of the previous release's page — see the Iron Rule in `SKILL.md`.
|
||||
|
||||
## Fields
|
||||
|
||||
| Field | What goes in it |
|
||||
|---|---|
|
||||
| Version | The release being announced, e.g. `6.11.0`. Appears in the intro sentence, the page title, the Maven snippet, and both JIRA link labels. |
|
||||
| Parent page | Always `Migration Guide`, page id `13981`. Create the page as its child, and add it to that page's index — see `SKILL.md`. |
|
||||
| Prior notes page | Title of the previous **released** version's page in the same series, e.g. `Version Notes 6.10.0`. Skip versions that were cut but never released. |
|
||||
| JIRA version id | The numeric id for `ReleaseNote.jspa?version=`. Obtain from the WW project's versions — it is not the version name. `6.10.0` is `12357065`, `7.2.1` is `12355751`. |
|
||||
| DONE filter id | Saved-filter id for `issues/?filter=`, labelled `Struts X.Y.Z DONE`. Each release needs its own; a reused id lists the wrong release. |
|
||||
| TODO filter id | Constant across releases: `12351174`, labelled `Struts x.x.x TODO`. |
|
||||
| Issue sections | One `<h2>` per issue type present, ordered **Bug → New Feature → Improvement → Task → Dependency**, entries sorted by key ascending. |
|
||||
| Breaking changes | Optional. Authored, **one sentence plus the ticket link** per item. Omit the section when the release has none. |
|
||||
| Deprecations | Optional. Same one-line shape, for public API deprecated but still working. |
|
||||
| Rejected requests | Optional. Tickets resolved `Won't Do` against this fix version — never in a type section. |
|
||||
| Staging Repository | Always included, on every line — see `SKILL.md`. |
|
||||
|
||||
## Corrected storage format
|
||||
|
||||
Three defects present in the published pages are fixed here. Keep them fixed:
|
||||
|
||||
1. **`ac:name="language"` on the code macros.** The published Maven Dependency and
|
||||
Staging Repository macros carry `ac:name=""` with the value `xml`, which is a
|
||||
malformed parameter. The Archetype Catalog macro on the same pages has it right.
|
||||
2. **No `ac:macro-id` attributes.** The published pages share hard-coded macro ids
|
||||
across releases and across series because they were cloned. Omit the attribute and
|
||||
let Confluence assign one on save.
|
||||
3. **No trailing empty `<div>`s.** Every published page ends with two empty divs
|
||||
carrying inline `font-size: 24.0px` styling. They render as stray whitespace.
|
||||
|
||||
```xml
|
||||
<p><ac:emoticon ac:name="tick"/> These are the notes for the Struts version X.Y.Z distribution.</p>
|
||||
<p><ac:emoticon ac:name="tick"/> For prior notes in this release series, see <ac:link><ri:page ri:content-title="Version Notes PRIOR"/></ac:link></p>
|
||||
<p><ac:structured-macro ac:name="toc" ac:schema-version="1"/></p>
|
||||
|
||||
<h2>Maven users</h2>
|
||||
<p>If you are a Maven user, you might want to get started using the <ac:link><ri:page ri:content-title="Struts 2 Maven Archetypes"/><ac:plain-text-link-body><![CDATA[Maven Archetype]]></ac:plain-text-link-body></ac:link>.</p>
|
||||
<ac:structured-macro ac:name="code" ac:schema-version="1">
|
||||
<ac:parameter ac:name="title">Maven Dependency</ac:parameter>
|
||||
<ac:parameter ac:name="language">xml</ac:parameter>
|
||||
<ac:plain-text-body><![CDATA[<dependency>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-core</artifactId>
|
||||
<version>X.Y.Z</version>
|
||||
</dependency>
|
||||
]]></ac:plain-text-body>
|
||||
</ac:structured-macro>
|
||||
<p>You can also use Struts Archetype Catalog like below</p>
|
||||
<ac:structured-macro ac:name="code" ac:schema-version="1">
|
||||
<ac:parameter ac:name="language">text</ac:parameter>
|
||||
<ac:parameter ac:name="title">Struts Archetype Catalog</ac:parameter>
|
||||
<ac:plain-text-body><![CDATA[mvn archetype:generate -DarchetypeCatalog=http://struts.apache.org/]]></ac:plain-text-body>
|
||||
</ac:structured-macro>
|
||||
|
||||
<ac:structured-macro ac:name="code" ac:schema-version="1">
|
||||
<ac:parameter ac:name="title">Staging Repository</ac:parameter>
|
||||
<ac:parameter ac:name="language">xml</ac:parameter>
|
||||
<ac:plain-text-body><![CDATA[<repositories>
|
||||
<repository>
|
||||
<id>apache.nexus</id>
|
||||
<name>ASF Nexus Staging</name>
|
||||
<url>https://repository.apache.org/content/groups/staging/</url>
|
||||
</repository>
|
||||
</repositories>]]></ac:plain-text-body>
|
||||
</ac:structured-macro>
|
||||
|
||||
<!-- OPTIONAL: omit the whole section when the release has no breaking changes -->
|
||||
<h2>Breaking changes</h2>
|
||||
<ul style="list-style-type: square;">
|
||||
<li>ONE SENTENCE: WHAT AN APPLICATION SEES DIFFERENTLY [<a href="https://issues.apache.org/jira/browse/WW-XXXX">WW-XXXX</a>].</li>
|
||||
</ul>
|
||||
|
||||
<!-- OPTIONAL: public API deprecated but still working -->
|
||||
<h2>Deprecations</h2>
|
||||
<ul style="list-style-type: square;">
|
||||
<li><code>WHAT</code> is deprecated; use <code>REPLACEMENT</code> instead [<a href="https://issues.apache.org/jira/browse/WW-XXXX">WW-XXXX</a>].</li>
|
||||
</ul>
|
||||
|
||||
<!-- OPTIONAL: tickets resolved Won't Do against this fix version -->
|
||||
<h2>Rejected requests</h2>
|
||||
<p>Two long-standing requests were closed as <em>Won't Do</em> in this cycle. They are listed here so the decision is visible rather than silent.</p>
|
||||
<ul style="list-style-type: square;">
|
||||
<li>[<a href="https://issues.apache.org/jira/browse/WW-XXXX">WW-XXXX</a>] - SUMMARY - will not be implemented; REASON WHERE THE RELEASE MANAGER GAVE ONE.</li>
|
||||
</ul>
|
||||
|
||||
<h2>Bug</h2>
|
||||
<ul><li>[<a href="https://issues.apache.org/jira/browse/WW-XXXX">WW-XXXX</a>] - JIRA SUMMARY</li></ul>
|
||||
|
||||
<h2>Issue Detail</h2>
|
||||
<ul><li><a href="https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311041&version=JIRA_VERSION_ID">JIRA Release Notes X.Y.Z</a></li></ul>
|
||||
|
||||
<h2>Issue List</h2>
|
||||
<ul>
|
||||
<li><a href="https://issues.apache.org/jira/issues/?filter=DONE_FILTER_ID">Struts X.Y.Z DONE</a></li>
|
||||
<li><a href="https://issues.apache.org/jira/issues/?filter=12351174">Struts x.x.x TODO</a></li>
|
||||
</ul>
|
||||
|
||||
<h2>Other resources</h2>
|
||||
<ul>
|
||||
<li><a href="http://www.mail-archive.com/commits%40struts.apache.org/">Commit Logs</a></li>
|
||||
<li><a href="https://gitbox.apache.org/repos/asf?p=struts.git;a=summary">Source Code Repository</a></li>
|
||||
</ul>
|
||||
```
|
||||
|
||||
Repeat the issue `<h2>` block per type present, in the order given above.
|
||||
`projectId=12311041` is the WW project and is constant. Note `&` in the
|
||||
`ReleaseNote.jspa` URL — a bare `&` is invalid in storage format.
|
||||
|
||||
## Before publishing
|
||||
|
||||
- [ ] Every placeholder is replaced, and no guidance text survives on the page.
|
||||
- [ ] Page title is `Version Notes X.Y.Z` and the intro names the same version.
|
||||
- [ ] Prior-notes link resolves, and names the previous **released** version.
|
||||
- [ ] Maven snippet version matches the release.
|
||||
- [ ] `ReleaseNote.jspa` label and its `version=` id are the same release.
|
||||
- [ ] `DONE` filter label and its `filter=` id are the same release.
|
||||
- [ ] Issue list reconciled against the release branch via each ticket's linked PR, not taken from JIRA alone.
|
||||
- [ ] Every ticket's **resolution** checked, not just its status — `Won't Do` goes under Rejected requests.
|
||||
- [ ] Sections ordered Breaking changes → Deprecations → Rejected requests → Bug → New Feature → Improvement → Task → Dependency; empty ones omitted.
|
||||
- [ ] Each Breaking changes and Deprecations item is one sentence plus its ticket link.
|
||||
- [ ] Staging Repository block present.
|
||||
- [ ] No unpublished severity, CVE, or S2-XXX reference anywhere on the page, and any security summary truncated at a clause boundary was reported to the release manager.
|
||||
- [ ] Page created as a child of Migration Guide (`13981`).
|
||||
- [ ] **Listed at the top of the matching `Version Notes N.x` section on the Migration Guide**, and that edit verified against raw storage — the version diff renders empty even when the change landed.
|
||||
- [ ] Page re-fetched immediately before every write.
|
||||
|
||||
## GitHub release notes
|
||||
|
||||
- [ ] Body generated with `previous_tag_name` named explicitly, not left to GitHub's guess.
|
||||
- [ ] Entry count sane against `git log PREV..THIS`.
|
||||
- [ ] Original body saved first when editing an existing release, so it can be restored.
|
||||
- [ ] Entries split by **ticket, not author**: ticketed → `## What's Changed`; untick eted dependency bumps → `### Dependencies`; mixed PRs stay in What's Changed.
|
||||
- [ ] Generated order and entry text preserved within each section.
|
||||
- [ ] Split verified by diffing the sorted entry lists before and after — empty output.
|
||||
- [ ] `--prerelease` passed while the vote is open; `--verify-tag` when creating.
|
||||
|
||||
## Test-build announcement
|
||||
|
||||
- [ ] Drafted **after** the Version Notes page and GitHub release exist — it links both.
|
||||
- [ ] Subject `[TEST] Apache Struts X.Y.Z test build is ready`.
|
||||
- [ ] Addressed to **both** `dev@struts.apache.org` and `user@struts.apache.org`, Bcc `private@struts.apache.org`.
|
||||
- [ ] Risk clause matches reality: silent when there are no Breaking changes, "but it contains significant changes" when there are.
|
||||
- [ ] Tag underscored in the release link, version dotted in the dist path and page title.
|
||||
@@ -1,204 +0,0 @@
|
||||
---
|
||||
name: merging-dependabot-prs
|
||||
description: Use when triaging, classifying or landing Dependabot pull requests in this repo — clearing the open Dependabot queue, deciding whether a bump needs a WW Jira ticket, or checking whether a bump's build actually passed.
|
||||
---
|
||||
|
||||
# Merging Dependabot PRs
|
||||
|
||||
## Overview
|
||||
|
||||
Dependabot opens bumps against `main` and `support/struts-6-x-x`. Most land as-is.
|
||||
A bump that **ships to users** needs a WW Jira ticket first, and the ticket ID must
|
||||
reach the PR title, the PR body and the squash commit subject before it merges.
|
||||
|
||||
**Core principle: the decision is driven by the dependency's real Maven scope, not by
|
||||
what Dependabot calls it.** Dependabot's `build(deps-dev):` prefix and its
|
||||
`dependency-type:` trailer are guesses about *its own* ecosystem, not this project's
|
||||
POM. Read the POM.
|
||||
|
||||
## The decision
|
||||
|
||||
Read the semver class from the Dependabot commit trailer — never parse version strings:
|
||||
|
||||
```bash
|
||||
gh pr view <N> --json commits --jq '.commits[].messageBody' \
|
||||
| grep -E 'dependency-name:|update-type:'
|
||||
# update-type: version-update:semver-{patch|minor|major}
|
||||
```
|
||||
|
||||
Then find the real scope, and cross the two:
|
||||
|
||||
| What is being bumped | patch | minor | major |
|
||||
|---|---|---|---|
|
||||
| GitHub Action (`.github/workflows/*`) | merge bare | merge bare | merge bare |
|
||||
| Maven **plugin** or build tooling (`<build><plugins>`, `*-maven-plugin`, `maven-wrapper`) | merge bare | merge bare | merge bare |
|
||||
| Maven dep, `<scope>test</scope>` | merge bare | merge bare | merge bare |
|
||||
| Maven dep in `apps/` (showcase, rest-showcase) | merge bare | merge bare | merge bare |
|
||||
| Maven dep, **compile / runtime / provided** — including `<optional>true</optional>` | merge bare | **TICKET** | **TICKET** |
|
||||
|
||||
"Merge bare" always still requires a green build (see below).
|
||||
|
||||
### Finding the real scope
|
||||
|
||||
```bash
|
||||
grep -rn '<artifactId>NAME</artifactId>' --include=pom.xml . | grep -v /target/
|
||||
```
|
||||
|
||||
Read the `<scope>` on the surrounding `<dependency>` block in the module that declares it
|
||||
(`core/pom.xml`, `plugins/*/pom.xml`), not the `<dependencyManagement>` copy in
|
||||
`parent/pom.xml` — the managed block usually carries no scope.
|
||||
|
||||
- No `<scope>` element means **compile** — it ships.
|
||||
- `<optional>true</optional>` still ships: it is published in the module's POM and users
|
||||
who opt in inherit the version. Optional is not exempt.
|
||||
- For a version property (`jackson.version`, `byte-buddy.version`), resolve the property to
|
||||
the artifacts it feeds and take the widest scope among them.
|
||||
|
||||
## Is the build actually green?
|
||||
|
||||
`.asf.yaml` makes exactly one context required per branch:
|
||||
`Build and Test (JDK 17)` on `main`, `Build and Test (8)` on `support/struts-6-x-x`.
|
||||
|
||||
```bash
|
||||
gh pr view <N> --json mergeStateStatus,statusCheckRollup --jq \
|
||||
'"\(.mergeStateStatus) build=\([.statusCheckRollup[]
|
||||
| select((.name // "") | startswith("Build and Test"))
|
||||
| (.conclusion // .state)] | unique | join(","))"'
|
||||
```
|
||||
|
||||
- Green = every `Build and Test *` job is `SUCCESS`.
|
||||
- `continuous-integration/jenkins/pr-merge` is **not** a required context and flakes red
|
||||
("This commit cannot be built"). `mergeStateStatus: UNSTABLE` with all build jobs green
|
||||
is mergeable. Ignore Jenkins.
|
||||
- Any `Build and Test *` failure, or `mergeStateStatus: BLOCKED` — **stop**. Report it and
|
||||
move on to the next PR.
|
||||
|
||||
## Checkpoint — classify, then stop
|
||||
|
||||
Present one row per open PR and **wait for approval** before any Jira write, title edit or
|
||||
merge. Required columns:
|
||||
|
||||
| PR | Base | Bump | Semver | Real scope (+ where declared) | Build | Action |
|
||||
|
||||
Only after approval, run the recipes below.
|
||||
|
||||
## Landing a bare bump
|
||||
|
||||
```bash
|
||||
gh pr merge <N> --squash --subject "<exact current PR title> (#<N>)"
|
||||
```
|
||||
|
||||
`del_branch_on_merge: true` is set, so no `--delete-branch`.
|
||||
|
||||
## Landing a ticketed bump
|
||||
|
||||
Five steps, in order. All five are required.
|
||||
|
||||
**1. Create the ticket** — `mcp__asf-issues__jira_create_issue`:
|
||||
|
||||
```json
|
||||
{
|
||||
"project_key": "WW",
|
||||
"issue_type": "Dependency",
|
||||
"summary": "Bump <group:artifact or property> from <old> to <new>",
|
||||
"description": "Bump <group:artifact or property> from <old> to <new>",
|
||||
"components": "<affected module>",
|
||||
"additional_fields": "{\"priority\": {\"name\": \"Trivial\"}, \"fixVersions\": [{\"name\": \"<branch release version>\"}]}"
|
||||
}
|
||||
```
|
||||
|
||||
- `components` is its **own** parameter (comma-separated names), not a member of
|
||||
`additional_fields`. `additional_fields` must be a JSON **string**, not an object.
|
||||
- Issue type is **Dependency** — not Task, not Bug.
|
||||
- Component is the module that declares the dep: `Core`, `Plugin - REST`, `Plugin - JSON`,
|
||||
`Unit Tests`, `Build Management`, …
|
||||
- Fix version comes from the target branch's SNAPSHOT with `-SNAPSHOT` dropped
|
||||
(`grep -m1 SNAPSHOT pom.xml`): `main` → 7.4.0, `support/struts-6-x-x` → 6.12.0. This is a
|
||||
placeholder the release process may revise; do not treat it as a release commitment.
|
||||
|
||||
**2. Retitle the PR** — insert the ticket after the conventional-commit prefix, leave every
|
||||
other character alone:
|
||||
|
||||
```bash
|
||||
gh pr edit <N> --title "build(deps): WW-XXXX bump org.htmlunit:htmlunit from 4.21.0 to 5.1.0"
|
||||
# ^^^^^^^^ inserted; prefix and remainder verbatim
|
||||
```
|
||||
|
||||
**3. Add the Closes line to the body** — its own paragraph, after the leading `Bumps …`
|
||||
block and before the first `<details>`. Preserve the rest of Dependabot's body exactly:
|
||||
|
||||
```
|
||||
Bumps [org.htmlunit:htmlunit](https://github.com/HtmlUnit/htmlunit) from 4.21.0 to 5.1.0.
|
||||
|
||||
Closes [WW-XXXX](https://issues.apache.org/jira/browse/WW-XXXX)
|
||||
|
||||
<details>
|
||||
```
|
||||
|
||||
**4. Merge with the ticket in the squash subject:**
|
||||
|
||||
```bash
|
||||
gh pr merge <N> --squash --subject "build(deps): WW-XXXX bump org.htmlunit:htmlunit from 4.21.0 to 5.1.0 (#<N>)"
|
||||
```
|
||||
|
||||
Without an explicit `--subject`, GitHub takes the subject from Dependabot's *commit*
|
||||
headline and the ticket ID is silently lost from git history.
|
||||
|
||||
**5. Close the ticket as Fixed** — only after *every* PR on the ticket has merged:
|
||||
|
||||
```json
|
||||
{"issue_key": "WW-XXXX", "fields": "{\"status\": \"Closed\"}", "return_fields": "status"}
|
||||
```
|
||||
|
||||
The Jira MCP always resolves as *Fixed* and silently swallows any other resolution name —
|
||||
which is what is wanted here.
|
||||
|
||||
## One dependency, two branches, one ticket
|
||||
|
||||
Dependabot opens the same bump separately against `main` and `support/struts-6-x-x`. Before
|
||||
creating anything, look for the twin:
|
||||
|
||||
```bash
|
||||
gh pr list --state open --author app/dependabot --json number,title,baseRefName
|
||||
```
|
||||
|
||||
If a twin exists, create **one** ticket, put it in both PR titles/bodies, and list **both**
|
||||
fix versions on it (WW-5649 carries 6.11.0 and 7.3.0 for PRs #1760 and #1763). Close it once
|
||||
both have merged.
|
||||
|
||||
## Scope of this skill
|
||||
|
||||
Triage and land the queue. Do **not**, as part of it, open follow-up PRs — `dependabot.yml`
|
||||
ignore rules, license-header restorations, test-harness fixes. Report such findings in one
|
||||
line under the table and let the decision be made separately.
|
||||
|
||||
A ticket-worthy bump with a red build is real compatibility work, not a merge. Report the
|
||||
failure and stop; it needs its own ticket and its own branch. Never push a fix onto a
|
||||
Dependabot branch — Dependabot stops rebasing it, and a source change lands under a
|
||||
ticketless `build(deps):` title.
|
||||
|
||||
## Traps
|
||||
|
||||
| Trap | Reality |
|
||||
|---|---|
|
||||
| "It says `build(deps-dev)`, so it's a dev dependency" | That prefix is Dependabot's guess. `commons-validator` arrives as `deps-dev` and is test scope (true), but the prefix is not evidence — the POM is. |
|
||||
| "`dependency-type: direct:production`, so it ships" | `maven-wrapper` and `hibernate-core` both say `direct:production`; one is build tooling, the other ships. Read the POM. |
|
||||
| "`<optional>true</optional>` means users don't get it" | It is in the published POM and pins the version for anyone who opts in. Optional compile deps need a ticket. |
|
||||
| "git log shows no `WW-` on dependency commits, so titles aren't rewritten" | The squash *subject* historically came from Dependabot's commit headline while the *PR title* carried the ticket. Compare `gh pr view 1746 --json title` against `1f1674411`. Step 4 above exists to close that gap. |
|
||||
| "A red check means don't merge" | Only `Build and Test *` counts. The ASF Jenkins context is not required and flakes red. |
|
||||
| "Both branches need their own ticket" | One dependency, one ticket, two fix versions. |
|
||||
| "The build is green, so I can just merge it" | Green is necessary, not sufficient. Classify first, and stop at the checkpoint. |
|
||||
|
||||
## Red flags — stop and re-read
|
||||
|
||||
- About to run `gh pr merge` before presenting the classification table and getting approval
|
||||
- About to run `gh pr merge --squash` on a ticketed bump without `--subject`
|
||||
- Classified a dependency from the PR title alone, without grepping the POM for its scope
|
||||
- Creating a second ticket for a dependency that already has an open twin PR
|
||||
- Opening a follow-up PR that nobody asked for
|
||||
- Creating a Jira issue whose type is anything other than `Dependency`
|
||||
|
||||
## Related
|
||||
|
||||
- `creating-version-notes` — ticketed bumps appear in the Version Notes Dependency section;
|
||||
bare bumps deliberately do not, and their absence is not a reconciliation gap.
|
||||
@@ -1,153 +0,0 @@
|
||||
---
|
||||
name: releasing-struts
|
||||
description: Use when running or planning an Apache Struts release on any maintenance line (6.x, 7.x) - cutting the tag, staging artifacts, opening the vote, promoting, updating the site and announcing - or when asked what the next step in a release is.
|
||||
---
|
||||
|
||||
# Releasing Struts
|
||||
|
||||
## Overview
|
||||
|
||||
A release is seven phases with a gate between each.
|
||||
|
||||
**The process itself is published**, at
|
||||
[Release Guidelines](https://struts.apache.org/release-guidelines.html) — every phase, every
|
||||
command, the release policy and the one-time setup a new release manager needs. It is the source
|
||||
of truth, it is maintained in `apache/struts-site` (`source/release-guidelines.md`), and it is
|
||||
what you follow.
|
||||
|
||||
This skill is the agent's half of it: the judgement about *ordering* and *when to stop*, which
|
||||
sibling skill owns which document, and the points where a step is the release manager's to take
|
||||
rather than yours. [`release-runbook.md`](release-runbook.md) holds that last part.
|
||||
|
||||
**Core principle:** a phase is finished when its gate is verifiable by someone other than you.
|
||||
"I ran the command" is not a gate; "the URL resolves" is.
|
||||
|
||||
**Corrections go to the site page.** If a release teaches you something the guidelines get wrong,
|
||||
fix them in a PR to `apache/struts-site`. Only what is genuinely agent-specific belongs here.
|
||||
|
||||
## The phases
|
||||
|
||||
| # | Phase | Gate before moving on |
|
||||
|---|---|---|
|
||||
| 1 | Prepare | Branch green, version decided, parent poms released |
|
||||
| 2 | Cut | Tag pushed, artifacts in a **closed** Nexus staging repo |
|
||||
| 3 | Stage | Assemblies in `dist/dev`, Version Notes page live, `[TEST]` mail sent |
|
||||
| 4 | Vote | 72 h elapsed, three binding `+1`, result mail sent |
|
||||
| 5 | Promote | Nexus repo released, `dist/dev` → `dist/release`, 24 h rsync waited |
|
||||
| 6 | Publish | Site PR merged, GitHub release un-flagged, `[ANN]` mail delivered |
|
||||
| 7 | Advisories | Bulletins public, CVE records filled, advisory mails sent from the CVE tool |
|
||||
|
||||
Phase 7 only exists when the release carries a security fix, and *publishing* the advisory is
|
||||
**strictly after** phase 6 — see *Security work is a separate clock* below. Writing the bulletin
|
||||
is not: it is usually drafted long before the release exists, and often on its own timetable
|
||||
entirely.
|
||||
|
||||
## Which skill owns which artifact
|
||||
|
||||
Cross-references, not copies. Do not restate what these settle:
|
||||
|
||||
- **`creating-version-notes`** — the Version Notes page, its Staging Repository block, the
|
||||
Migration Guide entry, the GitHub release notes, and the `[TEST]` mail. All of phase 3's
|
||||
paperwork.
|
||||
- **`creating-release-vote-mail`** — the `[VOTE]` mail. All of phase 4's paperwork.
|
||||
- **`creating-security-bulletins`** — the S2-XXX page, what may be disclosed and when,
|
||||
publication, and the advisory mails.
|
||||
|
||||
**That last one is not a phase of this process.** A bulletin gets written when the report is
|
||||
triaged, which may be months before a release carries the fix, and plenty of bulletins are
|
||||
handled with no release in flight at all. It is a skill in its own right, invoked whenever it is
|
||||
needed. Phase 7 is the reverse direction: *if* this release carries a security fix, then once
|
||||
phase 6 is done, go and follow that skill.
|
||||
|
||||
Phases 1, 2, 5 and 6 have no sibling skill — the guidelines carry those steps, and this skill
|
||||
carries the ordering that binds them.
|
||||
|
||||
## Two lines, two releases
|
||||
|
||||
`main` is the 7.x line; `support/struts-6-x-x` is 6.x. Both are protected and both require their
|
||||
build to pass. A change that lands on both is **two releases**, each with its own tag, vote,
|
||||
site entry and announcement — not one release mentioned twice.
|
||||
|
||||
They can be cut in parallel and voted in parallel, and usually are. Keep the version numbers
|
||||
independent: 6.11.0 and 7.3.0 shipped together and share nothing but a date.
|
||||
|
||||
**Neither line branch is where the release is cut.** Both August 2026 releases were built on a
|
||||
`release/X.Y.Z-RC1` branch off the line, so the `[maven-release-plugin]` commits never reach
|
||||
`main`. A failed vote is then a deleted branch, not a revert.
|
||||
|
||||
## The version number is chosen at release time
|
||||
|
||||
The `-SNAPSHOT` in the pom is a placeholder, not a decision. Pick the number from the semver
|
||||
impact of what actually landed since the last tag, and say so out loud before cutting — the tag
|
||||
is the first irreversible act of the release.
|
||||
|
||||
The pom cannot tell you: because releases are cut on a side branch, `main` still read
|
||||
`7.2.2-SNAPSHOT` after 7.3.0 had shipped.
|
||||
|
||||
## Security work is a separate clock
|
||||
|
||||
**Nothing about an unpublished advisory goes into the release paperwork.** Not the Version
|
||||
Notes, not the `[TEST]` mail, not the `[VOTE]`, not the commit messages, not the site entry.
|
||||
The tickets are neutral; that is deliberate and it is what makes the embargo survive a public
|
||||
release process.
|
||||
|
||||
The advisory follows the release, and the ordering is not negotiable:
|
||||
|
||||
```
|
||||
release GA → bulletin unrestricted → advisory mails → CVE pushed to MITRE
|
||||
```
|
||||
|
||||
A bulletin published before the fixed artifact is downloadable tells attackers what to look for
|
||||
and gives operators nothing to do about it.
|
||||
|
||||
**A 6.x release containing only embargoed fixes is self-disclosing** — the diff between the two
|
||||
tags is the vulnerability whatever the commit messages say. That is a reason to bundle it with
|
||||
unrelated work, or to publish the bulletins with the release, not a reason to pretend otherwise.
|
||||
|
||||
## The cwiki release pages are retired
|
||||
|
||||
The wiki pages a release manager used to land on — *Building Struts 2 — Normal release*,
|
||||
*Fast track release*, *Creating and Signing a Distribution*, *One time steps*,
|
||||
*Sample announcements* — were retired in August 2026 and now carry nothing but a pointer to
|
||||
[Release Guidelines](https://struts.apache.org/release-guidelines.html). Their old content
|
||||
survives only in page history, where it describes a process last revised between 2013 and 2017:
|
||||
`develop`/`master` branches, `people.apache.org`, an svn checkout of the production site.
|
||||
|
||||
**Never restore a step from that history.** If something in the guidelines looks incomplete, the
|
||||
answer is the last release, not the last wiki revision.
|
||||
|
||||
## Gates that are actually load-bearing
|
||||
|
||||
- **A closed Nexus staging repo, not just a successful `release:perform`.** Until it is closed
|
||||
the URL in the Version Notes resolves to nothing and every tester is blocked.
|
||||
- **72 hours, and three binding `+1`.** PMC votes are the binding ones; `private@` is on the
|
||||
vote mail so binding voters see it.
|
||||
- **24 hours after the `dist` move, before announcing.** ASF mirroring guidance. Announcing into
|
||||
an unmirrored release sends everyone to a 404.
|
||||
- **The GitHub release stops being a prerelease at phase 6, not at phase 3.** During the vote it
|
||||
must still be flagged, or the vote is on an artifact the world already treats as final.
|
||||
|
||||
## Red Flags — STOP
|
||||
|
||||
- Cutting a tag before the version number has been stated and agreed
|
||||
- A `[VOTE]` opened on a staging repo that is not closed, or on a link that 404s
|
||||
- Announcing before the 24-hour mirror wait
|
||||
- Any severity, CVE, S2-XXX or bulletin link in release paperwork
|
||||
- A bulletin unrestricted before the fixed release is downloadable
|
||||
- Reviving a step from the history of a retired cwiki page
|
||||
- One release "covering" both maintenance lines
|
||||
- Inferring the release version from the `-SNAPSHOT` in the pom
|
||||
- Closing or releasing a Nexus staging repository yourself — that is the release manager's login
|
||||
|
||||
## Common Mistakes
|
||||
|
||||
| Mistake | Reality |
|
||||
|---|---|
|
||||
| "`release:perform` succeeded, so the artifacts are staged" | They are staged and *open*. Close the repo or nobody can fetch them. |
|
||||
| "The vote passed, so it's released" | Nexus release, dist move and the mirror wait all come after. |
|
||||
| "I'll announce now and fix the site after" | The announcement links the site. Merge the site PR first. |
|
||||
| "The 6.x fix is the same change, so one announcement covers both" | Two artifacts, two downloads, two sets of affected users. |
|
||||
| "The advisory is an announcement, so it gets `[ANN]` too" | `[ANN]` is for releases. CVE reports take the CVE tool's subject unedited. |
|
||||
| "The pom says 7.3.1-SNAPSHOT, so this is 7.3.1" | The placeholder is not a decision. Semver impact decides. |
|
||||
| "The process is documented in this skill" | It is documented on the site. This skill adds ordering, ownership and hand-offs. |
|
||||
| "I found the release steps on the wiki" | Those pages are stubs now. Their history is the 2013–2017 process. |
|
||||
@@ -1,113 +0,0 @@
|
||||
# Release Runbook
|
||||
|
||||
**The process is published, not kept here.** Every phase, every command, every gate is at
|
||||
[Release Guidelines](https://struts.apache.org/release-guidelines.html), maintained in
|
||||
`apache/struts-site` as `source/release-guidelines.md`. Read it there and follow it.
|
||||
|
||||
This file holds only what that page cannot: the points where a step is a human's to take rather
|
||||
than yours, and the scripts this skill ships. [`SKILL.md`](SKILL.md) holds the sequence, the
|
||||
gates and the judgement.
|
||||
|
||||
**When you learn something new during a release, it goes in the site page.** A correction that
|
||||
lands only here is a correction the next release manager will never see.
|
||||
|
||||
## The scripts
|
||||
|
||||
Phases 3 and 5 ship with this skill, in [`scripts/`](scripts). The Release Guidelines link to
|
||||
them by GitHub URL, so they are part of the published process — changing their behaviour means
|
||||
updating that page too.
|
||||
|
||||
| Script | Phase | What it does |
|
||||
|---|---|---|
|
||||
| [`stage-assemblies.sh`](scripts/stage-assemblies.sh) | 3 | Closed staging repo → `dist/dev`, renamed and re-hashed |
|
||||
| [`promote-dist.sh`](scripts/promote-dist.sh) | 5 | `dist/dev` → `dist/release` |
|
||||
|
||||
Both take `$VERSION` from the environment, refuse to run without it, and refuse a value that is
|
||||
not a version number — `svn` resolves a `.` path element rather than rejecting it, so a stray
|
||||
`VERSION` would otherwise move the whole staging tree in one irreversible commit.
|
||||
|
||||
Run them from a scratch directory, never from a repository checkout: `stage-assemblies.sh`
|
||||
creates `./$VERSION` and a temporary svn working copy in the current directory. That means
|
||||
calling them by absolute path, since the scratch directory is not the checkout:
|
||||
|
||||
```bash
|
||||
cd "$(mktemp -d)"
|
||||
VERSION=7.3.0 ~/Projects/Apache/struts/.claude/skills/releasing-struts/scripts/stage-assemblies.sh
|
||||
```
|
||||
|
||||
## Phase 1 — Prepare
|
||||
|
||||
**If the JDK is wrong, ask — do not infer.** `mvn -v` reports what Maven is actually using, and
|
||||
the line dictates what that must be (7.x on 17, 6.x on 8). Local environments differ — jenv,
|
||||
SDKMAN, asdf, `JAVA_HOME` by hand, a Homebrew symlink — and guessing at someone's toolchain is
|
||||
how you end up building against a JDK they did not intend. `.java-version` is gitignored in this
|
||||
repo, so it is not a signal either.
|
||||
|
||||
**State the version number and get agreement before phase 2 begins.** The tag is the first
|
||||
irreversible act of the release, and the pom cannot tell you the number.
|
||||
|
||||
## Phase 2 — Cut
|
||||
|
||||
At the SCM tag prompt, `STRUTS_X_Y_Z` is typed by hand every time. **This one cannot move into
|
||||
the pom**, so do not "fix" it: `tagNameFormat` interpolates `@{project.version}` and has no
|
||||
string functions, so the best it could produce is `STRUTS_7.3.0`. The prompt stays.
|
||||
|
||||
**Closing the staging repository is the release manager's action, not yours.** It happens in the
|
||||
Nexus web UI at <https://repository.apache.org/> (Staging Repositories → select → Close), behind
|
||||
an ASF login. Say so, hand over, and **wait for confirmation before continuing** — phase 3
|
||||
fetches from the staging *group* URL and gets nothing while the repository is open.
|
||||
|
||||
The gate is worth checking yourself once you are told it is done:
|
||||
|
||||
```
|
||||
https://repository.apache.org/content/groups/staging/org/apache/struts/struts2-core/$VERSION/
|
||||
```
|
||||
|
||||
## Phase 3 — Stage
|
||||
|
||||
Run [`stage-assemblies.sh`](scripts/stage-assemblies.sh) as above, then **count the files** at
|
||||
`https://dist.apache.org/repos/dist/dev/struts/$VERSION/`: six assemblies, each with `.asc`,
|
||||
`.sha256` and `.sha512`, 24 in total. `set -eu` stops the script on a step that *fails*, not on a
|
||||
crawl that quietly returns a subset, so a short upload reaches `dist/dev` looking healthy.
|
||||
|
||||
Everything else in this phase belongs to **`creating-version-notes`**: the Version Notes page,
|
||||
its Staging Repository block, the Migration Guide entry, the GitHub release (created as a
|
||||
**prerelease**), and the `[TEST]` mail.
|
||||
|
||||
## Phase 4 — Vote
|
||||
|
||||
**`creating-release-vote-mail`** owns the mail. Nothing here.
|
||||
|
||||
## Phase 5 — Promote
|
||||
|
||||
Run [`promote-dist.sh`](scripts/promote-dist.sh). **Releasing the staging repository in Nexus is
|
||||
again the release manager's action** in the web UI — hand over and wait, as in phase 2.
|
||||
|
||||
Pruning old releases from `dist/release/struts/` is a deliberate decision, never an autopilot
|
||||
step: several supported versions from both lines are normally kept.
|
||||
|
||||
## Phase 6 — Publish
|
||||
|
||||
**The `[ANN]` prefix belongs to this mail, not to advisories.** Release announcements keep it;
|
||||
CVE advisory subjects do not — see phase 7.
|
||||
|
||||
**The `[ANN]` mail must be `text/plain`, and a draft made with the Gmail tool is an HTML draft
|
||||
whatever you pass it.** `announce@apache.org` rejects any message carrying a `text/html` part —
|
||||
|
||||
```
|
||||
ezmlm-reject: fatal: Sorry, a message part has an unacceptable MIME Content-Type: 'text/html' (#5.2.3)
|
||||
```
|
||||
|
||||
— and `announcements@struts.apache.org` answers *"Must be sent from an @apache.org address."*
|
||||
See *The mail must be text/plain* in `creating-release-vote-mail` for the full contract. One list
|
||||
accepting the mail is not evidence the format was right.
|
||||
|
||||
## Phase 7 — Advisories
|
||||
|
||||
**`creating-security-bulletins`** owns all of it: unrestricting the bulletin, the CVE record on
|
||||
<https://cveprocess.apache.org>, and the advisory mails. Follow that skill from here; it is not
|
||||
a step in this runbook.
|
||||
|
||||
**The mails are sent by the `Send these Emails` button** on the record's *OSS/ASF Emails* tab,
|
||||
not from a mailbox, and the subject the tool generates carries no `[ANN]`. That skill owns the
|
||||
detail, including the `userslist` field the button depends on.
|
||||
@@ -1,36 +0,0 @@
|
||||
#!/bin/sh
|
||||
#
|
||||
# Phase 5 - promote a release that passed its vote, moving the assemblies from
|
||||
# dist/dev to dist/release. This is the point at which the artifacts start
|
||||
# replicating to the mirrors.
|
||||
#
|
||||
# Usage: VERSION=7.3.0 ./promote-dist.sh
|
||||
#
|
||||
# Run it only after the vote has passed. Wait 24 hours after this before
|
||||
# announcing anything - the announcement links a download page that the mirrors
|
||||
# have to have caught up with first.
|
||||
|
||||
set -eu
|
||||
|
||||
if [ -z "${VERSION:-}" ]; then
|
||||
echo "VERSION is not set. Usage: VERSION=7.3.0 $0" >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# Not cosmetic. svn resolves a "." path element instead of rejecting it, so
|
||||
# VERSION="." would move the whole of dist/dev/struts into dist/release in one
|
||||
# irreversible server-side commit. ".." is rejected by svn; "." is not.
|
||||
case "$VERSION" in
|
||||
[0-9]*.[0-9]*.[0-9]*) ;;
|
||||
*)
|
||||
echo "VERSION must look like 7.3.0 (got '$VERSION')" >&2
|
||||
exit 1
|
||||
;;
|
||||
esac
|
||||
|
||||
svn mv "https://dist.apache.org/repos/dist/dev/struts/$VERSION/" \
|
||||
"https://dist.apache.org/repos/dist/release/struts/" \
|
||||
-m "Release Struts $VERSION"
|
||||
|
||||
echo "Done - verify https://dist.apache.org/repos/dist/release/struts/$VERSION/"
|
||||
echo "Now release the staging repository in Nexus, then wait 24 hours before announcing."
|
||||
@@ -1,103 +0,0 @@
|
||||
#!/bin/sh
|
||||
#
|
||||
# Phase 3 - move the release assemblies from the closed Nexus staging repository
|
||||
# into https://dist.apache.org/repos/dist/dev/struts/$VERSION so they can be tested
|
||||
# and voted on.
|
||||
#
|
||||
# Usage: cd "$(mktemp -d)" && VERSION=7.3.0 /path/to/stage-assemblies.sh
|
||||
#
|
||||
# Run it from a scratch directory, not from a repository checkout: it creates
|
||||
# ./$VERSION and a temporary svn working copy in the current directory.
|
||||
#
|
||||
# Requires: the staging repository must already be CLOSED in Nexus (an open repo
|
||||
# serves nothing under the staging *group* URL this fetches from), and your ASF
|
||||
# svn credentials for dist.apache.org.
|
||||
|
||||
set -eu
|
||||
|
||||
if [ -z "${VERSION:-}" ]; then
|
||||
echo "VERSION is not set. Usage: VERSION=7.3.0 $0" >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# Not cosmetic: a VERSION of "." resolves server-side to the parent directory,
|
||||
# which would publish the whole staging tree.
|
||||
case "$VERSION" in
|
||||
[0-9]*.[0-9]*.[0-9]*) ;;
|
||||
*)
|
||||
echo "VERSION must look like 7.3.0 (got '$VERSION')" >&2
|
||||
exit 1
|
||||
;;
|
||||
esac
|
||||
|
||||
STAGING_URL="https://repository.apache.org/content/groups/staging/org/apache/struts/struts2-assembly/$VERSION"
|
||||
DIST_DEV_URL="https://dist.apache.org/repos/dist/dev/struts/"
|
||||
|
||||
if [ -e "$VERSION" ]; then
|
||||
echo "Directory $VERSION already exists here - remove it or run elsewhere." >&2
|
||||
exit 1
|
||||
fi
|
||||
if [ -e struts-dev ]; then
|
||||
echo "Directory struts-dev already exists here - remove it or run elsewhere." >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# Unconditional, as in the original: a half-built working copy left behind can be
|
||||
# picked up and committed by a later run for a different version.
|
||||
cleanup() {
|
||||
rm -rf "$START_DIR/struts-dev"
|
||||
}
|
||||
START_DIR=$(pwd)
|
||||
trap cleanup EXIT
|
||||
|
||||
echo "Creating working dir $VERSION"
|
||||
mkdir "$VERSION"
|
||||
cd "$VERSION"
|
||||
|
||||
echo "Getting distro $VERSION from the staging repository"
|
||||
if ! wget -erobots=off -nv -l 1 --accept=zip,md5,sha1,asc -r --no-check-certificate -nd -nH "$STAGING_URL"; then
|
||||
echo "Download failed. Is the staging repository closed in Nexus?" >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
if ! ls ./*.zip >/dev/null 2>&1; then
|
||||
echo "No assemblies downloaded. Is the staging repository closed in Nexus?" >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# struts2-assembly-7.3.0-all.zip -> struts-7.3.0-all.zip, and the same for the
|
||||
# .asc/.md5/.sha1 beside each zip. The .pom files keep their name and are removed
|
||||
# below - narrowing this glob without widening that one republishes them.
|
||||
echo "Renaming files"
|
||||
for f in *2-assembly*.zip*; do
|
||||
[ -e "$f" ] || continue
|
||||
mv "$f" "$(echo "$f" | sed s/2-assembly//g)"
|
||||
done
|
||||
|
||||
echo "Removing unneeded files"
|
||||
rm -f struts2-assembly-*.pom*
|
||||
rm -f ./*.md5 ./*.sha1
|
||||
|
||||
# The ASF publishes sha256/sha512; Nexus only carries the legacy hashes.
|
||||
echo "Generating SHA signatures"
|
||||
for f in *.zip; do
|
||||
[ -f "$f" ] || continue
|
||||
shasum -a 256 "$f" > "$f.sha256"
|
||||
shasum -a 512 "$f" > "$f.sha512"
|
||||
done
|
||||
|
||||
echo "Staging the following files:"
|
||||
ls -1
|
||||
|
||||
cd "$START_DIR"
|
||||
|
||||
echo "Publishing artifacts for test"
|
||||
svn --no-auth-cache co --depth empty "$DIST_DEV_URL" struts-dev
|
||||
mv "$VERSION" struts-dev/
|
||||
cd struts-dev
|
||||
svn add --force ./
|
||||
svn --no-auth-cache commit -m "Updates test release $VERSION"
|
||||
|
||||
cd "$START_DIR"
|
||||
|
||||
echo "Done - verify https://dist.apache.org/repos/dist/dev/struts/$VERSION/"
|
||||
@@ -1,98 +0,0 @@
|
||||
---
|
||||
name: triaging-security-reports
|
||||
description: Use when a vulnerability or security report arrives for triage, when assessing a CVE/RCE/OGNL/injection claim against the code, or when drafting a reply to a security researcher — to research the claim from source without trusting the reporter and without fabricating your own facts.
|
||||
---
|
||||
|
||||
# Triaging Security Reports
|
||||
|
||||
## Overview
|
||||
|
||||
A security report is a **claim to be tested, not a finding to be confirmed or rebutted**. The reporter may be right, wrong, partially right, or right about the symptom and wrong about the cause. Your job is to independently re-derive the truth from current source.
|
||||
|
||||
**Core principle:** Every factual statement that ends up in your assessment or reply — the reporter's claims *and your own* — must be traced to current source code before you write it down. The most common failure is not believing the reporter; it is **inventing supporting facts to justify a verdict you already reached.**
|
||||
|
||||
**Process authority:** [`SECURITY.md`](../../../SECURITY.md) is the source of truth for the disclosure process (private handling, assessment checklist, reporting rules). Read it. This skill governs *how you research and respond*, not the process itself.
|
||||
|
||||
## The Iron Rule
|
||||
|
||||
```
|
||||
NO CLAIM IN A SECURITY RESPONSE WITHOUT A FILE:LINE YOU READ THIS SESSION.
|
||||
```
|
||||
|
||||
Applies to the verdict, every mitigation you cite, and every "default" you state. If you can't point to the line, you can't write the sentence.
|
||||
|
||||
## Research: report-blind, not report-led
|
||||
|
||||
Read the report once to know what to investigate. Then **research as if you were auditing that area cold** — do not let the report's framing drive your search.
|
||||
|
||||
For each claim, independently verify:
|
||||
|
||||
| Reporter asserts | You must verify from source |
|
||||
|---|---|
|
||||
| A line number ("bug is at X:392") | Read that line **and its call path** — is it even reachable as described? |
|
||||
| A severity / CVSS | Re-derive from actual exploitability, not their number |
|
||||
| "No mitigation / no gate exists" | Search for gates, filters, allowlists, authorizers *yourself* — absence claims are the most often wrong |
|
||||
| "Default configuration" | Check the **effective runtime default**, not one source (see trap below) |
|
||||
| "Same as CVE-XXXX" | Confirm the mechanism actually matches; analogy ≠ equivalence |
|
||||
| A working PoC | **Run it if it is runnable**, then trace whether the payload survives every filter on the path |
|
||||
|
||||
If the report has **no reproducible PoC against a default config**, that is itself a triage outcome — say so per `SECURITY.md`.
|
||||
|
||||
## Find the control case
|
||||
|
||||
A single odd behaviour is ambiguous — it can nearly always be read as intended. What settles it is the **sibling that behaves correctly under the same input**.
|
||||
|
||||
Before writing a verdict, find the case that ought to differ and check it: the annotated property beside the unannotated one, the ordinary setter beside the dynamic one, the sibling path the same control does cover. Behave alike and you are probably looking at a design decision. Diverge, and the control is incomplete — that divergence *is* the finding.
|
||||
|
||||
Prefer an executed differential to an argued one. An existing test that passes beside the reporter's failing one is the strongest evidence a triage can produce.
|
||||
|
||||
## The effective-default trap
|
||||
|
||||
A Java field initializer and the shipped config can disagree. Reading only one produces a confident, wrong claim.
|
||||
|
||||
```java
|
||||
private boolean requireAnnotations = false; // field initializer
|
||||
```
|
||||
```properties
|
||||
struts.parameters.requireAnnotations=true # default.properties OVERRIDES it
|
||||
```
|
||||
|
||||
**The effective default is `true`.** Always trace the full chain: field initializer → `@Inject` setter → `default.properties` → any struts.xml override. State the *effective runtime* value, and cite the file that actually wins.
|
||||
|
||||
## Vulnerability vs. operator responsibility
|
||||
|
||||
"In the default configuration" is a crutch — drop it. Decide the real question:
|
||||
|
||||
- **Is it a vulnerability?** Then it's a vulnerability whether or not it's the default. Handle it privately per `SECURITY.md`.
|
||||
- **Does it require an operator to opt into an insecure configuration?** A documented, opt-in setting (e.g. `cookiesName=*`, `devMode=true`) that works as advertised is the operator's responsibility, provided the docs carry the warning. Say "X works as documented; the operator owns the security implications of enabling it" — not "not a vuln *in the default config*."
|
||||
- **Is the RCE/escalation only reachable via application code the framework can't constrain?** (e.g. an action that moves an uploaded file to a web root.) Then it's an application concern, not a framework vulnerability — state that boundary explicitly.
|
||||
|
||||
## Drafting the reply
|
||||
|
||||
- Lead with the verdict and the *reason*, both grounded in file:line.
|
||||
- Cite a source for every mitigation you mention. If you didn't verify it this session, delete the sentence.
|
||||
- Prefer "works as documented / operator responsibility" framing over "default configuration."
|
||||
- **Don't over-promise.** Before pledging a hardening change, check it doesn't already exist (it often does) and that you intend to actually do it.
|
||||
- Acknowledge anything the reporter got right (e.g. correct CVE-fix verification) — it builds the relationship and signals you actually read it.
|
||||
- Keep it private: no public issue, PR, Jira, or list thread before triage. Never open a PR that is itself the security fix (see [`CLAUDE.md`](../../../CLAUDE.md)).
|
||||
|
||||
## Red Flags — STOP
|
||||
|
||||
- About to write "this is mitigated by X" — did you read X's line *this session*?
|
||||
- About to state a "default" from a field initializer — did you check `default.properties`?
|
||||
- Citing the reporter's line number without having traced its call path.
|
||||
- Asserting "no gate / no check exists" without having grepped for it.
|
||||
- Two of your own claims contradict each other → at least one is unverified. Stop and verify both.
|
||||
- Promising a fix/warning "we'll add" without checking it isn't already there.
|
||||
- Writing "not a vulnerability in the default configuration" → reframe as vuln-or-not + operator responsibility.
|
||||
|
||||
## Common Mistakes
|
||||
|
||||
| Mistake | Reality |
|
||||
|---|---|
|
||||
| "Reporter cited line 392, so that's the bug site" | A line is only a bug if it's *reachable* as described. Trace callers. |
|
||||
| "The field defaults to false, so the gate is off by default" | `default.properties` may override it to true. Check the effective value. |
|
||||
| "I'll add a mitigation to strengthen the rejection" | An unverified mitigation that's wrong discredits the whole response. Verify or omit. |
|
||||
| "It rejects the payload, obviously" | Confirm the specific PoC string fails the specific filter (e.g. full-match regex `ACCEPTED_PATTERN`). |
|
||||
| "We should add a startup warning" | Grep first — the warning frequently already exists. |
|
||||
| "Not a vuln in default config" | Either it's a vuln or it's operator-owned opt-in. The default-config hedge muddies both. |
|
||||
@@ -1,5 +0,0 @@
|
||||
# Set the default behavior, in case people don't have core.autocrlf set.
|
||||
* text=auto
|
||||
*.bat eol=crlf
|
||||
*.cmd eol=crlf
|
||||
*.sh eol=lf
|
||||
@@ -1,42 +0,0 @@
|
||||
version: 2
|
||||
updates:
|
||||
- package-ecosystem: "github-actions"
|
||||
directory: "/"
|
||||
schedule:
|
||||
interval: "weekly"
|
||||
- package-ecosystem: "maven"
|
||||
directory: "/"
|
||||
schedule:
|
||||
interval: "weekly"
|
||||
cooldown:
|
||||
default-days: 3
|
||||
target-branch: "main"
|
||||
- package-ecosystem: "maven"
|
||||
directory: "/"
|
||||
schedule:
|
||||
interval: "weekly"
|
||||
cooldown:
|
||||
default-days: 4
|
||||
target-branch: "support/struts-6-x-x"
|
||||
ignore:
|
||||
- dependency-name: "org.eclipse.jetty:jetty-maven-plugin"
|
||||
- dependency-name: "com.github.ben-manes.caffeine:caffeine"
|
||||
- dependency-name: "com.sun.xml.bind:jaxb-impl"
|
||||
- dependency-name: "javax.portlet:portlet-api"
|
||||
- dependency-name: "javax.servlet:javax.servlet-api"
|
||||
- dependency-name: "javax.servlet.jsp:jsp-api"
|
||||
- dependency-name: "org.mortbay.jetty:jsp-2.1"
|
||||
- dependency-name: "ognl:ognl"
|
||||
- dependency-name: "org.hibernate.validator:hibernate-validator"
|
||||
- dependency-name: "org.testng:testng"
|
||||
- dependency-name: "org.mockito:mockito-core"
|
||||
- dependency-name: "opensymphony:sitemesh"
|
||||
- dependency-name: "net.sf.jasperreports:jasperreports"
|
||||
- dependency-name: "javax.enterprise:cdi-api"
|
||||
- dependency-name: "org.springframework:*"
|
||||
- dependency-name: "org.apache.struts:struts-annotations"
|
||||
- dependency-name: "org.apache.juneau:juneau-marshall"
|
||||
- dependency-name: "org.apache.tomcat:tomcat-api"
|
||||
- dependency-name: "org.apache.tomcat:tomcat-juli"
|
||||
- dependency-name: "org.apache.tomcat:tomcat-jasper"
|
||||
- dependency-name: "org.apache.rat:apache-rat-plugin"
|
||||
@@ -1,136 +0,0 @@
|
||||
---
|
||||
name: code-review
|
||||
description: Apache Struts pull request review guide. Use when reviewing pull requests in this repository to check test conventions, security-sensitive framework code, PR and commit hygiene, and Struts-specific implementation patterns.
|
||||
license: Apache-2.0
|
||||
---
|
||||
|
||||
# Reviewing Apache Struts pull requests
|
||||
|
||||
Apache Struts is a mature MVC framework for Java. It uses OGNL for value stack
|
||||
expressions and FreeMarker for UI tag templates, and it has a long history of
|
||||
security vulnerabilities in exactly those areas. Review accordingly: the
|
||||
conventions below are not style preferences, they are the places where changes
|
||||
tend to go wrong in this codebase.
|
||||
|
||||
Deeper references, when a review needs them:
|
||||
|
||||
- [`CLAUDE.md`](../../../CLAUDE.md) — build commands, module layout, request lifecycle
|
||||
- [`SECURITY.md`](../../../SECURITY.md) — the vulnerability reporting process (source of truth)
|
||||
- [`THREAT_MODEL.md`](../../../THREAT_MODEL.md) — scope, trust boundaries, known non-findings
|
||||
- [`AGENTS.md`](../../../AGENTS.md) — rules for AI agents working on security findings
|
||||
|
||||
## 1. Tests
|
||||
|
||||
**This repository is JUnit 4. There is no JUnit 5 anywhere in it.**
|
||||
`parent/pom.xml` declares `junit:junit:4.13.2`; there are zero
|
||||
`org.junit.jupiter` imports. Two styles coexist and a new test must match the
|
||||
style already in the file it joins:
|
||||
|
||||
- **JUnit 3 style** — classes extending `XWorkTestCase`, which extends
|
||||
`junit.framework.TestCase`. Test methods must be named `testXxx()`. A Jupiter
|
||||
`@Test` annotation added to one of these **silently never runs** — it does not
|
||||
fail, it is simply not collected. Flag this as blocking whenever you see
|
||||
`org.junit.jupiter` in a diff.
|
||||
- **JUnit 4 style** — classes using `import org.junit.Test`.
|
||||
|
||||
Both styles are widespread and neither is being migrated away from.
|
||||
|
||||
AssertJ assertions and Mockito mocks are both available and widely used.
|
||||
Introducing JUnit 5 is a build-infrastructure change that needs its own `WW-`
|
||||
ticket; it is never a side effect of a feature PR.
|
||||
|
||||
### Tests that pass without testing anything
|
||||
|
||||
Three traps in this codebase produce green tests that assert nothing. Check for
|
||||
them whenever a PR adds a test in these areas:
|
||||
|
||||
- **Unpushed action.** An action object that was never pushed onto the value
|
||||
stack binds no parameters at all, so an assertion that "the parameter was not
|
||||
bound" passes for the wrong reason. Confirm the fixture pushes the action.
|
||||
- **`requireAnnotations` is off by default in a bare harness.**
|
||||
`ParametersInterceptor.requireAnnotations` is a Java field initialised to
|
||||
`false`; production turns it on through
|
||||
`struts.parameters.requireAnnotations=true` in `default.properties`. A test
|
||||
that constructs the interceptor directly and expects an unannotated parameter
|
||||
to be rejected will pass with the check disabled. The test must set the flag.
|
||||
- **Interned string literals defeat identity checks.** Where the framework
|
||||
compares against a marker constant with `==`, a String *literal* in a test is
|
||||
interned to the same instance as the constant, so the test passes vacuously
|
||||
even against unfixed code. Such fixtures must build the value at runtime, with
|
||||
an `assertNotSame` guard proving they did.
|
||||
|
||||
Run tests with `mvn test -DskipAssembly`; a single test with
|
||||
`mvn test -DskipAssembly -pl core -Dtest=MyClassTest#testMethodName`.
|
||||
|
||||
## 2. Security-sensitive changes
|
||||
|
||||
Watch for diffs touching OGNL expression evaluation, the OGNL allowlist and
|
||||
member access policies, parameter filtering and `@StrutsParameter` gating,
|
||||
file upload handling, action mapping and name cleanup, deserialization, path
|
||||
handling, or escaping in framework components and UI tag templates.
|
||||
|
||||
**When a change looks like it fixes a vulnerability rather than an ordinary
|
||||
bug, say so in neutral terms and stop there.** A pull request is public, so a
|
||||
review comment that names the weakness, explains how it is reached, or
|
||||
estimates its impact is itself a disclosure — precisely what the project's
|
||||
private process exists to prevent.
|
||||
|
||||
Use wording of this shape, and no more than this:
|
||||
|
||||
> This change touches security-sensitive framework code. Please confirm it is
|
||||
> not a fix for a suspected vulnerability before merging — see `SECURITY.md`.
|
||||
> Vulnerability fixes go through the private process at
|
||||
> `security@struts.apache.org`, not a public pull request.
|
||||
|
||||
Do **not**, in a review comment: describe the suspected weakness or its class,
|
||||
sketch an exploit or a triggering input, assess exploitability or severity,
|
||||
speculate about affected versions, or link the change to a specific CVE or
|
||||
security bulletin. If a reviewer needs to raise any of that, it belongs in
|
||||
private mail to `security@struts.apache.org`.
|
||||
|
||||
## 3. Pull request and commit hygiene
|
||||
|
||||
- **Title** — `WW-XXXX Description`. A Jira ticket ID is required for any code
|
||||
change; the tracker is <https://issues.apache.org/jira/projects/WW>.
|
||||
- **Description** — links the ticket:
|
||||
`Fixes [WW-XXXX](https://issues.apache.org/jira/browse/WW-XXXX)`.
|
||||
- **Exception** — pure documentation and build/CI changes (`SECURITY.md`,
|
||||
`AGENTS.md`, `CLAUDE.md`, `.github/`, workflows) take no ticket and use
|
||||
conventional-commit form instead: `docs: ...`, `build(ci): ...`, `chore: ...`.
|
||||
- Commit messages follow the same rule as the title.
|
||||
|
||||
Flag a missing or malformed ticket reference as a non-blocking comment, not as
|
||||
a code defect.
|
||||
|
||||
## 4. Struts implementation patterns
|
||||
|
||||
- **Temporary files** get UUID-based names in a controlled location, never a
|
||||
name derived from user input:
|
||||
|
||||
```java
|
||||
protected File createTemporaryFile(String fileName, Path location) {
|
||||
String uid = UUID.randomUUID().toString().replace("-", "_");
|
||||
return location.resolve("upload_" + uid + ".tmp").toFile();
|
||||
}
|
||||
```
|
||||
|
||||
- **OGNL** — evaluate only framework-generated expressions, and keep member
|
||||
access on an allowlist. Treat any new path that evaluates a
|
||||
request-derived string as OGNL as a blocking finding under section 2.
|
||||
- **Parameters** — request-settable action properties need `@StrutsParameter`;
|
||||
use `ParameterNameAware` to restrict accepted parameter names. Note that a
|
||||
`ModelDriven` action's own setters are a known exemption, so review changes
|
||||
there with care.
|
||||
- **Uploads** — validate content types, sanitise file names, enforce size
|
||||
limits.
|
||||
- **Naming** — framework default implementations are prefixed `Struts`
|
||||
(`StrutsBeanSelectionProvider`), not `Default`, for new classes.
|
||||
- **No placeholder TODOs** — a comment must not reference a Jira ticket that
|
||||
has not been filed.
|
||||
|
||||
## Reviewing the review
|
||||
|
||||
Keep findings proportionate. Blocking comments are for correctness, the JUnit 5
|
||||
trap, vacuous tests, and security-sensitive code paths. Everything else —
|
||||
naming, ticket references, style — is a suggestion or a nitpick, and should be
|
||||
labelled as such.
|
||||
@@ -17,25 +17,8 @@ name: "CodeQL"
|
||||
|
||||
on:
|
||||
push:
|
||||
branches:
|
||||
- 'main'
|
||||
- 'release/*'
|
||||
- 'support/*'
|
||||
paths-ignore:
|
||||
- '.claude/**'
|
||||
# Safe to filter by path here: no check from this workflow is required in
|
||||
# .asf.yaml, so a run that never happens blocks nothing.
|
||||
branches: [ "master" ]
|
||||
pull_request:
|
||||
paths-ignore:
|
||||
- '.claude/**'
|
||||
|
||||
permissions:
|
||||
# Needed to upload the results to code-scanning dashboard.
|
||||
security-events: write
|
||||
actions: read
|
||||
contents: read
|
||||
# Needed to access OIDC token.
|
||||
id-token: write
|
||||
|
||||
jobs:
|
||||
analyze:
|
||||
@@ -51,20 +34,14 @@ jobs:
|
||||
language: [ 'java' ]
|
||||
steps:
|
||||
- name: Checkout repository
|
||||
uses: actions/checkout@v7
|
||||
- name: Setup Java JDK
|
||||
uses: actions/setup-java@v5
|
||||
with:
|
||||
distribution: temurin
|
||||
java-version: 17
|
||||
cache: 'maven'
|
||||
uses: actions/checkout@v3
|
||||
- name: Initialize CodeQL
|
||||
uses: github/codeql-action/init@v4.37.8
|
||||
uses: github/codeql-action/init@v2
|
||||
with:
|
||||
languages: ${{ matrix.language }}
|
||||
languages: ${{ matrix.language }}
|
||||
- name: Autobuild
|
||||
uses: github/codeql-action/autobuild@v4.37.8
|
||||
uses: github/codeql-action/autobuild@v2
|
||||
- name: Perform CodeQL Analysis
|
||||
uses: github/codeql-action/analyze@v4.37.8
|
||||
uses: github/codeql-action/analyze@v2
|
||||
with:
|
||||
category: "/language:${{matrix.language}}"
|
||||
|
||||
+23
-91
@@ -13,113 +13,45 @@
|
||||
# See the License for the specific language governing permissions and
|
||||
# limitations under the License.
|
||||
|
||||
name: Java Maven
|
||||
name: Java Build
|
||||
|
||||
on:
|
||||
# Deliberately NOT filtered by path. "Build and Test (JDK 17)" is a required
|
||||
# status check in .asf.yaml, and a workflow skipped by path filtering never
|
||||
# reports its checks - they stay Pending and the pull request can never be
|
||||
# merged. The build job always runs instead, and its steps are skipped by
|
||||
# condition when only .claude/ changed (see `changes` below).
|
||||
pull_request:
|
||||
push:
|
||||
branches:
|
||||
- 'main'
|
||||
- 'develop'
|
||||
- 'release/*'
|
||||
- 'support/*'
|
||||
paths-ignore:
|
||||
- '.claude/**'
|
||||
workflow_dispatch:
|
||||
workflow_call:
|
||||
|
||||
permissions: read-all
|
||||
- master
|
||||
|
||||
env:
|
||||
MAVEN_OPTS: -Xmx2048m -Xms1024m
|
||||
LANG: en_US.utf8
|
||||
|
||||
jobs:
|
||||
changes:
|
||||
name: Detect changes outside .claude
|
||||
runs-on: ubuntu-latest
|
||||
outputs:
|
||||
code: ${{ steps.filter.outputs.code }}
|
||||
steps:
|
||||
- name: Check which paths the pull request touches
|
||||
id: filter
|
||||
env:
|
||||
GH_TOKEN: ${{ github.token }}
|
||||
run: |
|
||||
set -eu
|
||||
if [ "${{ github.event_name }}" != "pull_request" ]; then
|
||||
echo "Not a pull request - building."
|
||||
echo "code=true" >> "$GITHUB_OUTPUT"
|
||||
exit 0
|
||||
fi
|
||||
files=$(gh api --paginate \
|
||||
"repos/${{ github.repository }}/pulls/${{ github.event.number }}/files" \
|
||||
--jq '.[].filename')
|
||||
echo "Changed files:"
|
||||
printf '%s\n' "$files"
|
||||
# Anything outside .claude/ means a real build is needed; an empty
|
||||
# diff, or one confined to .claude/, does not. Tested by emptiness
|
||||
# rather than with `grep -qv`, whose exit status is not reliable
|
||||
# across grep implementations.
|
||||
outside=$(printf '%s\n' "$files" | grep -vE '^(\.claude/|$)' || true)
|
||||
if [ -n "$outside" ]; then
|
||||
echo "code=true" >> "$GITHUB_OUTPUT"
|
||||
else
|
||||
echo "Only .claude/ changed - skipping the build."
|
||||
echo "code=false" >> "$GITHUB_OUTPUT"
|
||||
fi
|
||||
|
||||
build:
|
||||
name: Build and Test (JDK ${{ matrix.java }})${{ matrix.profile == '-Pjakartaee11' && ' (Jakarta EE 11 + Spring 7)' || matrix.profile }}
|
||||
needs: changes
|
||||
# No job-level `if:` here on purpose. A matrix job whose condition is false
|
||||
# is skipped *before* the matrix expands, so it reports a single check run
|
||||
# named after the raw `${{ matrix.* }}` template - never "Build and Test
|
||||
# (JDK 17)". The required context then never reports at all and the pull
|
||||
# request stays blocked. Gate the steps instead: the matrix expands, every
|
||||
# expected check reports success, and nothing is built.
|
||||
runs-on: ubuntu-latest
|
||||
strategy:
|
||||
fail-fast: false
|
||||
matrix:
|
||||
include:
|
||||
- java: '17'
|
||||
profile: ''
|
||||
- java: '21'
|
||||
profile: ''
|
||||
- java: '21'
|
||||
profile: '-Pjakartaee11'
|
||||
- java: '25'
|
||||
profile: ''
|
||||
- java: '25'
|
||||
profile: '-Pjakartaee11'
|
||||
java: [ '8', '11', '17' ]
|
||||
steps:
|
||||
- name: Checkout code
|
||||
if: needs.changes.outputs.code == 'true'
|
||||
uses: actions/checkout@v7
|
||||
- name: Setup Java ${{ matrix.java }}
|
||||
if: needs.changes.outputs.code == 'true'
|
||||
uses: actions/setup-java@v5
|
||||
uses: actions/checkout@v3.0.2
|
||||
- name: Set up cache
|
||||
uses: actions/cache@v3.0.8
|
||||
with:
|
||||
distribution: temurin
|
||||
path: ~/.m2/repository
|
||||
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
|
||||
restore-keys: |
|
||||
${{ runner.os }}-maven-
|
||||
- name: Set up JDK ${{ matrix.java }}
|
||||
uses: actions/setup-java@v3
|
||||
with:
|
||||
distribution: adopt
|
||||
java-version: ${{ matrix.java }}
|
||||
cache: 'maven'
|
||||
- name: Maven Verify on Java ${{ matrix.java }}${{ matrix.profile == '-Pjakartaee11' && ' (Jakarta EE 11 + Spring 7)' || matrix.profile }}
|
||||
if: needs.changes.outputs.code == 'true'
|
||||
run: mvn -B -V -DskipAssembly verify ${{ matrix.profile }} --no-transfer-progress
|
||||
|
||||
- name: Test Summary ${{ matrix.java }} ${{ matrix.profile }}
|
||||
uses: mikepenz/action-junit-report@d9f48fc87bc235f7e214acf696ca5abc0a986f16 #v6.4.2
|
||||
continue-on-error: true
|
||||
if: always() && needs.changes.outputs.code == 'true'
|
||||
with:
|
||||
annotate_only: true # forked repo cannot write to checks so just do annotations
|
||||
report_paths: |
|
||||
**/surefire-reports/TEST-*.xml
|
||||
**/failsafe-reports/TEST-*.xml
|
||||
|
||||
- name: Build with Maven on Java ${{ matrix.java }}
|
||||
if: matrix.java != '11'
|
||||
run: mvn -B -V -DskipAssembly test --no-transfer-progress
|
||||
- name: Code coverage on Java ${{ matrix.java }}
|
||||
if: matrix.java == '11'
|
||||
env:
|
||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
|
||||
run: mvn -B -V -Pcoverage -DskipAssembly verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar --no-transfer-progress
|
||||
|
||||
@@ -1,106 +0,0 @@
|
||||
# Licensed to the Apache Software Foundation (ASF) under one or more
|
||||
# contributor license agreements. See the NOTICE file distributed with
|
||||
# this work for additional information regarding copyright ownership.
|
||||
# The ASF licenses this file to You under the Apache License, Version 2.0
|
||||
# (the "License"); you may not use this file except in compliance with
|
||||
# the License. You may obtain a copy of the License at
|
||||
#
|
||||
# http://www.apache.org/licenses/LICENSE-2.0
|
||||
#
|
||||
# Unless required by applicable law or agreed to in writing, software
|
||||
# distributed under the License is distributed on an "AS IS" BASIS,
|
||||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
# See the License for the specific language governing permissions and
|
||||
# limitations under the License.
|
||||
|
||||
name: OWASP checkup
|
||||
|
||||
on:
|
||||
# Safe to filter by path here: no check from this workflow is required in
|
||||
# .asf.yaml, so a run that never happens blocks nothing.
|
||||
pull_request:
|
||||
paths-ignore:
|
||||
- '.claude/**'
|
||||
push:
|
||||
branches:
|
||||
- 'main'
|
||||
- 'develop'
|
||||
- 'release/*'
|
||||
- 'support/*'
|
||||
paths-ignore:
|
||||
- '.claude/**'
|
||||
workflow_dispatch: #Allow manual triggers
|
||||
|
||||
permissions: read-all
|
||||
|
||||
env:
|
||||
MAVEN_OPTS: -Xmx2048m -Xms1024m
|
||||
LANG: en_US.utf8
|
||||
|
||||
jobs:
|
||||
|
||||
|
||||
owasp:
|
||||
name: OWASP
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 30
|
||||
env:
|
||||
HAVE_NIST_NVD_API_KEY: ${{ secrets.NIST_NVD_API_KEY != '' }}
|
||||
steps:
|
||||
- name: Checkout code
|
||||
uses: actions/checkout@v7
|
||||
- name: Setup Java 25
|
||||
uses: actions/setup-java@v5
|
||||
with:
|
||||
distribution: temurin
|
||||
java-version: 25
|
||||
cache: 'maven'
|
||||
|
||||
- name: Cache NVD Database
|
||||
id: cache-nvd
|
||||
uses: actions/cache/restore@v6
|
||||
with:
|
||||
path: ~/.m2/repository/org/owasp/dependency-check-data
|
||||
key: nvd-cache-${{ runner.os }}-owasp-${{ github.run_id }}
|
||||
restore-keys: |
|
||||
nvd-cache-${{ runner.os }}-owasp-
|
||||
nvd-cache-${{ runner.os }}-
|
||||
|
||||
- name: OWASP Dependency check update cache via NIST_NVD_API_KEY
|
||||
id: nvd-api-update
|
||||
if: ${{ env.HAVE_NIST_NVD_API_KEY == 'true' }}
|
||||
continue-on-error: true
|
||||
run: mvn -N -V -DskipAssembly -Dmaven.test.skip=true -Powasp-nvd-api -Pdependency-update-only --no-transfer-progress
|
||||
env:
|
||||
NIST_NVD_API_KEY: ${{ secrets.NIST_NVD_API_KEY}}
|
||||
|
||||
- name: OWASP Dependency check update cache via Mirror
|
||||
if: ${{ env.HAVE_NIST_NVD_API_KEY == 'false' || steps.nvd-api-update.outcome == 'failure' }}
|
||||
run: mvn -N -V -DskipAssembly -Dmaven.test.skip=true -Powasp-nvd-mirror -Pdependency-update-only --no-transfer-progress
|
||||
|
||||
- name: Cache NVD Database
|
||||
uses: actions/cache/save@v6
|
||||
if: ${{ always() }}
|
||||
with:
|
||||
path: ~/.m2/repository/org/owasp/dependency-check-data
|
||||
key: nvd-cache-${{ runner.os }}-owasp-${{ github.run_id }}
|
||||
|
||||
- name: OWASP check (Without running tests)
|
||||
run: mvn -B org.owasp:dependency-check-maven:aggregate -Pdependency-check -Pjakartaee11 -DautoUpdate=false --no-transfer-progress
|
||||
|
||||
- name: Upload Dependency Check reports
|
||||
uses: actions/upload-artifact@v7
|
||||
if: always()
|
||||
with:
|
||||
name: dependency-check
|
||||
path: target/dependency-check*
|
||||
|
||||
- name: Add OWASP summary
|
||||
if: always()
|
||||
run: |
|
||||
{
|
||||
echo "## OWASP Dependency Check"
|
||||
echo ""
|
||||
echo "The HTML report has been uploaded as the **dependency-check** artifact."
|
||||
echo "Download it from the Artifacts section of this workflow run."
|
||||
} >> "$GITHUB_STEP_SUMMARY"
|
||||
@@ -20,8 +20,7 @@ on:
|
||||
schedule:
|
||||
- cron: "30 1 * * 6" # Weekly on Saturdays
|
||||
push:
|
||||
branches:
|
||||
- "main"
|
||||
branches: [ "master" ]
|
||||
|
||||
permissions: read-all
|
||||
|
||||
@@ -41,12 +40,12 @@ jobs:
|
||||
steps:
|
||||
|
||||
- name: "Checkout code"
|
||||
uses: actions/checkout@v7 # 3.1.0
|
||||
uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # 3.1.0
|
||||
with:
|
||||
persist-credentials: false
|
||||
|
||||
- name: "Run analysis"
|
||||
uses: ossf/scorecard-action@2d1146689b8cda280b9bc96326124645441f03bc # 2.4.4
|
||||
uses: ossf/scorecard-action@99c53751e09b9529366343771cc321ec74e9bd3d # 2.0.6
|
||||
with:
|
||||
results_file: results.sarif
|
||||
results_format: sarif
|
||||
@@ -58,13 +57,13 @@ jobs:
|
||||
publish_results: true
|
||||
|
||||
- name: "Upload artifact"
|
||||
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # 7.0.1
|
||||
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # 3.1.0
|
||||
with:
|
||||
name: SARIF file
|
||||
path: results.sarif
|
||||
retention-days: 5
|
||||
|
||||
- name: "Upload to code-scanning"
|
||||
uses: github/codeql-action/upload-sarif@f58f0d11ebf5dedd870fab2f999275f7602cfa46 # 2.22.11
|
||||
uses: github/codeql-action/upload-sarif@b398f525a5587552e573b247ac661067fafa920b # 2.1.22
|
||||
with:
|
||||
sarif_file: results.sarif
|
||||
|
||||
@@ -1,61 +0,0 @@
|
||||
# Licensed to the Apache Software Foundation (ASF) under one or more
|
||||
# contributor license agreements. See the NOTICE file distributed with
|
||||
# this work for additional information regarding copyright ownership.
|
||||
# The ASF licenses this file to You under the Apache License, Version 2.0
|
||||
# (the "License"); you may not use this file except in compliance with
|
||||
# the License. You may obtain a copy of the License at
|
||||
#
|
||||
# http://www.apache.org/licenses/LICENSE-2.0
|
||||
#
|
||||
# Unless required by applicable law or agreed to in writing, software
|
||||
# distributed under the License is distributed on an "AS IS" BASIS,
|
||||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
# See the License for the specific language governing permissions and
|
||||
# limitations under the License.
|
||||
|
||||
name: SonarCloud
|
||||
|
||||
on:
|
||||
# Safe to filter by path here: no check from this workflow is required in
|
||||
# .asf.yaml, so a run that never happens blocks nothing.
|
||||
pull_request:
|
||||
paths-ignore:
|
||||
- '.claude/**'
|
||||
push:
|
||||
branches:
|
||||
- 'main'
|
||||
paths-ignore:
|
||||
- '.claude/**'
|
||||
|
||||
permissions: read-all
|
||||
|
||||
env:
|
||||
MAVEN_OPTS: -Xmx2048m -Xms1024m
|
||||
LANG: en_US.utf8
|
||||
HAVE_SONARCLOUD_TOKEN: ${{ secrets.SONARCLOUD_TOKEN != '' }}
|
||||
|
||||
jobs:
|
||||
sonarcloud:
|
||||
name: Scan
|
||||
runs-on: ubuntu-latest
|
||||
if: ${{ !github.event.pull_request.base.repo.fork && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
|
||||
steps:
|
||||
- uses: actions/checkout@v7
|
||||
with:
|
||||
fetch-depth: 0
|
||||
- uses: actions/setup-java@v5
|
||||
with:
|
||||
distribution: temurin
|
||||
java-version: 21
|
||||
cache: 'maven'
|
||||
- name: SonarCloud Scan
|
||||
if: ${{ env.HAVE_SONARCLOUD_TOKEN == 'true' }}
|
||||
env:
|
||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
|
||||
run: ./mvnw -B verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Pcoverage -DskipAssembly
|
||||
- name: SonarCloud Scan -- SKIPPED
|
||||
if: ${{ env.HAVE_SONARCLOUD_TOKEN != 'true' }}
|
||||
run: |
|
||||
echo "### SonarCloud not configured" >> $GITHUB_STEP_SUMMARY
|
||||
echo "secrets.SONARCLOUD_TOKEN not existing, cannot push coverage checks" >> $GITHUB_STEP_SUMMARY
|
||||
-10
@@ -22,8 +22,6 @@ Servers/
|
||||
|
||||
# Scripts
|
||||
*.sh
|
||||
# ... except the ones that are part of a skill and have to travel with it
|
||||
!.claude/skills/**/scripts/*.sh
|
||||
|
||||
# jenv
|
||||
.java-version
|
||||
@@ -48,11 +46,3 @@ test-output
|
||||
|
||||
# Tidelift CLI scanner
|
||||
.tidelift
|
||||
|
||||
# Claude Code local settings
|
||||
.claude/settings.local.json
|
||||
|
||||
# Cursor + Metals
|
||||
.cursor/
|
||||
.bloop/
|
||||
.metals/
|
||||
|
||||
+117
@@ -0,0 +1,117 @@
|
||||
/*
|
||||
* Copyright 2007-present the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
import java.net.*;
|
||||
import java.io.*;
|
||||
import java.nio.channels.*;
|
||||
import java.util.Properties;
|
||||
|
||||
public class MavenWrapperDownloader {
|
||||
|
||||
private static final String WRAPPER_VERSION = "0.5.6";
|
||||
/**
|
||||
* Default URL to download the maven-wrapper.jar from, if no 'downloadUrl' is provided.
|
||||
*/
|
||||
private static final String DEFAULT_DOWNLOAD_URL = "https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/"
|
||||
+ WRAPPER_VERSION + "/maven-wrapper-" + WRAPPER_VERSION + ".jar";
|
||||
|
||||
/**
|
||||
* Path to the maven-wrapper.properties file, which might contain a downloadUrl property to
|
||||
* use instead of the default one.
|
||||
*/
|
||||
private static final String MAVEN_WRAPPER_PROPERTIES_PATH =
|
||||
".mvn/wrapper/maven-wrapper.properties";
|
||||
|
||||
/**
|
||||
* Path where the maven-wrapper.jar will be saved to.
|
||||
*/
|
||||
private static final String MAVEN_WRAPPER_JAR_PATH =
|
||||
".mvn/wrapper/maven-wrapper.jar";
|
||||
|
||||
/**
|
||||
* Name of the property which should be used to override the default download url for the wrapper.
|
||||
*/
|
||||
private static final String PROPERTY_NAME_WRAPPER_URL = "wrapperUrl";
|
||||
|
||||
public static void main(String args[]) {
|
||||
System.out.println("- Downloader started");
|
||||
File baseDirectory = new File(args[0]);
|
||||
System.out.println("- Using base directory: " + baseDirectory.getAbsolutePath());
|
||||
|
||||
// If the maven-wrapper.properties exists, read it and check if it contains a custom
|
||||
// wrapperUrl parameter.
|
||||
File mavenWrapperPropertyFile = new File(baseDirectory, MAVEN_WRAPPER_PROPERTIES_PATH);
|
||||
String url = DEFAULT_DOWNLOAD_URL;
|
||||
if(mavenWrapperPropertyFile.exists()) {
|
||||
FileInputStream mavenWrapperPropertyFileInputStream = null;
|
||||
try {
|
||||
mavenWrapperPropertyFileInputStream = new FileInputStream(mavenWrapperPropertyFile);
|
||||
Properties mavenWrapperProperties = new Properties();
|
||||
mavenWrapperProperties.load(mavenWrapperPropertyFileInputStream);
|
||||
url = mavenWrapperProperties.getProperty(PROPERTY_NAME_WRAPPER_URL, url);
|
||||
} catch (IOException e) {
|
||||
System.out.println("- ERROR loading '" + MAVEN_WRAPPER_PROPERTIES_PATH + "'");
|
||||
} finally {
|
||||
try {
|
||||
if(mavenWrapperPropertyFileInputStream != null) {
|
||||
mavenWrapperPropertyFileInputStream.close();
|
||||
}
|
||||
} catch (IOException e) {
|
||||
// Ignore ...
|
||||
}
|
||||
}
|
||||
}
|
||||
System.out.println("- Downloading from: " + url);
|
||||
|
||||
File outputFile = new File(baseDirectory.getAbsolutePath(), MAVEN_WRAPPER_JAR_PATH);
|
||||
if(!outputFile.getParentFile().exists()) {
|
||||
if(!outputFile.getParentFile().mkdirs()) {
|
||||
System.out.println(
|
||||
"- ERROR creating output directory '" + outputFile.getParentFile().getAbsolutePath() + "'");
|
||||
}
|
||||
}
|
||||
System.out.println("- Downloading to: " + outputFile.getAbsolutePath());
|
||||
try {
|
||||
downloadFileFromURL(url, outputFile);
|
||||
System.out.println("Done");
|
||||
System.exit(0);
|
||||
} catch (Throwable e) {
|
||||
System.out.println("- Error downloading");
|
||||
e.printStackTrace();
|
||||
System.exit(1);
|
||||
}
|
||||
}
|
||||
|
||||
private static void downloadFileFromURL(String urlString, File destination) throws Exception {
|
||||
if (System.getenv("MVNW_USERNAME") != null && System.getenv("MVNW_PASSWORD") != null) {
|
||||
String username = System.getenv("MVNW_USERNAME");
|
||||
char[] password = System.getenv("MVNW_PASSWORD").toCharArray();
|
||||
Authenticator.setDefault(new Authenticator() {
|
||||
@Override
|
||||
protected PasswordAuthentication getPasswordAuthentication() {
|
||||
return new PasswordAuthentication(username, password);
|
||||
}
|
||||
});
|
||||
}
|
||||
URL website = new URL(urlString);
|
||||
ReadableByteChannel rbc;
|
||||
rbc = Channels.newChannel(website.openStream());
|
||||
FileOutputStream fos = new FileOutputStream(destination);
|
||||
fos.getChannel().transferFrom(rbc, 0, Long.MAX_VALUE);
|
||||
fos.close();
|
||||
rbc.close();
|
||||
}
|
||||
|
||||
}
|
||||
+18
-3
@@ -1,3 +1,18 @@
|
||||
wrapperVersion=3.3.4
|
||||
distributionType=only-script
|
||||
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.9/apache-maven-3.9.9-bin.zip
|
||||
# Licensed to the Apache Software Foundation (ASF) under one
|
||||
# or more contributor license agreements. See the NOTICE file
|
||||
# distributed with this work for additional information
|
||||
# regarding copyright ownership. The ASF licenses this file
|
||||
# to you under the Apache License, Version 2.0 (the
|
||||
# "License"); you may not use this file except in compliance
|
||||
# with the License. You may obtain a copy of the License at
|
||||
#
|
||||
# http://www.apache.org/licenses/LICENSE-2.0
|
||||
#
|
||||
# Unless required by applicable law or agreed to in writing,
|
||||
# software distributed under the License is distributed on an
|
||||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||
# KIND, either express or implied. See the License for the
|
||||
# specific language governing permissions and limitations
|
||||
# under the License.
|
||||
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.6/apache-maven-3.8.6-bin.zip
|
||||
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar
|
||||
|
||||
@@ -1,31 +0,0 @@
|
||||
# Vulnerability Research Agent
|
||||
|
||||
You are helping a security researcher evaluate and report potential vulnerabilities in Apache Struts.
|
||||
|
||||
[`SECURITY.md`](SECURITY.md) is the source of truth for the Apache Struts vulnerability reporting process. **Read it first and follow it.** This file is a short
|
||||
LLM-facing wrapper around that policy; it does not replace it.
|
||||
|
||||
## Workflow
|
||||
|
||||
Before drafting any report, opening an issue, posting publicly, or reaching a security conclusion:
|
||||
|
||||
1. **Pre-reporting checks** — complete every step in [`SECURITY.md` § Before Reporting](SECURITY.md#before-reporting):
|
||||
- read the Struts security policy,
|
||||
- read the Struts security guidelines,
|
||||
- check previously disclosed vulnerabilities and Security Bulletins.
|
||||
2. **Assess** the finding against the questions in [`SECURITY.md` § Assessment](SECURITY.md#assessment), and route it through the disposition guide in
|
||||
[`THREAT_MODEL.md`](THREAT_MODEL.md) (scope, trust boundaries, in-model security properties, and the known-non-findings list). If the answers do not still
|
||||
point to a likely new framework vulnerability, stop and explain — do not draft a new report.
|
||||
3. **Report privately** to `security@struts.apache.org` following [`SECURITY.md` § Private Report Requirements](SECURITY.md#private-report-requirements) and
|
||||
[§ Report Quality Rules](SECURITY.md#report-quality-rules).
|
||||
|
||||
Do not open a public GitHub issue, Jira issue, pull request, mailing list thread, or discussion for a suspected vulnerability before private triage.
|
||||
|
||||
## Rules for AI Agents
|
||||
|
||||
- **Never submit a pull request that fixes a suspected vulnerability.** Before opening any PR, verify the change is not a security patch — OGNL injection,
|
||||
parameter filtering bypass, file upload exploit, authentication or authorization bypass, RCE, SSRF, path traversal, deserialization, XSS in framework
|
||||
components, etc. If it is, stop and direct the researcher to report it privately to `security@struts.apache.org` instead. Vulnerability fixes go through
|
||||
the private security process, not public PRs.
|
||||
- Do not speculate beyond what can be demonstrated. If severity is uncertain, say so explicitly.
|
||||
- If the issue turns out to be application misconfiguration, an already-disclosed CVE, or a non-Struts problem, stop and explain — do not draft a new report.
|
||||
@@ -1,107 +0,0 @@
|
||||
# CLAUDE.md
|
||||
|
||||
This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
|
||||
|
||||
For detailed procedures, use the specialized skills in `.claude/skills/`.
|
||||
|
||||
## Project Overview
|
||||
|
||||
Apache Struts is a mature MVC web application framework for Java (originally WebWork 2). Uses OGNL for value stack expressions and FreeMarker for UI tag templates.
|
||||
|
||||
**Version**: read it from the root `pom.xml` — it is `7.4.0-SNAPSHOT` as of 2026-08-23. Do not treat the `-SNAPSHOT` value as the next release number: the release version is chosen at release time from the semver impact of the accumulated changes, so `7.4.0-SNAPSHOT` may well ship as something else. Released versions are git tags like `STRUTS_7_2_1`.
|
||||
|
||||
### Build Commands
|
||||
|
||||
```bash
|
||||
# Run tests (skip assembly for speed)
|
||||
mvn test -DskipAssembly
|
||||
|
||||
# Single test in specific module
|
||||
mvn test -DskipAssembly -pl core -Dtest=MyClassTest#testMethodName
|
||||
|
||||
# Jakarta EE 11 / Spring 7 profile
|
||||
mvn clean install -Pjakartaee11
|
||||
```
|
||||
|
||||
### Project Structure
|
||||
|
||||
```
|
||||
struts/
|
||||
├── core/ # struts2-core - main framework
|
||||
├── plugins/ # Plugin modules (json, rest, spring, tiles, velocity, etc.)
|
||||
├── apps/ # Sample applications (showcase, rest-showcase)
|
||||
├── assembly/ # Distribution packaging
|
||||
├── bom/ # Bill of Materials for dependency management
|
||||
├── parent/ # Parent POM with shared configuration
|
||||
└── jakarta/ # Jakarta EE compatibility modules
|
||||
```
|
||||
|
||||
### Core Architecture
|
||||
|
||||
**Request Lifecycle**: `Dispatcher` → `ActionProxy` → `ActionInvocation` → Interceptor stack → `Action` → Result
|
||||
|
||||
Key packages in `org.apache.struts2`:
|
||||
|
||||
- `dispatcher` - Request handling, `Dispatcher`, servlet integration
|
||||
- `interceptor` - Built-in interceptors (params, validation, fileUpload)
|
||||
- `components` - UI tag components (form, textfield, submit)
|
||||
- `action` - Action interfaces (`UploadedFilesAware`, `SessionAware`, etc.)
|
||||
- `security` - Security utilities and OGNL member access policies
|
||||
|
||||
## Security-Critical Patterns
|
||||
|
||||
Apache Struts has a history of security vulnerabilities (OGNL injection, temp file exploits). Apply these Struts-specific patterns:
|
||||
|
||||
1. **Temporary files**: Use UUID-based names in controlled locations (see example below)
|
||||
2. **OGNL expressions**: Evaluate only framework-generated OGNL; use allowlist member access
|
||||
3. **File uploads**: Validate content types, sanitize filenames, enforce size limits
|
||||
4. **Parameter filtering**: Use `ParameterNameAware` to restrict accepted parameter names
|
||||
|
||||
```java
|
||||
// Secure temporary file pattern
|
||||
protected File createTemporaryFile(String fileName, Path location) {
|
||||
String uid = UUID.randomUUID().toString().replace("-", "_");
|
||||
return location.resolve("upload_" + uid + ".tmp").toFile();
|
||||
}
|
||||
```
|
||||
|
||||
## Security Reports & Scans
|
||||
|
||||
For any security-related activity — vulnerability scans, security analysis, drafting security reports — **[`SECURITY.md`](SECURITY.md) is the source of truth**.
|
||||
Read it first and follow its pre-reporting checks, assessment checklist, and reporting requirements. Reports must be sent privately to
|
||||
`security@struts.apache.org`; do not open a public GitHub issue, Jira issue, pull request, or mailing list thread for a suspected vulnerability before private
|
||||
triage. [`AGENTS.md`](AGENTS.md) is a shorter LLM-facing wrapper around the same process.
|
||||
[`THREAT_MODEL.md`](THREAT_MODEL.md) is where the scope lives — trust boundaries, the security properties the framework does and does not provide, the
|
||||
recurring non-findings (§11a), and the triage dispositions (§13). Read it before judging whether a finding is real: on Struts most candidate findings are
|
||||
closed as application responsibility or non-default configuration rather than as framework bugs.
|
||||
|
||||
## Testing
|
||||
|
||||
Run with `mvn test -DskipAssembly`.
|
||||
|
||||
**Tests are JUnit 4 — there is no JUnit 5 anywhere in this repo.** `parent/pom.xml` declares
|
||||
`junit:junit:4.13.2`; there are zero `org.junit.jupiter` imports. Two styles coexist:
|
||||
|
||||
- **JUnit 3 style** — classes extending `XWorkTestCase` (which extends `junit.framework.TestCase`).
|
||||
Methods must be named `testXxx()`. A Jupiter `@Test` annotation added to one of these **silently
|
||||
never runs** — it does not fail, it is simply not collected.
|
||||
- **JUnit 4 style** — classes using `import org.junit.Test`.
|
||||
|
||||
Both styles are widespread and neither is being migrated away from; `grep -rl` for either marker
|
||||
gives the current split.
|
||||
|
||||
Before adding a test, open the target file and match the style already there. AssertJ assertions and
|
||||
Mockito mocks are both available and widely used. Introducing Jupiter is a build-infrastructure change
|
||||
that needs its own `WW-` ticket, never a side effect of a feature.
|
||||
|
||||
## Pull Requests
|
||||
|
||||
- **Title format**: `WW-XXXX Description` — a Jira ticket ID is required for any code change.
|
||||
Pure documentation and build/CI changes (`SECURITY.md`, `AGENTS.md`, `CLAUDE.md`, `.claude/`,
|
||||
workflows) take no ticket and use conventional-commit form instead: `docs: ...`, `build(ci): ...`,
|
||||
`chore: ...`
|
||||
- **Link ticket in description**: `Fixes [WW-XXXX](https://issues.apache.org/jira/browse/WW-XXXX)`
|
||||
- **Issue tracker**: https://issues.apache.org/jira/projects/WW
|
||||
- **Never submit a PR that fixes a suspected vulnerability.** Before opening a PR, verify the change is not a security patch (OGNL injection, parameter
|
||||
filtering bypass, file upload exploit, auth bypass, RCE, SSRF, path traversal, deserialization, XSS in framework components, etc.). If it is, stop and report
|
||||
it privately to `security@struts.apache.org` — see [`SECURITY.md`](SECURITY.md).
|
||||
@@ -1,2 +0,0 @@
|
||||
# Request PR review from any Apache Struts committer
|
||||
* @apache/struts-committers
|
||||
-118
@@ -1,118 +0,0 @@
|
||||
<!---
|
||||
Licensed to the Apache Software Foundation (ASF) under one or more
|
||||
contributor license agreements. See the NOTICE file distributed with
|
||||
this work for additional information regarding copyright ownership.
|
||||
The ASF licenses this file to You under the Apache License, Version 2.0
|
||||
(the "License"); you may not use this file except in compliance with
|
||||
the License. You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
-->
|
||||
# Contributing to Apache Struts
|
||||
|
||||
Thanks for your interest in contributing! Apache Struts is maintained by a
|
||||
community of volunteers under the [Apache Software Foundation](https://www.apache.org/).
|
||||
This guide walks a first-time contributor from a fresh clone to a merged pull
|
||||
request. You do not need to be a committer to contribute — anyone can open a PR.
|
||||
|
||||
## Getting help
|
||||
|
||||
- **Mailing lists:** Subscribe and ask on the developer or user list — see
|
||||
<https://struts.apache.org/mail.html>. The developer list is the best place
|
||||
to discuss a change before you start larger work.
|
||||
- **Issue tracker:** [JIRA WW project](https://issues.apache.org/jira/projects/WW).
|
||||
- **Homepage & docs:** <https://struts.apache.org/>.
|
||||
|
||||
If you are unsure whether a change is wanted, ask on the developer list or
|
||||
comment on the relevant JIRA issue first.
|
||||
|
||||
## Project overview
|
||||
|
||||
Apache Struts is a mature MVC web framework for Java (originally WebWork 2). It
|
||||
uses OGNL for value-stack expressions and FreeMarker for UI tag templates. The
|
||||
repository is a multi-module Maven build:
|
||||
|
||||
| Module | Responsibility |
|
||||
|------------|-------------------------------------------------------------|
|
||||
| `core` | `struts2-core` — the main framework |
|
||||
| `plugins` | Plugin modules (json, rest, spring, tiles, velocity, …) |
|
||||
| `apps` | Sample applications (showcase, rest-showcase) |
|
||||
| `assembly` | Distribution packaging |
|
||||
| `bom` | Bill of Materials for dependency management |
|
||||
| `parent` | Parent POM with shared configuration |
|
||||
| `jakarta` | Jakarta EE compatibility modules |
|
||||
|
||||
The request lifecycle is `Dispatcher` → `ActionProxy` → `ActionInvocation` →
|
||||
interceptor stack → `Action` → `Result`.
|
||||
|
||||
## Prerequisites & building
|
||||
|
||||
- **JDK 17** and **Maven**.
|
||||
- Run the tests (skipping assembly for speed):
|
||||
|
||||
```bash
|
||||
mvn test -DskipAssembly
|
||||
```
|
||||
|
||||
- Run a single test in a specific module:
|
||||
|
||||
```bash
|
||||
mvn test -DskipAssembly -pl core -Dtest=MyClassTest#testMethodName
|
||||
```
|
||||
|
||||
- Build against the Jakarta EE 11 / Spring 7 profile:
|
||||
|
||||
```bash
|
||||
mvn clean install -Pjakartaee11
|
||||
```
|
||||
|
||||
Tests use JUnit 5 with AssertJ assertions and Mockito for mocking.
|
||||
|
||||
## Finding something to work on
|
||||
|
||||
Browse the [JIRA WW project](https://issues.apache.org/jira/projects/WW) for
|
||||
open issues. Comment on an issue to let others know you are working on it. If
|
||||
no ticket exists for your change, **file one first** — every commit and pull
|
||||
request must reference a `WW-XXXX` ticket ID.
|
||||
|
||||
## Development workflow
|
||||
|
||||
1. Fork the repository and clone your fork.
|
||||
2. Create a branch off `main` named after the ticket, e.g. `WW-1234-short-description`.
|
||||
3. Implement your change **with tests**. Keep commits focused.
|
||||
4. Prefix every commit message with the ticket ID: `WW-1234 Describe the change`.
|
||||
5. Run `mvn test -DskipAssembly` and make sure it passes before opening a PR.
|
||||
|
||||
## Submitting a pull request
|
||||
|
||||
- **Title format:** `WW-XXXX Description` (the JIRA ticket ID is required).
|
||||
- **Link the ticket** in the description:
|
||||
`Fixes [WW-XXXX](https://issues.apache.org/jira/browse/WW-XXXX)`.
|
||||
- Continuous integration must pass, and reviewers expect code changes to come
|
||||
with tests.
|
||||
|
||||
## Reporting security issues
|
||||
|
||||
**Do not** open a public GitHub issue, JIRA issue, pull request, or
|
||||
mailing-list thread for a suspected vulnerability. Report it privately to
|
||||
**security@struts.apache.org**. See [`SECURITY.md`](SECURITY.md) for the full
|
||||
process. This includes OGNL injection, parameter-filtering bypasses, file
|
||||
upload exploits, authentication bypass, RCE, SSRF, path traversal,
|
||||
deserialization, and XSS in framework components.
|
||||
|
||||
## Licensing & Code of Conduct
|
||||
|
||||
- Apache Struts is licensed under the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0).
|
||||
- Every new source file must include the standard ASF license header (see any
|
||||
existing source file or this file's header for the exact text).
|
||||
- By submitting a pull request you agree to license your contribution under the
|
||||
Apache License 2.0. The ASF does not require a separate signed CLA for typical
|
||||
contributions.
|
||||
- All participation is governed by the
|
||||
[ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
|
||||
Vendored
+67
-88
@@ -1,22 +1,4 @@
|
||||
#!groovy
|
||||
/*
|
||||
* Licensed to the Apache Software Foundation (ASF) under one
|
||||
* or more contributor license agreements. See the NOTICE file
|
||||
* distributed with this work for additional information
|
||||
* regarding copyright ownership. The ASF licenses this file
|
||||
* to you under the Apache License, Version 2.0 (the
|
||||
* "License"); you may not use this file except in compliance
|
||||
* with the License. You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing,
|
||||
* software distributed under the License is distributed on an
|
||||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||
* KIND, either express or implied. See the License for the
|
||||
* specific language governing permissions and limitations
|
||||
* under the License.
|
||||
*/
|
||||
|
||||
pipeline {
|
||||
agent none
|
||||
@@ -41,66 +23,28 @@ pipeline {
|
||||
cleanWs deleteDirs: true, patterns: [[pattern: '**/target/**', type: 'INCLUDE']]
|
||||
}
|
||||
}
|
||||
stage('Detect changes') {
|
||||
steps {
|
||||
script {
|
||||
// Skip the build when a change only touched .claude/ - agent
|
||||
// instructions, not code. Fails open: anything unexpected (no
|
||||
// baseline, an unreachable commit, a git error) reports true and
|
||||
// the build runs as before.
|
||||
//
|
||||
// On a pull request the baseline is the merge base with the
|
||||
// target branch, NOT GIT_PREVIOUS_SUCCESSFUL_COMMIT. That pointer
|
||||
// is the previous head of this same PR, so once the PR is rebased
|
||||
// (or the target is merged into it) everything the target branch
|
||||
// absorbed in the meantime looks like a change of the PR's own.
|
||||
// The multibranch checkout already fetches the target branch, so
|
||||
// origin/$CHANGE_TARGET resolves here. On a branch build there is
|
||||
// no target and the previous successful commit is the only
|
||||
// baseline available.
|
||||
env.CODE_CHANGED = sh(returnStdout: true, script: '''
|
||||
set -u
|
||||
target="${CHANGE_TARGET:-}"
|
||||
if [ -n "$target" ]; then
|
||||
base=$(git merge-base "origin/${target}" HEAD 2>/dev/null || true)
|
||||
else
|
||||
base="${GIT_PREVIOUS_SUCCESSFUL_COMMIT:-}"
|
||||
fi
|
||||
if [ -z "$base" ] || ! git cat-file -e "${base}^{commit}" 2>/dev/null; then
|
||||
echo true
|
||||
exit 0
|
||||
fi
|
||||
outside=$(git diff --name-only "$base" HEAD | grep -vE '^(\\.claude/|$)' || true)
|
||||
if [ -n "$outside" ]; then
|
||||
echo true
|
||||
else
|
||||
echo false
|
||||
fi
|
||||
''').trim()
|
||||
echo "Changes outside .claude/: ${env.CODE_CHANGED}"
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
stage('JDK 21') {
|
||||
when {
|
||||
expression { env.CODE_CHANGED != 'false' }
|
||||
}
|
||||
stage('JDK 17') {
|
||||
agent {
|
||||
label 'ubuntu'
|
||||
}
|
||||
tools {
|
||||
jdk 'jdk_21_latest'
|
||||
jdk 'jdk_17_latest'
|
||||
maven 'maven_3_latest'
|
||||
}
|
||||
environment {
|
||||
MAVEN_OPTS = "-Xmx1024m"
|
||||
}
|
||||
stages {
|
||||
stage('Build') {
|
||||
steps {
|
||||
sh './mvnw -B clean install -DskipTests -DskipAssembly'
|
||||
}
|
||||
}
|
||||
stage('Test') {
|
||||
steps {
|
||||
sh './mvnw -B -DskipAssembly verify'
|
||||
sh './mvnw -B test'
|
||||
}
|
||||
post {
|
||||
always {
|
||||
@@ -116,24 +60,21 @@ pipeline {
|
||||
}
|
||||
}
|
||||
}
|
||||
stage('JDK 17') {
|
||||
when {
|
||||
expression { env.CODE_CHANGED != 'false' }
|
||||
}
|
||||
stage('JDK 11') {
|
||||
agent {
|
||||
label 'ubuntu'
|
||||
}
|
||||
tools {
|
||||
jdk 'jdk_17_latest'
|
||||
jdk 'jdk_11_latest'
|
||||
maven 'maven_3_latest'
|
||||
}
|
||||
environment {
|
||||
MAVEN_OPTS = "-Xmx2048m"
|
||||
MAVEN_OPTS = "-Xmx1024m"
|
||||
}
|
||||
stages {
|
||||
stage('Install') {
|
||||
stage('Build') {
|
||||
steps {
|
||||
sh './mvnw -B install -DskipTests -DskipAssembly'
|
||||
sh './mvnw -B clean install -DskipTests -DskipAssembly'
|
||||
}
|
||||
}
|
||||
stage('Test') {
|
||||
@@ -147,12 +88,55 @@ pipeline {
|
||||
}
|
||||
}
|
||||
}
|
||||
stage('Code Quality') {
|
||||
when {
|
||||
branch 'master'
|
||||
}
|
||||
steps {
|
||||
withCredentials([string(credentialsId: 'asf-struts-sonarcloud', variable: 'SONARCLOUD_TOKEN')]) {
|
||||
sh './mvnw -B -Pcoverage -DskipAssembly -Dsonar.login=${SONARCLOUD_TOKEN} verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar'
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
post {
|
||||
always {
|
||||
cleanWs deleteDirs: true, patterns: [[pattern: '**/target/**', type: 'INCLUDE']]
|
||||
}
|
||||
}
|
||||
}
|
||||
stage('JDK 8') {
|
||||
agent {
|
||||
label 'ubuntu'
|
||||
}
|
||||
tools {
|
||||
jdk 'jdk_1.8_latest'
|
||||
maven 'maven_3_latest'
|
||||
}
|
||||
environment {
|
||||
MAVEN_OPTS = "-Xmx1024m"
|
||||
}
|
||||
stages {
|
||||
stage('Build') {
|
||||
steps {
|
||||
sh './mvnw -B clean install -DskipTests -DskipAssembly'
|
||||
}
|
||||
}
|
||||
stage('Test') {
|
||||
steps {
|
||||
sh './mvnw -B test'
|
||||
// step([$class: 'JiraIssueUpdater', issueSelector: [$class: 'DefaultIssueSelector'], scm: scm])
|
||||
}
|
||||
post {
|
||||
always {
|
||||
junit(testResults: '**/surefire-reports/*.xml', allowEmptyResults: true)
|
||||
junit(testResults: '**/failsafe-reports/*.xml', allowEmptyResults: true)
|
||||
}
|
||||
}
|
||||
}
|
||||
stage('Build Source & JavaDoc') {
|
||||
when {
|
||||
anyOf {
|
||||
branch 'main'
|
||||
branch 'support/struts-6-x-x'
|
||||
}
|
||||
branch 'master'
|
||||
}
|
||||
steps {
|
||||
dir("local-snapshots-dir/") {
|
||||
@@ -163,10 +147,7 @@ pipeline {
|
||||
}
|
||||
stage('Deploy Snapshot') {
|
||||
when {
|
||||
anyOf {
|
||||
branch 'main'
|
||||
branch 'support/struts-6-x-x'
|
||||
}
|
||||
branch 'master'
|
||||
}
|
||||
steps {
|
||||
withCredentials([file(credentialsId: 'lukaszlenart-repository-access-token', variable: 'CUSTOM_SETTINGS')]) {
|
||||
@@ -176,10 +157,7 @@ pipeline {
|
||||
}
|
||||
stage('Upload nightlies') {
|
||||
when {
|
||||
anyOf {
|
||||
branch 'main'
|
||||
branch 'support/struts-6-x-x'
|
||||
}
|
||||
branch 'master'
|
||||
}
|
||||
steps {
|
||||
sh './mvnw -B package -DskipTests'
|
||||
@@ -190,7 +168,8 @@ pipeline {
|
||||
sshTransfer(
|
||||
remoteDirectory: '/struts/snapshot',
|
||||
removePrefix: 'assembly/target/assembly/out',
|
||||
sourceFiles: 'assembly/target/assembly/out/struts-*.zip'
|
||||
sourceFiles: 'assembly/target/assembly/out/struts-*.zip',
|
||||
cleanRemote: true
|
||||
)
|
||||
],
|
||||
verbose: true
|
||||
@@ -211,7 +190,7 @@ pipeline {
|
||||
failure {
|
||||
script {
|
||||
emailext(
|
||||
to: "notifications@struts.apache.org",
|
||||
to: "dev@struts.apache.org",
|
||||
recipientProviders: [[$class: 'DevelopersRecipientProvider']],
|
||||
from: "Mr. Jenkins <jenkins@builds.apache.org>",
|
||||
subject: "Jenkins job ${env.JOB_NAME}#${env.BUILD_NUMBER} failed",
|
||||
@@ -234,7 +213,7 @@ Director of Continuous Integration
|
||||
unstable {
|
||||
script {
|
||||
emailext(
|
||||
to: "notifications@struts.apache.org",
|
||||
to: "dev@struts.apache.org",
|
||||
recipientProviders: [[$class: 'DevelopersRecipientProvider']],
|
||||
from: "Mr. Jenkins <jenkins@builds.apache.org>",
|
||||
subject: "Jenkins job ${env.JOB_NAME}#${env.BUILD_NUMBER} unstable",
|
||||
@@ -257,7 +236,7 @@ Director of Continuous Integration
|
||||
fixed {
|
||||
script {
|
||||
emailext(
|
||||
to: "notifications@struts.apache.org",
|
||||
to: "dev@struts.apache.org",
|
||||
recipientProviders: [[$class: 'DevelopersRecipientProvider']],
|
||||
from: 'Mr. Jenkins <jenkins@builds.apache.org>',
|
||||
subject: "Jenkins job ${env.JOB_NAME}#${env.BUILD_NUMBER} back to normal",
|
||||
|
||||
@@ -17,9 +17,9 @@
|
||||
The Apache Struts web framework
|
||||
-------------------------------
|
||||
|
||||
[](https://ci-builds.apache.org/job/Struts/job/Struts%20Core/job/main/)
|
||||
[](https://ci-builds.apache.org/job/Struts/job/Struts%20Core/job/master/)
|
||||
[](https://github.com/apache/struts/actions/workflows/maven.yml)
|
||||
[](https://maven-badges.sml.io/sonatype-central/org.apache.struts/struts2-core/)
|
||||
[](https://maven-badges.herokuapp.com/maven-central/org.apache.struts/struts2-core/)
|
||||
[](https://javadoc.io/doc/org.apache.struts/struts2-core)
|
||||
[](https://sonarcloud.io/summary/new_code?id=apache_struts)
|
||||
[](https://deps.dev/maven/org.apache.struts%3Astruts2-core)
|
||||
@@ -103,15 +103,8 @@ the Struts approach.
|
||||
|
||||
## Commercial Support
|
||||
|
||||
The Apache Struts community does not offer commercial support by itself, but we maintain [a list of companies offering
|
||||
commercial support on our website](https://struts.apache.org/commercial-support.html).
|
||||
The Apache Struts community does not offer commercial support by itself.
|
||||
|
||||
Some Apache Struts maintainers are working with [Tidelift](https://tidelift.com/) to provide commercial support and
|
||||
invest paid working time in the improvement of the Apache Struts framework. For more information, visit
|
||||
the [Tidelift resources regarding Apache Struts](https://tidelift.com/subscription/pkg/maven-org-apache-struts-struts2-core?utm_source=maven-org-apache-struts-struts2-core&utm_medium=referral&utm_campaign=readme)
|
||||
|
||||
## Thank you
|
||||
|
||||
[YourKit](https://www.yourkit.com/) is kindly supporting open source projects with its full-featured Java Profiler.
|
||||
YourKit is the creator of innovative and intelligent tools for profiling Java and .NET applications.
|
||||
As an Apache committer, you can get a free license at [YourKit's open source sponsorship program](https://www.yourkit.com/java/profiler/purchase/#os_license).
|
||||
|
||||
+8
-134
@@ -1,30 +1,16 @@
|
||||
# Security Policy
|
||||
|
||||
## Threat Model
|
||||
|
||||
A structured threat model for the Apache Struts framework — scope, adversary model,
|
||||
the security properties the framework provides vs. leaves to the application, and a
|
||||
triage-disposition guide for inbound reports and automated-scanner findings — is
|
||||
maintained in [`THREAT_MODEL.md`](THREAT_MODEL.md). It is additive to this policy:
|
||||
this `SECURITY.md` and the [security guidance](https://struts.apache.org/security/)
|
||||
remain canonical for the reporting process and configuration details.
|
||||
|
||||
## Supported Versions
|
||||
|
||||
Please visit the [Releases](https://struts.apache.org/releases.html#prior-releases) page to see full information about each version
|
||||
Please vist the [Releases](https://struts.apache.org/releases.html#prior-releases) page to see full information about each version
|
||||
and what potential vulnerability it can have:
|
||||
|
||||
| Version | Supported |
|
||||
|---------|-----------|
|
||||
| 7.x | yes |
|
||||
| 6.x.x | yes |
|
||||
| 2.5.x | no |
|
||||
| 2.3.x | no |
|
||||
| 2.2.x | no |
|
||||
| 2.1.x | no |
|
||||
| 2.0.x | no |
|
||||
| Version | Supported |
|
||||
| ------- | ------------------ |
|
||||
| 6.0.0 | :white_check_mark: |
|
||||
| 2.5.30 | :white_check_mark: |
|
||||
|
||||
## Reporting New Security Issues with the Apache Struts
|
||||
## Reporting New Security Issues with thr Apache Struts
|
||||
|
||||
([original](https://struts.apache.org/security.html))
|
||||
|
||||
@@ -42,124 +28,12 @@ All mail sent to this address that does not relate to security problems in the A
|
||||
```
|
||||
|
||||
Note that all networked servers are subject to denial of service attacks, and we cannot promise magic
|
||||
workarounds to generic problems (such as a client streaming lots of data to your server or requesting
|
||||
the same URL repeatedly). In general, our philosophy is to avoid any attacks that can cause the server
|
||||
workarounds to generic problems (such as a client streaming lots of data to your server, or re-requesting
|
||||
the same URL repeatedly). In general our philosophy is to avoid any attacks which can cause the server
|
||||
to consume resources in a non-linear relationship to the size of inputs.
|
||||
|
||||
To be clear about the linear cases: that philosophy describes what we design against, not a threshold a
|
||||
report has to clear before we will accept it. Framework code that reads or retains request-derived input
|
||||
**without any bound** is in scope even where the growth is merely linear, and we have assigned CVEs for
|
||||
exactly that. What stays out of scope is the generic case above — where the cost to the server is
|
||||
proportionate, no framework limit is missing or ineffective, and the defence belongs to your servlet
|
||||
container, reverse proxy, or network.
|
||||
|
||||
The mailing address is: [security@struts.apache.org](mailto:security@struts.apache.org)
|
||||
|
||||
[General network server security tips](http://httpd.apache.org/docs/trunk/misc/security_tips.html)
|
||||
|
||||
[The Apache Security Team](http://www.apache.org/security/)
|
||||
|
||||
## Do not disclose through a pull request, commit, or issue
|
||||
|
||||
**A fix is a disclosure.** Opening a public pull request, pushing a commit, branch, or
|
||||
fork, or filing a public Jira/GitHub issue that **fixes, describes, or hints at** a
|
||||
suspected vulnerability reveals where the weakness is — often with a working roadmap to
|
||||
exploit it — before a fixed release exists. This holds even if you never attach a
|
||||
proof-of-concept, and even if you believe the impact is low or you are "just hardening"
|
||||
the code.
|
||||
|
||||
If you have found, or suspect you have found, a security problem:
|
||||
|
||||
- **Do not** open a public PR, commit, branch, fork, Jira issue, or mailing-list thread
|
||||
for it.
|
||||
- **Do** email [security@struts.apache.org](mailto:security@struts.apache.org) first and
|
||||
wait for the PMC to triage it and agree how the fix will be handled — the fix is
|
||||
typically prepared privately and landed alongside the advisory and release.
|
||||
|
||||
If you notice a possible security issue while working on an unrelated bug or PR, stop and
|
||||
email the private list before pushing the change. **When in doubt, treat it as
|
||||
security-sensitive and email the list** — a private report that turns out to be a
|
||||
non-issue costs far less than a public change that turns out to be exploitable.
|
||||
|
||||
## Before Reporting
|
||||
|
||||
Before sending a vulnerability report, run through the following checks. They exist to prevent duplicate reports, public disclosure of untriaged issues,
|
||||
and reports for behavior that is already documented as insecure configuration.
|
||||
|
||||
### 1. Read this policy
|
||||
|
||||
Confirm:
|
||||
|
||||
- which Struts versions are currently supported (see [Supported Versions](#supported-versions)),
|
||||
- where reports must be sent (see [Reporting New Security Issues](#reporting-new-security-issues-with-the-apache-struts)),
|
||||
- which reports do not belong on the private security list.
|
||||
|
||||
### 2. Read the Struts security guidelines
|
||||
|
||||
Review the [Struts security guidance](https://struts.apache.org/security/) and determine whether the finding is already covered by documented secure
|
||||
configuration or application guidance, including but not limited to:
|
||||
|
||||
- Config Browser Plugin exposure,
|
||||
- direct JSP access,
|
||||
- `devMode` is required to exploit the vulnerability,
|
||||
- `@StrutsParameter` usage and parameter annotation requirements,
|
||||
- unsafe setters or getters exposed to request parameters,
|
||||
- use of incoming values in localization or forced OGNL evaluation,
|
||||
- raw JSP EL expressions,
|
||||
- custom error pages,
|
||||
- Dynamic Method Invocation and Strict Method Invocation,
|
||||
- accepted and excluded parameter patterns,
|
||||
- Fetch Metadata, COOP, and COEP protections,
|
||||
- OGNL sandboxing, allowlists, excluded classes/packages, and OGNL Guard settings.
|
||||
|
||||
If the behavior is caused by an application ignoring documented security guidance, that is not an Apache Struts framework vulnerability.
|
||||
|
||||
### 3. Check previously disclosed vulnerabilities
|
||||
|
||||
Compare the finding against already disclosed Struts vulnerabilities — affected versions, impact ratings, mitigations, and fixed versions:
|
||||
|
||||
- [Struts security information](https://struts.apache.org/security/)
|
||||
- [Prior releases and vulnerability notes](https://struts.apache.org/releases.html#prior-releases)
|
||||
- [Security Bulletins (S2 series)](https://cwiki.apache.org/confluence/display/WW/Security+Bulletins)
|
||||
|
||||
If the finding overlaps with a known vulnerability, link to the existing bulletin, advisory, CVE, or release notes instead of drafting a new report.
|
||||
|
||||
## Assessment
|
||||
|
||||
Before drafting a report, confirm:
|
||||
|
||||
1. Is the affected version supported?
|
||||
2. Is the behavior in Apache Struts framework code, rather than only in an application using Struts?
|
||||
3. Is it already documented as insecure configuration or unsupported usage?
|
||||
4. Is it a duplicate of a previously disclosed vulnerability or Security Bulletin?
|
||||
5. Can the impact be demonstrated with a minimal, self-contained reproduction?
|
||||
|
||||
Only proceed with a private report when these answers still point to a likely new vulnerability in the framework.
|
||||
|
||||
## Private Report Requirements
|
||||
|
||||
A useful private report includes:
|
||||
|
||||
- affected Struts version or version range,
|
||||
- affected component or module,
|
||||
- required application configuration, if any,
|
||||
- minimal reproduction steps,
|
||||
- expected behavior,
|
||||
- actual behavior,
|
||||
- demonstrated security impact,
|
||||
- whether authentication or special privileges are required,
|
||||
- proposed fix or mitigation, if known.
|
||||
|
||||
Do not speculate beyond what can be demonstrated. If severity is uncertain, say so explicitly.
|
||||
|
||||
## Report Quality Rules
|
||||
|
||||
- One vulnerability per report.
|
||||
- Keep reproduction steps minimal and self-contained.
|
||||
- Do not include unrelated findings.
|
||||
- Do not publish exploit details or proof-of-concept code publicly before the Struts project has triaged the issue. **A fix, patch, or hardening change is a
|
||||
public disclosure in the same way a PoC is** — see [Do not disclose through a pull request, commit, or issue](#do-not-disclose-through-a-pull-request-commit-or-issue).
|
||||
**Pushing a PoC to a public GitHub repository, gist, fork, or branch counts as public disclosure** — even a "test" or throwaway repo. Private repositories
|
||||
are acceptable for sharing a PoC, but access must be granted individually to each PMC member who will triage the report.
|
||||
- Do not send ordinary bugs, usage questions, or generic denial-of-service concerns to the private security list.
|
||||
- If the issue is not a vulnerability in Apache Struts source code, use the appropriate public support or issue channel instead.
|
||||
|
||||
-591
@@ -1,591 +0,0 @@
|
||||
<!--
|
||||
Licensed to the Apache Software Foundation (ASF) under one or more
|
||||
contributor license agreements. See the NOTICE file distributed with
|
||||
this work for additional information regarding copyright ownership.
|
||||
The ASF licenses this file to You under the Apache License, Version 2.0
|
||||
(the "License"); you may not use this file except in compliance with
|
||||
the License. You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
-->
|
||||
# Apache Struts — Threat Model (v0 draft)
|
||||
|
||||
## §1 Header
|
||||
|
||||
- **Project:** Apache Struts (`apache/struts`), `main` @ HEAD (2026-06). Scope: the
|
||||
Struts framework in `apache/struts` only (the core MVC framework, its
|
||||
interceptors, tags, and the plugins shipped in this repo).
|
||||
- **Date:** 2026-06-24. **Drafted for PMC review** via the threat-model-producer
|
||||
rubric (Scovetta). This is an unratified proposal, not an ASF Security team or
|
||||
PMC position; authorship and sponsorship are settled only once the PMC adopts it
|
||||
(see Status below and §14).
|
||||
- **Status:** DRAFT — not yet reviewed by the Struts PMC. Built as a strict
|
||||
superset of the existing [`SECURITY.md`](SECURITY.md) and the published
|
||||
[Struts security guidance](https://struts.apache.org/security/); every
|
||||
load-bearing claim is tagged for provenance (see §14 for open questions).
|
||||
- **Last revised:** 2026-08-15 — re-baselined against Security Bulletins
|
||||
**S2-070 … S2-074**, published 2026-08-14. This fired the §12 trigger twice over:
|
||||
those bulletins added default-hardening controls (7.3.0 / 6.11.0, §5a) and named two
|
||||
vulnerability classes the v0 draft did not carry as properties at all (§8.6, §8.7).
|
||||
Bulletin-to-section map in §16.
|
||||
- **Version binding:** versioned with the project; a report against version *N*
|
||||
is triaged against the model as it stood at *N*. The security envelope changed
|
||||
materially at **7.0** (several hardening knobs flipped to secure-by-default) and
|
||||
again at **7.3.0 / 6.11.0** (the first resource-bound controls — §5a), so the version
|
||||
is itself load-bearing.
|
||||
- **Reporting cross-reference:** §8-property violations → report privately per
|
||||
[`SECURITY.md`](SECURITY.md) (`security@struts.apache.org`); §3/§9/§11a findings
|
||||
are closed citing this document and the existing `SECURITY.md` "Before
|
||||
Reporting" checks.
|
||||
- **Provenance legend:** *(documented)* = Struts' own docs/`SECURITY.md`/security
|
||||
site; *(maintainer)* = confirmed by a Struts PMC member through this process;
|
||||
*(inferred)* = reasoned from architecture/docs, not yet PMC-ratified — each has
|
||||
a matching §14 open question.
|
||||
- **Draft confidence:** the bulk is *(documented)* — Struts has an unusually rich
|
||||
published security policy — with a handful of *(inferred)* scoping calls for the
|
||||
PMC to ratify.
|
||||
|
||||
**What Struts is.** Apache Struts 2 is a **Java MVC web framework** for building
|
||||
server-side web applications. A request flows: servlet filter → action mapping →
|
||||
**interceptor stack** (parameter population, validation, etc.) → **Action** →
|
||||
**result** (typically a JSP/FreeMarker view). Request parameters are bound onto
|
||||
action properties via setters, and view/configuration expressions are evaluated
|
||||
through **OGNL (Object-Graph Navigation Language)** against the **ValueStack**.
|
||||
*(documented — struts.apache.org)*
|
||||
|
||||
**The framework's own security philosophy (load-bearing).** Struts
|
||||
**"doesn't provide any security mechanism — it is just a pure web framework."**
|
||||
*(documented — [security guidance](https://struts.apache.org/security/))* It is
|
||||
not an authentication, authorization, session-security, or input-sanitisation
|
||||
layer; those are the embedding application's responsibility (§3/§10). What Struts
|
||||
*does* take an active stance on is **not letting its own machinery — chiefly OGNL
|
||||
expression evaluation and request-parameter binding — become an injection vector**.
|
||||
That single sentence shapes the whole model: most "Struts is insecure" reports are
|
||||
either OGNL-injection-class (in model, §8) or application-responsibility (out of
|
||||
model, §3/§11a).
|
||||
|
||||
Two corrections to that framing, drawn from the project's own published record.
|
||||
First, injection containment is not the only thing the framework owes its own
|
||||
machinery: it also owes **isolation between concurrently-served requests** and
|
||||
**bounds on what a single client can make it allocate or retain** (§8.6, §8.7).
|
||||
Second, OGNL remains the highest-*severity* class but is no longer the high-*volume*
|
||||
one — S2-070 through S2-074 are five consecutive bulletins with no OGNL among them
|
||||
(§16). A triager who expects every real finding to be OGNL-shaped will misroute the
|
||||
ones that are not.
|
||||
|
||||
## §2 Scope and intended use
|
||||
|
||||
Intended deployment: the Struts JARs are a **dependency embedded inside a web
|
||||
application** (a WAR) that the application developer writes, configures, and
|
||||
deploys into a servlet container (Tomcat, Jetty, …) behind the operator's
|
||||
perimeter. Struts is **in-process** with the application; it has no daemon, no
|
||||
listening socket of its own, and no trust boundary against the application code
|
||||
it runs inside. *(documented — it is a framework, not a server.)*
|
||||
|
||||
**Caller roles.**
|
||||
|
||||
- **Untrusted HTTP client** — sends requests (parameters, headers, cookies,
|
||||
multipart uploads) to a Struts-backed endpoint. **The primary untrusted boundary.**
|
||||
Struts must treat all request-derived values as hostile. *(documented — the
|
||||
parameter/OGNL hardening exists precisely for this actor.)*
|
||||
- **Application developer** — writes the actions, JSPs, struts.xml/annotations,
|
||||
and chooses the hardening settings (§5a). **Trusted by the framework** — their
|
||||
code and configuration run with the application's privileges. A finding that
|
||||
requires the developer to write unsafe code or disable a default protection is
|
||||
the application's bug, not Struts' (§3). *(documented — the developer-responsibility
|
||||
section of the security guidance.)*
|
||||
- **Operator** — deploys the WAR, sets `devMode` off, restricts dev-only plugins,
|
||||
configures the container and JVM. **Trusted.** *(documented.)*
|
||||
|
||||
**Component families.**
|
||||
|
||||
| Family | Entry point | Touches | In model? |
|
||||
| --- | --- | --- | --- |
|
||||
| OGNL evaluation + ValueStack | expression eval for params, tags, results | in-JVM code paths | **In — the central attack surface** *(documented)* |
|
||||
| Parameter binding (`ParametersInterceptor`, `@StrutsParameter`) | request params → action setters | reflection into app objects | **In — primary boundary** *(documented)* |
|
||||
| Interceptor stack (cookie, fileupload, fetch-metadata, COOP/COEP, …) | per-request processing | request data | **In** *(documented)* |
|
||||
| Tag library / JSP & FreeMarker integration | view rendering, expression output | template eval | **In — output-side OGNL/EL** *(documented)* |
|
||||
| File upload (Jakarta multipart) | multipart request parsing | temp files | **In — historical CVE surface** *(documented — S2 bulletins)* |
|
||||
| Request-body readers (JSON body population, CSP violation-report collection) | reads the raw request body | heap, parse state | **In** *(documented — S2-070, S2-072, S2-073)* |
|
||||
| Bundled plugins (REST, JSON, Convention, …) in this repo | extra mappers/result types | request data | **In — same request-trust surface** *(documented — S2-070/071/072 are JSON-plugin bulletins; §14 Q-plugins answered)* |
|
||||
| Config Browser Plugin | exposes internal config | dev-only diagnostic | **In as dev-only** — exposure in prod is operator misconfig (§3/§11a) *(documented)* |
|
||||
| Embedding application's own actions/JSPs/config | the developer's code | as the app | **Out — application responsibility (§3)** *(documented)* |
|
||||
| Examples / showcase / test apps | demo code | n/a | **Out** *(see §3)* |
|
||||
|
||||
**An optional feature is not a "non-default configuration."** Four of the five most
|
||||
recent bulletins concern surfaces that stay inert until an application turns them on:
|
||||
the JSON plugin's population of actions from a request body, its SMD / JSON-RPC branch
|
||||
(`enableSMD`), and a mapped endpoint collecting CSP violation reports. **None of that
|
||||
is `OUT-OF-MODEL: non-default-config`.** That disposition is for settings the project
|
||||
documents as *unsafe* (`devMode`, a disabled §5a hardening knob); a feature the project
|
||||
documents as *available* is in model at full request-trust level from the moment an
|
||||
application enables it, and the framework owes it the same §8 properties as the default
|
||||
path. Read literally, the v0 draft let a triager close all four — S2-070, S2-071,
|
||||
S2-072, S2-073 — as non-default configuration; this paragraph is what prevents that.
|
||||
*(documented — S2-070/071/072/073; §13, §14 Q-optional.)*
|
||||
|
||||
## §3 Out of scope (explicit non-goals)
|
||||
|
||||
The detailed lists of developer anti-patterns and insecure configurations are
|
||||
maintained in the project's own docs and are **not duplicated here** — this model
|
||||
links to them and assigns each a triage disposition (§13):
|
||||
|
||||
- **Anything the application developer is responsible for.** Struts provides no
|
||||
security mechanism of its own *(documented)*. The full enumeration —
|
||||
developer-exposed unsafe setters, request parameters used in localization or
|
||||
forced OGNL evaluation, raw `${...}` JSP-EL over untrusted values, direct JSP
|
||||
access, mixing security levels in one namespace — is in the
|
||||
[security guidance](https://struts.apache.org/security/) and
|
||||
[`SECURITY.md`](SECURITY.md). All are `OUT-OF-MODEL: application-responsibility`.
|
||||
- **Findings that only manifest with a documented-insecure / non-default setting**
|
||||
(`devMode=true`, Config Browser Plugin exposed in production, DMI enabled, or a
|
||||
§5a hardening knob turned off) → `OUT-OF-MODEL: non-default-config`. *(documented.)*
|
||||
- **The servlet container, JVM, JDK, and OS**, and the application's own
|
||||
authentication, authorization, session management, CSRF token storage, and
|
||||
transport (TLS). Struts is "a pure web framework," not a security framework.
|
||||
*(documented / inferred — §14 Q-env.)*
|
||||
- **Generic denial of service** — flooding, bandwidth exhaustion, or repeating a URL:
|
||||
cases where the cost to the server stays proportionate and no framework limit is
|
||||
missing or ineffective. The defence is the operator's, ahead of the application
|
||||
(container, reverse proxy, network). *(documented — [`SECURITY.md`](SECURITY.md).)*
|
||||
**This exclusion is narrower than the v0 draft claimed.** That draft read
|
||||
`SECURITY.md`'s "avoid resource consumption non-linear in the size of inputs" as a
|
||||
triage threshold and put everything linear out of model. The project's own bulletins
|
||||
say otherwise: S2-072, S2-073, and S2-074 are all linear and all carry CVEs. The test
|
||||
is **whether a bound exists, not what shape the curve is** (§8.7) — `SECURITY.md`
|
||||
now states this directly.
|
||||
- **Already-disclosed S2-series vulnerabilities** — a duplicate of an existing
|
||||
Security Bulletin/CVE is closed by reference (the
|
||||
[`SECURITY.md` "Before Reporting"](SECURITY.md) checks), not re-triaged.
|
||||
- **Examples, showcase, and test applications** shipped in the repo. *(inferred — §14 Q-scope.)*
|
||||
|
||||
## §4 Trust boundaries and data flow
|
||||
|
||||
```
|
||||
Untrusted HTTP request
|
||||
│ params, headers, cookies, multipart
|
||||
▼
|
||||
Servlet filter ─► action mapping ─► Interceptor stack ─► Action ─► Result (JSP/FreeMarker)
|
||||
│ │
|
||||
ParametersInterceptor tag/result OGNL eval
|
||||
binds params to setters against ValueStack
|
||||
│ │
|
||||
▼ ▼
|
||||
OGNL evaluation against the ValueStack ◄── the trust boundary
|
||||
(allowlist / excluded classes+packages /
|
||||
expression length / @StrutsParameter)
|
||||
```
|
||||
|
||||
- **HTTP client → framework** is the one boundary Struts owns. Every request-derived
|
||||
string (parameter *names* as well as *values*, cookie names/values, header values,
|
||||
multipart filenames) is untrusted and may carry an OGNL payload. The framework's
|
||||
job at this boundary is to bind parameters and evaluate expressions **without
|
||||
letting attacker input reach an OGNL evaluation that creates or changes executable
|
||||
code**. *(documented.)*
|
||||
- **Framework → application code** is *not* a trust boundary — Struts runs the
|
||||
developer's actions and templates in-process, fully trusted. *(documented.)*
|
||||
|
||||
**Reachability precondition (triager's test).** A finding is in-model only if it is
|
||||
reachable by an **untrusted HTTP client against a Struts application that follows the
|
||||
documented secure configuration** (current-version defaults, `devMode` off, dev-only
|
||||
plugins restricted, no developer anti-patterns from §3). A finding that needs
|
||||
`devMode`, a disabled default protection, a developer-introduced unsafe setter, or a
|
||||
documented anti-pattern is `OUT-OF-MODEL`. *(documented/inferred — §14 Q-default.)*
|
||||
|
||||
## §5 Assumptions about the environment
|
||||
|
||||
- A servlet container and a JVM the operator maintains; Struts does not patch or
|
||||
harden them. *(inferred — §14 Q-env.)*
|
||||
- The application is deployed with the **current supported version** (7.x or 6.x per
|
||||
`SECURITY.md`); 2.x is end-of-life and out of support. *(documented — Supported
|
||||
Versions table.)*
|
||||
- The operator runs production with `devMode=false` and dev-only diagnostics (Config
|
||||
Browser Plugin) disabled or access-controlled. *(documented.)*
|
||||
- Struts opens no sockets and makes no outbound connections of its own; any network
|
||||
egress is the application's. *(inferred — §14 Q-egress.)*
|
||||
|
||||
## §5a Build-time and configuration variants — **the central knob set**
|
||||
|
||||
Struts' security envelope is set almost entirely by **runtime configuration**. The
|
||||
**authoritative, current list of every hardening setting (purpose + secure default)
|
||||
lives in the [security guidance](https://struts.apache.org/security/) and is not
|
||||
reproduced here.** Only the triage-load-bearing facts:
|
||||
|
||||
- The security posture **changed materially at 7.0**, where a cluster of
|
||||
OGNL-injection and parameter-binding defences became **secure-by-default** —
|
||||
notably the OGNL allowlist (`struts.allowlist.enable`), the `@StrutsParameter`
|
||||
annotation requirement (`struts.parameters.requireAnnotations`), excluded
|
||||
classes/packages, the expression-length cap (`struts.ognl.expressionMaxLength`,
|
||||
default 256), and the static-field/proxy/default-package/custom-map disallows.
|
||||
- The envelope moved again at **7.3.0 / 6.11.0**, which added the first *resource-bound*
|
||||
controls — the substance of §8.7, and on by default. The localized-text caches became
|
||||
bounded (`struts.i18n.cacheMaxSize`) and the CSP violation-report read became bounded
|
||||
(`struts.csp.report.maxSize`, default 8192; a configured value outside 1..1048576 is
|
||||
ignored and the default kept). `struts.locale.validateRequestLocale` (default `false`)
|
||||
is the one opt-in of the set: it restricts request-derived locales to the runtime's
|
||||
available-locale set. *(documented — S2-073, S2-074.)*
|
||||
- `struts.devMode` (must be `false` in production) and Dynamic Method Invocation
|
||||
(gated by Strict Method Invocation since 2.5) are the two settings whose *insecure*
|
||||
value most often turns a non-finding into an apparent finding.
|
||||
- The **FetchMetadata / COOP / COEP** interceptors (6.0+) are opt-in cross-origin
|
||||
defences (§8.5).
|
||||
|
||||
**Insecure-default question (wave 1).** Because the secure posture is the **7.0
|
||||
default set**, the triage rule needs ratifying: is "a finding that only works with a
|
||||
pre-7.0 default, or with a 7.0 hardening knob turned off" `OUT-OF-MODEL:
|
||||
non-default-config`, with §10 carrying "deploy current version with defaults"? — §14
|
||||
Q-default. The OGNL **Java Security Manager sandbox** (`-Dognl.security.manager`) is a
|
||||
separate, opt-in defence built on the JDK `SecurityManager`, which has been
|
||||
**deprecated for removal since JDK 17 (JEP 411), disabled by default since JDK 18,
|
||||
and permanently disabled in JDK 24 (JEP 486)** *(documented — JDK release notes)* —
|
||||
so on modern JDKs the model cannot treat it as a relied-upon control (§14 Q-jsm).
|
||||
|
||||
## §6 Assumptions about inputs
|
||||
|
||||
| Surface | Input | Attacker-controllable? | Concern |
|
||||
| --- | --- | --- | --- |
|
||||
| Parameter binding | request parameter **names and values** | **yes** | OGNL injection via crafted names; binding to unsafe setters |
|
||||
| Cookies | cookie names/values (Cookie Interceptor) | **yes** | same OGNL/parameter concerns; checked by accepted/excluded patterns |
|
||||
| Headers | request headers | **yes** | header-driven expression/log paths |
|
||||
| Multipart upload | file content, filename, content-type | **yes** | parser robustness, temp-file handling (S2 history) |
|
||||
| Request body | raw body bytes (JSON body, CSP violation report) | **yes** | must be read under a bound; a limit the framework advertises must bound the read it names (§8.7) |
|
||||
| Expression context | values that reach an OGNL eval (tags, results, forced eval) | **yes if developer feeds untrusted input in** | the core RCE channel |
|
||||
| struts.xml / annotations / action code | framework + app configuration | **no — developer-trusted** | not an attacker surface (§3) |
|
||||
|
||||
The accepted/excluded pattern checkers (`AcceptedPatternsChecker` /
|
||||
`ExcludedPatternsChecker`, since 2.3.20) validate parameter names/values for the
|
||||
Parameters and Cookie interceptors; a custom override that drops below the framework
|
||||
defaults is a developer error, not a framework flaw. *(documented.)*
|
||||
|
||||
A request-derived value that becomes a **key in framework-managed state** is an input
|
||||
class in its own right, not merely a value in flight — a request-derived locale keys the
|
||||
framework's localized-text caches, for instance. Such state can be reached through
|
||||
ordinary request handling, not only through an application feature deliberately built on
|
||||
it. When triaging, ask not only "where does this value get evaluated?" but "what does the
|
||||
framework *retain*, keyed on it, and is that bounded?" *(documented — S2-074.)*
|
||||
|
||||
## §7 Adversary model
|
||||
|
||||
- **In scope:** an **untrusted remote HTTP client** with no credentials, able to send
|
||||
arbitrary parameters, headers, cookies, and multipart uploads to any
|
||||
Struts-handled endpoint. Capabilities: craft parameter names/values carrying OGNL,
|
||||
attempt to reach executable-code creation through the ValueStack, pollute
|
||||
parameter binding, exploit a file-upload or multipart parsing bug, or drive framework
|
||||
code into an unbounded allocation or an unbounded retention (§8.7). Goal: **remote
|
||||
code execution via OGNL** (the dominant Struts threat), and secondarily data
|
||||
disclosure — including disclosure *across* concurrent requests — SSRF through
|
||||
framework features, or denial of service. *(documented — the OGNL lineage is the
|
||||
framework's stated central concern.)*
|
||||
- **Two capabilities the v0 draft left implicit.** The client can issue requests
|
||||
**concurrently**, racing any state the framework shares between them (§8.6); and it
|
||||
can **repeat** requests to accumulate framework-side state, where no single request
|
||||
is remarkable and the harm is in the aggregate (§8.7). Single-request reasoning is
|
||||
not sufficient to clear a surface. *(documented — S2-070/071, S2-074.)*
|
||||
- **On-path network attacker** — only where the application/operator has not deployed
|
||||
TLS; transport security is the app's, so this is largely out of model (§3). *(inferred — §14 Q-env.)*
|
||||
- **Out of scope:** the application developer (writes trusted code/config); the
|
||||
operator (deploys, sets devMode/plugins); anyone with container/host/JVM control;
|
||||
and a developer who disables a default protection or follows a documented
|
||||
anti-pattern (§3). *(documented.)*
|
||||
|
||||
## §8 Security properties the framework provides
|
||||
|
||||
*(In the current-version, default-hardening posture; each lists violation symptom +
|
||||
severity. Most are documented controls — the OGNL-injection defences are the core of
|
||||
Struts' security work.)*
|
||||
|
||||
1. **OGNL injection containment.** Attacker-supplied request data (parameter names/
|
||||
values, cookies, headers) must not reach an OGNL evaluation that creates or alters
|
||||
executable code. Enforced in depth by the default controls listed in §5a / the
|
||||
[security guidance](https://struts.apache.org/security/) (allowlist, excluded
|
||||
classes/packages, expression-length cap, static-field/proxy/default-package/
|
||||
custom-map disallows, excluded node types). *Violation:* a crafted request
|
||||
achieving OGNL-driven code execution (or class-loader/member access beyond the
|
||||
allowlist) on a default-configured current-version app. *Severity:*
|
||||
security-critical (the S2-RCE class). *(documented.)*
|
||||
2. **Parameter-binding safety (7.0).** Request parameters bind only to setters the
|
||||
developer marked `@StrutsParameter` (to the declared depth); arbitrary deep/nested
|
||||
property traversal is not reachable by default. *Violation:* parameters reaching
|
||||
an unannotated setter, or nesting beyond the declared depth, on a default 7.0 app.
|
||||
*Severity:* critical. *(documented.)*
|
||||
3. **Method-invocation control.** Dynamic Method Invocation is gated by Strict Method
|
||||
Invocation; a client cannot invoke arbitrary action methods by name when DMI is at
|
||||
its recommended (off/strict) setting. *Violation:* arbitrary method invocation on a
|
||||
default app. *Severity:* high–critical. *(documented.)*
|
||||
4. **Expression-length and node-type bounds.** OGNL expressions over the configured
|
||||
length (default 256) and forbidden node types are rejected before evaluation.
|
||||
*Violation:* bypass of these bounds. *Severity:* high. *(documented.)*
|
||||
5. **Cross-origin / fetch-metadata defences (opt-in).** When the FetchMetadata, COOP,
|
||||
and COEP interceptors are enabled, the framework emits/enforces the corresponding
|
||||
`Sec-Fetch-*` and cross-origin isolation behaviour. *Violation:* the interceptor
|
||||
failing to enforce its documented behaviour when enabled. *Severity:* medium–high.
|
||||
*(documented — opt-in since 6.0.)*
|
||||
6. **Per-request state isolation.** A framework component holding per-request state —
|
||||
parse state, serialization state, buffers — is not shared between requests being
|
||||
served concurrently. *Violation:* data associated with one request becoming
|
||||
observable in another, or a limit that holds for a single request being defeated by
|
||||
racing two. *Severity:* high — it is a disclosure and integrity failure at once, and
|
||||
it can void another §8 control rather than merely leaking. *Note:* this property is
|
||||
violated by an ordinary concurrency bug, with no attacker sophistication required;
|
||||
the same defect harms honest concurrent users. *(documented — S2-070, S2-071.)*
|
||||
7. **Bounded consumption of request-derived input.** Framework code that reads a request
|
||||
body reads it under a limit, and framework-managed state keyed on request-derived
|
||||
values (caches, maps) is bounded. A limit the framework advertises bounds the
|
||||
operation it appears to govern. *Violation:* a single request making the framework
|
||||
allocate in proportion to its size with no ceiling; unbounded retention accumulated
|
||||
across requests; or a configured limit that does not constrain the read it names.
|
||||
*Severity:* moderate–high (denial of service). *Note:* **linear growth is a
|
||||
violation.** The test is whether a bound exists, not whether the curve bends — see
|
||||
§3, and `SECURITY.md`'s paragraph on the linear cases. *(documented — S2-072,
|
||||
S2-073, S2-074.)*
|
||||
|
||||
## §9 Security properties the framework does *not* provide
|
||||
|
||||
- **No security mechanism in the general sense.** Struts provides no authentication,
|
||||
authorization, session security, CSRF token store, input sanitisation, or output
|
||||
encoding *for the application's own data* — "it is just a pure web framework."
|
||||
*(documented.)*
|
||||
- *False friend:* "Struts has no built-in login/access control" is **by design**,
|
||||
not a vulnerability.
|
||||
- **No protection against developer anti-patterns or non-default config** — unsafe
|
||||
setters, raw `${}` on user input, request params in localization/forced eval,
|
||||
direct JSP access, `devMode` on, disabled hardening (§3/§5a).
|
||||
- **No defence once OGNL evaluation is fed untrusted input by the application
|
||||
itself** (forced expression evaluation on a request value) — that is the developer
|
||||
handing OGNL the attacker's string. *(documented.)*
|
||||
- **No hard anti-DoS guarantee.** The framework bounds what its own code reads and
|
||||
retains (§8.7) and designs against super-linear consumption, but it cannot protect an
|
||||
application from flooding, bandwidth exhaustion, or repeated requests whose cost to
|
||||
the server stays proportionate — that is the operator's to absorb, ahead of the
|
||||
application. The disclaimed property is *availability under generic load*, not
|
||||
*boundedness of framework code*, which §8.7 does provide. *(documented.)*
|
||||
- **The OGNL Java Security Manager sandbox is not a relied-upon control on modern
|
||||
JDKs** (the underlying `SecurityManager` is deprecated for removal since JDK 17 and
|
||||
permanently disabled in JDK 24; see §5a). *(documented.)*
|
||||
- **Auto-generated error pages do not escape action names** (historical S2-006) — the
|
||||
app must define custom error pages; XSS in the default error page is a documented
|
||||
hardening item, not a defended property. *(documented.)*
|
||||
- **Well-known classes (framework):** OGNL/expression injection, multipart/file-upload
|
||||
parsing bugs, and parameter-pollution are the highest-severity recurring classes — but
|
||||
the recent record adds two more that are currently the *more frequent* ones:
|
||||
**unbounded reads and unbounded framework-managed state** (S2-072/073/074) and **state
|
||||
shared across concurrent requests** (S2-070/071). Reflected XSS, CSRF token
|
||||
management, and transport security remain the application's. *(documented — §16.)*
|
||||
|
||||
## §10 Downstream (developer + operator) responsibilities
|
||||
|
||||
The full, authoritative how-to is the [security guidance](https://struts.apache.org/security/)
|
||||
and [`SECURITY.md`](SECURITY.md); in one line: **deploy a current supported version
|
||||
with the default hardening left on, `devMode` off, dev-only plugins restricted,
|
||||
parameter setters annotated, JSPs hidden behind actions, and the application's own
|
||||
authn/authz/CSRF/TLS supplied** (Struts provides none of those). The threat-model
|
||||
value is only that a finding requiring the developer to *violate* one of these is
|
||||
`OUT-OF-MODEL` (§3/§13), not that this list is novel.
|
||||
|
||||
Two more that the recent bulletins name explicitly, both as workarounds and as standing
|
||||
practice: the **operator** enforces a maximum request-body size ahead of the
|
||||
application, in the reverse proxy or the servlet container, for any endpoint that
|
||||
accepts a body; and the **developer** sets `struts.locale` to a fixed value wherever
|
||||
request-derived locales are not actually needed. Both are defence in depth — they are
|
||||
*not* substitutes for the §8.7 bounds, and a missing framework bound stays a framework
|
||||
finding whether or not the operator happened to configure around it.
|
||||
*(documented — S2-072, S2-073, S2-074.)*
|
||||
|
||||
## §11 Known misuse patterns
|
||||
|
||||
These are the §3 application-responsibility / non-default-config items viewed as
|
||||
"things integrators get wrong" — running `devMode=true` in production or exposing the
|
||||
Config Browser Plugin; disabling a default OGNL/binding protection "to make something
|
||||
work"; exposing unsafe setters to binding; feeding request parameters into forced
|
||||
OGNL evaluation or localization; allowing direct `*.jsp` access or raw `${}` EL on
|
||||
untrusted values; relying on the OGNL Java Security Manager sandbox on modern JDKs. Each
|
||||
is documented in the [security guidance](https://struts.apache.org/security/); the
|
||||
disposition mapping is §11a/§13.
|
||||
|
||||
## §11a Known non-findings (recurring false positives)
|
||||
|
||||
*(Seeded directly from `SECURITY.md` "Before Reporting" — the PMC owns the
|
||||
authoritative list; §14 Q12.)*
|
||||
|
||||
- **"OGNL/RCE that only works with `devMode=true`."** `OUT-OF-MODEL: non-default-config`
|
||||
— devMode is a development-only setting documented as unsafe for production.
|
||||
- **"An action setter lets me inject a value / reach a dangerous method."** When the
|
||||
setter is developer-exposed without `@StrutsParameter` (7.0), or performs an unsafe
|
||||
side effect, this is `OUT-OF-MODEL: application-responsibility`. In-model only if it
|
||||
bypasses the framework's *default* binding/OGNL protections.
|
||||
- **"Direct JSP access discloses X / executes Y."** App-deployment misconfiguration —
|
||||
JSPs must be hidden behind actions. `OUT-OF-MODEL: application-responsibility`.
|
||||
- **"Raw `${}` EL / forced OGNL eval on my request parameter is exploitable."** The
|
||||
application fed untrusted input to expression evaluation — documented anti-pattern,
|
||||
not a framework flaw.
|
||||
- **"Config Browser Plugin exposes internal configuration."** Dev-only diagnostic;
|
||||
exposing it in production is operator misconfiguration. `OUT-OF-MODEL: non-default-config`.
|
||||
- **"I can enumerate / pass arbitrary parameters."** Parameter binding is the point of
|
||||
the framework; in-model only when it crosses the default annotation/allowlist
|
||||
protections.
|
||||
- **"Generic DoS: I hammered a URL / saturated the pipe."** Not accepted — proportionate
|
||||
cost with no missing framework bound is the operator's to absorb (§3). **But "I sent a
|
||||
large body" does not belong to this bullet by default:** if framework code reads that
|
||||
body into memory with no ceiling, it is a §8.7 violation and `VALID`, as S2-072 and
|
||||
S2-073 both were. Establish that a bound exists before closing on this ground. *(This
|
||||
bullet previously read "I streamed a huge body," which would have closed S2-072.)*
|
||||
- **"A framework cache grew when I sent many distinct values."** In model only where the
|
||||
cache is genuinely *unbounded*, or keyed on an unvalidated and unbounded input set. A
|
||||
bounded cache reaching its ceiling and evicting is working as designed, and a cache
|
||||
keyed on a validated finite set — a locale restricted to the runtime's available
|
||||
locales, for instance — is not unbounded. *(documented — S2-074.)*
|
||||
- **Duplicate of a disclosed S2-series bulletin/CVE** — closed by reference.
|
||||
- **Dependency-tail CVEs** (a transitive jar, e.g. a logging or XML library) from an
|
||||
SCA scan — triage upstream unless Struts' own code reaches the vulnerable path with
|
||||
untrusted input.
|
||||
|
||||
## §12 Conditions that would change this model
|
||||
|
||||
- A change to the default-hardening set (e.g. a new secure-by-default knob, or a
|
||||
default flipped) — re-baseline §5a/§8/§11a.
|
||||
- A new request-facing surface, a new bundled plugin, or a new expression/templating
|
||||
integration with its own trust surface.
|
||||
- A change to how OGNL evaluation, the allowlist, or parameter binding works.
|
||||
- A report that cannot be routed to a §13 disposition → revise §8/§9.
|
||||
- **A published bulletin whose vulnerability class is not already a §8 property** — the
|
||||
clearest signal that the model under-describes what the framework actually guarantees,
|
||||
and the strongest one, because the PMC has already decided the question by issuing the
|
||||
CVE. S2-070 … S2-074 triggered exactly this re-baseline (§16); the check belongs in
|
||||
the release routine, not in the next report's triage.
|
||||
|
||||
## §13 Triage dispositions
|
||||
|
||||
| Disposition | Meaning | Licensed by |
|
||||
| --- | --- | --- |
|
||||
| `VALID` | A §8 property breaks via an untrusted HTTP client on a current-version, default-hardened app. | §8, §6, §7 |
|
||||
| `VALID-HARDENING` | A §11 misuse is too easy, or a default could be tightened. | §11/§5a |
|
||||
| `OUT-OF-MODEL: application-responsibility` | Requires a developer anti-pattern (unsafe setter, raw EL, forced eval, direct JSP) or the app's own authn/authz. | §3/§10 |
|
||||
| `OUT-OF-MODEL: non-default-config` | Only manifests with `devMode`, a dev-only plugin, DMI, or a disabled default protection — i.e. a setting the project documents as *unsafe*. **Not** a feature the project documents as optional and an application has enabled (§2). | §5a, §2 |
|
||||
| `OUT-OF-MODEL: adversary-not-in-scope` | Requires container/host/JVM/developer control. | §7 |
|
||||
| `OUT-OF-MODEL: unsupported-version` | Only affects an end-of-life (2.x) version. | §5 |
|
||||
| `BY-DESIGN: property-disclaimed` | Concerns a property §9 disclaims (no built-in authn/authz/encoding; generic DoS; JSM on JDK21+). | §9 |
|
||||
| `KNOWN-NON-FINDING` | Matches §11a. | §11a |
|
||||
| `DUPLICATE` | Matches a disclosed S2-series bulletin/CVE. | §3 |
|
||||
| `MODEL-GAP` | Unroutable. | triggers §12 |
|
||||
|
||||
## §14 Open questions for the maintainers
|
||||
|
||||
**Answered since v0 — by the project's own published record (S2-070 … S2-074)**
|
||||
|
||||
These two are carried here rather than deleted: the PMC settled them by issuing CVEs,
|
||||
so what remains is ratifying the *wording*, not the substance.
|
||||
|
||||
- **Q-dos — answered.** The line is **boundedness, not curve shape**. Framework code
|
||||
that reads or retains request-derived input with no ceiling is in model even where the
|
||||
growth is linear — S2-072, S2-073, and S2-074 all carry CVEs on linear growth — while
|
||||
generic load whose cost stays proportionate is not. Folded into §3, §8.7, §9, and
|
||||
§11a; the matching clarification is now in [`SECURITY.md`](SECURITY.md) so the model
|
||||
is no longer paraphrasing that document into a rule it does not state.
|
||||
- **Q-plugins — answered.** Bundled plugins are in scope at the same request-trust
|
||||
level: S2-070, S2-071, and S2-072 are all JSON-plugin bulletins with CVEs. The
|
||||
follow-on distinction this exposed — optional *feature* versus documented-unsafe
|
||||
*configuration* — is now in §2 and §13, and is put to the PMC as Q-optional below.
|
||||
|
||||
**Wave 1 — scope, defaults, intended use**
|
||||
|
||||
- **Q-default.** Confirm the triage baseline is "current supported version (7.x/6.x)
|
||||
with the documented default hardening on, `devMode` off, dev-only plugins
|
||||
restricted" — and that a finding requiring a pre-7.0 default or a disabled hardening
|
||||
knob is `OUT-OF-MODEL: non-default-config`. (§5a/§13.)
|
||||
- **Q-scope.** Confirm the in-scope surface is the framework in `apache/struts`
|
||||
(core + interceptors + tags + bundled plugins), with the embedding application's own
|
||||
actions/JSPs/config, and examples/showcase, out of scope. (§2/§3.)
|
||||
- **Q-philosophy.** Confirm the framing that Struts provides **no security mechanism
|
||||
of its own** beyond OGNL/parameter-binding injection containment — i.e. authn,
|
||||
authz, session security, CSRF token storage, output encoding, and transport are the
|
||||
application's. (§9.)
|
||||
- **Q-env.** Confirm the servlet container, JVM, JDK, and OS are out of scope — Struts
|
||||
does not patch or harden them, and the operator maintains them. (§3/§5.)
|
||||
- **Q-egress.** Confirm Struts opens no sockets and makes no outbound connections of
|
||||
its own, so any network egress (and the SSRF surface it implies) is the
|
||||
application's. (§5/§7.)
|
||||
|
||||
**Wave 2 — mechanism confirmations**
|
||||
|
||||
- **Q-ognl.** Confirm the §8.1 list is the authoritative set of default OGNL-injection
|
||||
defences (allowlist, excluded classes/packages/patterns, expression length,
|
||||
static-field/proxy/default-package/custom-map disallows, excluded node types) and
|
||||
that a bypass of any on a default app is `VALID`. (§8.)
|
||||
- **Q-jsm.** Confirm the OGNL Java Security Manager sandbox is **not** a relied-upon
|
||||
control (opt-in, and non-functional on modern JDKs — see §5a), so a report premised
|
||||
on its absence is not a finding. (§5a/§9.)
|
||||
- **Q-concurrency.** Confirm §8.6 as a framework property: per-request state must not be
|
||||
shared between concurrently-served requests, and a violation is `VALID` on its own —
|
||||
including where the only demonstrated consequence is that another framework limit can
|
||||
be raced, with no data shown to cross. (§8.6, from S2-070/071.)
|
||||
- **Q-bounds.** Confirm the §8.7 scope: does it cover *all* framework-managed state
|
||||
keyed on request-derived values, or only the caches and body reads bounded in
|
||||
7.3.0/6.11.0? A triager needs to know whether an unbounded structure found elsewhere
|
||||
in the framework is `VALID` or `VALID-HARDENING`. (§8.7.)
|
||||
|
||||
**Wave 3 — surfaces & false-friends**
|
||||
|
||||
- **Q-optional.** Confirm the §2 rule that a documented-optional feature (JSON body
|
||||
population, `enableSMD`, a mapped CSP-report endpoint, any bundled plugin) is in model
|
||||
once an application enables it, and that `OUT-OF-MODEL: non-default-config` is
|
||||
reserved for settings the project documents as *unsafe*. (§2/§13.)
|
||||
- **Q-plugin-risk.** With Q-plugins answered, the residual: are any bundled plugins
|
||||
(e.g. REST/XML) historically higher-risk enough to warrant their own §8 note? (§2.)
|
||||
- **Q-upload.** Confirm the multipart/file-upload surface (Jakarta) and what the
|
||||
framework guarantees vs. leaves to the container/app. (§2/§6.)
|
||||
- **Q12.** Beyond the `SECURITY.md` "Before Reporting" list already folded into §11a,
|
||||
what do scanners/researchers most often report against Struts that you consider a
|
||||
non-finding? (Feeds §11a.)
|
||||
|
||||
## §15 Appendix — existing-policy back-map
|
||||
|
||||
This `THREAT_MODEL.md` is **additive** — it does not replace
|
||||
[`SECURITY.md`](SECURITY.md) (reporting process, supported versions, "Before
|
||||
Reporting" checks) or the published [security guidance](https://struts.apache.org/security/);
|
||||
both are preserved and remain canonical for the reporting workflow. The discoverability
|
||||
chain is `AGENTS.md` → `SECURITY.md` → this model. Mapping of existing-policy claims to
|
||||
sections:
|
||||
|
||||
| Existing-policy statement | Threat-model § |
|
||||
| --- | --- |
|
||||
| "Struts doesn't provide any security mechanism — pure web framework" | §1, §9, §13 (`BY-DESIGN`) |
|
||||
| OGNL is the central historical vuln class | §1, §7, §8.1 |
|
||||
| devMode / Config Browser Plugin are dev-only | §3, §5a, §11a |
|
||||
| `@StrutsParameter` / unsafe setters | §6, §8.2, §10, §11a |
|
||||
| Direct JSP access / raw `${}` EL / forced eval / localization | §3, §10, §11a |
|
||||
| Allowlist / excluded classes/packages / expression length (7.0 defaults) | §5a, §8.1 |
|
||||
| DMI / Strict Method Invocation | §5a, §8.3 |
|
||||
| FetchMetadata / COOP / COEP | §5a, §8.5 |
|
||||
| OGNL JSM sandbox (modern-JDK limitation) | §5a, §9 |
|
||||
| Generic DoS not accepted; non-linear-in-input philosophy | §3, §9 |
|
||||
| Unbounded reads/state are in scope even when linear | §3, §8.7, §11a |
|
||||
| Resource bounds (i18n cache size, CSP report size, locale validation) | §5a, §8.7 |
|
||||
| "Before Reporting" duplicate/known-config checks | §3, §11a, §13 (`DUPLICATE`) |
|
||||
| Supported versions (2.x EOL) | §5, §13 (`OUT-OF-MODEL: unsupported-version`) |
|
||||
|
||||
## §16 Appendix — recent-bulletin back-map (S2-070 … S2-074)
|
||||
|
||||
The five bulletins published on **2026-08-14** are the evidence base for the 2026-08-15
|
||||
revision, and the reason §8 grew two properties. Each is a published
|
||||
[Security Bulletin](https://cwiki.apache.org/confluence/display/WW/Security+Bulletins)
|
||||
on the Struts cwiki, all five published the same day. Ratings are the bulletins' own.
|
||||
|
||||
| Bulletin | Rating | What it establishes for the model | § |
|
||||
| --- | --- | --- | --- |
|
||||
| **S2-070** (CVE-2026-73631) — shared parsing state, JSON plugin | Moderate | Per-request parse state shared across concurrent requests: cross-request disclosure and integrity loss, **and bypass of a configured limit** — one defect voiding another control | §8.6, §7, §2 |
|
||||
| **S2-071** (CVE-2026-73632) — shared serialization state, JSON plugin | Low | The same on the response side; the `json` *result type* is unaffected because a writer is built per request — the negative control for §8.6 | §8.6, §2 |
|
||||
| **S2-072** (CVE-2026-73633) — unbounded read of a JSON request body | Moderate | Linear DoS with a CVE, and an advertised limit (JSON input length) that did **not** bound the read it appeared to govern | §8.7, §3, §11a |
|
||||
| **S2-073** (CVE-2026-73634) — unbounded read of a CSP violation report | Moderate | Core rather than a plugin; inert until an application maps the endpoint; ordinarily unauthenticated *by design*, since browsers post to it directly | §8.7, §2, §10 |
|
||||
| **S2-074** (CVE-2026-73635) — unbounded localized-text cache growth | Moderate | Affects the **default configuration** rather than an opt-in feature; a request-derived value used as a **cache key**, making unbounded *retention* a class of its own alongside unbounded reads | §8.7, §6, §5a, §11a |
|
||||
|
||||
Three of the five would have been closed as non-findings by the v0 draft — S2-072 and
|
||||
S2-073 under §11a's "I streamed a huge body," S2-074 under §3's super-linear-only rule —
|
||||
and the remaining two had no §8 property to violate. That is the honest summary of what
|
||||
this revision fixes, and the reason §12 now carries a bulletin-driven re-baseline
|
||||
trigger.
|
||||
+7
-2
@@ -24,8 +24,7 @@
|
||||
<parent>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-parent</artifactId>
|
||||
<version>7.4.0-SNAPSHOT</version>
|
||||
<relativePath>../parent/pom.xml</relativePath>
|
||||
<version>6.1.2.2</version>
|
||||
</parent>
|
||||
<artifactId>struts2-apps</artifactId>
|
||||
<packaging>pom</packaging>
|
||||
@@ -37,6 +36,9 @@
|
||||
|
||||
<properties>
|
||||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
|
||||
|
||||
<maven.site.skip>true</maven.site.skip>
|
||||
<maven.site.deploy.skip>true</maven.site.deploy.skip>
|
||||
</properties>
|
||||
|
||||
<build>
|
||||
@@ -91,10 +93,13 @@
|
||||
<dependency>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-core</artifactId>
|
||||
<version>${project.version}</version>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.springframework</groupId>
|
||||
<artifactId>spring-test</artifactId>
|
||||
<version>${spring.platformVersion}</version>
|
||||
<scope>test</scope>
|
||||
</dependency>
|
||||
</dependencies>
|
||||
|
||||
@@ -1,18 +0,0 @@
|
||||
# Rest Showcase
|
||||
|
||||
> **WARNING:** This application is a demonstration/development tool only. It is **NOT** intended for production
|
||||
> deployment. Deploying this application on a publicly accessible server may pose security risks.
|
||||
|
||||
Rest Showcase is a simple example of a REST app built with the REST plugin.
|
||||
|
||||
For more on getting started with Struts, see:
|
||||
|
||||
- https://struts.apache.org/getting-started/
|
||||
|
||||
## I18N
|
||||
|
||||
Please note that this project was created with the assumption that it will be run in an environment where the default
|
||||
locale is set to English. This means that the default messages defined in `package.properties` are in English.
|
||||
|
||||
If the default locale for your server is different, then rename `package.properties` to `package_en.properties` and
|
||||
create a new `package.properties` with proper values for your default locale.
|
||||
@@ -0,0 +1,15 @@
|
||||
README.txt - Rest Showcase Webapp
|
||||
|
||||
Rest Showcase is a simple example of REST app build with the REST plugin.
|
||||
|
||||
For more on getting started with Struts, see
|
||||
|
||||
* http://cwiki.apache.org/WW/home.html
|
||||
|
||||
I18N:
|
||||
=====
|
||||
Please note that this project was created with the assumption that it will be run
|
||||
in an environment where the default locale is set to English. This means that
|
||||
the default messages defined in package.properties are in English. If the default
|
||||
locale for your server is different, then rename package.properties to package_en.properties
|
||||
and create a new package.properties with proper values for your default locale.
|
||||
@@ -24,12 +24,12 @@
|
||||
<parent>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-apps</artifactId>
|
||||
<version>7.4.0-SNAPSHOT</version>
|
||||
<version>6.1.2.2</version>
|
||||
</parent>
|
||||
|
||||
<artifactId>struts2-rest-showcase</artifactId>
|
||||
<packaging>war</packaging>
|
||||
<version>7.4.0-SNAPSHOT</version>
|
||||
<version>6.1.2.2</version>
|
||||
<name>Struts 2 Rest Showcase Webapp</name>
|
||||
<description>Struts 2 Rest Showcase Example</description>
|
||||
|
||||
@@ -56,10 +56,12 @@
|
||||
<dependency>
|
||||
<groupId>org.apache.logging.log4j</groupId>
|
||||
<artifactId>log4j-api</artifactId>
|
||||
<version>${log4j2.version}</version>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.apache.logging.log4j</groupId>
|
||||
<artifactId>log4j-core</artifactId>
|
||||
<version>${log4j2.version}</version>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
@@ -76,8 +78,9 @@
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.htmlunit</groupId>
|
||||
<groupId>net.sourceforge.htmlunit</groupId>
|
||||
<artifactId>htmlunit</artifactId>
|
||||
<version>2.39.0</version>
|
||||
<scope>test</scope>
|
||||
</dependency>
|
||||
|
||||
@@ -99,14 +102,6 @@
|
||||
</exclusions>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.webjars</groupId>
|
||||
<artifactId>bootstrap</artifactId>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.webjars.npm</groupId>
|
||||
<artifactId>bootstrap-icons</artifactId>
|
||||
</dependency>
|
||||
</dependencies>
|
||||
|
||||
<build>
|
||||
@@ -115,7 +110,7 @@
|
||||
<plugin>
|
||||
<groupId>org.eclipse.jetty</groupId>
|
||||
<artifactId>jetty-maven-plugin</artifactId>
|
||||
<version>11.0.26</version>
|
||||
<version>9.4.46.v20220331</version>
|
||||
<configuration>
|
||||
<stopKey>CTRL+C</stopKey>
|
||||
<stopPort>8999</stopPort>
|
||||
|
||||
@@ -18,30 +18,30 @@
|
||||
*/
|
||||
package org.demo.rest.example;
|
||||
|
||||
import org.apache.struts2.ModelDriven;
|
||||
import org.apache.struts2.Validateable;
|
||||
import org.apache.struts2.ValidationAwareSupport;
|
||||
import java.util.Collection;
|
||||
|
||||
import org.apache.logging.log4j.LogManager;
|
||||
import org.apache.logging.log4j.Logger;
|
||||
import org.apache.struts2.convention.annotation.Result;
|
||||
import org.apache.struts2.convention.annotation.Results;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import org.apache.struts2.rest.DefaultHttpHeaders;
|
||||
import org.apache.struts2.rest.HttpHeaders;
|
||||
import org.apache.struts2.convention.annotation.Results;
|
||||
import org.apache.struts2.convention.annotation.Result;
|
||||
|
||||
import java.util.Collection;
|
||||
import com.opensymphony.xwork2.ModelDriven;
|
||||
import com.opensymphony.xwork2.Validateable;
|
||||
import com.opensymphony.xwork2.ValidationAwareSupport;
|
||||
|
||||
@Results({
|
||||
@Result(name="success", type="redirectAction", params = {"actionName" , "orders"})
|
||||
})
|
||||
public class OrdersController extends ValidationAwareSupport implements ModelDriven<Object>, Validateable {
|
||||
public class OrdersController extends ValidationAwareSupport implements ModelDriven<Object>, Validateable{
|
||||
|
||||
private static final Logger log = LogManager.getLogger(OrdersController.class);
|
||||
|
||||
private Order model = new Order();
|
||||
private String id;
|
||||
private Collection<Order> list;
|
||||
private final OrdersService ordersService = new OrdersService();
|
||||
private OrdersService ordersService = new OrdersService();
|
||||
|
||||
// GET /orders/1
|
||||
public HttpHeaders show() {
|
||||
@@ -54,7 +54,7 @@ public class OrdersController extends ValidationAwareSupport implements ModelDri
|
||||
return new DefaultHttpHeaders("index")
|
||||
.disableCaching();
|
||||
}
|
||||
|
||||
|
||||
// GET /orders/1/edit
|
||||
public String edit() {
|
||||
return "edit";
|
||||
@@ -101,15 +101,13 @@ public class OrdersController extends ValidationAwareSupport implements ModelDri
|
||||
}
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setId(String id) {
|
||||
if (id != null) {
|
||||
this.model = ordersService.get(id);
|
||||
}
|
||||
this.id = id;
|
||||
}
|
||||
|
||||
@Override
|
||||
|
||||
public Object getModel() {
|
||||
return (list != null ? list : model);
|
||||
}
|
||||
|
||||
@@ -18,14 +18,11 @@
|
||||
*/
|
||||
package org.demo.rest.example;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.HashMap;
|
||||
import java.util.List;
|
||||
import java.util.Map;
|
||||
import java.util.*;
|
||||
|
||||
public class OrdersService {
|
||||
|
||||
private static final Map<String,Order> orders = new HashMap<>();
|
||||
private static Map<String,Order> orders = new HashMap<String,Order>();
|
||||
private static int nextId = 6;
|
||||
static {
|
||||
orders.put("3", new Order("3", "Bob", 33));
|
||||
|
||||
@@ -26,6 +26,7 @@
|
||||
</Console>
|
||||
</Appenders>
|
||||
<Loggers>
|
||||
<Logger name="com.opensymphony.xwork2" level="info"/>
|
||||
<Logger name="org.apache.struts2" level="info"/>
|
||||
<Logger name="org.demo.rest" level="debug"/>
|
||||
<Root level="warn">
|
||||
|
||||
@@ -20,8 +20,8 @@
|
||||
*/
|
||||
-->
|
||||
<!DOCTYPE struts PUBLIC
|
||||
"-//Apache Software Foundation//DTD Struts Configuration 6.0//EN"
|
||||
"https://struts.apache.org/dtds/struts-6.0.dtd">
|
||||
"-//Apache Software Foundation//DTD Struts Configuration 2.5//EN"
|
||||
"https://struts.apache.org/dtds/struts-2.5.dtd">
|
||||
|
||||
|
||||
<struts>
|
||||
@@ -31,7 +31,6 @@
|
||||
<constant name="struts.convention.default.parent.package" value="rest-showcase"/>
|
||||
|
||||
<constant name="struts.convention.package.locators" value="example"/>
|
||||
<constant name="struts.webjars.allowlist" value="bootstrap,bootstrap-icons"/>
|
||||
|
||||
<!-- Uncomment the lines below to use Jackson XML bindings instead of the XStream library to handle XML serialisations -->
|
||||
<!--
|
||||
|
||||
@@ -29,8 +29,7 @@
|
||||
<title>Orders</title>
|
||||
<!-- Using a standard HTML link tag with JSP EL to get the contextPath may be simpler, but this is an equivalent for s:link -->
|
||||
<s:set var="pageContextPath"><%=((HttpServletRequest)request).getContextPath()%></s:set>
|
||||
<link rel="stylesheet" href="<s:webjar path='bootstrap/css/bootstrap.min.css'/>"/>
|
||||
<link rel="stylesheet" href="<s:webjar path='bootstrap-icons/font/bootstrap-icons.min.css'/>"/>
|
||||
<s:link href="%{#pageContextPath}/css/bootstrap.min.css" rel="stylesheet"></s:link>
|
||||
<s:link href="%{#pageContextPath}/css/app.css" rel="stylesheet"></s:link>
|
||||
|
||||
<!-- HTML5 Shim and Respond.js IE8 support of HTML5 elements and media queries -->
|
||||
@@ -45,7 +44,7 @@
|
||||
<div class="row">
|
||||
<div class="col-md-12">
|
||||
|
||||
<div class="border-bottom pb-2 mb-3">
|
||||
<div class="page-header">
|
||||
<h1>Delete Order ${id}</h1>
|
||||
</div>
|
||||
|
||||
@@ -60,7 +59,7 @@
|
||||
</form>
|
||||
<br />
|
||||
<a href="${pageContext.request.contextPath}/orders" class="btn btn-info">
|
||||
<i class="bi bi-arrow-left"></i> Back to Orders
|
||||
<span class="glyphicon glyphicon-arrow-left"></span> Back to Orders
|
||||
</a>
|
||||
</div><!--/col-md-12--->
|
||||
</div><!--/row-->
|
||||
|
||||
@@ -29,8 +29,7 @@
|
||||
<title>Orders</title>
|
||||
<!-- Using a standard HTML link tag with JSP EL to get the contextPath may be simpler, but this is an equivalent for s:link -->
|
||||
<s:set var="pageContextPath"><%=((HttpServletRequest)request).getContextPath()%></s:set>
|
||||
<link rel="stylesheet" href="<s:webjar path='bootstrap/css/bootstrap.min.css'/>"/>
|
||||
<link rel="stylesheet" href="<s:webjar path='bootstrap-icons/font/bootstrap-icons.min.css'/>"/>
|
||||
<s:link href="%{#pageContextPath}/css/bootstrap.min.css" rel="stylesheet"></s:link>
|
||||
<s:link href="%{#pageContextPath}/css/app.css" rel="stylesheet"></s:link>
|
||||
|
||||
<!-- HTML5 Shim and Respond.js IE8 support of HTML5 elements and media queries -->
|
||||
@@ -45,22 +44,22 @@
|
||||
<div class="row">
|
||||
<div class="col-md-12">
|
||||
|
||||
<div class="border-bottom pb-2 mb-3">
|
||||
<div class="page-header">
|
||||
<h1>Order <s:property value="id" /></h1>
|
||||
</div>
|
||||
|
||||
<s:actionmessage cssClass="alert alert-danger"/>
|
||||
|
||||
<s:form method="post" action="%{#request.contextPath}/orders/%{id}" theme="simple">
|
||||
<s:form method="post" action="%{#request.contextPath}/orders/%{id}" cssClass="form-horizontal" theme="simple">
|
||||
<s:hidden name="_method" value="put" />
|
||||
<div class="row mb-3">
|
||||
<label class="col-sm-2 col-form-label" for="id">ID</label>
|
||||
<div class="form-group">
|
||||
<label class="col-sm-2 control-label" for="id">ID</label>
|
||||
<div class="col-sm-4">
|
||||
<s:textfield id="id" name="id" disabled="true" cssClass="form-control"/>
|
||||
</div>
|
||||
</div>
|
||||
<div class="row mb-3">
|
||||
<label class="col-sm-2 col-form-label" for="clientName">Client</label>
|
||||
<div class="form-group">
|
||||
<label class="col-sm-2 control-label" for="clientName">Client</label>
|
||||
<div class="col-sm-4">
|
||||
<s:textfield id="clientName" name="clientName" cssClass="form-control"/>
|
||||
</div>
|
||||
@@ -68,8 +67,8 @@
|
||||
<s:fielderror fieldName="clientName" />
|
||||
</div>
|
||||
</div>
|
||||
<div class="row mb-3">
|
||||
<label class="col-sm-2 col-form-label" for="amount">Amount</label>
|
||||
<div class="form-group">
|
||||
<label class="col-sm-2 control-label" for="amount">Amount</label>
|
||||
<div class="col-sm-4">
|
||||
<s:textfield id="amount" name="amount" cssClass="form-control" />
|
||||
</div>
|
||||
@@ -77,14 +76,15 @@
|
||||
<s:fielderror fieldName="amount" />
|
||||
</div>
|
||||
</div>
|
||||
<div class="row mb-3">
|
||||
<div class="offset-sm-2 col-sm-4">
|
||||
<div class="form-group">
|
||||
<div class="col-sm-offset-2 col-sm-4">
|
||||
<s:submit cssClass="btn btn-primary"/>
|
||||
</div>
|
||||
</div>
|
||||
<table>
|
||||
</s:form>
|
||||
<a href="${pageContext.request.contextPath}/orders" class="btn btn-info">
|
||||
<i class="bi bi-arrow-left"></i> Back to Orders
|
||||
<span class="glyphicon glyphicon-arrow-left"></span> Back to Orders
|
||||
</a>
|
||||
</div><!--/col-md-12--->
|
||||
</div><!--/row-->
|
||||
|
||||
@@ -29,8 +29,7 @@
|
||||
<title>Orders</title>
|
||||
<!-- Using a standard HTML link tag with JSP EL to get the contextPath may be simpler, but this is an equivalent for s:link -->
|
||||
<s:set var="pageContextPath"><%=((HttpServletRequest)request).getContextPath()%></s:set>
|
||||
<link rel="stylesheet" href="<s:webjar path='bootstrap/css/bootstrap.min.css'/>"/>
|
||||
<link rel="stylesheet" href="<s:webjar path='bootstrap-icons/font/bootstrap-icons.min.css'/>"/>
|
||||
<s:link href="%{#pageContextPath}/css/bootstrap.min.css" rel="stylesheet"></s:link>
|
||||
<s:link href="%{#pageContextPath}/css/app.css" rel="stylesheet"></s:link>
|
||||
|
||||
<!-- HTML5 Shim and Respond.js IE8 support of HTML5 elements and media queries -->
|
||||
@@ -45,15 +44,15 @@
|
||||
<div class="row">
|
||||
<div class="col-md-12">
|
||||
|
||||
<div class="border-bottom pb-2 mb-3">
|
||||
<div class="page-header">
|
||||
<h1>New Order</h1>
|
||||
</div>
|
||||
|
||||
<s:actionmessage cssClass="alert alert-danger"/>
|
||||
|
||||
<s:form method="post" action="%{#request.contextPath}/orders" theme="simple">
|
||||
<div class="row mb-3">
|
||||
<label class="col-sm-2 col-form-label" for="clientName">Client</label>
|
||||
<s:form method="post" action="%{#request.contextPath}/orders" cssClass="form-horizontal" theme="simple">
|
||||
<div class="form-group">
|
||||
<label class="col-sm-2 control-label" for="clientName">Client</label>
|
||||
<div class="col-sm-4">
|
||||
<s:textfield id="clientName" name="clientName" cssClass="form-control"/>
|
||||
</div>
|
||||
@@ -61,8 +60,8 @@
|
||||
<s:fielderror fieldName="clientName" />
|
||||
</div>
|
||||
</div>
|
||||
<div class="row mb-3">
|
||||
<label class="col-sm-2 col-form-label" for="amount">Amount</label>
|
||||
<div class="form-group">
|
||||
<label class="col-sm-2 control-label" for="amount">Amount</label>
|
||||
<div class="col-sm-4">
|
||||
<s:textfield id="amount" name="amount" cssClass="form-control"/>
|
||||
</div>
|
||||
@@ -70,14 +69,14 @@
|
||||
<s:fielderror fieldName="amount" />
|
||||
</div>
|
||||
</div>
|
||||
<div class="row mb-3">
|
||||
<div class="offset-sm-2 col-sm-4">
|
||||
<div class="form-group">
|
||||
<div class="col-sm-offset-2 col-sm-4">
|
||||
<s:submit cssClass="btn btn-primary"/>
|
||||
</div>
|
||||
</div>
|
||||
</s:form>
|
||||
<a href="${pageContext.request.contextPath}/orders" class="btn btn-info">
|
||||
<i class="bi bi-arrow-left"></i> Back to Orders
|
||||
<span class="glyphicon glyphicon-arrow-left"></apan> Back to Orders
|
||||
</a>
|
||||
</div><!--/col-md-12--->
|
||||
</div><!--/row-->
|
||||
|
||||
@@ -29,8 +29,7 @@
|
||||
<title>Orders</title>
|
||||
<!-- Using a standard HTML link tag with JSP EL to get the contextPath may be simpler, but this is an equivalent for s:link -->
|
||||
<s:set var="pageContextPath"><%=((HttpServletRequest)request).getContextPath()%></s:set>
|
||||
<link rel="stylesheet" href="<s:webjar path='bootstrap/css/bootstrap.min.css'/>"/>
|
||||
<link rel="stylesheet" href="<s:webjar path='bootstrap-icons/font/bootstrap-icons.min.css'/>"/>
|
||||
<s:link href="%{#pageContextPath}/css/bootstrap.min.css" rel="stylesheet"></s:link>
|
||||
<s:link href="%{#pageContextPath}/css/app.css" rel="stylesheet"></s:link>
|
||||
|
||||
<!-- HTML5 Shim and Respond.js IE8 support of HTML5 elements and media queries -->
|
||||
@@ -45,7 +44,7 @@
|
||||
<div class="row">
|
||||
<div class="col-md-12">
|
||||
|
||||
<div class="border-bottom pb-2 mb-3">
|
||||
<div class="page-header">
|
||||
<h1>Orders</h1>
|
||||
</div>
|
||||
<s:actionmessage cssClass="alert alert-danger"/>
|
||||
@@ -63,15 +62,15 @@
|
||||
<td><s:property value="amount"/></td>
|
||||
<td>
|
||||
<div class="btn-group">
|
||||
<a href="orders/${id}" class="btn btn-secondary"><i class="bi bi-eye"></i> View</a>
|
||||
<a href="orders/${id}/edit" class="btn btn-secondary"><i class="bi bi-pencil"></i> Edit</a>
|
||||
<a href="orders/${id}/deleteConfirm" class="btn btn-danger"><i class="bi bi-trash"></i> Delete</a>
|
||||
<a href="orders/${id}" class="btn btn-default"><span class="glyphicon glyphicon-eye-open"></span> View</a>
|
||||
<a href="orders/${id}/edit" class="btn btn-default"><span class="glyphicon glyphicon-edit"></span> Edit</a>
|
||||
<a href="orders/${id}/deleteConfirm" class="btn btn-danger"><span class="glyphicon glyphicon-trash"></span> Delete</a>
|
||||
</div>
|
||||
</td>
|
||||
</tr>
|
||||
</s:iterator>
|
||||
</table>
|
||||
<a href="orders/new" class="btn btn-primary"><i class="bi bi-file-earmark"></i> Create a new order</a>
|
||||
<a href="orders/new" class="btn btn-primary"><span class="glyphicon glyphicon-file"></span> Create a new order</a>
|
||||
</div><!--/col-md-12--->
|
||||
</div><!--/row-->
|
||||
</div><!--/container-->
|
||||
|
||||
@@ -29,8 +29,7 @@
|
||||
<title>Orders</title>
|
||||
<!-- Using a standard HTML link tag with JSP EL to get the contextPath may be simpler, but this is an equivalent for s:link -->
|
||||
<s:set var="pageContextPath"><%=((HttpServletRequest)request).getContextPath()%></s:set>
|
||||
<link rel="stylesheet" href="<s:webjar path='bootstrap/css/bootstrap.min.css'/>"/>
|
||||
<link rel="stylesheet" href="<s:webjar path='bootstrap-icons/font/bootstrap-icons.min.css'/>"/>
|
||||
<s:link href="%{#pageContextPath}/css/bootstrap.min.css" rel="stylesheet"></s:link>
|
||||
<s:link href="%{#pageContextPath}/css/app.css" rel="stylesheet"></s:link>
|
||||
|
||||
<!-- HTML5 Shim and Respond.js IE8 support of HTML5 elements and media queries -->
|
||||
@@ -44,25 +43,25 @@
|
||||
<div class="container-fluid">
|
||||
<div class="row">
|
||||
<div class="col-md-12">
|
||||
<div class="border-bottom pb-2 mb-3">
|
||||
<div class="page-header">
|
||||
<h1>Order ${id}</h1>
|
||||
</div>
|
||||
<table class="table table-striped">
|
||||
<tr>
|
||||
<td class="col-3">ID</td>
|
||||
<td class="col-9"><s:property value="id"/></td>
|
||||
<td class="span3">ID</td>
|
||||
<td class="span9"><s:property value="id"/></td>
|
||||
</tr>
|
||||
<tr>
|
||||
<td class="col-3">Client</td>
|
||||
<td class="col-9"><s:property value="clientName"/></td>
|
||||
<td class="span3">Client</td>
|
||||
<td class="span9"><s:property value="clientName"/></td>
|
||||
</tr>
|
||||
<tr>
|
||||
<td class="col-3">Amount</td>
|
||||
<td class="col-9"><s:property value="amount"/></td>
|
||||
<td class="span3">Amount</td>
|
||||
<td class="span9"><s:property value="amount"/></td>
|
||||
</tr>
|
||||
</table>
|
||||
<a href="${pageContext.request.contextPath}/orders" class="btn btn-info">
|
||||
<i class="bi bi-arrow-left"></i> Back to Orders
|
||||
<span class="glyphicon glyphicon-arrow-left"></span> Back to Orders
|
||||
</a>
|
||||
</div><!--/col-md-12--->
|
||||
</div><!--/row-->
|
||||
|
||||
@@ -0,0 +1,476 @@
|
||||
/*!
|
||||
* Bootstrap v3.3.4 (http://getbootstrap.com)
|
||||
* Copyright 2011-2015 Twitter, Inc.
|
||||
* Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
|
||||
*/
|
||||
|
||||
.btn-default,
|
||||
.btn-primary,
|
||||
.btn-success,
|
||||
.btn-info,
|
||||
.btn-warning,
|
||||
.btn-danger {
|
||||
text-shadow: 0 -1px 0 rgba(0, 0, 0, .2);
|
||||
-webkit-box-shadow: inset 0 1px 0 rgba(255, 255, 255, .15), 0 1px 1px rgba(0, 0, 0, .075);
|
||||
box-shadow: inset 0 1px 0 rgba(255, 255, 255, .15), 0 1px 1px rgba(0, 0, 0, .075);
|
||||
}
|
||||
.btn-default:active,
|
||||
.btn-primary:active,
|
||||
.btn-success:active,
|
||||
.btn-info:active,
|
||||
.btn-warning:active,
|
||||
.btn-danger:active,
|
||||
.btn-default.active,
|
||||
.btn-primary.active,
|
||||
.btn-success.active,
|
||||
.btn-info.active,
|
||||
.btn-warning.active,
|
||||
.btn-danger.active {
|
||||
-webkit-box-shadow: inset 0 3px 5px rgba(0, 0, 0, .125);
|
||||
box-shadow: inset 0 3px 5px rgba(0, 0, 0, .125);
|
||||
}
|
||||
.btn-default .badge,
|
||||
.btn-primary .badge,
|
||||
.btn-success .badge,
|
||||
.btn-info .badge,
|
||||
.btn-warning .badge,
|
||||
.btn-danger .badge {
|
||||
text-shadow: none;
|
||||
}
|
||||
.btn:active,
|
||||
.btn.active {
|
||||
background-image: none;
|
||||
}
|
||||
.btn-default {
|
||||
text-shadow: 0 1px 0 #fff;
|
||||
background-image: -webkit-linear-gradient(top, #fff 0%, #e0e0e0 100%);
|
||||
background-image: -o-linear-gradient(top, #fff 0%, #e0e0e0 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#fff), to(#e0e0e0));
|
||||
background-image: linear-gradient(to bottom, #fff 0%, #e0e0e0 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ffffffff', endColorstr='#ffe0e0e0', GradientType=0);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);
|
||||
background-repeat: repeat-x;
|
||||
border-color: #dbdbdb;
|
||||
border-color: #ccc;
|
||||
}
|
||||
.btn-default:hover,
|
||||
.btn-default:focus {
|
||||
background-color: #e0e0e0;
|
||||
background-position: 0 -15px;
|
||||
}
|
||||
.btn-default:active,
|
||||
.btn-default.active {
|
||||
background-color: #e0e0e0;
|
||||
border-color: #dbdbdb;
|
||||
}
|
||||
.btn-default.disabled,
|
||||
.btn-default:disabled,
|
||||
.btn-default[disabled] {
|
||||
background-color: #e0e0e0;
|
||||
background-image: none;
|
||||
}
|
||||
.btn-primary {
|
||||
background-image: -webkit-linear-gradient(top, #337ab7 0%, #265a88 100%);
|
||||
background-image: -o-linear-gradient(top, #337ab7 0%, #265a88 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#337ab7), to(#265a88));
|
||||
background-image: linear-gradient(to bottom, #337ab7 0%, #265a88 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff337ab7', endColorstr='#ff265a88', GradientType=0);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);
|
||||
background-repeat: repeat-x;
|
||||
border-color: #245580;
|
||||
}
|
||||
.btn-primary:hover,
|
||||
.btn-primary:focus {
|
||||
background-color: #265a88;
|
||||
background-position: 0 -15px;
|
||||
}
|
||||
.btn-primary:active,
|
||||
.btn-primary.active {
|
||||
background-color: #265a88;
|
||||
border-color: #245580;
|
||||
}
|
||||
.btn-primary.disabled,
|
||||
.btn-primary:disabled,
|
||||
.btn-primary[disabled] {
|
||||
background-color: #265a88;
|
||||
background-image: none;
|
||||
}
|
||||
.btn-success {
|
||||
background-image: -webkit-linear-gradient(top, #5cb85c 0%, #419641 100%);
|
||||
background-image: -o-linear-gradient(top, #5cb85c 0%, #419641 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#5cb85c), to(#419641));
|
||||
background-image: linear-gradient(to bottom, #5cb85c 0%, #419641 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff5cb85c', endColorstr='#ff419641', GradientType=0);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);
|
||||
background-repeat: repeat-x;
|
||||
border-color: #3e8f3e;
|
||||
}
|
||||
.btn-success:hover,
|
||||
.btn-success:focus {
|
||||
background-color: #419641;
|
||||
background-position: 0 -15px;
|
||||
}
|
||||
.btn-success:active,
|
||||
.btn-success.active {
|
||||
background-color: #419641;
|
||||
border-color: #3e8f3e;
|
||||
}
|
||||
.btn-success.disabled,
|
||||
.btn-success:disabled,
|
||||
.btn-success[disabled] {
|
||||
background-color: #419641;
|
||||
background-image: none;
|
||||
}
|
||||
.btn-info {
|
||||
background-image: -webkit-linear-gradient(top, #5bc0de 0%, #2aabd2 100%);
|
||||
background-image: -o-linear-gradient(top, #5bc0de 0%, #2aabd2 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#5bc0de), to(#2aabd2));
|
||||
background-image: linear-gradient(to bottom, #5bc0de 0%, #2aabd2 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff5bc0de', endColorstr='#ff2aabd2', GradientType=0);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);
|
||||
background-repeat: repeat-x;
|
||||
border-color: #28a4c9;
|
||||
}
|
||||
.btn-info:hover,
|
||||
.btn-info:focus {
|
||||
background-color: #2aabd2;
|
||||
background-position: 0 -15px;
|
||||
}
|
||||
.btn-info:active,
|
||||
.btn-info.active {
|
||||
background-color: #2aabd2;
|
||||
border-color: #28a4c9;
|
||||
}
|
||||
.btn-info.disabled,
|
||||
.btn-info:disabled,
|
||||
.btn-info[disabled] {
|
||||
background-color: #2aabd2;
|
||||
background-image: none;
|
||||
}
|
||||
.btn-warning {
|
||||
background-image: -webkit-linear-gradient(top, #f0ad4e 0%, #eb9316 100%);
|
||||
background-image: -o-linear-gradient(top, #f0ad4e 0%, #eb9316 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#f0ad4e), to(#eb9316));
|
||||
background-image: linear-gradient(to bottom, #f0ad4e 0%, #eb9316 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#fff0ad4e', endColorstr='#ffeb9316', GradientType=0);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);
|
||||
background-repeat: repeat-x;
|
||||
border-color: #e38d13;
|
||||
}
|
||||
.btn-warning:hover,
|
||||
.btn-warning:focus {
|
||||
background-color: #eb9316;
|
||||
background-position: 0 -15px;
|
||||
}
|
||||
.btn-warning:active,
|
||||
.btn-warning.active {
|
||||
background-color: #eb9316;
|
||||
border-color: #e38d13;
|
||||
}
|
||||
.btn-warning.disabled,
|
||||
.btn-warning:disabled,
|
||||
.btn-warning[disabled] {
|
||||
background-color: #eb9316;
|
||||
background-image: none;
|
||||
}
|
||||
.btn-danger {
|
||||
background-image: -webkit-linear-gradient(top, #d9534f 0%, #c12e2a 100%);
|
||||
background-image: -o-linear-gradient(top, #d9534f 0%, #c12e2a 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#d9534f), to(#c12e2a));
|
||||
background-image: linear-gradient(to bottom, #d9534f 0%, #c12e2a 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ffd9534f', endColorstr='#ffc12e2a', GradientType=0);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);
|
||||
background-repeat: repeat-x;
|
||||
border-color: #b92c28;
|
||||
}
|
||||
.btn-danger:hover,
|
||||
.btn-danger:focus {
|
||||
background-color: #c12e2a;
|
||||
background-position: 0 -15px;
|
||||
}
|
||||
.btn-danger:active,
|
||||
.btn-danger.active {
|
||||
background-color: #c12e2a;
|
||||
border-color: #b92c28;
|
||||
}
|
||||
.btn-danger.disabled,
|
||||
.btn-danger:disabled,
|
||||
.btn-danger[disabled] {
|
||||
background-color: #c12e2a;
|
||||
background-image: none;
|
||||
}
|
||||
.thumbnail,
|
||||
.img-thumbnail {
|
||||
-webkit-box-shadow: 0 1px 2px rgba(0, 0, 0, .075);
|
||||
box-shadow: 0 1px 2px rgba(0, 0, 0, .075);
|
||||
}
|
||||
.dropdown-menu > li > a:hover,
|
||||
.dropdown-menu > li > a:focus {
|
||||
background-color: #e8e8e8;
|
||||
background-image: -webkit-linear-gradient(top, #f5f5f5 0%, #e8e8e8 100%);
|
||||
background-image: -o-linear-gradient(top, #f5f5f5 0%, #e8e8e8 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#f5f5f5), to(#e8e8e8));
|
||||
background-image: linear-gradient(to bottom, #f5f5f5 0%, #e8e8e8 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#fff5f5f5', endColorstr='#ffe8e8e8', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.dropdown-menu > .active > a,
|
||||
.dropdown-menu > .active > a:hover,
|
||||
.dropdown-menu > .active > a:focus {
|
||||
background-color: #2e6da4;
|
||||
background-image: -webkit-linear-gradient(top, #337ab7 0%, #2e6da4 100%);
|
||||
background-image: -o-linear-gradient(top, #337ab7 0%, #2e6da4 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#337ab7), to(#2e6da4));
|
||||
background-image: linear-gradient(to bottom, #337ab7 0%, #2e6da4 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff337ab7', endColorstr='#ff2e6da4', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.navbar-default {
|
||||
background-image: -webkit-linear-gradient(top, #fff 0%, #f8f8f8 100%);
|
||||
background-image: -o-linear-gradient(top, #fff 0%, #f8f8f8 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#fff), to(#f8f8f8));
|
||||
background-image: linear-gradient(to bottom, #fff 0%, #f8f8f8 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ffffffff', endColorstr='#fff8f8f8', GradientType=0);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);
|
||||
background-repeat: repeat-x;
|
||||
border-radius: 4px;
|
||||
-webkit-box-shadow: inset 0 1px 0 rgba(255, 255, 255, .15), 0 1px 5px rgba(0, 0, 0, .075);
|
||||
box-shadow: inset 0 1px 0 rgba(255, 255, 255, .15), 0 1px 5px rgba(0, 0, 0, .075);
|
||||
}
|
||||
.navbar-default .navbar-nav > .open > a,
|
||||
.navbar-default .navbar-nav > .active > a {
|
||||
background-image: -webkit-linear-gradient(top, #dbdbdb 0%, #e2e2e2 100%);
|
||||
background-image: -o-linear-gradient(top, #dbdbdb 0%, #e2e2e2 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#dbdbdb), to(#e2e2e2));
|
||||
background-image: linear-gradient(to bottom, #dbdbdb 0%, #e2e2e2 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ffdbdbdb', endColorstr='#ffe2e2e2', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
-webkit-box-shadow: inset 0 3px 9px rgba(0, 0, 0, .075);
|
||||
box-shadow: inset 0 3px 9px rgba(0, 0, 0, .075);
|
||||
}
|
||||
.navbar-brand,
|
||||
.navbar-nav > li > a {
|
||||
text-shadow: 0 1px 0 rgba(255, 255, 255, .25);
|
||||
}
|
||||
.navbar-inverse {
|
||||
background-image: -webkit-linear-gradient(top, #3c3c3c 0%, #222 100%);
|
||||
background-image: -o-linear-gradient(top, #3c3c3c 0%, #222 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#3c3c3c), to(#222));
|
||||
background-image: linear-gradient(to bottom, #3c3c3c 0%, #222 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff3c3c3c', endColorstr='#ff222222', GradientType=0);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.navbar-inverse .navbar-nav > .open > a,
|
||||
.navbar-inverse .navbar-nav > .active > a {
|
||||
background-image: -webkit-linear-gradient(top, #080808 0%, #0f0f0f 100%);
|
||||
background-image: -o-linear-gradient(top, #080808 0%, #0f0f0f 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#080808), to(#0f0f0f));
|
||||
background-image: linear-gradient(to bottom, #080808 0%, #0f0f0f 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff080808', endColorstr='#ff0f0f0f', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
-webkit-box-shadow: inset 0 3px 9px rgba(0, 0, 0, .25);
|
||||
box-shadow: inset 0 3px 9px rgba(0, 0, 0, .25);
|
||||
}
|
||||
.navbar-inverse .navbar-brand,
|
||||
.navbar-inverse .navbar-nav > li > a {
|
||||
text-shadow: 0 -1px 0 rgba(0, 0, 0, .25);
|
||||
}
|
||||
.navbar-static-top,
|
||||
.navbar-fixed-top,
|
||||
.navbar-fixed-bottom {
|
||||
border-radius: 0;
|
||||
}
|
||||
@media (max-width: 767px) {
|
||||
.navbar .navbar-nav .open .dropdown-menu > .active > a,
|
||||
.navbar .navbar-nav .open .dropdown-menu > .active > a:hover,
|
||||
.navbar .navbar-nav .open .dropdown-menu > .active > a:focus {
|
||||
color: #fff;
|
||||
background-image: -webkit-linear-gradient(top, #337ab7 0%, #2e6da4 100%);
|
||||
background-image: -o-linear-gradient(top, #337ab7 0%, #2e6da4 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#337ab7), to(#2e6da4));
|
||||
background-image: linear-gradient(to bottom, #337ab7 0%, #2e6da4 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff337ab7', endColorstr='#ff2e6da4', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
}
|
||||
.alert {
|
||||
text-shadow: 0 1px 0 rgba(255, 255, 255, .2);
|
||||
-webkit-box-shadow: inset 0 1px 0 rgba(255, 255, 255, .25), 0 1px 2px rgba(0, 0, 0, .05);
|
||||
box-shadow: inset 0 1px 0 rgba(255, 255, 255, .25), 0 1px 2px rgba(0, 0, 0, .05);
|
||||
}
|
||||
.alert-success {
|
||||
background-image: -webkit-linear-gradient(top, #dff0d8 0%, #c8e5bc 100%);
|
||||
background-image: -o-linear-gradient(top, #dff0d8 0%, #c8e5bc 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#dff0d8), to(#c8e5bc));
|
||||
background-image: linear-gradient(to bottom, #dff0d8 0%, #c8e5bc 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ffdff0d8', endColorstr='#ffc8e5bc', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
border-color: #b2dba1;
|
||||
}
|
||||
.alert-info {
|
||||
background-image: -webkit-linear-gradient(top, #d9edf7 0%, #b9def0 100%);
|
||||
background-image: -o-linear-gradient(top, #d9edf7 0%, #b9def0 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#d9edf7), to(#b9def0));
|
||||
background-image: linear-gradient(to bottom, #d9edf7 0%, #b9def0 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ffd9edf7', endColorstr='#ffb9def0', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
border-color: #9acfea;
|
||||
}
|
||||
.alert-warning {
|
||||
background-image: -webkit-linear-gradient(top, #fcf8e3 0%, #f8efc0 100%);
|
||||
background-image: -o-linear-gradient(top, #fcf8e3 0%, #f8efc0 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#fcf8e3), to(#f8efc0));
|
||||
background-image: linear-gradient(to bottom, #fcf8e3 0%, #f8efc0 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#fffcf8e3', endColorstr='#fff8efc0', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
border-color: #f5e79e;
|
||||
}
|
||||
.alert-danger {
|
||||
background-image: -webkit-linear-gradient(top, #f2dede 0%, #e7c3c3 100%);
|
||||
background-image: -o-linear-gradient(top, #f2dede 0%, #e7c3c3 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#f2dede), to(#e7c3c3));
|
||||
background-image: linear-gradient(to bottom, #f2dede 0%, #e7c3c3 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#fff2dede', endColorstr='#ffe7c3c3', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
border-color: #dca7a7;
|
||||
}
|
||||
.progress {
|
||||
background-image: -webkit-linear-gradient(top, #ebebeb 0%, #f5f5f5 100%);
|
||||
background-image: -o-linear-gradient(top, #ebebeb 0%, #f5f5f5 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#ebebeb), to(#f5f5f5));
|
||||
background-image: linear-gradient(to bottom, #ebebeb 0%, #f5f5f5 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ffebebeb', endColorstr='#fff5f5f5', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.progress-bar {
|
||||
background-image: -webkit-linear-gradient(top, #337ab7 0%, #286090 100%);
|
||||
background-image: -o-linear-gradient(top, #337ab7 0%, #286090 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#337ab7), to(#286090));
|
||||
background-image: linear-gradient(to bottom, #337ab7 0%, #286090 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff337ab7', endColorstr='#ff286090', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.progress-bar-success {
|
||||
background-image: -webkit-linear-gradient(top, #5cb85c 0%, #449d44 100%);
|
||||
background-image: -o-linear-gradient(top, #5cb85c 0%, #449d44 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#5cb85c), to(#449d44));
|
||||
background-image: linear-gradient(to bottom, #5cb85c 0%, #449d44 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff5cb85c', endColorstr='#ff449d44', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.progress-bar-info {
|
||||
background-image: -webkit-linear-gradient(top, #5bc0de 0%, #31b0d5 100%);
|
||||
background-image: -o-linear-gradient(top, #5bc0de 0%, #31b0d5 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#5bc0de), to(#31b0d5));
|
||||
background-image: linear-gradient(to bottom, #5bc0de 0%, #31b0d5 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff5bc0de', endColorstr='#ff31b0d5', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.progress-bar-warning {
|
||||
background-image: -webkit-linear-gradient(top, #f0ad4e 0%, #ec971f 100%);
|
||||
background-image: -o-linear-gradient(top, #f0ad4e 0%, #ec971f 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#f0ad4e), to(#ec971f));
|
||||
background-image: linear-gradient(to bottom, #f0ad4e 0%, #ec971f 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#fff0ad4e', endColorstr='#ffec971f', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.progress-bar-danger {
|
||||
background-image: -webkit-linear-gradient(top, #d9534f 0%, #c9302c 100%);
|
||||
background-image: -o-linear-gradient(top, #d9534f 0%, #c9302c 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#d9534f), to(#c9302c));
|
||||
background-image: linear-gradient(to bottom, #d9534f 0%, #c9302c 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ffd9534f', endColorstr='#ffc9302c', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.progress-bar-striped {
|
||||
background-image: -webkit-linear-gradient(45deg, rgba(255, 255, 255, .15) 25%, transparent 25%, transparent 50%, rgba(255, 255, 255, .15) 50%, rgba(255, 255, 255, .15) 75%, transparent 75%, transparent);
|
||||
background-image: -o-linear-gradient(45deg, rgba(255, 255, 255, .15) 25%, transparent 25%, transparent 50%, rgba(255, 255, 255, .15) 50%, rgba(255, 255, 255, .15) 75%, transparent 75%, transparent);
|
||||
background-image: linear-gradient(45deg, rgba(255, 255, 255, .15) 25%, transparent 25%, transparent 50%, rgba(255, 255, 255, .15) 50%, rgba(255, 255, 255, .15) 75%, transparent 75%, transparent);
|
||||
}
|
||||
.list-group {
|
||||
border-radius: 4px;
|
||||
-webkit-box-shadow: 0 1px 2px rgba(0, 0, 0, .075);
|
||||
box-shadow: 0 1px 2px rgba(0, 0, 0, .075);
|
||||
}
|
||||
.list-group-item.active,
|
||||
.list-group-item.active:hover,
|
||||
.list-group-item.active:focus {
|
||||
text-shadow: 0 -1px 0 #286090;
|
||||
background-image: -webkit-linear-gradient(top, #337ab7 0%, #2b669a 100%);
|
||||
background-image: -o-linear-gradient(top, #337ab7 0%, #2b669a 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#337ab7), to(#2b669a));
|
||||
background-image: linear-gradient(to bottom, #337ab7 0%, #2b669a 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff337ab7', endColorstr='#ff2b669a', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
border-color: #2b669a;
|
||||
}
|
||||
.list-group-item.active .badge,
|
||||
.list-group-item.active:hover .badge,
|
||||
.list-group-item.active:focus .badge {
|
||||
text-shadow: none;
|
||||
}
|
||||
.panel {
|
||||
-webkit-box-shadow: 0 1px 2px rgba(0, 0, 0, .05);
|
||||
box-shadow: 0 1px 2px rgba(0, 0, 0, .05);
|
||||
}
|
||||
.panel-default > .panel-heading {
|
||||
background-image: -webkit-linear-gradient(top, #f5f5f5 0%, #e8e8e8 100%);
|
||||
background-image: -o-linear-gradient(top, #f5f5f5 0%, #e8e8e8 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#f5f5f5), to(#e8e8e8));
|
||||
background-image: linear-gradient(to bottom, #f5f5f5 0%, #e8e8e8 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#fff5f5f5', endColorstr='#ffe8e8e8', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.panel-primary > .panel-heading {
|
||||
background-image: -webkit-linear-gradient(top, #337ab7 0%, #2e6da4 100%);
|
||||
background-image: -o-linear-gradient(top, #337ab7 0%, #2e6da4 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#337ab7), to(#2e6da4));
|
||||
background-image: linear-gradient(to bottom, #337ab7 0%, #2e6da4 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff337ab7', endColorstr='#ff2e6da4', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.panel-success > .panel-heading {
|
||||
background-image: -webkit-linear-gradient(top, #dff0d8 0%, #d0e9c6 100%);
|
||||
background-image: -o-linear-gradient(top, #dff0d8 0%, #d0e9c6 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#dff0d8), to(#d0e9c6));
|
||||
background-image: linear-gradient(to bottom, #dff0d8 0%, #d0e9c6 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ffdff0d8', endColorstr='#ffd0e9c6', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.panel-info > .panel-heading {
|
||||
background-image: -webkit-linear-gradient(top, #d9edf7 0%, #c4e3f3 100%);
|
||||
background-image: -o-linear-gradient(top, #d9edf7 0%, #c4e3f3 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#d9edf7), to(#c4e3f3));
|
||||
background-image: linear-gradient(to bottom, #d9edf7 0%, #c4e3f3 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ffd9edf7', endColorstr='#ffc4e3f3', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.panel-warning > .panel-heading {
|
||||
background-image: -webkit-linear-gradient(top, #fcf8e3 0%, #faf2cc 100%);
|
||||
background-image: -o-linear-gradient(top, #fcf8e3 0%, #faf2cc 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#fcf8e3), to(#faf2cc));
|
||||
background-image: linear-gradient(to bottom, #fcf8e3 0%, #faf2cc 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#fffcf8e3', endColorstr='#fffaf2cc', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.panel-danger > .panel-heading {
|
||||
background-image: -webkit-linear-gradient(top, #f2dede 0%, #ebcccc 100%);
|
||||
background-image: -o-linear-gradient(top, #f2dede 0%, #ebcccc 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#f2dede), to(#ebcccc));
|
||||
background-image: linear-gradient(to bottom, #f2dede 0%, #ebcccc 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#fff2dede', endColorstr='#ffebcccc', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
}
|
||||
.well {
|
||||
background-image: -webkit-linear-gradient(top, #e8e8e8 0%, #f5f5f5 100%);
|
||||
background-image: -o-linear-gradient(top, #e8e8e8 0%, #f5f5f5 100%);
|
||||
background-image: -webkit-gradient(linear, left top, left bottom, from(#e8e8e8), to(#f5f5f5));
|
||||
background-image: linear-gradient(to bottom, #e8e8e8 0%, #f5f5f5 100%);
|
||||
filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ffe8e8e8', endColorstr='#fff5f5f5', GradientType=0);
|
||||
background-repeat: repeat-x;
|
||||
border-color: #dcdcdc;
|
||||
-webkit-box-shadow: inset 0 1px 3px rgba(0, 0, 0, .05), 0 1px 0 rgba(255, 255, 255, .1);
|
||||
box-shadow: inset 0 1px 3px rgba(0, 0, 0, .05), 0 1px 0 rgba(255, 255, 255, .1);
|
||||
}
|
||||
/*# sourceMappingURL=bootstrap-theme.css.map */
|
||||
File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long
+6584
File diff suppressed because it is too large
Load Diff
File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long
+3
-13
@@ -18,41 +18,31 @@
|
||||
*/
|
||||
package it.org.apache.struts2.rest.example;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
import net.sourceforge.jwebunit.junit.WebTestCase;
|
||||
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.assertTextNotPresent;
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.assertTextPresent;
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.beginAt;
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.getTestContext;
|
||||
public class GetOrdersTest extends WebTestCase {
|
||||
|
||||
public class GetOrdersTest {
|
||||
|
||||
@Before
|
||||
public void setUp() throws Exception {
|
||||
getTestContext().setBaseUrl(ParameterUtils.getBaseUrl());
|
||||
}
|
||||
|
||||
@Test
|
||||
|
||||
public void testGetOrders() {
|
||||
beginAt("/orders/3");
|
||||
assertTextPresent("Bob");
|
||||
assertTextNotPresent("Sarah");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testGetOrdersInHtml() {
|
||||
beginAt("/orders/3.xhtml");
|
||||
assertTextPresent("Bob");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testGetOrdersInXml() {
|
||||
beginAt("/orders/3.xml");
|
||||
assertTextPresent("<clientName>Bob");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testGetOrdersInJson() {
|
||||
beginAt("/orders/3.json");
|
||||
assertTextPresent("\"clientName\":\"Bob\"");
|
||||
|
||||
+3
-12
@@ -18,21 +18,15 @@
|
||||
*/
|
||||
package it.org.apache.struts2.rest.example;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
import net.sourceforge.jwebunit.junit.WebTestCase;
|
||||
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.assertTextPresent;
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.beginAt;
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.getTestContext;
|
||||
public class ListOrdersTest extends WebTestCase {
|
||||
|
||||
public class ListOrdersTest {
|
||||
|
||||
@Before
|
||||
public void setUp() throws Exception {
|
||||
getTestContext().setBaseUrl(ParameterUtils.getBaseUrl());
|
||||
}
|
||||
|
||||
@Test
|
||||
|
||||
public void testListOrders() {
|
||||
beginAt("/orders");
|
||||
assertTextPresent("Bob");
|
||||
@@ -40,7 +34,6 @@ public class ListOrdersTest {
|
||||
assertTextPresent("Jim");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testListOrdersInHtml() {
|
||||
beginAt("/orders.xhtml");
|
||||
assertTextPresent("Bob");
|
||||
@@ -48,7 +41,6 @@ public class ListOrdersTest {
|
||||
assertTextPresent("Jim");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testListOrdersInXml() {
|
||||
beginAt("/orders.xml");
|
||||
assertTextPresent("<clientName>Bob");
|
||||
@@ -56,7 +48,6 @@ public class ListOrdersTest {
|
||||
assertTextPresent("<clientName>Jim");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testListOrdersInJson() {
|
||||
beginAt("/orders.json");
|
||||
assertTextPresent("\"clientName\":\"Bob\"");
|
||||
|
||||
+4
-24
@@ -18,37 +18,23 @@
|
||||
*/
|
||||
package it.org.apache.struts2.rest.example;
|
||||
|
||||
import com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException;
|
||||
import net.sourceforge.jwebunit.junit.WebTestCase;
|
||||
import org.apache.http.client.methods.CloseableHttpResponse;
|
||||
import org.apache.http.client.methods.HttpPost;
|
||||
import org.apache.http.entity.StringEntity;
|
||||
import org.apache.http.impl.client.CloseableHttpClient;
|
||||
import org.apache.http.impl.client.HttpClients;
|
||||
import org.htmlunit.FailingHttpStatusCodeException;
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
|
||||
import java.io.IOException;
|
||||
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.assertLinkNotPresentWithText;
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.assertTextFieldEquals;
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.assertTextPresent;
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.beginAt;
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.getTestContext;
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.setTextField;
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.setWorkingForm;
|
||||
import static net.sourceforge.jwebunit.junit.JWebUnit.submit;
|
||||
import static org.junit.Assert.assertEquals;
|
||||
import static org.junit.Assert.assertNull;
|
||||
import static org.junit.Assert.assertTrue;
|
||||
public class PostOrderTest extends WebTestCase {
|
||||
|
||||
public class PostOrderTest {
|
||||
|
||||
@Before
|
||||
public void setUp() throws Exception {
|
||||
getTestContext().setBaseUrl(ParameterUtils.getBaseUrl());
|
||||
}
|
||||
|
||||
@Test
|
||||
|
||||
public void testPostOrder() {
|
||||
beginAt("/orders/new");
|
||||
setWorkingForm(0);
|
||||
@@ -59,7 +45,6 @@ public class PostOrderTest {
|
||||
assertLinkNotPresentWithText("Back to Orders");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testPostOrderWithErrors() {
|
||||
beginAt("/orders/new");
|
||||
setWorkingForm(0);
|
||||
@@ -73,7 +58,6 @@ public class PostOrderTest {
|
||||
assertTextFieldEquals("amount", "321");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testPostOrderInHtml() {
|
||||
beginAt("/orders/new.xhtml");
|
||||
setWorkingForm(0);
|
||||
@@ -88,7 +72,6 @@ public class PostOrderTest {
|
||||
assertLinkNotPresentWithText("Back to Orders");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testPostOrderInXml() throws IOException {
|
||||
CloseableHttpClient client = HttpClients.createDefault();
|
||||
HttpPost httpPost = new HttpPost(ParameterUtils.getBaseUrl() + "/orders.xml");
|
||||
@@ -102,7 +85,6 @@ public class PostOrderTest {
|
||||
client.close();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testPostOrderInXmlWithBadData() throws IOException {
|
||||
CloseableHttpClient client = HttpClients.createDefault();
|
||||
HttpPost httpPost = new HttpPost(ParameterUtils.getBaseUrl() + "/orders.xml");
|
||||
@@ -116,7 +98,6 @@ public class PostOrderTest {
|
||||
client.close();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testPostOrderInJson() throws IOException {
|
||||
CloseableHttpClient client = HttpClients.createDefault();
|
||||
HttpPost httpPost = new HttpPost(ParameterUtils.getBaseUrl() + "/orders.json");
|
||||
@@ -127,7 +108,6 @@ public class PostOrderTest {
|
||||
client.close();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testPostOrderInJsonWithBadData() throws IOException {
|
||||
CloseableHttpClient client = HttpClients.createDefault();
|
||||
HttpPost httpPost = new HttpPost(ParameterUtils.getBaseUrl() + "/orders.json");
|
||||
|
||||
@@ -1,19 +0,0 @@
|
||||
# Showcase
|
||||
|
||||
> **WARNING:** This application is a demonstration/development tool only. It is **NOT** intended for production
|
||||
> deployment. It contains features such as source code viewing that intentionally expose internal application details.
|
||||
> Deploying this application on a publicly accessible server may pose security risks.
|
||||
|
||||
Showcase is a collection of examples with code that you might adopt and adapt in your own applications.
|
||||
|
||||
For more on getting started with Struts, see:
|
||||
|
||||
- https://struts.apache.org/getting-started/
|
||||
|
||||
## I18N
|
||||
|
||||
Please note that this project was created with the assumption that it will be run in an environment where the default
|
||||
locale is set to English. This means that the default messages defined in `package.properties` are in English.
|
||||
|
||||
If the default locale for your server is different, then rename `package.properties` to `package_en.properties` and
|
||||
create a new `package.properties` with proper values for your default locale.
|
||||
@@ -0,0 +1,16 @@
|
||||
README.txt - showcase
|
||||
|
||||
Showcase is a collection of examples with code that you might be adopt and
|
||||
adapt in your own applications.
|
||||
|
||||
For more on getting started with Struts, see
|
||||
|
||||
* http://cwiki.apache.org/WW/home.html
|
||||
|
||||
I18N:
|
||||
=====
|
||||
Please note that this project was created with the assumption that it will be run
|
||||
in an environment where the default locale is set to English. This means that
|
||||
the default messages defined in package.properties are in English. If the default
|
||||
locale for your server is different, then rename package.properties to package_en.properties
|
||||
and create a new package.properties with proper values for your default locale.
|
||||
+45
-105
@@ -24,7 +24,7 @@
|
||||
<parent>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-apps</artifactId>
|
||||
<version>7.4.0-SNAPSHOT</version>
|
||||
<version>6.1.2.2</version>
|
||||
</parent>
|
||||
|
||||
<artifactId>struts2-showcase</artifactId>
|
||||
@@ -48,16 +48,32 @@
|
||||
<artifactId>struts2-config-browser-plugin</artifactId>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-sitemesh-plugin</artifactId>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-tiles-plugin</artifactId>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-dwr-plugin</artifactId>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-json-plugin</artifactId>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.apache.tiles</groupId>
|
||||
<artifactId>tiles-jsp</artifactId>
|
||||
<scope>runtime</scope>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-convention-plugin</artifactId>
|
||||
@@ -82,23 +98,10 @@
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-velocity-plugin</artifactId>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-velocity-tools-view-jakarta</artifactId>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-velocity-tools-jsp-jakarta</artifactId>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-xslt-plugin</artifactId>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>jakarta.servlet</groupId>
|
||||
<artifactId>jakarta.servlet-api</artifactId>
|
||||
<groupId>javax.servlet</groupId>
|
||||
<artifactId>javax.servlet-api</artifactId>
|
||||
<scope>provided</scope>
|
||||
</dependency>
|
||||
|
||||
@@ -106,28 +109,35 @@
|
||||
<dependency>
|
||||
<groupId>org.apache.logging.log4j</groupId>
|
||||
<artifactId>log4j-api</artifactId>
|
||||
<version>${log4j2.version}</version>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.apache.logging.log4j</groupId>
|
||||
<artifactId>log4j-core</artifactId>
|
||||
<version>${log4j2.version}</version>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.apache.logging.log4j</groupId>
|
||||
<artifactId>log4j-jcl</artifactId>
|
||||
<version>${log4j2.version}</version>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.apache.logging.log4j</groupId>
|
||||
<artifactId>log4j-slf4j-impl</artifactId>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.apache.logging.log4j</groupId>
|
||||
<artifactId>log4j-web</artifactId>
|
||||
<version>${log4j2.version}</version>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.sitemesh</groupId>
|
||||
<artifactId>sitemesh</artifactId>
|
||||
<version>3.2.3</version>
|
||||
<groupId>opensymphony</groupId>
|
||||
<artifactId>sitemesh</artifactId>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.directwebremoting</groupId>
|
||||
<artifactId>dwr</artifactId>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>commons-fileupload</groupId>
|
||||
<artifactId>commons-fileupload</artifactId>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
@@ -136,95 +146,28 @@
|
||||
<scope>test</scope>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.assertj</groupId>
|
||||
<artifactId>assertj-core</artifactId>
|
||||
<dependency>
|
||||
<groupId>net.sourceforge.htmlunit</groupId>
|
||||
<artifactId>htmlunit</artifactId>
|
||||
<version>2.61.0</version>
|
||||
<scope>test</scope>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.htmlunit</groupId>
|
||||
<artifactId>htmlunit</artifactId>
|
||||
<scope>test</scope>
|
||||
</dependency>
|
||||
|
||||
<!-- BeanValidation Example -->
|
||||
<dependency>
|
||||
<groupId>org.hibernate.validator</groupId>
|
||||
<artifactId>hibernate-validator</artifactId>
|
||||
<version>${hibernate-validator.version}</version>
|
||||
<exclusions>
|
||||
<exclusion>
|
||||
<groupId>jakarta.validation</groupId>
|
||||
<artifactId>jakarta.validation-api</artifactId>
|
||||
</exclusion>
|
||||
</exclusions>
|
||||
</dependency>
|
||||
|
||||
<!--
|
||||
Nashorn (the built-in JDK javascript engine) was deprecated in JDK 11 and removed in JDK 15
|
||||
As a result attempting to use @ScriptAssert on JDK 17 leads to the exception
|
||||
See more details
|
||||
https://stackoverflow.com/questions/78008950/resolve-org-hibernate-validator-spi-scripting-scriptevaluatornotfoundexception
|
||||
-->
|
||||
<dependency>
|
||||
<groupId>org.codehaus.groovy</groupId>
|
||||
<artifactId>groovy-jsr223</artifactId>
|
||||
<version>3.0.25</version>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.webjars</groupId>
|
||||
<artifactId>bootstrap</artifactId>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.webjars.npm</groupId>
|
||||
<artifactId>bootstrap-icons</artifactId>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.webjars</groupId>
|
||||
<artifactId>jquery</artifactId>
|
||||
<version>${webjars-jquery-showcase.version}</version>
|
||||
</dependency>
|
||||
</dependencies>
|
||||
|
||||
<build>
|
||||
<plugins>
|
||||
<plugin>
|
||||
<groupId>org.apache.maven.plugins</groupId>
|
||||
<artifactId>maven-dependency-plugin</artifactId>
|
||||
<executions>
|
||||
<execution>
|
||||
<?m2e ignore?>
|
||||
<id>copy-dependencies</id>
|
||||
<phase>package</phase>
|
||||
<goals>
|
||||
<goal>copy</goal>
|
||||
</goals>
|
||||
<configuration>
|
||||
<outputDirectory>${project.build.directory}/extraclasspath</outputDirectory>
|
||||
<artifactItems>
|
||||
<artifactItem>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-velocity-tools-view-jakarta</artifactId>
|
||||
<destFileName>struts2-velocity-tools-view-jakarta.jar</destFileName>
|
||||
</artifactItem>
|
||||
<artifactItem>
|
||||
<groupId>org.apache.struts</groupId>
|
||||
<artifactId>struts2-velocity-tools-jsp-jakarta</artifactId>
|
||||
<destFileName>struts2-velocity-tools-jsp-jakarta.jar</destFileName>
|
||||
</artifactItem>
|
||||
</artifactItems>
|
||||
<overWriteReleases>false</overWriteReleases>
|
||||
<overWriteSnapshots>false</overWriteSnapshots>
|
||||
<overWriteIfNewer>true</overWriteIfNewer>
|
||||
</configuration>
|
||||
</execution>
|
||||
</executions>
|
||||
</plugin>
|
||||
<plugin>
|
||||
<groupId>org.apache.maven.plugins</groupId>
|
||||
<artifactId>maven-failsafe-plugin</artifactId>
|
||||
<version>3.5.6</version>
|
||||
<version>3.0.0-M6</version>
|
||||
<configuration>
|
||||
<includes>
|
||||
<include>it.org.apache.struts2.showcase.*Test</include>
|
||||
@@ -251,7 +194,7 @@
|
||||
<plugin>
|
||||
<groupId>org.eclipse.jetty</groupId>
|
||||
<artifactId>jetty-maven-plugin</artifactId>
|
||||
<version>11.0.26</version>
|
||||
<version>9.4.46.v20220331</version>
|
||||
<configuration>
|
||||
<stopKey>CTRL+C</stopKey>
|
||||
<stopPort>8999</stopPort>
|
||||
@@ -264,15 +207,12 @@
|
||||
<httpConnector>
|
||||
<port>8090</port>
|
||||
</httpConnector>
|
||||
<scan>10</scan>
|
||||
<webApp>
|
||||
<extraClasspath>
|
||||
${project.build.directory}/extraclasspath/struts2-velocity-tools-view-jakarta.jar,
|
||||
${project.build.directory}/extraclasspath/struts2-velocity-tools-jsp-jakarta
|
||||
</extraClasspath>
|
||||
<contextPath>/struts2-showcase</contextPath>
|
||||
<descriptor>${basedir}/src/main/webapp/WEB-INF/web.xml</descriptor>
|
||||
</webApp>
|
||||
<scanIntervalSeconds>10</scanIntervalSeconds>
|
||||
<webAppSourceDirectory>${basedir}/src/main/webapp/</webAppSourceDirectory>
|
||||
<webAppConfig>
|
||||
<contextPath>/struts2-showcase</contextPath>
|
||||
<descriptor>${basedir}/src/main/webapp/WEB-INF/web.xml</descriptor>
|
||||
</webAppConfig>
|
||||
</configuration>
|
||||
<executions>
|
||||
<execution>
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
import java.text.DateFormat;
|
||||
import java.util.Calendar;
|
||||
|
||||
+2
-3
@@ -20,8 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
import org.apache.struts2.showcase.ajax.tree.Category;
|
||||
|
||||
//START SNIPPET: treeExampleDynamicJavaSelected
|
||||
@@ -31,7 +30,7 @@ public class DynamicTreeSelectAction extends ActionSupport {
|
||||
private long nodeId;
|
||||
private Category currentCategory;
|
||||
|
||||
@StrutsParameter
|
||||
|
||||
public void setNodeId(long nodeId) {
|
||||
this.nodeId = nodeId;
|
||||
}
|
||||
|
||||
+2
-17
@@ -20,8 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.LinkedHashMap;
|
||||
@@ -75,7 +74,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _favouriteCartoonCharactersKeys;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFavouriteCartoonCharacters(List favouriteCartoonCharacters) {
|
||||
_favouriteCartoonCharactersKeys = favouriteCartoonCharacters;
|
||||
}
|
||||
@@ -84,7 +82,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _notFavouriteCartoonCharactersKeys;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setNotFavouriteCartoonCharacters(List notFavouriteCartoonCharacters) {
|
||||
_notFavouriteCartoonCharactersKeys = notFavouriteCartoonCharacters;
|
||||
}
|
||||
@@ -111,7 +108,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _favouriteCarsKeys;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFavouriteCars(List favouriteCars) {
|
||||
_favouriteCarsKeys = favouriteCars;
|
||||
}
|
||||
@@ -120,7 +116,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _notFavouriteCarsKeys;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setNotFavouriteCars(List notFavouriteCars) {
|
||||
_notFavouriteCarsKeys = notFavouriteCars;
|
||||
}
|
||||
@@ -147,7 +142,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _favouriteMotorcyclesKeys;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFavouriteMotorcycles(List favouriteMotorcycles) {
|
||||
_favouriteMotorcyclesKeys = favouriteMotorcycles;
|
||||
}
|
||||
@@ -156,7 +150,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _notFavouriteMotorcyclesKeys;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setNotFavouriteMotorcycles(List notFavouriteMotorcycles) {
|
||||
_notFavouriteMotorcyclesKeys = notFavouriteMotorcycles;
|
||||
}
|
||||
@@ -183,7 +176,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _favouriteCountriesKeys;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFavouriteCountries(List favouriteCountries) {
|
||||
_favouriteCountriesKeys = favouriteCountries;
|
||||
}
|
||||
@@ -192,7 +184,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _notFavouriteCountriesKeys;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setNotFavouriteCountries(List notFavouriteCountries) {
|
||||
_notFavouriteCountriesKeys = notFavouriteCountries;
|
||||
}
|
||||
@@ -214,7 +205,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _favouriteSportsKeys;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFavouriteSports(List favouriteSportsKeys) {
|
||||
this._favouriteSportsKeys = favouriteSportsKeys;
|
||||
}
|
||||
@@ -223,7 +213,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _nonFavouriteSportsKeys;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setNonFavouriteSports(List notFavouriteSportsKeys) {
|
||||
this._nonFavouriteSportsKeys = notFavouriteSportsKeys;
|
||||
}
|
||||
@@ -233,7 +222,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _prioritisedFavouriteCartoonCharacters;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setPrioritisedFavouriteCartoonCharacters(List prioritisedFavouriteCartoonCharacters) {
|
||||
_prioritisedFavouriteCartoonCharacters = prioritisedFavouriteCartoonCharacters;
|
||||
}
|
||||
@@ -242,7 +230,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _prioritisedFavouriteCars;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setPrioritisedFavouriteCars(List prioritisedFavouriteCars) {
|
||||
_prioritisedFavouriteCars = prioritisedFavouriteCars;
|
||||
}
|
||||
@@ -252,7 +239,6 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _prioritisedFavouriteCountries;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setPrioritisedFavouriteCountries(List prioritisedFavouriteCountries) {
|
||||
_prioritisedFavouriteCountries = prioritisedFavouriteCountries;
|
||||
}
|
||||
@@ -278,13 +264,12 @@ public class LotsOfOptiontransferselectAction extends ActionSupport {
|
||||
return _favouriteCities;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFavouriteCities(List favouriteCities) {
|
||||
this._favouriteCities = favouriteCities;
|
||||
}
|
||||
|
||||
// actions
|
||||
@Override
|
||||
|
||||
public String input() throws Exception {
|
||||
return SUCCESS;
|
||||
}
|
||||
|
||||
+2
-7
@@ -20,8 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
/**
|
||||
*
|
||||
@@ -37,7 +36,6 @@ public class LotsOfRichtexteditorAction extends ActionSupport {
|
||||
return this.description1;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setDescription1(String description1) {
|
||||
this.description1 = description1;
|
||||
}
|
||||
@@ -47,7 +45,6 @@ public class LotsOfRichtexteditorAction extends ActionSupport {
|
||||
return this.description2;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setDescription2(String description2) {
|
||||
this.description2 = description2;
|
||||
}
|
||||
@@ -57,7 +54,6 @@ public class LotsOfRichtexteditorAction extends ActionSupport {
|
||||
return this.description3;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setDescription3(String description3) {
|
||||
this.description3 = description3;
|
||||
}
|
||||
@@ -67,12 +63,11 @@ public class LotsOfRichtexteditorAction extends ActionSupport {
|
||||
return this.description4;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setDescription4(String description4) {
|
||||
this.description4 = description4;
|
||||
}
|
||||
|
||||
@Override
|
||||
|
||||
public String input() throws Exception {
|
||||
return SUCCESS;
|
||||
}
|
||||
|
||||
@@ -20,8 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.LinkedHashMap;
|
||||
@@ -76,11 +75,11 @@ public class MoreSelectsAction extends ActionSupport {
|
||||
return list;
|
||||
}
|
||||
|
||||
|
||||
public List getPrioritisedFavouriteCartoonCharacters() {
|
||||
return _prioritisedFavouriteCartoonCharacters;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setPrioritisedFavouriteCartoonCharacters(List prioritisedFavouriteCartoonCharacters) {
|
||||
_prioritisedFavouriteCartoonCharacters = prioritisedFavouriteCartoonCharacters;
|
||||
}
|
||||
@@ -89,16 +88,15 @@ public class MoreSelectsAction extends ActionSupport {
|
||||
return _prioritisedFavouriteCars;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setPrioritisedFavouriteCars(List prioritisedFavouriteCars) {
|
||||
_prioritisedFavouriteCars = prioritisedFavouriteCars;
|
||||
}
|
||||
|
||||
|
||||
public List getPrioritisedFavouriteCountries() {
|
||||
return _prioritisedFavouriteCountries;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setPrioritisedFavouriteCountries(List prioritisedFavouriteCountries) {
|
||||
_prioritisedFavouriteCountries = prioritisedFavouriteCountries;
|
||||
}
|
||||
@@ -107,7 +105,6 @@ public class MoreSelectsAction extends ActionSupport {
|
||||
return favouriteNumbers;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFavouriteNumbers(List favouriteNumbers) {
|
||||
this.favouriteNumbers = favouriteNumbers;
|
||||
}
|
||||
@@ -132,13 +129,12 @@ public class MoreSelectsAction extends ActionSupport {
|
||||
return favouriteCities;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFavouriteCities(List favouriteCities) {
|
||||
this.favouriteCities = favouriteCities;
|
||||
}
|
||||
|
||||
// actions
|
||||
@Override
|
||||
|
||||
public String input() throws Exception {
|
||||
return SUCCESS;
|
||||
}
|
||||
|
||||
+1
-3
@@ -20,8 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
import org.apache.struts2.showcase.ajax.tree.Category;
|
||||
|
||||
public class ShowAjaxDynamicTreeAction extends ActionSupport {
|
||||
@@ -35,7 +34,6 @@ public class ShowAjaxDynamicTreeAction extends ActionSupport {
|
||||
return nodeId;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setNodeId(int nodeId) {
|
||||
this.nodeId = nodeId;
|
||||
}
|
||||
|
||||
@@ -20,7 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
import org.apache.struts2.showcase.ajax.tree.Category;
|
||||
|
||||
// START SNIPPET: treeExampleDynamicJavaShow
|
||||
|
||||
@@ -20,19 +20,13 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.Validateable;
|
||||
import org.apache.struts2.util.ValueStack;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
import com.opensymphony.xwork2.Validateable;
|
||||
import com.opensymphony.xwork2.util.ValueStack;
|
||||
import org.apache.struts2.ServletActionContext;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
|
||||
import java.io.File;
|
||||
import java.util.ArrayList;
|
||||
import java.util.Collections;
|
||||
import java.util.Date;
|
||||
import java.util.HashMap;
|
||||
import java.util.List;
|
||||
import java.util.Map;
|
||||
import java.util.*;
|
||||
|
||||
/**
|
||||
*/
|
||||
@@ -95,7 +89,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return leftSideCartoonCharacters;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setLeftSideCartoonCharacters(List leftSideCartoonCharacters) {
|
||||
this.leftSideCartoonCharacters = leftSideCartoonCharacters;
|
||||
}
|
||||
@@ -105,7 +98,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return rightSideCartoonCharacters;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setRightSideCartoonCharacters(List rightSideCartoonCharacters) {
|
||||
this.rightSideCartoonCharacters = rightSideCartoonCharacters;
|
||||
}
|
||||
@@ -115,7 +107,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return favouriteVehicalType;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFavouriteVehicalType(String favouriteVehicalType) {
|
||||
this.favouriteVehicalType = favouriteVehicalType;
|
||||
}
|
||||
@@ -124,7 +115,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return favouriteVehicalSpecific;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFavouriteVehicalSpecific(String favouriteVehicalSpecific) {
|
||||
this.favouriteVehicalSpecific = favouriteVehicalSpecific;
|
||||
}
|
||||
@@ -155,7 +145,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return name;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setName(String name) {
|
||||
this.name = name;
|
||||
}
|
||||
@@ -164,7 +153,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return birthday;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setBirthday(Date birthday) {
|
||||
this.birthday = birthday;
|
||||
}
|
||||
@@ -173,7 +161,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return bio;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setBio(String bio) {
|
||||
this.bio = bio;
|
||||
}
|
||||
@@ -182,7 +169,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return favouriteColor;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFavouriteColor(String favoriteColor) {
|
||||
this.favouriteColor = favoriteColor;
|
||||
}
|
||||
@@ -191,7 +177,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return friends;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFriends(List friends) {
|
||||
this.friends = friends;
|
||||
}
|
||||
@@ -200,7 +185,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return bestFriend;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setBestFriend(String bestFriend) {
|
||||
this.bestFriend = bestFriend;
|
||||
}
|
||||
@@ -209,7 +193,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return legalAge;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setLegalAge(boolean legalAge) {
|
||||
this.legalAge = legalAge;
|
||||
}
|
||||
@@ -218,7 +201,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return state;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setState(String state) {
|
||||
this.state = state;
|
||||
}
|
||||
@@ -227,12 +209,10 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return region;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setRegion(String region) {
|
||||
this.region = region;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setPicture(File picture) {
|
||||
this.picture = picture;
|
||||
}
|
||||
@@ -241,17 +221,14 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return this.picture;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setPictureContentType(String pictureContentType) {
|
||||
this.pictureContentType = pictureContentType;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setPictureFileName(String pictureFileName) {
|
||||
this.pictureFileName = pictureFileName;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setFavouriteLanguage(String favouriteLanguage) {
|
||||
this.favouriteLanguage = favouriteLanguage;
|
||||
}
|
||||
@@ -260,7 +237,7 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return favouriteLanguage;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
|
||||
public void setThoughts(String thoughts) {
|
||||
this.thoughts = thoughts;
|
||||
}
|
||||
@@ -273,7 +250,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return wakeup;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setWakeup(Date wakeup) {
|
||||
this.wakeup = wakeup;
|
||||
}
|
||||
@@ -327,7 +303,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return this.description;
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean equals(Object obj) {
|
||||
if (!(obj instanceof VehicalType)) {
|
||||
return false;
|
||||
@@ -336,7 +311,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public int hashCode() {
|
||||
return key.hashCode();
|
||||
}
|
||||
@@ -360,7 +334,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
return this.description;
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean equals(Object obj) {
|
||||
if (!(obj instanceof VehicalSpecific)) {
|
||||
return false;
|
||||
@@ -369,7 +342,6 @@ public class UITagExample extends ActionSupport implements Validateable {
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public int hashCode() {
|
||||
return key.hashCode();
|
||||
}
|
||||
|
||||
+51
-52
@@ -18,10 +18,9 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.action;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
import org.apache.logging.log4j.LogManager;
|
||||
import org.apache.logging.log4j.Logger;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import org.apache.struts2.showcase.dao.Dao;
|
||||
import org.apache.struts2.showcase.model.IdEntity;
|
||||
|
||||
@@ -34,62 +33,62 @@ import java.util.Collection;
|
||||
|
||||
public abstract class AbstractCRUDAction extends ActionSupport {
|
||||
|
||||
private static final Logger log = LogManager.getLogger(AbstractCRUDAction.class);
|
||||
private static final Logger log = LogManager.getLogger(AbstractCRUDAction.class);
|
||||
|
||||
private Collection availableItems;
|
||||
private String[] toDelete;
|
||||
private Collection availableItems;
|
||||
private String[] toDelete;
|
||||
|
||||
protected abstract Dao getDao();
|
||||
protected abstract Dao getDao();
|
||||
|
||||
public Collection getAvailableItems() {
|
||||
return availableItems;
|
||||
}
|
||||
|
||||
public String[] getToDelete() {
|
||||
return toDelete;
|
||||
}
|
||||
public Collection getAvailableItems() {
|
||||
return availableItems;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setToDelete(String[] toDelete) {
|
||||
this.toDelete = toDelete;
|
||||
}
|
||||
public String[] getToDelete() {
|
||||
return toDelete;
|
||||
}
|
||||
|
||||
public String list() throws Exception {
|
||||
this.availableItems = getDao().findAll();
|
||||
if (log.isDebugEnabled()) {
|
||||
log.debug("AbstractCRUDAction - [list]: " + (availableItems != null ? "" + availableItems.size() : "no") + " items found");
|
||||
}
|
||||
return execute();
|
||||
}
|
||||
public void setToDelete(String[] toDelete) {
|
||||
this.toDelete = toDelete;
|
||||
}
|
||||
|
||||
public String delete() throws Exception {
|
||||
if (toDelete != null) {
|
||||
int count = 0;
|
||||
for (String s : toDelete) {
|
||||
count = count + getDao().delete(s);
|
||||
}
|
||||
if (log.isDebugEnabled()) {
|
||||
log.debug("AbstractCRUDAction - [delete]: {} items deleted.", count);
|
||||
}
|
||||
}
|
||||
return SUCCESS;
|
||||
}
|
||||
public String list() throws Exception {
|
||||
this.availableItems = getDao().findAll();
|
||||
if (log.isDebugEnabled()) {
|
||||
log.debug("AbstractCRUDAction - [list]: " + (availableItems != null ? "" + availableItems.size() : "no") + " items found");
|
||||
}
|
||||
return execute();
|
||||
}
|
||||
|
||||
/**
|
||||
* Utility method for fetching already persistent object from storage for usage in params-prepare-params cycle.
|
||||
*
|
||||
* @param tryId The id to try to get persistent object for
|
||||
* @param tryObject The object, induced by first params invocation, possibly containing id to try to get persistent
|
||||
* object for
|
||||
* @return The persistent object, if found. <tt>null</tt> otherwise.
|
||||
*/
|
||||
protected IdEntity fetch(Serializable tryId, IdEntity tryObject) {
|
||||
IdEntity result = null;
|
||||
if (tryId != null) {
|
||||
result = getDao().get(tryId);
|
||||
} else if (tryObject != null) {
|
||||
result = getDao().get(tryObject.getId());
|
||||
}
|
||||
return result;
|
||||
}
|
||||
public String delete() throws Exception {
|
||||
if (toDelete != null) {
|
||||
int count = 0;
|
||||
for (int i = 0, j = toDelete.length; i < j; i++) {
|
||||
count = count + getDao().delete(toDelete[i]);
|
||||
}
|
||||
if (log.isDebugEnabled()) {
|
||||
log.debug("AbstractCRUDAction - [delete]: " + count + " items deleted.");
|
||||
}
|
||||
}
|
||||
return SUCCESS;
|
||||
}
|
||||
|
||||
/**
|
||||
* Utility method for fetching already persistent object from storage for usage in params-prepare-params cycle.
|
||||
*
|
||||
* @param tryId The id to try to get persistent object for
|
||||
* @param tryObject The object, induced by first params invocation, possibly containing id to try to get persistent
|
||||
* object for
|
||||
* @return The persistent object, if found. <tt>null</tt> otherwise.
|
||||
*/
|
||||
protected IdEntity fetch(Serializable tryId, IdEntity tryObject) {
|
||||
IdEntity result = null;
|
||||
if (tryId != null) {
|
||||
result = getDao().get(tryId);
|
||||
} else if (tryObject != null) {
|
||||
result = getDao().get(tryObject.getId());
|
||||
}
|
||||
return result;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -18,10 +18,9 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.action;
|
||||
|
||||
import org.apache.struts2.Preparable;
|
||||
import com.opensymphony.xwork2.Preparable;
|
||||
import org.apache.logging.log4j.LogManager;
|
||||
import org.apache.logging.log4j.Logger;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import org.apache.struts2.showcase.application.TestDataProvider;
|
||||
import org.apache.struts2.showcase.dao.Dao;
|
||||
import org.apache.struts2.showcase.dao.EmployeeDao;
|
||||
@@ -53,7 +52,7 @@ public class EmployeeAction extends AbstractCRUDAction implements Preparable {
|
||||
|
||||
public String execute() throws Exception {
|
||||
if (getCurrentEmployee() != null && getCurrentEmployee().getOtherSkills() != null) {
|
||||
setSelectedSkills(new ArrayList<>());
|
||||
setSelectedSkills(new ArrayList<String>());
|
||||
Iterator it = getCurrentEmployee().getOtherSkills().iterator();
|
||||
while (it.hasNext()) {
|
||||
getSelectedSkills().add(((Skill) it.next()).getName());
|
||||
@@ -74,12 +73,10 @@ public class EmployeeAction extends AbstractCRUDAction implements Preparable {
|
||||
return empId;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setEmpId(Long empId) {
|
||||
this.empId = empId;
|
||||
}
|
||||
|
||||
@StrutsParameter(depth = 2)
|
||||
public Employee getCurrentEmployee() {
|
||||
return currentEmployee;
|
||||
}
|
||||
|
||||
@@ -18,13 +18,9 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.action;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
import java.util.Arrays;
|
||||
import java.util.Date;
|
||||
import java.util.HashMap;
|
||||
import java.util.List;
|
||||
import java.util.Map;
|
||||
import java.util.*;
|
||||
|
||||
public class ExampleAction extends ActionSupport {
|
||||
public static final String CONSTANT = "Struts Rocks!";
|
||||
@@ -50,7 +46,7 @@ public class ExampleAction extends ActionSupport {
|
||||
}
|
||||
|
||||
public Map<String, Book> getBooks() {
|
||||
Map<String, Book> books = new HashMap<>();
|
||||
Map<String, Book> books = new HashMap<String, Book>();
|
||||
books.put("Iliad", new Book("Iliad", "Homer"));
|
||||
books.put("The Republic", new Book("The Replublic", "Plato"));
|
||||
books.put("Thus Spake Zarathustra", new Book("Thus Spake Zarathustra",
|
||||
@@ -83,4 +79,4 @@ class Book {
|
||||
public void setAuthor(String author) {
|
||||
this.author = author;
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -18,16 +18,11 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.action;
|
||||
|
||||
import org.apache.struts2.action.Action;
|
||||
import org.apache.struts2.interceptor.annotations.After;
|
||||
import com.opensymphony.xwork2.Action;
|
||||
import com.opensymphony.xwork2.interceptor.annotations.After;
|
||||
import org.apache.struts2.ServletActionContext;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
|
||||
import java.io.BufferedWriter;
|
||||
import java.io.File;
|
||||
import java.io.FileOutputStream;
|
||||
import java.io.FileWriter;
|
||||
import java.io.IOException;
|
||||
import java.io.*;
|
||||
import java.net.URL;
|
||||
|
||||
/**
|
||||
@@ -67,7 +62,6 @@ public class JSPEvalAction extends ExampleAction {
|
||||
}
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setJsp(String jsp) {
|
||||
this.jsp = jsp;
|
||||
}
|
||||
|
||||
-133
@@ -1,133 +0,0 @@
|
||||
/*
|
||||
* Licensed to the Apache Software Foundation (ASF) under one
|
||||
* or more contributor license agreements. See the NOTICE file
|
||||
* distributed with this work for additional information
|
||||
* regarding copyright ownership. The ASF licenses this file
|
||||
* to you under the Apache License, Version 2.0 (the
|
||||
* "License"); you may not use this file except in compliance
|
||||
* with the License. You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing,
|
||||
* software distributed under the License is distributed on an
|
||||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||
* KIND, either express or implied. See the License for the
|
||||
* specific language governing permissions and limitations
|
||||
* under the License.
|
||||
*/
|
||||
package org.apache.struts2.showcase.action;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import org.apache.struts2.showcase.model.MyDto;
|
||||
|
||||
import java.lang.reflect.Field;
|
||||
import java.util.ArrayList;
|
||||
import java.util.Arrays;
|
||||
import java.util.HashMap;
|
||||
import java.util.List;
|
||||
import java.util.Map;
|
||||
|
||||
import static java.util.Collections.singletonList;
|
||||
import static java.util.Collections.singletonMap;
|
||||
|
||||
/**
|
||||
* This class supports {@link com.atlassian.confluence.stateless.webdriver.selenium3.security.StrutsParametersTest}
|
||||
* which prevents critical security regressions. Do NOT modify without understanding the motivation behind the tests and
|
||||
* the implications of any changes.
|
||||
*/
|
||||
public class ParamsAnnotationAction extends ActionSupport {
|
||||
|
||||
@StrutsParameter
|
||||
public String varToPrint;
|
||||
|
||||
public String publicField = "no";
|
||||
|
||||
@StrutsParameter
|
||||
public String publicFieldAnnotated = "no";
|
||||
|
||||
private String privateField = "no";
|
||||
|
||||
public int[] publicArray = new int[]{0};
|
||||
|
||||
@StrutsParameter(depth = 1)
|
||||
public int[] publicArrayAnnotated = new int[]{0};
|
||||
|
||||
public List<String> publicList = new ArrayList<>(singletonList("no"));
|
||||
|
||||
@StrutsParameter(depth = 1)
|
||||
public List<String> publicListAnnotated = new ArrayList<>(singletonList("no"));
|
||||
|
||||
private List<String> privateList = new ArrayList<>(singletonList("no"));
|
||||
|
||||
public Map<String, String> publicMap = new HashMap<>(singletonMap("key", "no"));
|
||||
|
||||
@StrutsParameter(depth = 1)
|
||||
public Map<String, String> publicMapAnnotated = new HashMap<>(singletonMap("key", "no"));
|
||||
|
||||
public MyDto publicMyDto = new MyDto();
|
||||
|
||||
@StrutsParameter(depth = 2)
|
||||
public MyDto publicMyDtoAnnotated = new MyDto();
|
||||
|
||||
@StrutsParameter(depth = 1)
|
||||
public MyDto publicMyDtoAnnotatedDepthOne = new MyDto();
|
||||
|
||||
private MyDto privateMyDto = new MyDto();
|
||||
|
||||
public void setPrivateFieldMethod(String privateField) {
|
||||
this.privateField = privateField;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setPrivateFieldMethodAnnotated(String privateField) {
|
||||
this.privateField = privateField;
|
||||
}
|
||||
|
||||
public List<String> getPrivateListMethod() {
|
||||
return privateList;
|
||||
}
|
||||
|
||||
@StrutsParameter(depth = 1)
|
||||
public List<String> getPrivateListMethodAnnotated() {
|
||||
return privateList;
|
||||
}
|
||||
|
||||
public MyDto getUnsafeMethodMyDto() {
|
||||
return privateMyDto;
|
||||
}
|
||||
|
||||
@StrutsParameter(depth = 2)
|
||||
public MyDto getSafeMethodMyDto() {
|
||||
return privateMyDto;
|
||||
}
|
||||
|
||||
@StrutsParameter(depth = 1)
|
||||
public MyDto getSafeMethodMyDtoDepthOne() {
|
||||
return privateMyDto;
|
||||
}
|
||||
|
||||
public String renderVarToPrint() throws ReflectiveOperationException {
|
||||
if (varToPrint == null) {
|
||||
return "null";
|
||||
}
|
||||
Field field = this.getClass().getDeclaredField(varToPrint);
|
||||
field.setAccessible(true);
|
||||
try {
|
||||
return String.format("%s{%s}", varToPrint,
|
||||
field.getType().isArray() ? stringifyArray(field.get(this)) : field.get(this));
|
||||
} finally {
|
||||
field.setAccessible(false);
|
||||
}
|
||||
}
|
||||
|
||||
private String stringifyArray(Object array) {
|
||||
switch (array.getClass().getComponentType().getName()) {
|
||||
case "int":
|
||||
return Arrays.toString((int[]) array);
|
||||
default:
|
||||
return "TODO";
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -18,10 +18,9 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.action;
|
||||
|
||||
import org.apache.struts2.Preparable;
|
||||
import com.opensymphony.xwork2.Preparable;
|
||||
import org.apache.logging.log4j.LogManager;
|
||||
import org.apache.logging.log4j.Logger;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import org.apache.struts2.showcase.dao.Dao;
|
||||
import org.apache.struts2.showcase.dao.SkillDao;
|
||||
import org.apache.struts2.showcase.model.Skill;
|
||||
@@ -46,7 +45,6 @@ public class SkillAction extends AbstractCRUDAction implements Preparable {
|
||||
*
|
||||
* @throws Exception thrown if a system level exception occurs.
|
||||
*/
|
||||
@Override
|
||||
public void prepare() throws Exception {
|
||||
Skill preFetched = (Skill) fetch(getSkillName(), getCurrentSkill());
|
||||
if (preFetched != null) {
|
||||
@@ -65,7 +63,6 @@ public class SkillAction extends AbstractCRUDAction implements Preparable {
|
||||
return skillName;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setSkillName(String skillName) {
|
||||
this.skillName = skillName;
|
||||
}
|
||||
@@ -74,7 +71,6 @@ public class SkillAction extends AbstractCRUDAction implements Preparable {
|
||||
return skillDao;
|
||||
}
|
||||
|
||||
@StrutsParameter(depth = 1)
|
||||
public Skill getCurrentSkill() {
|
||||
return currentSkill;
|
||||
}
|
||||
|
||||
+1
-4
@@ -18,8 +18,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.actionchaining;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
public class ActionChain1 extends ActionSupport {
|
||||
|
||||
@@ -27,7 +26,6 @@ public class ActionChain1 extends ActionSupport {
|
||||
|
||||
private String actionChain1Property1 = "Property Set In Action Chain 1";
|
||||
|
||||
@Override
|
||||
public String input() throws Exception {
|
||||
return SUCCESS;
|
||||
}
|
||||
@@ -36,7 +34,6 @@ public class ActionChain1 extends ActionSupport {
|
||||
return actionChain1Property1;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setActionChain1Property1(String actionChain1Property1) {
|
||||
this.actionChain1Property1 = actionChain1Property1;
|
||||
}
|
||||
|
||||
+2
-5
@@ -18,8 +18,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.actionchaining;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
public class ActionChain2 extends ActionSupport {
|
||||
|
||||
@@ -28,7 +27,6 @@ public class ActionChain2 extends ActionSupport {
|
||||
private String actionChain1Property1;
|
||||
private String actionChain2Property1 = "Property Set in Action Chain 2";
|
||||
|
||||
@Override
|
||||
public String execute() throws Exception {
|
||||
return SUCCESS;
|
||||
}
|
||||
@@ -37,16 +35,15 @@ public class ActionChain2 extends ActionSupport {
|
||||
return actionChain1Property1;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setActionChain1Property1(String actionChain1Property1) {
|
||||
this.actionChain1Property1 = actionChain1Property1;
|
||||
}
|
||||
|
||||
|
||||
public String getActionChain2Property1() {
|
||||
return actionChain2Property1;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setActionChain2Property1(String actionChain2Property1) {
|
||||
this.actionChain2Property1 = actionChain2Property1;
|
||||
}
|
||||
|
||||
+4
-6
@@ -18,8 +18,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.actionchaining;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
public class ActionChain3 extends ActionSupport {
|
||||
|
||||
@@ -29,7 +28,7 @@ public class ActionChain3 extends ActionSupport {
|
||||
private String actionChain2Property1;
|
||||
private String actionChain3Property1 = "Property set in Action Chain 3";
|
||||
|
||||
@Override
|
||||
|
||||
public String execute() throws Exception {
|
||||
return SUCCESS;
|
||||
}
|
||||
@@ -38,25 +37,24 @@ public class ActionChain3 extends ActionSupport {
|
||||
return actionChain1Property1;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setActionChain1Property1(String actionChain1Property1) {
|
||||
this.actionChain1Property1 = actionChain1Property1;
|
||||
}
|
||||
|
||||
|
||||
public String getActionChain2Property1() {
|
||||
return actionChain2Property1;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setActionChain2Property1(String actionChain2Property1) {
|
||||
this.actionChain2Property1 = actionChain2Property1;
|
||||
}
|
||||
|
||||
|
||||
public String getActionChain3Property1() {
|
||||
return actionChain3Property1;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setActionChain3Property1(String actionChain3Property1) {
|
||||
this.actionChain3Property1 = actionChain3Property1;
|
||||
}
|
||||
|
||||
@@ -20,11 +20,11 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.ajax;
|
||||
|
||||
import org.apache.struts2.action.Action;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.Action;
|
||||
|
||||
import java.io.Serializable;
|
||||
|
||||
|
||||
public class AjaxTestAction implements Action, Serializable {
|
||||
|
||||
private static int counter = 0;
|
||||
@@ -46,7 +46,6 @@ public class AjaxTestAction implements Action, Serializable {
|
||||
return data;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setData(String data) {
|
||||
this.data = data;
|
||||
}
|
||||
|
||||
+2
-5
@@ -20,19 +20,17 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.ajax;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
|
||||
public class AutocompleterExampleAction extends ActionSupport {
|
||||
private String select;
|
||||
private final List<String> options = new ArrayList<>();
|
||||
private List<String> options = new ArrayList<String>();
|
||||
|
||||
private static final long serialVersionUID = -8481638176160014396L;
|
||||
|
||||
@Override
|
||||
public String execute() throws Exception {
|
||||
if ("fruits".equals(select)) {
|
||||
options.add("apple");
|
||||
@@ -51,7 +49,6 @@ public class AutocompleterExampleAction extends ActionSupport {
|
||||
return select;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setSelect(String select) {
|
||||
this.select = select;
|
||||
}
|
||||
|
||||
+1
-4
@@ -20,8 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.ajax;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
import java.text.SimpleDateFormat;
|
||||
import java.util.Date;
|
||||
@@ -52,7 +51,6 @@ public class Example4ShowPanelAction extends ActionSupport {
|
||||
return gender;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setGender(String gender) {
|
||||
this.gender = gender;
|
||||
}
|
||||
@@ -61,7 +59,6 @@ public class Example4ShowPanelAction extends ActionSupport {
|
||||
return name;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setName(String name) {
|
||||
this.name = name;
|
||||
}
|
||||
|
||||
@@ -20,8 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.ajax;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
public class Example5Action extends ActionSupport {
|
||||
|
||||
@@ -38,7 +37,6 @@ public class Example5Action extends ActionSupport {
|
||||
return name;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setName(String name) {
|
||||
this.name = name;
|
||||
}
|
||||
@@ -47,7 +45,6 @@ public class Example5Action extends ActionSupport {
|
||||
return age;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setAge(Integer age) {
|
||||
this.age = age;
|
||||
}
|
||||
|
||||
@@ -46,7 +46,8 @@ public class Category {
|
||||
new Category(15, "Dojo"),
|
||||
new Category(16, "Prototype"),
|
||||
new Category(17, "Scriptaculous"),
|
||||
new Category(18, "OpenRico")));
|
||||
new Category(18, "OpenRico"),
|
||||
new Category(19, "DWR")));
|
||||
}
|
||||
|
||||
public static Category getById(long id) {
|
||||
|
||||
@@ -20,8 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.ajax.tree;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
/**
|
||||
*/
|
||||
@@ -29,7 +28,6 @@ public class GetCategory extends ActionSupport {
|
||||
private long catId;
|
||||
private Category category;
|
||||
|
||||
@Override
|
||||
public String execute() throws Exception {
|
||||
if (catId < 1) {
|
||||
// force the root
|
||||
@@ -41,7 +39,6 @@ public class GetCategory extends ActionSupport {
|
||||
return SUCCESS;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setCatId(long catId) {
|
||||
this.catId = catId;
|
||||
}
|
||||
|
||||
@@ -24,8 +24,6 @@ package org.apache.struts2.showcase.ajax.tree;
|
||||
/**
|
||||
*/
|
||||
public class Toggle extends GetCategory {
|
||||
|
||||
@Override
|
||||
public String execute() throws Exception {
|
||||
super.execute();
|
||||
|
||||
|
||||
+60
-63
@@ -31,10 +31,9 @@ import org.springframework.beans.factory.InitializingBean;
|
||||
import org.springframework.beans.factory.annotation.Autowired;
|
||||
import org.springframework.stereotype.Service;
|
||||
|
||||
import java.io.Serial;
|
||||
import java.io.Serializable;
|
||||
import java.util.Arrays;
|
||||
import java.util.Date;
|
||||
import java.util.List;
|
||||
|
||||
/**
|
||||
* TestDataProvider.
|
||||
@@ -42,76 +41,74 @@ import java.util.List;
|
||||
@Service
|
||||
public class TestDataProvider implements Serializable, InitializingBean {
|
||||
|
||||
@Serial
|
||||
private static final long serialVersionUID = 1L;
|
||||
private static final Logger log = LogManager.getLogger(TestDataProvider.class);
|
||||
private static final long serialVersionUID = 1L;
|
||||
private static final Logger log = LogManager.getLogger(TestDataProvider.class);
|
||||
|
||||
public static final String[] POSITIONS = {
|
||||
"Developer",
|
||||
"System Architect",
|
||||
"Sales Manager",
|
||||
"CEO"
|
||||
};
|
||||
public static final String[] POSITIONS = {
|
||||
"Developer",
|
||||
"System Architect",
|
||||
"Sales Manager",
|
||||
"CEO"
|
||||
};
|
||||
|
||||
public static final String[] LEVELS = {
|
||||
"Junior",
|
||||
"Senior",
|
||||
"Master"
|
||||
};
|
||||
public static final String[] LEVELS = {
|
||||
"Junior",
|
||||
"Senior",
|
||||
"Master"
|
||||
};
|
||||
|
||||
private static final Skill[] TEST_SKILLS = {
|
||||
new Skill("WW-SEN", "Struts Senior Developer"),
|
||||
new Skill("WW-JUN", "Struts Junior Developer"),
|
||||
new Skill("SPRING-DEV", "Spring Developer")
|
||||
};
|
||||
private static final Skill[] TEST_SKILLS = {
|
||||
new Skill("WW-SEN", "Struts Senior Developer"),
|
||||
new Skill("WW-JUN", "Struts Junior Developer"),
|
||||
new Skill("SPRING-DEV", "Spring Developer")
|
||||
};
|
||||
|
||||
public static final Employee[] TEST_EMPLOYEES = {
|
||||
new Employee(1L, "Alan", "Smithee", new Date(), 2000f, true, POSITIONS[0],
|
||||
TEST_SKILLS[0], null, "alan", LEVELS[0], "Nice guy"),
|
||||
new Employee(2L, "Robert", "Robson", new Date(), 10000f, false, POSITIONS[1],
|
||||
TEST_SKILLS[1], List.of(TEST_SKILLS).subList(1, TEST_SKILLS.length), "rob", LEVELS[1], "Smart guy")
|
||||
};
|
||||
public static final Employee[] TEST_EMPLOYEES = {
|
||||
new Employee(new Long(1), "Alan", "Smithee", new Date(), new Float(2000f), true, POSITIONS[0],
|
||||
TEST_SKILLS[0], null, "alan", LEVELS[0], "Nice guy"),
|
||||
new Employee(new Long(2), "Robert", "Robson", new Date(), new Float(10000f), false, POSITIONS[1],
|
||||
TEST_SKILLS[1], Arrays.asList(TEST_SKILLS).subList(1, TEST_SKILLS.length), "rob", LEVELS[1], "Smart guy")
|
||||
};
|
||||
|
||||
@Autowired
|
||||
private SkillDao skillDao;
|
||||
@Autowired
|
||||
private SkillDao skillDao;
|
||||
|
||||
@Autowired
|
||||
private EmployeeDao employeeDao;
|
||||
@Autowired
|
||||
private EmployeeDao employeeDao;
|
||||
|
||||
protected void addTestSkills() {
|
||||
try {
|
||||
for (Skill testSkill : TEST_SKILLS) {
|
||||
skillDao.merge(testSkill);
|
||||
}
|
||||
if (log.isInfoEnabled()) {
|
||||
log.info("TestDataProvider - [addTestSkills]: Added test skill data.");
|
||||
}
|
||||
} catch (StorageException e) {
|
||||
log.error("TestDataProvider - [addTestSkills]: Exception caught: {}", e.getMessage());
|
||||
}
|
||||
}
|
||||
protected void addTestSkills() {
|
||||
try {
|
||||
for (int i = 0, j = TEST_SKILLS.length; i < j; i++) {
|
||||
skillDao.merge(TEST_SKILLS[i]);
|
||||
}
|
||||
if (log.isInfoEnabled()) {
|
||||
log.info("TestDataProvider - [addTestSkills]: Added test skill data.");
|
||||
}
|
||||
} catch (StorageException e) {
|
||||
log.error("TestDataProvider - [addTestSkills]: Exception catched: " + e.getMessage());
|
||||
}
|
||||
}
|
||||
|
||||
protected void addTestEmployees() {
|
||||
try {
|
||||
for (Employee testEmployee : TEST_EMPLOYEES) {
|
||||
employeeDao.merge(testEmployee);
|
||||
}
|
||||
if (log.isInfoEnabled()) {
|
||||
log.info("TestDataProvider - [addTestEmployees]: Added test employee data.");
|
||||
}
|
||||
} catch (StorageException e) {
|
||||
log.error("TestDataProvider - [addTestEmployees]: Exception caught: {}", e.getMessage());
|
||||
}
|
||||
}
|
||||
protected void addTestEmployees() {
|
||||
try {
|
||||
for (int i = 0, j = TEST_EMPLOYEES.length; i < j; i++) {
|
||||
employeeDao.merge(TEST_EMPLOYEES[i]);
|
||||
}
|
||||
if (log.isInfoEnabled()) {
|
||||
log.info("TestDataProvider - [addTestEmployees]: Added test employee data.");
|
||||
}
|
||||
} catch (StorageException e) {
|
||||
log.error("TestDataProvider - [addTestEmployees]: Exception catched: " + e.getMessage());
|
||||
}
|
||||
}
|
||||
|
||||
protected void addTestData() {
|
||||
addTestSkills();
|
||||
addTestEmployees();
|
||||
}
|
||||
protected void addTestData() {
|
||||
addTestSkills();
|
||||
addTestEmployees();
|
||||
}
|
||||
|
||||
@Override
|
||||
public void afterPropertiesSet() throws Exception {
|
||||
addTestData();
|
||||
}
|
||||
public void afterPropertiesSet() throws Exception {
|
||||
addTestData();
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@@ -18,13 +18,13 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.async;
|
||||
|
||||
import jakarta.servlet.Filter;
|
||||
import jakarta.servlet.FilterChain;
|
||||
import jakarta.servlet.FilterConfig;
|
||||
import jakarta.servlet.ServletException;
|
||||
import jakarta.servlet.ServletRequest;
|
||||
import jakarta.servlet.ServletResponse;
|
||||
import jakarta.servlet.http.HttpServletRequest;
|
||||
import javax.servlet.Filter;
|
||||
import javax.servlet.FilterChain;
|
||||
import javax.servlet.FilterConfig;
|
||||
import javax.servlet.ServletException;
|
||||
import javax.servlet.ServletRequest;
|
||||
import javax.servlet.ServletResponse;
|
||||
import javax.servlet.http.HttpServletRequest;
|
||||
import java.io.IOException;
|
||||
|
||||
/**
|
||||
|
||||
@@ -18,8 +18,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.async;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
@@ -35,12 +34,10 @@ public class ChatRoomAction extends ActionSupport {
|
||||
|
||||
private static final List<String> messages = new ArrayList<>();
|
||||
|
||||
@StrutsParameter
|
||||
public void setMessage(String message) {
|
||||
this.message = message;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setLastIndex(Integer lastIndex) {
|
||||
this.lastIndex = lastIndex;
|
||||
}
|
||||
@@ -50,12 +47,15 @@ public class ChatRoomAction extends ActionSupport {
|
||||
}
|
||||
|
||||
public Callable<String> receiveNewMessages() throws Exception {
|
||||
return () -> {
|
||||
while (lastIndex >= messages.size()) {
|
||||
Thread.sleep(3000);
|
||||
return new Callable<String>() {
|
||||
@Override
|
||||
public String call() throws Exception {
|
||||
while (lastIndex >= messages.size()) {
|
||||
Thread.sleep(3000);
|
||||
}
|
||||
newMessages = messages.subList(lastIndex, messages.size());
|
||||
return SUCCESS;
|
||||
}
|
||||
newMessages = messages.subList(lastIndex, messages.size());
|
||||
return SUCCESS;
|
||||
};
|
||||
}
|
||||
|
||||
|
||||
+4
-4
@@ -21,10 +21,10 @@
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
|
||||
import org.apache.struts2.action.Action;
|
||||
import org.apache.struts2.ActionContext;
|
||||
import org.apache.struts2.ActionInvocation;
|
||||
import org.apache.struts2.interceptor.AbstractInterceptor;
|
||||
import com.opensymphony.xwork2.Action;
|
||||
import com.opensymphony.xwork2.ActionContext;
|
||||
import com.opensymphony.xwork2.ActionInvocation;
|
||||
import com.opensymphony.xwork2.interceptor.AbstractInterceptor;
|
||||
import org.apache.logging.log4j.LogManager;
|
||||
import org.apache.logging.log4j.Logger;
|
||||
|
||||
|
||||
@@ -20,10 +20,10 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
import org.apache.struts2.action.Action;
|
||||
import org.apache.struts2.ActionContext;
|
||||
import org.apache.struts2.ActionInvocation;
|
||||
import org.apache.struts2.interceptor.AbstractInterceptor;
|
||||
import com.opensymphony.xwork2.Action;
|
||||
import com.opensymphony.xwork2.ActionContext;
|
||||
import com.opensymphony.xwork2.ActionInvocation;
|
||||
import com.opensymphony.xwork2.interceptor.AbstractInterceptor;
|
||||
import org.apache.logging.log4j.LogManager;
|
||||
import org.apache.logging.log4j.Logger;
|
||||
|
||||
|
||||
@@ -20,9 +20,8 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.action.SessionAware;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.SessionAware;
|
||||
|
||||
import java.util.Map;
|
||||
|
||||
@@ -31,7 +30,7 @@ public class ChatLoginAction extends ActionSupport implements SessionAware {
|
||||
private static final long serialVersionUID = 1L;
|
||||
|
||||
private ChatService chatService;
|
||||
private Map<String, Object> session;
|
||||
private Map session;
|
||||
|
||||
private String name;
|
||||
|
||||
@@ -43,7 +42,6 @@ public class ChatLoginAction extends ActionSupport implements SessionAware {
|
||||
return this.name;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setName(String name) {
|
||||
this.name = name;
|
||||
}
|
||||
@@ -62,8 +60,8 @@ public class ChatLoginAction extends ActionSupport implements SessionAware {
|
||||
}
|
||||
|
||||
|
||||
@Override
|
||||
public void withSession(Map<String, Object> session) {
|
||||
this.session = session;
|
||||
}
|
||||
// === SessionAware ===
|
||||
public void setSession(Map session) {
|
||||
this.session = session;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -20,19 +20,18 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.SessionAware;
|
||||
|
||||
import java.util.Map;
|
||||
|
||||
import org.apache.struts2.action.SessionAware;
|
||||
|
||||
public class ChatLogoutAction extends ActionSupport implements SessionAware {
|
||||
|
||||
private static final long serialVersionUID = 1L;
|
||||
|
||||
private ChatService chatService;
|
||||
|
||||
private Map<String, Object> session;
|
||||
private Map session;
|
||||
|
||||
|
||||
public ChatLogoutAction(ChatService chatService) {
|
||||
@@ -51,8 +50,8 @@ public class ChatLogoutAction extends ActionSupport implements SessionAware {
|
||||
}
|
||||
|
||||
|
||||
@Override
|
||||
public void withSession(Map<String, Object> session) {
|
||||
this.session = session;
|
||||
}
|
||||
// === SessionAware ===
|
||||
public void setSession(Map session) {
|
||||
this.session = session;
|
||||
}
|
||||
}
|
||||
|
||||
+3
-3
@@ -25,9 +25,9 @@ import org.apache.logging.log4j.LogManager;
|
||||
import org.springframework.web.context.WebApplicationContext;
|
||||
import org.springframework.web.context.support.WebApplicationContextUtils;
|
||||
|
||||
import jakarta.servlet.http.HttpSession;
|
||||
import jakarta.servlet.http.HttpSessionEvent;
|
||||
import jakarta.servlet.http.HttpSessionListener;
|
||||
import javax.servlet.http.HttpSession;
|
||||
import javax.servlet.http.HttpSessionEvent;
|
||||
import javax.servlet.http.HttpSessionListener;
|
||||
|
||||
public class ChatSessionListener implements HttpSessionListener {
|
||||
|
||||
|
||||
@@ -20,8 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
public class CrudRoomAction extends ActionSupport {
|
||||
|
||||
@@ -37,7 +36,6 @@ public class CrudRoomAction extends ActionSupport {
|
||||
return description;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setDescription(String description) {
|
||||
this.description = description;
|
||||
}
|
||||
@@ -46,7 +44,6 @@ public class CrudRoomAction extends ActionSupport {
|
||||
return name;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setName(String name) {
|
||||
this.name = name;
|
||||
}
|
||||
|
||||
@@ -20,8 +20,8 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
import org.apache.struts2.conversion.impl.XWorkConverter;
|
||||
import org.apache.struts2.inject.Inject;
|
||||
import com.opensymphony.xwork2.conversion.impl.XWorkConverter;
|
||||
import com.opensymphony.xwork2.inject.Inject;
|
||||
import org.apache.logging.log4j.Logger;
|
||||
import org.apache.logging.log4j.LogManager;
|
||||
import org.apache.struts2.util.StrutsTypeConverter;
|
||||
|
||||
@@ -20,9 +20,8 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.action.SessionAware;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.SessionAware;
|
||||
|
||||
import java.util.Map;
|
||||
|
||||
@@ -31,14 +30,13 @@ public class EnterRoomAction extends ActionSupport implements SessionAware {
|
||||
private static final long serialVersionUID = 1L;
|
||||
|
||||
private ChatService chatService;
|
||||
private Map<String, Object> session;
|
||||
private Map session;
|
||||
private String roomName;
|
||||
|
||||
public String getRoomName() {
|
||||
return this.roomName;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setRoomName(String roomName) {
|
||||
this.roomName = roomName;
|
||||
}
|
||||
@@ -58,9 +56,10 @@ public class EnterRoomAction extends ActionSupport implements SessionAware {
|
||||
return SUCCESS;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void withSession(Map<String, Object> session) {
|
||||
this.session = session;
|
||||
}
|
||||
|
||||
// === SessionAware ===
|
||||
public void setSession(Map session) {
|
||||
this.session = session;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@@ -20,9 +20,8 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.action.SessionAware;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.SessionAware;
|
||||
|
||||
import java.util.Map;
|
||||
|
||||
@@ -32,13 +31,12 @@ public class ExitRoomAction extends ActionSupport implements SessionAware {
|
||||
|
||||
private String roomName;
|
||||
|
||||
private Map<String, Object> session;
|
||||
private Map session;
|
||||
|
||||
public String getRoomName() {
|
||||
return roomName;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setRoomName(String roomName) {
|
||||
this.roomName = roomName;
|
||||
}
|
||||
@@ -56,9 +54,9 @@ public class ExitRoomAction extends ActionSupport implements SessionAware {
|
||||
return SUCCESS;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void withSession(Map<String, Object> session) {
|
||||
this.session = session;
|
||||
}
|
||||
// === SessionAware ===
|
||||
public void setSession(Map session) {
|
||||
this.session = session;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
+3
-5
@@ -20,8 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
@@ -31,14 +30,13 @@ public class MessagesAvailableInRoomAction extends ActionSupport {
|
||||
private static final long serialVersionUID = 1L;
|
||||
|
||||
private String roomName;
|
||||
private final ChatService chatService;
|
||||
private List<ChatMessage> messagesAvailableInRoom = new ArrayList<>();
|
||||
private ChatService chatService;
|
||||
private List<ChatMessage> messagesAvailableInRoom = new ArrayList<ChatMessage>();
|
||||
|
||||
public String getRoomName() {
|
||||
return this.roomName;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setRoomName(String roomName) {
|
||||
this.roomName = roomName;
|
||||
}
|
||||
|
||||
+1
-1
@@ -20,7 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
|
||||
+8
-12
@@ -20,9 +20,8 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.action.SessionAware;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.SessionAware;
|
||||
|
||||
import java.util.Map;
|
||||
|
||||
@@ -30,11 +29,11 @@ public class SendMessageToRoomAction extends ActionSupport implements SessionAwa
|
||||
|
||||
private static final long serialVersionUID = 1L;
|
||||
|
||||
private final ChatService chatService;
|
||||
private ChatService chatService;
|
||||
|
||||
private String roomName;
|
||||
private String message;
|
||||
private Map<String, Object> session;
|
||||
private Map session;
|
||||
|
||||
|
||||
public SendMessageToRoomAction(ChatService chatService) {
|
||||
@@ -45,7 +44,6 @@ public class SendMessageToRoomAction extends ActionSupport implements SessionAwa
|
||||
return this.roomName;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setRoomName(String roomName) {
|
||||
this.roomName = roomName;
|
||||
}
|
||||
@@ -54,12 +52,11 @@ public class SendMessageToRoomAction extends ActionSupport implements SessionAwa
|
||||
return this.message;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setMessage(String message) {
|
||||
this.message = message;
|
||||
}
|
||||
|
||||
@Override
|
||||
|
||||
public String execute() throws Exception {
|
||||
User user = (User) session.get(ChatAuthenticationInterceptor.USER_SESSION_KEY);
|
||||
try {
|
||||
@@ -70,10 +67,9 @@ public class SendMessageToRoomAction extends ActionSupport implements SessionAwa
|
||||
return SUCCESS;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void withSession(Map<String, Object> session) {
|
||||
this.session = session;
|
||||
}
|
||||
public void setSession(Map session) {
|
||||
this.session = session;
|
||||
}
|
||||
|
||||
|
||||
}
|
||||
|
||||
+1
-1
@@ -20,7 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
|
||||
+3
-6
@@ -20,8 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.chat;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
@@ -30,8 +29,8 @@ public class UsersAvailableInRoomAction extends ActionSupport {
|
||||
|
||||
private static final long serialVersionUID = 1L;
|
||||
|
||||
private final ChatService chatService;
|
||||
private List<User> usersAvailableInRoom = new ArrayList<>();
|
||||
private ChatService chatService;
|
||||
private List<User> usersAvailableInRoom = new ArrayList<User>();
|
||||
|
||||
private String roomName;
|
||||
|
||||
@@ -44,7 +43,6 @@ public class UsersAvailableInRoomAction extends ActionSupport {
|
||||
return this.roomName;
|
||||
}
|
||||
|
||||
@StrutsParameter
|
||||
public void setRoomName(String roomName) {
|
||||
this.roomName = roomName;
|
||||
}
|
||||
@@ -53,7 +51,6 @@ public class UsersAvailableInRoomAction extends ActionSupport {
|
||||
return usersAvailableInRoom;
|
||||
}
|
||||
|
||||
@Override
|
||||
public String execute() throws Exception {
|
||||
try {
|
||||
usersAvailableInRoom = chatService.getUsersAvailableInRoom(roomName);
|
||||
|
||||
+2
-4
@@ -20,8 +20,7 @@
|
||||
*/
|
||||
package org.apache.struts2.showcase.conversion;
|
||||
|
||||
import org.apache.struts2.ActionSupport;
|
||||
import org.apache.struts2.interceptor.parameter.StrutsParameter;
|
||||
import com.opensymphony.xwork2.ActionSupport;
|
||||
|
||||
import java.util.LinkedHashSet;
|
||||
import java.util.Set;
|
||||
@@ -31,7 +30,7 @@ import java.util.Set;
|
||||
*/
|
||||
public class AddressAction extends ActionSupport {
|
||||
|
||||
private Set<Address> addresses = new LinkedHashSet<>();
|
||||
private Set<Address> addresses = new LinkedHashSet<Address>();
|
||||
|
||||
public String input() throws Exception {
|
||||
return SUCCESS;
|
||||
@@ -42,7 +41,6 @@ public class AddressAction extends ActionSupport {
|
||||
return SUCCESS;
|
||||
}
|
||||
|
||||
@StrutsParameter(depth = 2)
|
||||
public Set<Address> getAddresses() {
|
||||
return addresses;
|
||||
}
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user