mirror of
https://github.com/apache/struts.git
synced 2026-08-06 15:17:00 +00:00
Lukasz Lenart
b154b7ca43
* ci(owasp): cap job timeout and disable NVD auto-update in check step The OWASP job intermittently failed with no reason other than timeouts. Root cause is the unreliable NIST NVD feed (see dependency-check#8633): keyless NVD downloads are heavily rate-limited and stall. Two fixes: - Add timeout-minutes: 30 so a hung NVD download fails fast instead of dragging to the 6h GitHub Actions default. - Add -DautoUpdate=false to the check step so it reads only the cache populated by the preceding update-only step. Previously the check step carried neither the mirror datafeed URL nor the API key, so on any cache staleness/miss it synced directly against NIST - the unreliable path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * ci(owasp): fall back to NVD mirror when the API update fails The NIST NVD API is unreliable even with an API key (retries exhausted, see dependency-check#8633). Previously the mirror datafeed was used only when no API key was present, so apache/struts always took the flaky API path and never the mirror. Make the API update step continue-on-error and run the mirror update as a fallback when the API step fails (or when no API key is configured). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
101 lines
3.4 KiB
YAML
101 lines
3.4 KiB
YAML
# Licensed to the Apache Software Foundation (ASF) under one or more
|
|
# contributor license agreements. See the NOTICE file distributed with
|
|
# this work for additional information regarding copyright ownership.
|
|
# The ASF licenses this file to You under the Apache License, Version 2.0
|
|
# (the "License"); you may not use this file except in compliance with
|
|
# the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
name: OWASP checkup
|
|
|
|
on:
|
|
pull_request:
|
|
push:
|
|
branches:
|
|
- 'main'
|
|
- 'develop'
|
|
- 'release/*'
|
|
- 'support/*'
|
|
workflow_dispatch: #Allow manual triggers
|
|
|
|
permissions: read-all
|
|
|
|
env:
|
|
MAVEN_OPTS: -Xmx2048m -Xms1024m
|
|
LANG: en_US.utf8
|
|
|
|
jobs:
|
|
|
|
|
|
owasp:
|
|
name: OWASP
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 30
|
|
env:
|
|
HAVE_NIST_NVD_API_KEY: ${{ secrets.NIST_NVD_API_KEY != '' }}
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v7
|
|
- name: Setup Java 25
|
|
uses: actions/setup-java@v5
|
|
with:
|
|
distribution: temurin
|
|
java-version: 25
|
|
cache: 'maven'
|
|
|
|
- name: Cache NVD Database
|
|
id: cache-nvd
|
|
uses: actions/cache/restore@v6
|
|
with:
|
|
path: ~/.m2/repository/org/owasp/dependency-check-data
|
|
key: nvd-cache-${{ runner.os }}-owasp-${{ github.run_id }}
|
|
restore-keys: |
|
|
nvd-cache-${{ runner.os }}-owasp-
|
|
nvd-cache-${{ runner.os }}-
|
|
|
|
- name: OWASP Dependency check update cache via NIST_NVD_API_KEY
|
|
id: nvd-api-update
|
|
if: ${{ env.HAVE_NIST_NVD_API_KEY == 'true' }}
|
|
continue-on-error: true
|
|
run: mvn -N -V -DskipAssembly -Dmaven.test.skip=true -Powasp-nvd-api -Pdependency-update-only --no-transfer-progress
|
|
env:
|
|
NIST_NVD_API_KEY: ${{ secrets.NIST_NVD_API_KEY}}
|
|
|
|
- name: OWASP Dependency check update cache via Mirror
|
|
if: ${{ env.HAVE_NIST_NVD_API_KEY == 'false' || steps.nvd-api-update.outcome == 'failure' }}
|
|
run: mvn -N -V -DskipAssembly -Dmaven.test.skip=true -Powasp-nvd-mirror -Pdependency-update-only --no-transfer-progress
|
|
|
|
- name: Cache NVD Database
|
|
uses: actions/cache/save@v6
|
|
if: ${{ always() }}
|
|
with:
|
|
path: ~/.m2/repository/org/owasp/dependency-check-data
|
|
key: nvd-cache-${{ runner.os }}-owasp-${{ github.run_id }}
|
|
|
|
- name: OWASP check (Without running tests)
|
|
run: mvn -B org.owasp:dependency-check-maven:aggregate -Pdependency-check -Pjakartaee11 -DautoUpdate=false --no-transfer-progress
|
|
|
|
- name: Upload Dependency Check reports
|
|
uses: actions/upload-artifact@v7
|
|
if: always()
|
|
with:
|
|
name: dependency-check
|
|
path: target/dependency-check*
|
|
|
|
- name: Add OWASP summary
|
|
if: always()
|
|
run: |
|
|
{
|
|
echo "## OWASP Dependency Check"
|
|
echo ""
|
|
echo "The HTML report has been uploaded as the **dependency-check** artifact."
|
|
echo "Download it from the Artifacts section of this workflow run."
|
|
} >> "$GITHUB_STEP_SUMMARY"
|