Cwikius-Spring/spring-security
1
0
Fork 0
mirror of synced 2026-07-19 17:45:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Save query parameters in WebSessionServerRequestCache

Browse Source 
Previously, URL query parameters were lost when saving a request
in WebSessionServerRequestCache. Now it is properly saved and
restored.

Fixes: gh-6421
This commit is contained in:
Denis Washington
2019-01-15 13:56:21 +01:00
committed by Rob Winch
parent 7f2f12c428
commit 548dc4496c
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/src/main/java/org/springframework/security/web/server/savedrequest/WebSessionServerRequestCache.java
+3 -1
View File
@@ -90,7 +90,9 @@ public class WebSessionServerRequestCache implements ServerRequestCache {
}
private static String pathInApplication(ServerHttpRequest request) {
return request.getPath().pathWithinApplication().value();
String path = request.getPath().pathWithinApplication().value();
String query = request.getURI().getRawQuery();
return path + (query != null ? "?" + query : "");
}
private static ServerWebExchangeMatcher createDefaultRequestMacher() {
web/src/test/java/org/springframework/security/web/server/savedrequest/WebSessionServerRequestCacheTests.java
+10
View File
@@ -44,6 +44,16 @@ public class WebSessionServerRequestCacheTests {
assertThat(saved).isEqualTo(exchange.getRequest().getURI());
}
@Test
public void saveRequestGetRequestWithQueryParamsWhenGetThenFound() {
MockServerWebExchange exchange = MockServerWebExchange.from(MockServerHttpRequest.get("/secured/").queryParam("key", "value").accept(MediaType.TEXT_HTML));
this.cache.saveRequest(exchange).block();
URI saved = this.cache.getRedirectUri(exchange).block();
assertThat(saved).isEqualTo(exchange.getRequest().getURI());
}
@Test
public void saveRequestGetRequestWhenFaviconThenNotFound() {
MockServerWebExchange exchange = MockServerWebExchange.from(MockServerHttpRequest.get("/favicon.png").accept(MediaType.TEXT_HTML));