Adding assertions on constructor arg values.

core/src/main/java/org/springframework/security/access/vote/AbstractAccessDecisionManager.java

@@ -54,6 +54,7 @@ public abstract class AbstractAccessDecisionManager implements AccessDecisionMan
     }
 
     protected AbstractAccessDecisionManager(List<AccessDecisionVoter> decisionVoters) {
+        Assert.notEmpty(decisionVoters, "A list of AccessDecisionVoters is required");
         this.decisionVoters = decisionVoters;
     }
 

core/src/main/java/org/springframework/security/authentication/ProviderManager.java

@@ -100,13 +100,19 @@ public class ProviderManager implements AuthenticationManager, MessageSourceAwar
     }
 
     public ProviderManager(List<AuthenticationProvider> providers, AuthenticationManager parent) {
+        Assert.notNull(providers, "providers list cannot be null");
         this.providers = providers;
         this.parent = parent;
+        checkState();
     }
 
     //~ Methods ========================================================================================================
 
     public void afterPropertiesSet() throws Exception {
+        checkState();
+    }
+
+    private void checkState() {
         if (parent == null && providers.isEmpty()) {
             throw new IllegalArgumentException("A parent AuthenticationManager or a list " +
                     "of AuthenticationProviders is required");

web/src/main/java/org/springframework/security/web/access/ExceptionTranslationFilter.java

@@ -91,6 +91,8 @@ public class ExceptionTranslationFilter extends GenericFilterBean {
     }
 
     public ExceptionTranslationFilter(AuthenticationEntryPoint authenticationEntryPoint, RequestCache requestCache) {
+        Assert.notNull(authenticationEntryPoint, "authenticationEntryPoint cannot be null");
+        Assert.notNull(requestCache, "requestCache cannot be null");
         this.authenticationEntryPoint = authenticationEntryPoint;
         this.requestCache = requestCache;
     }

web/src/main/java/org/springframework/security/web/authentication/rememberme/AbstractRememberMeServices.java

@@ -60,13 +60,15 @@ public abstract class AbstractRememberMeServices implements RememberMeServices,
     private GrantedAuthoritiesMapper authoritiesMapper = new NullAuthoritiesMapper();
 
     /**
-     * @deprecated Use cosntructor injection
+     * @deprecated Use constructor injection
      */
     @Deprecated
     protected AbstractRememberMeServices() {
     }
 
     protected AbstractRememberMeServices(String key, UserDetailsService userDetailsService) {
+        Assert.hasLength(key, "key cannot be empty or null");
+        Assert.notNull(userDetailsService, "UserDetailsService cannot be null");
         this.key = key;
         this.userDetailsService = userDetailsService;
     }

web/src/main/java/org/springframework/security/web/savedrequest/RequestCacheAwareFilter.java

@@ -9,6 +9,7 @@ import javax.servlet.ServletResponse;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
+import org.springframework.util.Assert;
 import org.springframework.web.filter.GenericFilterBean;
 
 /**
@@ -31,6 +32,7 @@ public class RequestCacheAwareFilter extends GenericFilterBean {
     }
 
     public RequestCacheAwareFilter(RequestCache requestCache) {
+        Assert.notNull(requestCache, "requestCache cannot be null");
         this.requestCache = requestCache;
     }
 

web/src/main/java/org/springframework/security/web/session/SessionManagementFilter.java

@@ -52,6 +52,8 @@ public class SessionManagementFilter extends GenericFilterBean {
     }
 
     public SessionManagementFilter(SecurityContextRepository securityContextRepository, SessionAuthenticationStrategy sessionStrategy) {
+        Assert.notNull(securityContextRepository, "SecurityContextRepository cannot be null");
+        Assert.notNull(sessionStrategy, "SessionAuthenticationStrategy cannot be null");
         this.securityContextRepository = securityContextRepository;
         this.sessionStrategy = sessionStrategy;
     }