Move to appropriate location.

acl/pom.xml

@@ -3,13 +3,13 @@
     <parent>
         <artifactId>spring-security-parent</artifactId>
         <groupId>org.springframework.security</groupId>
-        <version>2.0.3</version>
+        <version>2.0.1</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
     <groupId>org.springframework.security</groupId>
     <artifactId>spring-security-acl</artifactId>
     <name>Spring Security - ACL module</name>
-    <version>2.0.3</version>
+    <version>2.0.1</version>
     <packaging>bundle</packaging>
 
     <dependencies>
@@ -48,12 +48,12 @@
     
     <properties>
         <spring.osgi.export>
-            org.springframework.security.*;version=${pom.version.osgi}
+            org.springframework.security.*;version=${pom.version}
         </spring.osgi.export>
             
         <spring.osgi.import>
             net.sf.ehcache.*;version="[1.4.1, 2.0.0)";resolution:=optional,
-            org.springframework.security.*;version="[${pom.version.osgi},${pom.version.osgi}]",
+            org.springframework.security.*;version="[${pom.version},${pom.version}]",
             org.springframework.context.*;version="${spring.version.osgi}",
             org.springframework.dao.*;version="${spring.version.osgi}";resolution:=optional,
             org.springframework.jdbc.*;version="${spring.version.osgi}";resolution:=optional,

acl/src/main/java/org/springframework/security/acls/domain/AbstractPermission.java

@@ -1,59 +0,0 @@
-package org.springframework.security.acls.domain;
-
-import org.springframework.security.acls.AclFormattingUtils;
-import org.springframework.security.acls.Permission;
-
-/**
- * Provides an abstract superclass for {@link Permission} implementations.
- * 
- * @author Ben Alex
- * @since 2.0.3
- * @see AbstractRegisteredPermission
- * 
- */
-public abstract class AbstractPermission implements Permission {
-
-    //~ Instance fields ================================================================================================
-
-    protected char code;
-    protected int mask;
-
-    //~ Constructors ===================================================================================================
-
-    protected AbstractPermission(int mask, char code) {
-        this.mask = mask;
-        this.code = code;
-    }
-
-    //~ Methods ========================================================================================================
-
-    public final boolean equals(Object arg0) {
-        if (arg0 == null) {
-            return false;
-        }
-
-        if (!(arg0 instanceof Permission)) {
-            return false;
-        }
-
-        Permission rhs = (Permission) arg0;
-
-        return (this.mask == rhs.getMask());
-    }
-
-    public final int getMask() {
-        return mask;
-    }
-
-    public String getPattern() {
-        return AclFormattingUtils.printBinary(mask, code);
-    }
-
-    public final String toString() {
-        return this.getClass().getSimpleName() + "[" + getPattern() + "=" + mask + "]";
-    }
-
-	public final int hashCode() {
-		return this.mask;
-	}
-}

acl/src/main/java/org/springframework/security/acls/domain/AbstractRegisteredPermission.java

@@ -1,39 +0,0 @@
-package org.springframework.security.acls.domain;
-
-import org.springframework.security.acls.Permission;
-
-/**
- * Provides an abstract base for standard {@link Permission} instances that wish to offer static convenience
- * methods to callers via delegation to {@link DefaultPermissionFactory}.
- * 
- * @author Ben Alex
- * @since 2.0.3
- *
- */
-public abstract class AbstractRegisteredPermission extends AbstractPermission {
-	protected static DefaultPermissionFactory defaultPermissionFactory = new DefaultPermissionFactory();
-
-    protected AbstractRegisteredPermission(int mask, char code) {
-    	super(mask, code);
-    }
-	
-    protected final static void registerPermissionsFor(Class subClass) {
-    	defaultPermissionFactory.registerPublicPermissions(subClass);
-    }
-    
-    public final static Permission buildFromMask(int mask) {
-        return defaultPermissionFactory.buildFromMask(mask);
-    }
-
-    public final static Permission[] buildFromMask(int[] masks) {
-        return defaultPermissionFactory.buildFromMask(masks);
-    }
-
-    public final static Permission buildFromName(String name) {
-    	return defaultPermissionFactory.buildFromName(name);
-    }
-
-    public final static Permission[] buildFromName(String[] names) {
-        return defaultPermissionFactory.buildFromName(names);
-    }
-}

acl/src/main/java/org/springframework/security/acls/domain/BasePermission.java

@@ -14,36 +14,157 @@
  */
 package org.springframework.security.acls.domain;
 
+import org.springframework.security.acls.AclFormattingUtils;
 import org.springframework.security.acls.Permission;
 
+import org.springframework.util.Assert;
+
+import java.lang.reflect.Field;
+
+import java.util.HashMap;
+import java.util.Map;
+
 
 /**
  * A set of standard permissions.
- * 
- * <p>
- * You may subclass this class to add additional permissions, or use this class as a guide
- * for creating your own permission classes.
- * </p>
- * 
+ *
  * @author Ben Alex
  * @version $Id$
  */
-public class BasePermission extends AbstractRegisteredPermission {
+public final class BasePermission implements Permission {
+    //~ Static fields/initializers =====================================================================================
+
     public static final Permission READ = new BasePermission(1 << 0, 'R'); // 1
     public static final Permission WRITE = new BasePermission(1 << 1, 'W'); // 2
     public static final Permission CREATE = new BasePermission(1 << 2, 'C'); // 4
     public static final Permission DELETE = new BasePermission(1 << 3, 'D'); // 8
     public static final Permission ADMINISTRATION = new BasePermission(1 << 4, 'A'); // 16
-    
-    /**
-     * Registers the public static permissions defined on this class. This is mandatory so
-     * that the static methods will operate correctly.
-     */
+    private static Map locallyDeclaredPermissionsByInteger = new HashMap();
+    private static Map locallyDeclaredPermissionsByName = new HashMap();
+
     static {
-    	registerPermissionsFor(BasePermission.class);
+        Field[] fields = BasePermission.class.getDeclaredFields();
+
+        for (int i = 0; i < fields.length; i++) {
+            try {
+                Object fieldValue = fields[i].get(null);
+
+                if (BasePermission.class.isAssignableFrom(fieldValue.getClass())) {
+                    // Found a BasePermission static field
+                    BasePermission perm = (BasePermission) fieldValue;
+                    locallyDeclaredPermissionsByInteger.put(new Integer(perm.getMask()), perm);
+                    locallyDeclaredPermissionsByName.put(fields[i].getName(), perm);
+                }
+            } catch (Exception ignore) {}
+        }
     }
 
-    protected BasePermission(int mask, char code) {
-    	super(mask, code);
+    //~ Instance fields ================================================================================================
+
+    private char code;
+    private int mask;
+
+    //~ Constructors ===================================================================================================
+
+    private BasePermission(int mask, char code) {
+        this.mask = mask;
+        this.code = code;
     }
+
+    //~ Methods ========================================================================================================
+
+    /**
+     * Dynamically creates a <code>CumulativePermission</code> or <code>BasePermission</code> representing the
+     * active bits in the passed mask.
+     *
+     * @param mask to build
+     *
+     * @return a Permission representing the requested object
+     */
+    public static Permission buildFromMask(int mask) {
+        if (locallyDeclaredPermissionsByInteger.containsKey(new Integer(mask))) {
+            // The requested mask has an exactly match against a statically-defined BasePermission, so return it
+            return (Permission) locallyDeclaredPermissionsByInteger.get(new Integer(mask));
+        }
+
+        // To get this far, we have to use a CumulativePermission
+        CumulativePermission permission = new CumulativePermission();
+
+        for (int i = 0; i < 32; i++) {
+            int permissionToCheck = 1 << i;
+
+            if ((mask & permissionToCheck) == permissionToCheck) {
+                Permission p = (Permission) locallyDeclaredPermissionsByInteger.get(new Integer(permissionToCheck));
+                Assert.state(p != null,
+                    "Mask " + permissionToCheck + " does not have a corresponding static BasePermission");
+                permission.set(p);
+            }
+        }
+
+        return permission;
+    }
+
+    public static Permission[] buildFromMask(int[] masks) {
+        if ((masks == null) || (masks.length == 0)) {
+            return new Permission[0];
+        }
+
+        Permission[] permissions = new Permission[masks.length];
+
+        for (int i = 0; i < masks.length; i++) {
+            permissions[i] = buildFromMask(masks[i]);
+        }
+
+        return permissions;
+    }
+
+    public static Permission buildFromName(String name) {
+        Assert.isTrue(locallyDeclaredPermissionsByName.containsKey(name), "Unknown permission '" + name + "'");
+
+        return (Permission) locallyDeclaredPermissionsByName.get(name);
+    }
+
+    public static Permission[] buildFromName(String[] names) {
+        if ((names == null) || (names.length == 0)) {
+            return new Permission[0];
+        }
+
+        Permission[] permissions = new Permission[names.length];
+
+        for (int i = 0; i < names.length; i++) {
+            permissions[i] = buildFromName(names[i]);
+        }
+
+        return permissions;
+    }
+
+    public boolean equals(Object arg0) {
+        if (arg0 == null) {
+            return false;
+        }
+
+        if (!(arg0 instanceof Permission)) {
+            return false;
+        }
+
+        Permission rhs = (Permission) arg0;
+
+        return (this.mask == rhs.getMask());
+    }
+
+    public int getMask() {
+        return mask;
+    }
+
+    public String getPattern() {
+        return AclFormattingUtils.printBinary(mask, code);
+    }
+
+    public String toString() {
+        return "BasePermission[" + getPattern() + "=" + mask + "]";
+    }
+
+	public int hashCode() {
+		return this.mask;
+	}
 }

acl/src/main/java/org/springframework/security/acls/domain/CumulativePermission.java

@@ -19,21 +19,20 @@ import org.springframework.security.acls.Permission;
 
 
 /**
- * Represents a <code>Permission</code> that is constructed at runtime from other permissions.
- * 
- * <p>Methods return <code>this</code>, in order to facilitate method chaining.</p>
+ * Represents a <code>Permission</code> that is constructed at runtime from other permissions.<p>Methods return
+ * <code>this</code>, in order to facilitate method chaining.</p>
  *
  * @author Ben Alex
  * @version $Id$
  */
-public class CumulativePermission extends AbstractPermission {
+public class CumulativePermission implements Permission {
+    //~ Instance fields ================================================================================================
 
     private String pattern = THIRTY_TWO_RESERVED_OFF;
+    private int mask = 0;
+
+    //~ Methods ========================================================================================================
 
-    public CumulativePermission() {
-    	super(0, ' ');
-    }
-    
     public CumulativePermission clear(Permission permission) {
         this.mask &= ~permission.getMask();
         this.pattern = AclFormattingUtils.demergePatterns(this.pattern, permission.getPattern());
@@ -47,16 +46,43 @@ public class CumulativePermission extends AbstractPermission {
 
         return this;
     }
+
     
+    public boolean equals(Object arg0) {
+        if (arg0 == null)
+        {
+            return false;
+        }
+        
+        if (!(arg0 instanceof Permission)) {
+            return false;
+        }
+
+        Permission rhs = (Permission) arg0;
+
+        return (this.mask == rhs.getMask());
+    }
+
+	public int hashCode() {
+		return this.mask;
+	}
+
+	public int getMask() {
+        return this.mask;
+    }
+
+    public String getPattern() {
+        return this.pattern;
+    }
+
     public CumulativePermission set(Permission permission) {
         this.mask |= permission.getMask();
         this.pattern = AclFormattingUtils.mergePatterns(this.pattern, permission.getPattern());
 
         return this;
     }
-    
-    public String getPattern() {
-        return this.pattern;
-    }
 
+    public String toString() {
+        return "CumulativePermission[" + pattern + "=" + this.mask + "]";
+    }
 }

acl/src/main/java/org/springframework/security/acls/domain/DefaultPermissionFactory.java

@@ -1,127 +0,0 @@
-package org.springframework.security.acls.domain;
-
-import java.lang.reflect.Field;
-import java.util.HashMap;
-import java.util.Map;
-
-import org.springframework.security.acls.Permission;
-import org.springframework.security.acls.jdbc.LookupStrategy;
-import org.springframework.util.Assert;
-
-/**
- * Default implementation of {@link PermissionFactory}.
- * 
- * <p>
- * Generally this class will be used by a {@link Permission} instance, as opposed to being dependency
- * injected into a {@link LookupStrategy} or similar. Nevertheless, the latter mode of operation is
- * fully supported (in which case your {@link Permission} implementations probably should extend
- * {@link AbstractPermission} instead of {@link AbstractRegisteredPermission}).
- * </p>
- * 
- * @author Ben Alex
- * @since 2.0.3
- *
- */
-public class DefaultPermissionFactory implements PermissionFactory {
-    private Map registeredPermissionsByInteger = new HashMap();
-    private Map registeredPermissionsByName = new HashMap();
-
-    /**
-     * Permit registration of a {@link DefaultPermissionFactory} class. The class must provide
-     * public static fields of type {@link Permission} to represent the possible permissions.
-     * 
-     * @param clazz a {@link Permission} class with public static fields to register
-     */
-    public void registerPublicPermissions(Class clazz) {
-        Assert.notNull(clazz, "Class required");
-        Assert.isAssignable(Permission.class, clazz);
-        
-    	Field[] fields = clazz.getFields();
-
-        for (int i = 0; i < fields.length; i++) {
-            try {
-                Object fieldValue = fields[i].get(null);
-
-                if (Permission.class.isAssignableFrom(fieldValue.getClass())) {
-                    // Found a Permission static field
-                    Permission perm = (Permission) fieldValue;
-                    String permissionName = fields[i].getName();
-                    
-                    registerPermission(perm, permissionName);
-                }
-            } catch (Exception ignore) {}
-        }
-    }
-
-	public void registerPermission(Permission perm, String permissionName) {
-		Assert.notNull(perm, "Permission required");
-		Assert.hasText(permissionName, "Permission name required");
-		
-		Integer mask = new Integer(perm.getMask());
-
-		// Ensure no existing Permission uses this integer or code
-		Assert.isTrue(!registeredPermissionsByInteger.containsKey(mask), "An existing Permission already provides mask " + mask);
-		Assert.isTrue(!registeredPermissionsByName.containsKey(permissionName), "An existing Permission already provides name '" + permissionName + "'");
-		
-		// Register the new Permission
-		registeredPermissionsByInteger.put(mask, perm);
-		registeredPermissionsByName.put(permissionName, perm);
-	}
-    
-    public Permission buildFromMask(int mask) {
-        if (registeredPermissionsByInteger.containsKey(new Integer(mask))) {
-            // The requested mask has an exactly match against a statically-defined Permission, so return it
-            return (Permission) registeredPermissionsByInteger.get(new Integer(mask));
-        }
-
-        // To get this far, we have to use a CumulativePermission
-        CumulativePermission permission = new CumulativePermission();
-
-        for (int i = 0; i < 32; i++) {
-            int permissionToCheck = 1 << i;
-
-            if ((mask & permissionToCheck) == permissionToCheck) {
-                Permission p = (Permission) registeredPermissionsByInteger.get(new Integer(permissionToCheck));
-                Assert.state(p != null, "Mask " + permissionToCheck + " does not have a corresponding static Permission");
-                permission.set(p);
-            }
-        }
-
-        return permission;
-    }
-
-    public Permission[] buildFromMask(int[] masks) {
-        if ((masks == null) || (masks.length == 0)) {
-            return new Permission[0];
-        }
-
-        Permission[] permissions = new Permission[masks.length];
-
-        for (int i = 0; i < masks.length; i++) {
-            permissions[i] = buildFromMask(masks[i]);
-        }
-
-        return permissions;
-    }
-
-    public Permission buildFromName(String name) {
-        Assert.isTrue(registeredPermissionsByName.containsKey(name), "Unknown permission '" + name + "'");
-
-        return (Permission) registeredPermissionsByName.get(name);
-    }
-
-    public Permission[] buildFromName(String[] names) {
-        if ((names == null) || (names.length == 0)) {
-            return new Permission[0];
-        }
-
-        Permission[] permissions = new Permission[names.length];
-
-        for (int i = 0; i < names.length; i++) {
-            permissions[i] = buildFromName(names[i]);
-        }
-
-        return permissions;
-    }
-    
-}

acl/src/main/java/org/springframework/security/acls/domain/PermissionFactory.java

@@ -1,24 +0,0 @@
-package org.springframework.security.acls.domain;
-
-import org.springframework.security.acls.Permission;
-
-/**
- * Provides a simple mechanism to retrieve {@link Permission} instances from integer masks.
- * 
- * @author Ben Alex
- * @since 2.0.3
- * 
- */
-public interface PermissionFactory {
-
-	/**
-	 * Dynamically creates a <code>CumulativePermission</code> or <code>BasePermission</code> representing the
-	 * active bits in the passed mask.
-	 *
-	 * @param mask to build
-	 *
-	 * @return a Permission representing the requested object
-	 */
-	public abstract Permission buildFromMask(int mask);
-
-}

acl/src/main/java/org/springframework/security/acls/jdbc/BasicLookupStrategy.java

@@ -49,7 +49,6 @@ import org.springframework.security.acls.sid.PrincipalSid;
 import org.springframework.security.acls.sid.Sid;
 import org.springframework.security.util.FieldUtils;
 import org.springframework.util.Assert;
-import org.springframework.util.StringUtils;
 
 
 /**
@@ -240,8 +239,7 @@ public final class BasicLookupStrategy implements LookupStrategy {
                 recipient = new GrantedAuthoritySid(rs.getString("ace_sid"));
             }
 
-            int mask = rs.getInt("mask");
-			Permission permission = convertMaskIntoPermission(mask);
+            Permission permission = BasePermission.buildFromMask(rs.getInt("mask"));
             boolean granting = rs.getBoolean("granting");
             boolean auditSuccess = rs.getBoolean("audit_success");
             boolean auditFailure = rs.getBoolean("audit_failure");
@@ -266,10 +264,6 @@ public final class BasicLookupStrategy implements LookupStrategy {
         }
     }
 
-	protected Permission convertMaskIntoPermission(int mask) {
-		return BasePermission.buildFromMask(mask);
-	}
-
     /**
      * Looks up a batch of <code>ObjectIdentity</code>s directly from the database.<p>The caller is responsible
      * for optimization issues, such as selecting the identities to lookup, ensuring the cache doesn't contain them
@@ -299,10 +293,10 @@ public final class BasicLookupStrategy implements LookupStrategy {
                     for (int i = 0; i < objectIdentities.length; i++) {
                         // Determine prepared statement values for this iteration
                         String javaType = objectIdentities[i].getJavaType().getName();
+                        Assert.isInstanceOf(Long.class, objectIdentities[i].getIdentifier(),
+                            "This class requires ObjectIdentity.getIdentifier() to be a Long");
 
-                        // No need to check for nulls, as guaranteed non-null by ObjectIdentity.getIdentifier() interface contract
-                        String identifier = objectIdentities[i].getIdentifier().toString();
-                        long id = (Long.valueOf(identifier)).longValue();
+                        long id = ((Long) objectIdentities[i].getIdentifier()).longValue();
 
                         // Inject values
                         ps.setLong((2 * i) + 1, id);

acl/src/main/java/org/springframework/security/acls/jdbc/JdbcAclService.java

@@ -53,7 +53,7 @@ public class JdbcAclService implements AclService {
     //~ Static fields/initializers =====================================================================================
 
     protected static final Log log = LogFactory.getLog(JdbcAclService.class);
-    private static final String selectAclObjectWithParent = "select obj.object_id_identity as obj_id, class.class as class "
+    private static final String selectAclObjectWithParent = "select obj.object_id_identity obj_id, class.class class "
         + "from acl_object_identity obj, acl_object_identity parent, acl_class class "
         + "where obj.parent_object = parent.id and obj.object_id_class = class.id "
         + "and parent.object_id_identity = ? and parent.object_id_class = ("

acl/src/main/java/org/springframework/security/acls/jdbc/JdbcMutableAclService.java

@@ -64,8 +64,7 @@ public class JdbcMutableAclService extends JdbcAclService implements MutableAclS
     private AclCache aclCache;
     private String deleteEntryByObjectIdentityForeignKey = "delete from acl_entry where acl_object_identity=?";
     private String deleteObjectIdentityByPrimaryKey = "delete from acl_object_identity where id=?";
-    private String classIdentityQuery = "call identity()"; // should be overridden for postgres : select currval('acl_class_seq')
-    private String sidIdentityQuery = "call identity()"; // should be overridden for postgres : select currval('acl_siq_seq')
+    private String identityQuery = "call identity()";
     private String insertClass = "insert into acl_class (class) values (?)";
     private String insertEntry = "insert into acl_entry "
         + "(acl_object_identity, ace_order, sid, mask, granting, audit_success, audit_failure)"
@@ -177,7 +176,7 @@ public class JdbcMutableAclService extends JdbcAclService implements MutableAclS
                 jdbcTemplate.update(insertClass, new Object[] {clazz.getName()});
                 Assert.isTrue(TransactionSynchronizationManager.isSynchronizationActive(),
                         "Transaction must be running");
-                classId = new Long(jdbcTemplate.queryForLong(classIdentityQuery));
+                classId = new Long(jdbcTemplate.queryForLong(identityQuery));
             }
         } else {
             classId = (Long) classIds.iterator().next();
@@ -222,7 +221,7 @@ public class JdbcMutableAclService extends JdbcAclService implements MutableAclS
                 jdbcTemplate.update(insertSid, new Object[] {new Boolean(principal), sidName});
                 Assert.isTrue(TransactionSynchronizationManager.isSynchronizationActive(),
                         "Transaction must be running");
-                sidId = new Long(jdbcTemplate.queryForLong(sidIdentityQuery));
+                sidId = new Long(jdbcTemplate.queryForLong(identityQuery));
             }
         } else {
             sidId = (Long) sidIds.iterator().next();
@@ -381,15 +380,11 @@ public class JdbcMutableAclService extends JdbcAclService implements MutableAclS
         }
     }
 
-	public void setClassIdentityQuery(String identityQuery) {
+	public void setIdentityQuery(String identityQuery) {
 		Assert.hasText(identityQuery, "New identity query is required");
-		this.classIdentityQuery = identityQuery;
+		this.identityQuery = identityQuery;
 	}
 
-	public void setSidIdentityQuery(String identityQuery) {
-		Assert.hasText(identityQuery, "New identity query is required");
-		this.sidIdentityQuery = identityQuery;
-	}
 	/**
 	 * @param foreignKeysInDatabase if false this class will perform additional FK constrain checking, which may
 	 * cause deadlocks (the default is true, so deadlocks are avoided but the database is expected to enforce FKs)

acl/src/main/java/org/springframework/security/acls/objectidentity/ObjectIdentityImpl.java

@@ -15,7 +15,6 @@
 package org.springframework.security.acls.objectidentity;
 
 import org.springframework.security.acls.IdentityUnavailableException;
-import org.springframework.security.acls.jdbc.LookupStrategy;
 
 import org.springframework.util.Assert;
 import org.springframework.util.ClassUtils;
@@ -98,12 +97,6 @@ public class ObjectIdentityImpl implements ObjectIdentity {
     /**
      * Important so caching operates properly.<P>Considers an object of the same class equal if it has the same
      * <code>classname</code> and <code>id</code> properties.</p>
-     * 
-     * <p>
-     * Note that this class uses string equality for the identifier field, which ensures it better supports
-     * differences between {@link LookupStrategy} requirements and the domain object represented by this
-     * <code>ObjectIdentityImpl</code>.
-     * </p>
      *
      * @param arg0 object to compare
      *
@@ -120,7 +113,7 @@ public class ObjectIdentityImpl implements ObjectIdentity {
 
         ObjectIdentityImpl other = (ObjectIdentityImpl) arg0;
 
-        if (this.getIdentifier().toString().equals(other.getIdentifier().toString()) && this.getJavaType().equals(other.getJavaType())) {
+        if (this.getIdentifier().equals(other.getIdentifier()) && this.getJavaType().equals(other.getJavaType())) {
             return true;
         }
 

acl/src/main/java/org/springframework/security/afterinvocation/AbstractAclProvider.java

@@ -34,20 +34,20 @@ import org.springframework.util.Assert;
 
 
 /**
- * Abstract {@link AfterInvocationProvider} which provides commonly-used ACL-related services.
+ * DOCUMENT ME!
  *
- * @author Ben Alex
- * @version $Id$
+ * @author $author$
+ * @version $Revision$
   */
 public abstract class AbstractAclProvider implements AfterInvocationProvider {
     //~ Instance fields ================================================================================================
 
-    protected AclService aclService;
-    protected Class processDomainObjectClass = Object.class;
-    protected ObjectIdentityRetrievalStrategy objectIdentityRetrievalStrategy = new ObjectIdentityRetrievalStrategyImpl();
-    protected SidRetrievalStrategy sidRetrievalStrategy = new SidRetrievalStrategyImpl();
-    protected String processConfigAttribute;
-    protected Permission[] requirePermission = {BasePermission.READ};
+    private AclService aclService;
+    private Class processDomainObjectClass = Object.class;
+    private ObjectIdentityRetrievalStrategy objectIdentityRetrievalStrategy = new ObjectIdentityRetrievalStrategyImpl();
+    private SidRetrievalStrategy sidRetrievalStrategy = new SidRetrievalStrategyImpl();
+    private String processConfigAttribute;
+    private Permission[] requirePermission = {BasePermission.READ};
 
     //~ Constructors ===================================================================================================
 

acl/src/test/java/org/springframework/security/acls/domain/PermissionTests.java

@@ -22,7 +22,7 @@ import org.springframework.security.acls.Permission;
 
 
 /**
- * Tests classes associated with Permission.
+ * Tests BasePermission and CumulativePermission.
  *
  * @author Ben Alex
  * @version $Id${date}
@@ -63,9 +63,9 @@ public class PermissionTests {
         assertEquals("CumulativePermission[...............................R=1]",
                 new CumulativePermission().set(BasePermission.READ).toString());
 
-        System.out.println("A =  " + new CumulativePermission().set(SpecialPermission.ENTER).set(BasePermission.ADMINISTRATION).toString());
-        assertEquals("CumulativePermission[..........................EA....=48]",
-                new CumulativePermission().set(SpecialPermission.ENTER).set(BasePermission.ADMINISTRATION).toString());
+        System.out.println("A =  " + new CumulativePermission().set(BasePermission.ADMINISTRATION).toString());
+        assertEquals("CumulativePermission[...........................A....=16]",
+                new CumulativePermission().set(BasePermission.ADMINISTRATION).toString());
 
         System.out.println("RA = "
                 + new CumulativePermission().set(BasePermission.ADMINISTRATION).set(BasePermission.READ).toString());

acl/src/test/java/org/springframework/security/acls/domain/SpecialPermission.java

@@ -1,40 +0,0 @@
-/* Copyright 2004, 2005, 2006 Acegi Technology Pty Limited
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.springframework.security.acls.domain;
-
-import org.springframework.security.acls.Permission;
-
-
-/**
- * A test permission.
- * 
- * @author Ben Alex
- * @version $Id$
- */
-public class SpecialPermission extends BasePermission {
-    public static final Permission ENTER = new SpecialPermission(1 << 5, 'E'); // 32
-    
-    /**
-     * Registers the public static permissions defined on this class. This is mandatory so
-     * that the static methods will operate correctly.
-     */
-    static {
-    	registerPermissionsFor(SpecialPermission.class);
-    }
-
-    protected SpecialPermission(int mask, char code) {
-    	super(mask, code);
-    }
-}

acl/src/test/java/org/springframework/security/acls/jdbc/BasicLookupStrategyTests.java

@@ -120,8 +120,7 @@ public class BasicLookupStrategyTests {
     public void testAclsRetrievalWithDefaultBatchSize() throws Exception {
         ObjectIdentity topParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(100));
         ObjectIdentity middleParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(101));
-        // Deliberately use an integer for the child, to reproduce bug report in SEC-819
-        ObjectIdentity childOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Integer(102));
+        ObjectIdentity childOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(102));
 
         Map map = this.strategy.readAclsById(new ObjectIdentity[] { topParentOid, middleParentOid, childOid }, null);
         checkEntries(topParentOid, middleParentOid, childOid, map);
@@ -129,7 +128,7 @@ public class BasicLookupStrategyTests {
 
     @Test
     public void testAclsRetrievalFromCacheOnly() throws Exception {
-        ObjectIdentity topParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Integer(100));
+        ObjectIdentity topParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(100));
         ObjectIdentity middleParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(101));
         ObjectIdentity childOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(102));
 
@@ -146,7 +145,7 @@ public class BasicLookupStrategyTests {
     @Test
     public void testAclsRetrievalWithCustomBatchSize() throws Exception {
         ObjectIdentity topParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(100));
-        ObjectIdentity middleParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Integer(101));
+        ObjectIdentity middleParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(101));
         ObjectIdentity childOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(102));
 
         // Set a batch size to allow multiple database queries in order to retrieve all acls
@@ -228,7 +227,7 @@ public class BasicLookupStrategyTests {
         jdbcTemplate.execute(query);
         
         ObjectIdentity topParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(100));
-        ObjectIdentity middleParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Integer(101));
+        ObjectIdentity middleParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(101));
         ObjectIdentity childOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(102));
         ObjectIdentity middleParent2Oid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(103));
         
@@ -261,8 +260,8 @@ public class BasicLookupStrategyTests {
 
         ObjectIdentity grandParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(104));
         ObjectIdentity parent1Oid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(105));
-        ObjectIdentity parent2Oid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Integer(106));
-        ObjectIdentity childOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Integer(107));
+        ObjectIdentity parent2Oid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(106));
+        ObjectIdentity childOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(107));
 
         // First lookup only child, thus populating the cache with grandParent, parent1 and child
         Permission[] checkPermission = new Permission[] { BasePermission.READ };
@@ -291,4 +290,21 @@ public class BasicLookupStrategyTests {
         Assert.assertTrue(foundParent2Acl.isGranted(checkPermission, sids, false));
     }
     
+    @Test
+    public void testAclsWithDifferentSerializableTypesAsObjectIdentities() throws Exception {
+        String query = "INSERT INTO acl_object_identity(ID,OBJECT_ID_CLASS,OBJECT_ID_IDENTITY,PARENT_OBJECT,OWNER_SID,ENTRIES_INHERITING) VALUES (4,2,104,null,1,1);"
+                + "INSERT INTO acl_entry(ID,ACL_OBJECT_IDENTITY,ACE_ORDER,SID,MASK,GRANTING,AUDIT_SUCCESS,AUDIT_FAILURE) VALUES (5,4,0,1,1,1,0,0)";
+        jdbcTemplate.execute(query);
+
+        ObjectIdentity oid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Integer(104));
+        Sid[] sids = new Sid[] { new PrincipalSid("ben") };
+        ObjectIdentity[] childOids = new ObjectIdentity[] { oid };
+        
+        try {
+            Map foundAcls = strategy.readAclsById(childOids, sids);
+            Assert.fail("It should have thrown IllegalArgumentException");
+        } catch(IllegalArgumentException expected) {
+            Assert.assertTrue(true);
+        }
+    }
 }

acl/src/test/java/org/springframework/security/acls/jdbc/JdbcAclServiceTests.java

@@ -97,7 +97,7 @@ public class JdbcAclServiceTests extends AbstractTransactionalDataSourceSpringCo
 
         ObjectIdentity topParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(100));
         ObjectIdentity middleParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(101));
-        ObjectIdentity childOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Integer(102));
+        ObjectIdentity childOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(102));
 
         MutableAcl topParent = jdbcMutableAclService.createAcl(topParentOid);
         MutableAcl middleParent = jdbcMutableAclService.createAcl(middleParentOid);
@@ -337,7 +337,7 @@ public class JdbcAclServiceTests extends AbstractTransactionalDataSourceSpringCo
 
         ObjectIdentity topParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(100));
         ObjectIdentity middleParentOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(101));
-        ObjectIdentity childOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Integer(102));
+        ObjectIdentity childOid = new ObjectIdentityImpl("org.springframework.security.TargetObject", new Long(102));
         
         // Remove the child and check all related database rows were removed accordingly
         jdbcMutableAclService.deleteAcl(childOid, false);

adapters/catalina/pom.xml

@@ -3,7 +3,7 @@
   <parent>
     <groupId>org.springframework.security</groupId>
     <artifactId>spring-security-adapters</artifactId>
-    <version>2.0.3</version>
+    <version>2.0.1</version>
   </parent>
   <artifactId>spring-security-catalina</artifactId>
   <name>Spring Security - Catalina adapter</name>

adapters/jboss/pom.xml

@@ -3,7 +3,7 @@
   <parent>
     <groupId>org.springframework.security</groupId>
     <artifactId>spring-security-adapters</artifactId>
-    <version>2.0.3</version>
+    <version>2.0.1</version>
   </parent>
   <artifactId>spring-security-jboss</artifactId>
   <name>Spring Security - JBoss adapter</name>

adapters/jetty/pom.xml

@@ -3,7 +3,7 @@
   <parent>
     <groupId>org.springframework.security</groupId>
     <artifactId>spring-security-adapters</artifactId>
-    <version>2.0.3</version>
+    <version>2.0.1</version>
   </parent>
   <artifactId>spring-security-jetty</artifactId>
   <name>Spring Security - Jetty adapter</name>

adapters/pom.xml

@@ -3,7 +3,7 @@
   <parent>
     <groupId>org.springframework.security</groupId>
     <artifactId>spring-security-parent</artifactId>
-    <version>2.0.3</version>
+    <version>2.0.1</version>
   </parent>
   <artifactId>spring-security-adapters</artifactId>
   <name>Spring Security - Adapters</name>

adapters/resin/pom.xml

@@ -3,7 +3,7 @@
   <parent>
     <groupId>org.springframework.security</groupId>
     <artifactId>spring-security-adapters</artifactId>
-    <version>2.0.3</version>
+    <version>2.0.1</version>
   </parent>
   <artifactId>spring-security-resin</artifactId>
   <name>Spring Security - Resin adapter</name>

cas/pom.xml

@@ -3,7 +3,7 @@
     <parent>
         <groupId>org.springframework.security</groupId>
         <artifactId>spring-security-parent</artifactId>
-        <version>2.0.3</version>
+        <version>2.0.1</version>
     </parent>
     <artifactId>spring-security-cas-client</artifactId>
     <name>Spring Security - CAS support</name>
@@ -31,7 +31,7 @@
         <dependency>
             <groupId>org.jasig.cas</groupId>
             <artifactId>cas-client-core</artifactId>
-            <version>3.1.3</version>
+            <version>3.1.1</version>
         </dependency>
         <dependency>
             <groupId>net.sf.ehcache</groupId>
@@ -42,11 +42,11 @@
     
     <properties>
       	<spring.osgi.export>
-      	    org.springframework.security.*;version=${pom.version.osgi}
+      	    org.springframework.security.*;version=${pom.version}
       	</spring.osgi.export>
             
     	<spring.osgi.import>
-    	    org.springframework.security.*;version="[${pom.version.osgi},${pom.version.osgi}]",
+    	    org.springframework.security.*;version="[${pom.version},${pom.version}]",
             org.springframework.beans.*;version="${spring.version.osgi}",
             org.springframework.context.*;version="${spring.version.osgi}",
             org.springframework.dao.*;version="${spring.version.osgi}";resolution:=optional,
@@ -54,7 +54,7 @@
             javax.servlet.*;version="[2.4.0, 3.0.0)";resolution:=optional,
             net.sf.ehcache.*;version="[1.4.1, 2.0.0)";resolution:=optional,
             org.apache.commons.logging.*;version="[1.1.1, 2.0.0)",
-            org.jasig.cas.client.*;version="[3.1.3, 4.0.0)"
+            org.jasig.cas.client.*;version="[3.1.1, 4.0.0)"
     	</spring.osgi.import>
 
     	<spring.osgi.private.pkg>

cas/src/main/java/org/springframework/security/ui/cas/CasProcessingFilter.java

@@ -15,11 +15,6 @@
 
 package org.springframework.security.ui.cas;
 
-import java.io.IOException;
-
-import org.jasig.cas.client.proxy.ProxyGrantingTicketStorage;
-import org.jasig.cas.client.util.CommonUtils;
-import org.jasig.cas.client.validation.TicketValidator;
 import org.springframework.security.Authentication;
 import org.springframework.security.AuthenticationException;
 
@@ -29,7 +24,6 @@ import org.springframework.security.ui.AbstractProcessingFilter;
 import org.springframework.security.ui.FilterChainOrder;
 
 import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
 
 
 /**
@@ -44,11 +38,7 @@ import javax.servlet.http.HttpServletResponse;
  *  <p>The configured <code>AuthenticationManager</code> is expected to provide a provider that can recognise
  * <code>UsernamePasswordAuthenticationToken</code>s containing this special <code>principal</code> name, and process
  * them accordingly by validation with the CAS server.</p>
- * <p>By configuring a shared {@link ProxyGrantingTicketStorage} between the {@link TicketValidator} and the CasProcessingFilter
- * one can have the CasProcessingFilter handle the proxying requirements for CAS.  In addition, the URI endpoint for the proxying
- * would also need to be configured (i.e. the part after protocol, hostname, and port).
- * 
- * <p><b>Do not use this class directly.</b> Instead configure <code>web.xml</code> to use the {@link
+ *  <p><b>Do not use this class directly.</b> Instead configure <code>web.xml</code> to use the {@link
  * org.springframework.security.util.FilterToBeanProxy}.</p>
  *
  * @author Ben Alex
@@ -67,17 +57,8 @@ public class CasProcessingFilter extends AbstractProcessingFilter {
      */
     public static final String CAS_STATELESS_IDENTIFIER = "_cas_stateless_";
 
-    /**
-     * The last portion of the receptor url, i.e. /proxy/receptor
-     */
-    private String proxyReceptorUrl;
-    
-    /**
-     * The backing storage to store ProxyGrantingTicket requests.
-     */
-    private ProxyGrantingTicketStorage proxyGrantingTicketStorage;
+    //~ Methods ========================================================================================================
 
-    //~ Methods ========================================================================================================  
     public Authentication attemptAuthentication(final HttpServletRequest request)
         throws AuthenticationException {
         final String username = CAS_STATEFUL_IDENTIFIER;
@@ -106,35 +87,4 @@ public class CasProcessingFilter extends AbstractProcessingFilter {
     public int getOrder() {
         return FilterChainOrder.CAS_PROCESSING_FILTER;
     }
-    
-
-    /**
-     * Overridden to provide proxying capabilities.
-     */
-	protected boolean requiresAuthentication(final HttpServletRequest request,
-			final HttpServletResponse response) {
-		final String requestUri = request.getRequestURI();
-
-        if (CommonUtils.isEmpty(this.proxyReceptorUrl) || !requestUri.endsWith(this.proxyReceptorUrl) || this.proxyGrantingTicketStorage == null) {
-        	return super.requiresAuthentication(request, response);
-        }
-
-        try {
-        	CommonUtils.readAndRespondToProxyReceptorRequest(request, response, this.proxyGrantingTicketStorage);
-        	return false;
-        } catch (final IOException e) {
-        	return super.requiresAuthentication(request, response);
-        }
-	}
-
-	public final void setProxyReceptorUrl(final String proxyReceptorUrl) {
-		this.proxyReceptorUrl = proxyReceptorUrl;
-	}
-
-	public final void setProxyGrantingTicketStorage(
-			final ProxyGrantingTicketStorage proxyGrantingTicketStorage) {
-		this.proxyGrantingTicketStorage = proxyGrantingTicketStorage;
-	}
-	
-	
 }

cas/src/main/java/org/springframework/security/ui/cas/CasProcessingFilterEntryPoint.java

@@ -30,14 +30,12 @@ import org.springframework.util.Assert;
 
 
 /**
- * Used by the <code>ExceptionTranslationFilter</code> to commence authentication via the JA-SIG Central
- * Authentication Service (CAS).
- * <p>
- * The user's browser will be redirected to the JA-SIG CAS enterprise-wide login page. 
- * This page is specified by the <code>loginUrl</code> property. Once login is complete, the CAS login page will
+ * Used by the <code>SecurityEnforcementFilter</code> to commence authentication via the JA-SIG Central
+ * Authentication Service (CAS).<P>The user's browser will be redirected to the JA-SIG CAS enterprise-wide login
+ * page. This page is specified by the <code>loginUrl</code> property. Once login is complete, the CAS login page will
  * redirect to the page indicated by the <code>service</code> property. The <code>service</code> is a HTTP URL
  * belonging to the current application. The <code>service</code> URL is monitored by the {@link CasProcessingFilter},
- * which will validate the CAS login was successful.
+ * which will validate the CAS login was successful.</p>
  *
  * @author Ben Alex
  * @author Scott Battaglia
@@ -67,8 +65,8 @@ public class CasProcessingFilterEntryPoint implements AuthenticationEntryPoint,
     }
 
     public void commence(final ServletRequest servletRequest, final ServletResponse servletResponse,
-    		final AuthenticationException authenticationException) throws IOException, ServletException {
-
+        final AuthenticationException authenticationException)
+        throws IOException, ServletException {
         final HttpServletResponse response = (HttpServletResponse) servletResponse;
         final String urlEncodedService = CommonUtils.constructServiceUrl(null, response, this.serviceProperties.getService(), null, "ticket", this.encodeServiceUrlWithSessionId);
         final String redirectUrl = CommonUtils.constructRedirectUrl(this.loginUrl, "service", urlEncodedService, this.serviceProperties.isSendRenew(), false);

cas/src/main/java/org/springframework/security/ui/cas/ServiceProperties.java

@@ -21,10 +21,9 @@ import org.springframework.util.Assert;
 
 /**
  * Stores properties related to this CAS service.
- * <p>
- * Each web application capable of processing CAS tickets is known as a service.
+ * <p>Each web application capable of processing CAS tickets is known as a service.
  * This class stores the properties that are relevant to the local CAS service, being the application
- * that is being secured by Spring Security.
+ * that is being secured by Spring Security.</p>
  *
  * @author Ben Alex
  * @version $Id$
@@ -43,8 +42,7 @@ public class ServiceProperties implements InitializingBean {
 
     /**
      * Represents the service the user is authenticating to.
-     * <p>
-     * This service is the callback URL belonging to the local Spring Security System for Spring secured application.
+     * <p>This service is the callback URL belonging to the local Spring Security System for Spring secured application.
      * For example,
      * <pre>
      * https://www.mycompany.com/application/j_spring_cas_security_check
@@ -58,12 +56,10 @@ public class ServiceProperties implements InitializingBean {
 
     /**
      * Indicates whether the <code>renew</code> parameter should be sent to the CAS login URL and CAS
-     * validation URL.
-     * <p>
-     * If <code>true</code>, it will force CAS to authenticate the user again (even if the
+     * validation URL.<p>If <code>true</code>, it will force CAS to authenticate the user again (even if the
      * user has previously authenticated). During ticket validation it will require the ticket was generated as a
      * consequence of an explicit login. High security applications would probably set this to <code>true</code>.
-     * Defaults to <code>false</code>, providing automated single sign on.
+     * Defaults to <code>false</code>, providing automated single sign on.</p>
      *
      * @return whether to send the <code>renew</code> parameter to CAS
      */

core-tiger/pom.xml

@@ -3,7 +3,7 @@
     <parent>
         <groupId>org.springframework.security</groupId>
         <artifactId>spring-security-parent</artifactId>
-        <version>2.0.3</version>
+        <version>2.0.1</version>
     </parent>
     <packaging>bundle</packaging>    
     <artifactId>spring-security-core-tiger</artifactId>
@@ -32,6 +32,20 @@
             <artifactId>aspectjweaver</artifactId>
             <optional>true</optional>
         </dependency>
+        <dependency>
+            <groupId>org.springframework</groupId>
+            <artifactId>spring-core</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.springframework</groupId>
+            <artifactId>spring-aop</artifactId>
+            <version>${spring.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.springframework</groupId>
+            <artifactId>spring-support</artifactId>
+            <scope>runtime</scope>
+        </dependency>
         <dependency>
             <groupId>org.springframework</groupId>
             <artifactId>spring-jdbc</artifactId>
@@ -75,7 +89,7 @@
             
     	<spring.osgi.import>
     	    javax.annotation.*;version="[1.0.0, 2.0.0)",
-    	    org.springframework.security.*;version="[${pom.version.osgi},${pom.version.osgi}]",
+    	    org.springframework.security.*;version="[${pom.version},${pom.version}]",
     	    org.springframework.core.*;version="${spring.version.osgi}"
     	</spring.osgi.import>
 

core-tiger/src/test/resources/log4j.properties

@@ -1,12 +0,0 @@
-# Logging
-#
-# $Id: log4j.properties 2385 2007-12-20 20:53:26Z luke_t $
-
-log4j.rootCategory=DEBUG, stdout
-
-log4j.appender.stdout=org.apache.log4j.ConsoleAppender
-log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
-log4j.appender.stdout.layout.ConversionPattern=%d %p %c - %m%n
-
-log4j.category.org.springframework.security=DEBUG
-

core/pom.xml

@@ -3,7 +3,7 @@
     <parent>
         <groupId>org.springframework.security</groupId>
         <artifactId>spring-security-parent</artifactId>
-        <version>2.0.3</version>
+        <version>2.0.1</version>
     </parent>
     <packaging>bundle</packaging>
     <artifactId>spring-security-core</artifactId>

core/src/main/java/org/springframework/security/authoritymapping/SimpleAttributes2GrantedAuthoritiesMapper.java

@@ -90,7 +90,7 @@ public class SimpleAttributes2GrantedAuthoritiesMapper implements Attributes2Gra
         return attributePrefix == null ? "" : attributePrefix;
     }
 
-    public void setAttributePrefix(String string) {
+    public void seAttributePrefix(String string) {
         attributePrefix = string;
     }
 

core/src/main/java/org/springframework/security/concurrent/ConcurrentSessionControllerImpl.java

@@ -158,8 +158,4 @@ public class ConcurrentSessionControllerImpl implements ConcurrentSessionControl
     public void setSessionRegistry(SessionRegistry sessionRegistry) {
         this.sessionRegistry = sessionRegistry;
     }
-
-	public SessionRegistry getSessionRegistry() {
-		return sessionRegistry;
-	}
 }

core/src/main/java/org/springframework/security/concurrent/ConcurrentSessionFilter.java

@@ -21,7 +21,6 @@ import org.springframework.security.ui.FilterChainOrder;
 import org.springframework.security.ui.SpringSecurityFilter;
 import org.springframework.security.ui.logout.LogoutHandler;
 import org.springframework.security.ui.logout.SecurityContextLogoutHandler;
-import org.springframework.security.util.UrlUtils;
 import org.springframework.beans.factory.InitializingBean;
 import org.springframework.util.Assert;
 
@@ -61,7 +60,6 @@ public class ConcurrentSessionFilter extends SpringSecurityFilter implements Ini
 
     public void afterPropertiesSet() throws Exception {
         Assert.notNull(sessionRegistry, "SessionRegistry required");
-        Assert.isTrue(UrlUtils.isValidRedirectUrl(expiredUrl), expiredUrl + " isn't a valid redirect URL");
     }
 
     public void doFilterHttp(HttpServletRequest request, HttpServletResponse response, FilterChain chain)

core/src/main/java/org/springframework/security/config/AbstractUserDetailsServiceBeanDefinitionParser.java

@@ -23,12 +23,12 @@ public abstract class AbstractUserDetailsServiceBeanDefinitionParser implements
 	/**  UserDetailsService bean Id. For use in a stateful context (i.e. in AuthenticationProviderBDP) */
 	private String id;
 	
-	protected abstract String getBeanClassName(Element element);
+	protected abstract Class getBeanClass(Element element);
 	
     protected abstract void doParse(Element element, ParserContext parserContext, BeanDefinitionBuilder builder);	
 	
 	public BeanDefinition parse(Element element, ParserContext parserContext) {
-		BeanDefinitionBuilder builder = BeanDefinitionBuilder.rootBeanDefinition(getBeanClassName(element)); 
+		BeanDefinitionBuilder builder = BeanDefinitionBuilder.rootBeanDefinition(getBeanClass(element)); 
 		
 		doParse(element, parserContext, builder);
 		

core/src/main/java/org/springframework/security/config/AuthenticationManagerBeanDefinitionParser.java

@@ -1,51 +1,32 @@
 package org.springframework.security.config;
 
-import org.springframework.beans.factory.support.RootBeanDefinition;
 import org.springframework.beans.factory.xml.BeanDefinitionParser;
 import org.springframework.beans.factory.xml.ParserContext;
 import org.springframework.beans.factory.config.BeanDefinition;
-import org.springframework.beans.factory.config.RuntimeBeanReference;
 import org.springframework.util.StringUtils;
 
 import org.w3c.dom.Element;
 
 /**
- * Registers an alias name for the default ProviderManager used by the namespace
+ * Just registers an alias name for the default ProviderManager used by the namespace
  * configuration, allowing users to reference it in their beans and clearly see where the name is
- * coming from. Also allows the ConcurrentSessionController to be set on the ProviderManager.
+ * coming from.
  *
  * @author Luke Taylor
  * @version $Id$
  */
 public class AuthenticationManagerBeanDefinitionParser implements BeanDefinitionParser {
-    private static final String ATT_SESSION_CONTROLLER_REF = "session-controller-ref";
-	private static final String ATT_ALIAS = "alias";
+    private static final String ATT_ALIAS = "alias";
 
     public BeanDefinition parse(Element element, ParserContext parserContext) {
-    	BeanDefinition authManager = ConfigUtils.registerProviderManagerIfNecessary(parserContext);
-    	
         String alias = element.getAttribute(ATT_ALIAS);
 
         if (!StringUtils.hasText(alias)) {
             parserContext.getReaderContext().error(ATT_ALIAS + " is required.", element );
         }
-        
-        String sessionControllerRef = element.getAttribute(ATT_SESSION_CONTROLLER_REF);
-        
-        if (StringUtils.hasText(sessionControllerRef)) {
-            ConfigUtils.setSessionControllerOnAuthenticationManager(parserContext, 
-            		BeanIds.CONCURRENT_SESSION_CONTROLLER, element);
-        	authManager.getPropertyValues().addPropertyValue("sessionController", 
-        			new RuntimeBeanReference(sessionControllerRef));
-            RootBeanDefinition sessionRegistryInjector = new RootBeanDefinition(SessionRegistryInjectionBeanPostProcessor.class);
-            sessionRegistryInjector.setRole(BeanDefinition.ROLE_INFRASTRUCTURE);
-            sessionRegistryInjector.getConstructorArgumentValues().addGenericArgumentValue(sessionControllerRef);
-        	
-        	parserContext.getRegistry().registerBeanDefinition(BeanIds.SESSION_REGISTRY_INJECTION_POST_PROCESSOR, sessionRegistryInjector);
-        }
 
         parserContext.getRegistry().registerAlias(BeanIds.AUTHENTICATION_MANAGER, alias);
 
         return null;
-    }    
+    }
 }

core/src/main/java/org/springframework/security/config/BeanIds.java

@@ -1,5 +1,7 @@
 package org.springframework.security.config;
 
+import org.springframework.beans.factory.config.BeanDefinition;
+
 /**
  * Contains all the default Bean IDs created by the namespace support in Spring Security 2.
  * <p>
@@ -16,9 +18,7 @@ public abstract class BeanIds {
     /** Package protected as end users shouldn't really be using this BFPP directly */
 	static final String INTERCEPT_METHODS_BEAN_FACTORY_POST_PROCESSOR = "_interceptMethodsBeanfactoryPP";
     static final String CONTEXT_SOURCE_SETTING_POST_PROCESSOR = "_contextSettingPostProcessor";
-    static final String ENTRY_POINT_INJECTION_POST_PROCESSOR = "_entryPointInjectionBeanPostProcessor";
-    static final String USER_DETAILS_SERVICE_INJECTION_POST_PROCESSOR = "_userServiceInjectionPostProcessor";
-    static final String SESSION_REGISTRY_INJECTION_POST_PROCESSOR = "_sessionRegistryInjectionPostProcessor";    
+    static final String HTTP_POST_PROCESSOR = "_httpConfigBeanFactoryPostProcessor";
     static final String FILTER_CHAIN_POST_PROCESSOR = "_filterChainProxyPostProcessor";
     static final String FILTER_LIST = "_filterChainList";
 
@@ -63,7 +63,7 @@ public abstract class BeanIds {
     public static final String CONTEXT_SOURCE = "_securityContextSource";
     public static final String PORT_MAPPER = "_portMapper";
     public static final String X509_FILTER = "_x509ProcessingFilter";
-    public static final String X509_AUTH_PROVIDER = "_x509AuthenticationProvider";
+    public static final String X509_AUTH_PROVIDER = "_x509AuthenitcationProvider";
     public static final String PRE_AUTH_ENTRY_POINT = "_preAuthenticatedProcessingFilterEntryPoint";
     public static final String REMEMBER_ME_SERVICES_INJECTION_POST_PROCESSOR = "_rememberMeServicesInjectionBeanPostProcessor";
 

core/src/main/java/org/springframework/security/config/ConcurrentSessionsBeanDefinitionParser.java

@@ -29,8 +29,7 @@ public class ConcurrentSessionsBeanDefinitionParser implements BeanDefinitionPar
     static final String ATT_EXPIRY_URL = "expired-url";
     static final String ATT_MAX_SESSIONS = "max-sessions";
     static final String ATT_EXCEPTION_IF_MAX_EXCEEDED = "exception-if-maximum-exceeded";
-    static final String ATT_SESSION_REGISTRY_ALIAS = "session-registry-alias";
-    static final String ATT_SESSION_REGISTRY_REF = "session-registry-ref";
+    static final String ATT_SESSION_REGISTRY_ALIAS = "session-registry-alias";    
 	
     public BeanDefinition parse(Element element, ParserContext parserContext) {
     	CompositeComponentDefinition compositeDef =
@@ -39,43 +38,26 @@ public class ConcurrentSessionsBeanDefinitionParser implements BeanDefinitionPar
     	
     	BeanDefinitionRegistry beanRegistry = parserContext.getRegistry();
 
-        String sessionRegistryId = element.getAttribute(ATT_SESSION_REGISTRY_REF);
-        
-        if (!StringUtils.hasText(sessionRegistryId)) {        	
-            RootBeanDefinition sessionRegistry = new RootBeanDefinition(SessionRegistryImpl.class);        
-            beanRegistry.registerBeanDefinition(BeanIds.SESSION_REGISTRY, sessionRegistry);
-            parserContext.registerComponent(new BeanComponentDefinition(sessionRegistry, BeanIds.SESSION_REGISTRY));
-            sessionRegistryId = BeanIds.SESSION_REGISTRY;
-        } else {
-        	// Register the default ID as an alias so that things like session fixation filter can access it
-        	beanRegistry.registerAlias(sessionRegistryId, BeanIds.SESSION_REGISTRY);
-        }
-
-        String registryAlias = element.getAttribute(ATT_SESSION_REGISTRY_ALIAS);
-        if (StringUtils.hasText(registryAlias)) {
-        	beanRegistry.registerAlias(sessionRegistryId, registryAlias);
-        }    	
-
+        RootBeanDefinition sessionRegistry = new RootBeanDefinition(SessionRegistryImpl.class);
         BeanDefinitionBuilder filterBuilder =
                 BeanDefinitionBuilder.rootBeanDefinition(ConcurrentSessionFilter.class);
-        filterBuilder.addPropertyValue("sessionRegistry", new RuntimeBeanReference(sessionRegistryId));
+        BeanDefinitionBuilder controllerBuilder
+                = BeanDefinitionBuilder.rootBeanDefinition(ConcurrentSessionControllerImpl.class);
+        controllerBuilder.addPropertyValue("sessionRegistry", new RuntimeBeanReference(BeanIds.SESSION_REGISTRY));
+        filterBuilder.addPropertyValue("sessionRegistry", new RuntimeBeanReference(BeanIds.SESSION_REGISTRY));
 
         Object source = parserContext.extractSource(element);
         filterBuilder.setSource(source);
         filterBuilder.setRole(BeanDefinition.ROLE_INFRASTRUCTURE);
-
+        controllerBuilder.setSource(source);
+        controllerBuilder.setRole(BeanDefinition.ROLE_INFRASTRUCTURE);
+        
         String expiryUrl = element.getAttribute(ATT_EXPIRY_URL);
 
         if (StringUtils.hasText(expiryUrl)) {
         	ConfigUtils.validateHttpRedirect(expiryUrl, parserContext, source);
             filterBuilder.addPropertyValue("expiredUrl", expiryUrl);
-        }        
-
-        BeanDefinitionBuilder controllerBuilder
-        	= BeanDefinitionBuilder.rootBeanDefinition(ConcurrentSessionControllerImpl.class);
-        controllerBuilder.setSource(source);
-        controllerBuilder.setRole(BeanDefinition.ROLE_INFRASTRUCTURE);        
-        controllerBuilder.addPropertyValue("sessionRegistry", new RuntimeBeanReference(sessionRegistryId));
+        }
 
         String maxSessions = element.getAttribute(ATT_MAX_SESSIONS);
 
@@ -90,14 +72,23 @@ public class ConcurrentSessionsBeanDefinitionParser implements BeanDefinitionPar
         }
 
         BeanDefinition controller = controllerBuilder.getBeanDefinition();
+        beanRegistry.registerBeanDefinition(BeanIds.SESSION_REGISTRY, sessionRegistry);
+        parserContext.registerComponent(new BeanComponentDefinition(sessionRegistry, BeanIds.SESSION_REGISTRY));
         
+        String registryAlias = element.getAttribute(ATT_SESSION_REGISTRY_ALIAS);
+        if (StringUtils.hasText(registryAlias)) {
+        	beanRegistry.registerAlias(BeanIds.SESSION_REGISTRY, registryAlias);
+        }
+
         beanRegistry.registerBeanDefinition(BeanIds.CONCURRENT_SESSION_CONTROLLER, controller);
         parserContext.registerComponent(new BeanComponentDefinition(controller, BeanIds.CONCURRENT_SESSION_CONTROLLER));
         beanRegistry.registerBeanDefinition(BeanIds.CONCURRENT_SESSION_FILTER, filterBuilder.getBeanDefinition());
         parserContext.registerComponent(new BeanComponentDefinition(filterBuilder.getBeanDefinition(), BeanIds.CONCURRENT_SESSION_FILTER));
         ConfigUtils.addHttpFilter(parserContext, new RuntimeBeanReference(BeanIds.CONCURRENT_SESSION_FILTER));
         
-        ConfigUtils.setSessionControllerOnAuthenticationManager(parserContext, BeanIds.CONCURRENT_SESSION_CONTROLLER, element);
+        BeanDefinition providerManager = ConfigUtils.registerProviderManagerIfNecessary(parserContext);
+
+        providerManager.getPropertyValues().addPropertyValue("sessionController", controller);
         
         parserContext.popAndRegisterContainingComponent();
         

core/src/main/java/org/springframework/security/config/ConfigUtils.java

@@ -1,13 +1,11 @@
 package org.springframework.security.config;
 
 import java.util.List;
-import java.util.Map;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.springframework.beans.BeanMetadataElement;
 import org.springframework.beans.MutablePropertyValues;
-import org.springframework.beans.PropertyValue;
 import org.springframework.beans.factory.config.BeanDefinition;
 import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
 import org.springframework.beans.factory.config.RuntimeBeanReference;
@@ -18,12 +16,10 @@ import org.springframework.beans.factory.xml.ParserContext;
 import org.springframework.security.afterinvocation.AfterInvocationProviderManager;
 import org.springframework.security.providers.ProviderManager;
 import org.springframework.security.userdetails.UserDetailsService;
-import org.springframework.security.util.UrlUtils;
 import org.springframework.security.vote.AffirmativeBased;
 import org.springframework.security.vote.AuthenticatedVoter;
 import org.springframework.security.vote.RoleVoter;
 import org.springframework.util.StringUtils;
-import org.w3c.dom.Element;
 
 /**
  * Utility methods used internally by the Spring Security namespace configuration code.
@@ -92,6 +88,28 @@ public abstract class ConfigUtils {
         return authManager;
     }
 
+    /**
+     * Obtains a user details service for use in RememberMeServices etc. Will return a caching version
+     * if available so should not be used for beans which need to separate the two. 
+     */
+    static RuntimeBeanReference getUserDetailsService(ConfigurableListableBeanFactory bf) {
+        String[] services = bf.getBeanNamesForType(CachingUserDetailsService.class, false, false);
+        
+        if (services.length == 0) {
+        	services = bf.getBeanNamesForType(UserDetailsService.class);
+        }
+
+        if (services.length == 0) {
+            throw new IllegalArgumentException("No UserDetailsService registered.");
+
+        } else if (services.length > 1) {
+            throw new IllegalArgumentException("More than one UserDetailsService registered. Please " +
+                    "use a specific Id in your configuration");
+        }
+
+        return new RuntimeBeanReference(services[0]);
+    }
+
     static ManagedList getRegisteredProviders(ParserContext parserContext) {
         BeanDefinition authManager = registerProviderManagerIfNecessary(parserContext);
         return (ManagedList) authManager.getPropertyValues().getPropertyValue("providers").getValue();
@@ -162,25 +180,12 @@ public abstract class ConfigUtils {
     
     /**
      * Checks the value of an XML attribute which represents a redirect URL.
-     * If not empty or starting with "$" (potential placeholder), "/" or "http" it will raise an error. 
+     * If not empty or starting with "/" or "http" it will raise an error. 
      */
     static void validateHttpRedirect(String url, ParserContext pc, Object source) {
-    	if (UrlUtils.isValidRedirectUrl(url) || url.startsWith("$")) {
+    	if (!StringUtils.hasText(url) || url.startsWith("/") || url.toLowerCase().startsWith("http")) {
     		return;
     	}
-    	pc.getReaderContext().warning(url + " is not a valid redirect URL (must start with '/' or http(s))", source);
-    }
-    
-    static void setSessionControllerOnAuthenticationManager(ParserContext pc, String beanName, Element sourceElt) {
-    	BeanDefinition authManager = registerProviderManagerIfNecessary(pc);
-        PropertyValue pv = authManager.getPropertyValues().getPropertyValue("sessionController");
-        
-        if (pv != null && pv.getValue() != null) {
-        	pc.getReaderContext().error("A session controller has already been set on the authentication manager. " +
-        			"The <concurrent-session-control> element isn't compatible with a custom session controller", 
-        			pc.extractSource(sourceElt));
-        }
-        
-        authManager.getPropertyValues().addPropertyValue("sessionController", new RuntimeBeanReference(beanName));
+    	pc.getReaderContext().error(url + " is not a valid redirect URL (must start with '/' or http(s))", source);
     }
 }

core/src/main/java/org/springframework/security/config/CustomAuthenticationProviderBeanDefinitionDecorator.java

@@ -3,7 +3,6 @@ package org.springframework.security.config;
 import org.springframework.beans.factory.xml.BeanDefinitionDecorator;
 import org.springframework.beans.factory.xml.ParserContext;
 import org.springframework.beans.factory.config.BeanDefinitionHolder;
-import org.springframework.beans.factory.config.RuntimeBeanReference;
 
 import org.w3c.dom.Node;
 
@@ -17,7 +16,7 @@ import org.w3c.dom.Node;
  */
 public class CustomAuthenticationProviderBeanDefinitionDecorator implements BeanDefinitionDecorator {
     public BeanDefinitionHolder decorate(Node node, BeanDefinitionHolder holder, ParserContext parserContext) {
-        ConfigUtils.getRegisteredProviders(parserContext).add(new RuntimeBeanReference(holder.getBeanName()));
+        ConfigUtils.getRegisteredProviders(parserContext).add(holder.getBeanDefinition());
 
         return holder;
     }

core/src/main/java/org/springframework/security/config/EntryPointInjectionBeanPostProcessor.java

@@ -1,59 +0,0 @@
-package org.springframework.security.config;
-
-import java.util.Map;
-
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-import org.springframework.beans.BeansException;
-import org.springframework.beans.factory.BeanFactory;
-import org.springframework.beans.factory.BeanFactoryAware;
-import org.springframework.beans.factory.config.BeanPostProcessor;
-import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
-import org.springframework.security.ui.AuthenticationEntryPoint;
-import org.springframework.security.ui.ExceptionTranslationFilter;
-import org.springframework.util.Assert;
-
-/**
- * 
- * @author Luke Taylor
- * @since 2.0.2
- */
-public class EntryPointInjectionBeanPostProcessor implements BeanPostProcessor, BeanFactoryAware {
-    private final Log logger = LogFactory.getLog(getClass());
-    private ConfigurableListableBeanFactory beanFactory;	
-
-	public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
-        if (!BeanIds.EXCEPTION_TRANSLATION_FILTER.equals(beanName)) {
-        	return bean;
-        }
-        
-        logger.info("Selecting AuthenticationEntryPoint for use in ExceptionTranslationFilter");
-        
-        ExceptionTranslationFilter etf = (ExceptionTranslationFilter) beanFactory.getBean(BeanIds.EXCEPTION_TRANSLATION_FILTER); 
-
-        Object entryPoint = null;
-        
-        if (beanFactory.containsBean(BeanIds.MAIN_ENTRY_POINT)) {
-            entryPoint = beanFactory.getBean(BeanIds.MAIN_ENTRY_POINT);
-            logger.info("Using main configured AuthenticationEntryPoint.");
-        } else {
-            Map entryPoints = beanFactory.getBeansOfType(AuthenticationEntryPoint.class);
-            Assert.isTrue(entryPoints.size() != 0, "No AuthenticationEntryPoint instances defined");
-            Assert.isTrue(entryPoints.size() == 1, "More than one AuthenticationEntryPoint defined in context");
-            entryPoint = entryPoints.values().toArray()[0];
-        }
-        
-        logger.info("Using bean '" + entryPoint + "' as the entry point.");
-        etf.setAuthenticationEntryPoint((AuthenticationEntryPoint) entryPoint);
-		
-		return bean;
-	}	
-	
-	public Object postProcessAfterInitialization(Object bean, String beanName) throws BeansException {
-		return bean;
-	}
-
-	public void setBeanFactory(BeanFactory beanFactory) throws BeansException {
-		this.beanFactory = (ConfigurableListableBeanFactory) beanFactory;
-	}
-}

core/src/main/java/org/springframework/security/config/FilterChainProxyPostProcessor.java

@@ -44,7 +44,7 @@ public class FilterChainProxyPostProcessor implements BeanPostProcessor, BeanFac
     private ListableBeanFactory beanFactory;
     
     public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
-        if(!BeanIds.FILTER_CHAIN_PROXY.equals(beanName)) {
+        if(!beanName.equals(BeanIds.FILTER_CHAIN_PROXY)) {
             return bean;
         }
         
@@ -66,7 +66,7 @@ public class FilterChainProxyPostProcessor implements BeanPostProcessor, BeanFac
                             unwrapFilter(previous) + "' have the same 'order' value. When using custom filters, " +
                             		"please make sure the positions do not conflict with default filters. " +
                             		"Alternatively you can disable the default filters by removing the corresponding " +
-                            		"child elements from <http> and avoiding the use of <http auto-config='true'>.");
+                            		"child elements from <http> and not avoiding the use of <http auto-config='true'>.");
                 }
             }
         }

core/src/main/java/org/springframework/security/config/FormLoginBeanDefinitionParser.java

@@ -1,6 +1,5 @@
 package org.springframework.security.config;
 
-import org.springframework.beans.PropertyValue;
 import org.springframework.beans.factory.config.BeanDefinition;
 import org.springframework.beans.factory.config.RuntimeBeanReference;
 import org.springframework.beans.factory.support.BeanDefinitionBuilder;
@@ -55,18 +54,6 @@ public class FormLoginBeanDefinitionParser implements BeanDefinitionParser {
         
         Object source = null;
 
-        // Copy values from the session fixation protection filter        
-        final Boolean sessionFixationProtectionEnabled = 
-            new Boolean(pc.getRegistry().containsBeanDefinition(BeanIds.SESSION_FIXATION_PROTECTION_FILTER));
-        Boolean migrateSessionAttributes = Boolean.FALSE;
-        
-        if (sessionFixationProtectionEnabled.booleanValue()) {
-            PropertyValue pv = 
-                    pc.getRegistry().getBeanDefinition(BeanIds.SESSION_FIXATION_PROTECTION_FILTER)
-                        .getPropertyValues().getPropertyValue("migrateSessionAttributes");
-            migrateSessionAttributes = (Boolean)pv.getValue(); 
-        }        
-        
         if (elt != null) {
         	source = pc.extractSource(elt);
             loginUrl = elt.getAttribute(ATT_LOGIN_URL);
@@ -92,20 +79,10 @@ public class FormLoginBeanDefinitionParser implements BeanDefinitionParser {
         filterBean.getPropertyValues().addPropertyValue("authenticationManager",
                 new RuntimeBeanReference(BeanIds.AUTHENTICATION_MANAGER));
         
-        filterBean.getPropertyValues().addPropertyValue("invalidateSessionOnSuccessfulAuthentication", 
-                sessionFixationProtectionEnabled);
-        filterBean.getPropertyValues().addPropertyValue("migrateInvalidatedSessionAttributes", 
-                migrateSessionAttributes);            
-        
         if (pc.getRegistry().containsBeanDefinition(BeanIds.REMEMBER_ME_SERVICES)) {
             filterBean.getPropertyValues().addPropertyValue("rememberMeServices", 
                     new RuntimeBeanReference(BeanIds.REMEMBER_ME_SERVICES) );
         }
-        
-        if (pc.getRegistry().containsBeanDefinition(BeanIds.SESSION_REGISTRY)) {
-            filterBean.getPropertyValues().addPropertyValue("sessionRegistry", 
-                    new RuntimeBeanReference(BeanIds.SESSION_REGISTRY));
-        }
 
         BeanDefinitionBuilder entryPointBuilder =
                 BeanDefinitionBuilder.rootBeanDefinition(AuthenticationProcessingFilterEntryPoint.class);

core/src/main/java/org/springframework/security/config/HttpSecurityBeanDefinitionParser.java

@@ -116,7 +116,7 @@ public class HttpSecurityBeanDefinitionParser implements BeanDefinitionParser {
         parseInterceptUrlsForChannelSecurityAndFilterChain(interceptUrlElts, filterChainMap, channelRequestMap, 
                 convertPathsToLowerCase, parserContext);
 
-        boolean allowSessionCreation = registerHttpSessionIntegrationFilter(element, parserContext);
+        registerHttpSessionIntegrationFilter(element, parserContext);
         
         registerServletApiFilter(element, parserContext);
                 
@@ -133,7 +133,7 @@ public class HttpSecurityBeanDefinitionParser implements BeanDefinitionParser {
                 DomUtils.getChildElementByTagName(element, Elements.PORT_MAPPINGS), parserContext);
         registry.registerBeanDefinition(BeanIds.PORT_MAPPER, portMapper);
 
-        registerExceptionTranslationFilter(element, parserContext, allowSessionCreation);
+        registerExceptionTranslationFilter(element, parserContext);
 
 
         if (channelRequestMap.size() > 0) {
@@ -174,21 +174,18 @@ public class HttpSecurityBeanDefinitionParser implements BeanDefinitionParser {
             new LogoutBeanDefinitionParser().parse(logoutElt, parserContext);
         }
         
-        parseBasicFormLoginAndOpenID(element, parserContext, autoConfig, allowSessionCreation);
+        parseBasicFormLoginAndOpenID(element, parserContext, autoConfig);
 
         Element x509Elt = DomUtils.getChildElementByTagName(element, Elements.X509);
         if (x509Elt != null) {
             new X509BeanDefinitionParser().parse(x509Elt, parserContext);
         }
 
-        // Register the post processors which will tie up the loose ends in the configuration once the app context has been created and all beans are available.
-        RootBeanDefinition postProcessor = new RootBeanDefinition(EntryPointInjectionBeanPostProcessor.class);
+        // Register the post processor which will tie up the loose ends in the configuration once the app context has been created and all beans are available.
+        RootBeanDefinition postProcessor = new RootBeanDefinition(HttpSecurityConfigPostProcessor.class);
         postProcessor.setRole(BeanDefinition.ROLE_INFRASTRUCTURE);
-        registry.registerBeanDefinition(BeanIds.ENTRY_POINT_INJECTION_POST_PROCESSOR, postProcessor);
-        RootBeanDefinition postProcessor2 = new RootBeanDefinition(UserDetailsServiceInjectionBeanPostProcessor.class);
-        postProcessor2.setRole(BeanDefinition.ROLE_INFRASTRUCTURE);
-        registry.registerBeanDefinition(BeanIds.USER_DETAILS_SERVICE_INJECTION_POST_PROCESSOR, postProcessor2);
-        
+        registry.registerBeanDefinition(BeanIds.HTTP_POST_PROCESSOR, postProcessor);
+
         return null;
     }
     
@@ -205,9 +202,8 @@ public class HttpSecurityBeanDefinitionParser implements BeanDefinitionParser {
         pc.getRegistry().registerAlias(BeanIds.FILTER_CHAIN_PROXY, BeanIds.SPRING_SECURITY_FILTER_CHAIN);        
     }
 
-    private boolean registerHttpSessionIntegrationFilter(Element element, ParserContext pc) {
+    private void registerHttpSessionIntegrationFilter(Element element, ParserContext pc) {
         RootBeanDefinition httpScif = new RootBeanDefinition(HttpSessionContextIntegrationFilter.class);
-        boolean sessionCreationAllowed = true;
         
         String createSession = element.getAttribute(ATT_CREATE_SESSION);
         if (OPT_CREATE_SESSION_ALWAYS.equals(createSession)) {
@@ -216,7 +212,6 @@ public class HttpSecurityBeanDefinitionParser implements BeanDefinitionParser {
         } else if (OPT_CREATE_SESSION_NEVER.equals(createSession)) {
             httpScif.getPropertyValues().addPropertyValue("allowSessionCreation", Boolean.FALSE);
             httpScif.getPropertyValues().addPropertyValue("forceEagerSessionCreation", Boolean.FALSE);
-            sessionCreationAllowed = false;
         } else {
             createSession = DEF_CREATE_SESSION_IF_REQUIRED;
             httpScif.getPropertyValues().addPropertyValue("allowSessionCreation", Boolean.TRUE);
@@ -225,8 +220,6 @@ public class HttpSecurityBeanDefinitionParser implements BeanDefinitionParser {
 
         pc.getRegistry().registerBeanDefinition(BeanIds.HTTP_SESSION_CONTEXT_INTEGRATION_FILTER, httpScif);
         ConfigUtils.addHttpFilter(pc, new RuntimeBeanReference(BeanIds.HTTP_SESSION_CONTEXT_INTEGRATION_FILTER));
-        
-        return sessionCreationAllowed;
     }
 
     // Adds the servlet-api integration filter if required    
@@ -256,13 +249,12 @@ public class HttpSecurityBeanDefinitionParser implements BeanDefinitionParser {
         return true;
     }
     
-    private void registerExceptionTranslationFilter(Element element, ParserContext pc, boolean allowSessionCreation) {
+    private void registerExceptionTranslationFilter(Element element, ParserContext pc) {
     	String accessDeniedPage = element.getAttribute(ATT_ACCESS_DENIED_PAGE);
     	ConfigUtils.validateHttpRedirect(accessDeniedPage, pc, pc.extractSource(element));
         BeanDefinitionBuilder exceptionTranslationFilterBuilder
             = BeanDefinitionBuilder.rootBeanDefinition(ExceptionTranslationFilter.class);
-        exceptionTranslationFilterBuilder.addPropertyValue("createSessionAllowed", new Boolean(allowSessionCreation));
-        
+ 
         if (StringUtils.hasText(accessDeniedPage)) {
             AccessDeniedHandlerImpl accessDeniedHandler = new AccessDeniedHandlerImpl();
             accessDeniedHandler.setErrorPage(accessDeniedPage);
@@ -284,11 +276,8 @@ public class HttpSecurityBeanDefinitionParser implements BeanDefinitionParser {
             builder.addPropertyValue("observeOncePerRequest", Boolean.FALSE);
         }
         
-        DefaultFilterInvocationDefinitionSource fids = 
-            new DefaultFilterInvocationDefinitionSource(matcher, filterInvocationDefinitionMap);
-        fids.setStripQueryStringFromUrls(matcher instanceof AntUrlPathMatcher);
-        
-        builder.addPropertyValue("objectDefinitionSource", fids);
+        builder.addPropertyValue("objectDefinitionSource", 
+                new DefaultFilterInvocationDefinitionSource(matcher, filterInvocationDefinitionMap));
         pc.getRegistry().registerBeanDefinition(BeanIds.FILTER_SECURITY_INTERCEPTOR, builder.getBeanDefinition());
         ConfigUtils.addHttpFilter(pc, new RuntimeBeanReference(BeanIds.FILTER_SECURITY_INTERCEPTOR));
     }
@@ -299,7 +288,7 @@ public class HttpSecurityBeanDefinitionParser implements BeanDefinitionParser {
                 new RuntimeBeanReference(BeanIds.CHANNEL_DECISION_MANAGER));
         DefaultFilterInvocationDefinitionSource channelFilterInvDefSource =
             new DefaultFilterInvocationDefinitionSource(matcher, channelRequestMap);
-        channelFilterInvDefSource.setStripQueryStringFromUrls(matcher instanceof AntUrlPathMatcher);
+        
         
         channelFilter.getPropertyValues().addPropertyValue("filterInvocationDefinitionSource",
                 channelFilterInvDefSource);
@@ -343,7 +332,7 @@ public class HttpSecurityBeanDefinitionParser implements BeanDefinitionParser {
         }
     }
     
-    private void parseBasicFormLoginAndOpenID(Element element, ParserContext pc, boolean autoConfig, boolean allowSessionCreation) {
+    private void parseBasicFormLoginAndOpenID(Element element, ParserContext pc, boolean autoConfig) {
         RootBeanDefinition formLoginFilter = null;
         RootBeanDefinition formLoginEntryPoint = null;
         String formLoginPage = null;        
@@ -394,15 +383,15 @@ public class HttpSecurityBeanDefinitionParser implements BeanDefinitionParser {
             }
             
             BeanDefinition openIDProvider = openIDProviderBuilder.getBeanDefinition();
+            ConfigUtils.getRegisteredProviders(pc).add(openIDProvider);
+            
             pc.getRegistry().registerBeanDefinition(BeanIds.OPEN_ID_PROVIDER, openIDProvider);
-            ConfigUtils.getRegisteredProviders(pc).add(new RuntimeBeanReference(BeanIds.OPEN_ID_PROVIDER));
         }
         
         boolean needLoginPage = false;
         
         if (formLoginFilter != null) {
         	needLoginPage = true;
-        	formLoginFilter.getPropertyValues().addPropertyValue("allowSessionCreation", new Boolean(allowSessionCreation));
 	        pc.getRegistry().registerBeanDefinition(BeanIds.FORM_LOGIN_FILTER, formLoginFilter);
 	        ConfigUtils.addHttpFilter(pc, new RuntimeBeanReference(BeanIds.FORM_LOGIN_FILTER));
 	        pc.getRegistry().registerBeanDefinition(BeanIds.FORM_LOGIN_ENTRY_POINT, formLoginEntryPoint);
@@ -410,7 +399,6 @@ public class HttpSecurityBeanDefinitionParser implements BeanDefinitionParser {
 
         if (openIDFilter != null) {
         	needLoginPage = true;
-        	openIDFilter.getPropertyValues().addPropertyValue("allowSessionCreation", new Boolean(allowSessionCreation));
 	        pc.getRegistry().registerBeanDefinition(BeanIds.OPEN_ID_FILTER, openIDFilter);
 	        ConfigUtils.addHttpFilter(pc, new RuntimeBeanReference(BeanIds.OPEN_ID_FILTER));
 	        pc.getRegistry().registerBeanDefinition(BeanIds.OPEN_ID_ENTRY_POINT, openIDEntryPoint);

core/src/main/java/org/springframework/security/config/HttpSecurityConfigPostProcessor.java

@@ -0,0 +1,150 @@
+package org.springframework.security.config;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+import org.springframework.beans.BeansException;
+import org.springframework.beans.PropertyValue;
+import org.springframework.beans.factory.BeanFactory;
+import org.springframework.beans.factory.NoSuchBeanDefinitionException;
+import org.springframework.beans.factory.config.BeanDefinition;
+import org.springframework.beans.factory.config.BeanFactoryPostProcessor;
+import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
+import org.springframework.beans.factory.config.RuntimeBeanReference;
+import org.springframework.beans.factory.support.BeanDefinitionBuilder;
+import org.springframework.beans.factory.support.RootBeanDefinition;
+import org.springframework.core.Ordered;
+import org.springframework.security.ui.AuthenticationEntryPoint;
+import org.springframework.security.userdetails.UserDetailsByNameServiceWrapper;
+import org.springframework.util.Assert;
+
+/**
+ * Responsible for tying up the HTTP security configuration once all the beans are registered.
+ * This class does not actually instantiate any beans (for example, it should not call {@link BeanFactory#getBean(String)}).
+ * All the wiring up should be done using bean definitions or bean references to avoid this. This approach should avoid any
+ * conflict with other processors.
+ *
+ * @author Luke Taylor
+ * @author Ben Alex
+ * @version $Id$
+ * @since 2.0
+ */
+public class HttpSecurityConfigPostProcessor implements BeanFactoryPostProcessor, Ordered {
+    private Log logger = LogFactory.getLog(getClass());
+
+    public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) throws BeansException {
+        injectUserDetailsServiceIntoRememberMeServices(beanFactory);
+        injectUserDetailsServiceIntoX509Provider(beanFactory);
+        injectUserDetailsServiceIntoOpenIDProvider(beanFactory);
+        injectAuthenticationEntryPointIntoExceptionTranslationFilter(beanFactory);
+    }
+
+    private void injectUserDetailsServiceIntoRememberMeServices(ConfigurableListableBeanFactory bf) {
+        try {
+            BeanDefinition rememberMeServices = bf.getBeanDefinition(BeanIds.REMEMBER_ME_SERVICES);
+            PropertyValue pv = rememberMeServices.getPropertyValues().getPropertyValue("userDetailsService");
+
+            if (pv == null) {
+                rememberMeServices.getPropertyValues().addPropertyValue("userDetailsService",
+                    ConfigUtils.getUserDetailsService(bf));
+            } else {
+            	RuntimeBeanReference cachingUserService = getCachingUserService(bf, pv.getValue());
+            	
+            	if (cachingUserService != null) {
+            		rememberMeServices.getPropertyValues().addPropertyValue("userDetailsService", cachingUserService);
+            	}            	
+            }
+        } catch (NoSuchBeanDefinitionException e) {
+            // ignore
+        }
+    }
+
+    private void injectUserDetailsServiceIntoX509Provider(ConfigurableListableBeanFactory bf) {
+        try {
+            BeanDefinition x509AuthProvider = bf.getBeanDefinition(BeanIds.X509_AUTH_PROVIDER);
+            PropertyValue pv = x509AuthProvider.getPropertyValues().getPropertyValue("preAuthenticatedUserDetailsService");
+
+            if (pv == null) {
+            	BeanDefinitionBuilder preAuthUserService = BeanDefinitionBuilder.rootBeanDefinition(UserDetailsByNameServiceWrapper.class);
+            	preAuthUserService.addPropertyValue("userDetailsService", ConfigUtils.getUserDetailsService(bf));
+                x509AuthProvider.getPropertyValues().addPropertyValue("preAuthenticatedUserDetailsService",
+                        preAuthUserService.getBeanDefinition());
+            } else {
+            	RootBeanDefinition preAuthUserService = (RootBeanDefinition) pv.getValue();
+            	Object userService = 
+            		preAuthUserService.getPropertyValues().getPropertyValue("userDetailsService").getValue();
+            	
+            	RuntimeBeanReference cachingUserService = getCachingUserService(bf, userService);
+            	
+            	if (cachingUserService != null) {
+            		preAuthUserService.getPropertyValues().addPropertyValue("userDetailsService", cachingUserService);
+            	}
+            }
+        } catch (NoSuchBeanDefinitionException e) {
+            // ignore
+        }
+    }
+    
+    private void injectUserDetailsServiceIntoOpenIDProvider(ConfigurableListableBeanFactory beanFactory) {
+        try {
+            BeanDefinition openIDProvider = beanFactory.getBeanDefinition(BeanIds.OPEN_ID_PROVIDER);
+            PropertyValue pv = openIDProvider.getPropertyValues().getPropertyValue("userDetailsService");
+
+            if (pv == null) {
+                openIDProvider.getPropertyValues().addPropertyValue("userDetailsService",
+                    ConfigUtils.getUserDetailsService(beanFactory));
+            }
+        } catch (NoSuchBeanDefinitionException e) {
+            // ignore
+        }
+    }
+    
+    private RuntimeBeanReference getCachingUserService(ConfigurableListableBeanFactory bf, Object userServiceRef) {
+    	Assert.isInstanceOf(RuntimeBeanReference.class, userServiceRef, 
+    			"userDetailsService property value must be a RuntimeBeanReference");
+    	
+    	String id = ((RuntimeBeanReference)userServiceRef).getBeanName();
+    	// Overwrite with the caching version if available
+    	String cachingId = id + AbstractUserDetailsServiceBeanDefinitionParser.CACHING_SUFFIX;
+    	
+    	if (bf.containsBeanDefinition(cachingId)) {
+    		return new RuntimeBeanReference(cachingId);
+    	}
+    	
+    	return null;
+    }
+
+    /**
+     * Selects the entry point that should be used in ExceptionTranslationFilter. If an entry point has been
+     * set during parsing of form, openID and basic authentication information, or via a custom reference
+     * (using <tt>custom-entry-point</tt>, then that will be used. Otherwise there
+     * must be a single entry point bean and that will be used.
+     * 
+     * Todo: this could probably be more easily be done in a BeanPostProcessor for ExceptionTranslationFilter.
+     *
+     */
+    private void injectAuthenticationEntryPointIntoExceptionTranslationFilter(ConfigurableListableBeanFactory beanFactory) {
+        logger.info("Selecting AuthenticationEntryPoint for use in ExceptionTranslationFilter");        
+        
+        BeanDefinition etf =
+                beanFactory.getBeanDefinition(BeanIds.EXCEPTION_TRANSLATION_FILTER);
+        
+        String entryPoint = null;
+        
+        if (beanFactory.containsBean(BeanIds.MAIN_ENTRY_POINT)) {
+            entryPoint = BeanIds.MAIN_ENTRY_POINT;
+            logger.info("Using main configured AuthenticationEntryPoint set to " + BeanIds.MAIN_ENTRY_POINT);
+        } else {
+            String[] entryPoints = beanFactory.getBeanNamesForType(AuthenticationEntryPoint.class);
+            Assert.isTrue(entryPoints.length != 0, "No AuthenticationEntryPoint instances defined");
+            Assert.isTrue(entryPoints.length == 1, "More than one AuthenticationEntryPoint defined in context");
+            entryPoint = entryPoints[0];
+        }
+        
+        logger.info("Using bean '" + entryPoint + "' as the entry point.");
+        etf.getPropertyValues().addPropertyValue("authenticationEntryPoint", new RuntimeBeanReference(entryPoint));
+    }
+
+    public int getOrder() {
+        return HIGHEST_PRECEDENCE + 1;
+    }
+}

core/src/main/java/org/springframework/security/config/JdbcUserServiceBeanDefinitionParser.java

@@ -1,5 +1,6 @@
 package org.springframework.security.config;
 
+import org.springframework.security.userdetails.jdbc.JdbcUserDetailsManager;
 import org.springframework.util.StringUtils;
 import org.springframework.beans.factory.support.BeanDefinitionBuilder;
 import org.springframework.beans.factory.xml.ParserContext;
@@ -17,8 +18,8 @@ public class JdbcUserServiceBeanDefinitionParser extends AbstractUserDetailsServ
 	static final String ATT_GROUP_AUTHORITIES_QUERY = "group-authorities-by-username-query";
 	static final String ATT_ROLE_PREFIX = "role-prefix";
 
-    protected String getBeanClassName(Element element) {
-        return "org.springframework.security.userdetails.jdbc.JdbcUserDetailsManager";
+    protected Class getBeanClass(Element element) {
+        return JdbcUserDetailsManager.class;
     }
 
     protected void doParse(Element element, ParserContext parserContext, BeanDefinitionBuilder builder) {

core/src/main/java/org/springframework/security/config/LdapProviderBeanDefinitionParser.java

@@ -1,8 +1,11 @@
 package org.springframework.security.config;
 
+import org.springframework.security.ldap.search.FilterBasedLdapUserSearch;
+import org.springframework.security.providers.ldap.LdapAuthenticationProvider;
+import org.springframework.security.providers.ldap.authenticator.BindAuthenticator;
+import org.springframework.security.providers.ldap.authenticator.PasswordComparisonAuthenticator;
 import org.springframework.beans.factory.config.BeanDefinition;
 import org.springframework.beans.factory.config.RuntimeBeanReference;
-import org.springframework.beans.factory.support.BeanDefinitionBuilder;
 import org.springframework.beans.factory.support.RootBeanDefinition;
 import org.springframework.beans.factory.xml.BeanDefinitionParser;
 import org.springframework.beans.factory.xml.ParserContext;
@@ -27,16 +30,12 @@ public class LdapProviderBeanDefinitionParser implements BeanDefinitionParser {
     private static final String ATT_USER_PASSWORD = "password-attribute";
     private static final String ATT_HASH = PasswordEncoderParser.ATT_HASH; 
     
-    private static final String DEF_USER_SEARCH_FILTER = "uid={0}";
-    
-    private static final String PROVIDER_CLASS = "org.springframework.security.providers.ldap.LdapAuthenticationProvider";
-    private static final String BIND_AUTH_CLASS = "org.springframework.security.providers.ldap.authenticator.BindAuthenticator";
-    private static final String PASSWD_AUTH_CLASS = "org.springframework.security.providers.ldap.authenticator.PasswordComparisonAuthenticator";
+    private static final String DEF_USER_SEARCH_FILTER="uid={0}";
 
     public BeanDefinition parse(Element elt, ParserContext parserContext) {
         RuntimeBeanReference contextSource = LdapUserServiceBeanDefinitionParser.parseServerReference(elt, parserContext);
         
-        BeanDefinition searchBean = LdapUserServiceBeanDefinitionParser.parseSearchBean(elt, parserContext);
+        RootBeanDefinition searchBean = LdapUserServiceBeanDefinitionParser.parseSearchBean(elt, parserContext);
         String userDnPattern = elt.getAttribute(ATT_USER_DN_PATTERN);
         
         String[] userDnPatternArray = new String[0];
@@ -46,25 +45,22 @@ public class LdapProviderBeanDefinitionParser implements BeanDefinitionParser {
             // TODO: Validate the pattern and make sure it is a valid DN.
         } else if (searchBean == null) {
             logger.info("No search information or DN pattern specified. Using default search filter '" + DEF_USER_SEARCH_FILTER + "'");
-            BeanDefinitionBuilder searchBeanBuilder = BeanDefinitionBuilder.rootBeanDefinition(LdapUserServiceBeanDefinitionParser.LDAP_SEARCH_CLASS); 
-            searchBeanBuilder.setSource(elt);
-            searchBeanBuilder.addConstructorArg("");
-            searchBeanBuilder.addConstructorArg(DEF_USER_SEARCH_FILTER);
-            searchBeanBuilder.addConstructorArg(contextSource);
-            searchBean = searchBeanBuilder.getBeanDefinition();
+            searchBean = new RootBeanDefinition(FilterBasedLdapUserSearch.class);
+            searchBean.setSource(elt);
+            searchBean.getConstructorArgumentValues().addIndexedArgumentValue(0, "");
+            searchBean.getConstructorArgumentValues().addIndexedArgumentValue(1, DEF_USER_SEARCH_FILTER);
+            searchBean.getConstructorArgumentValues().addIndexedArgumentValue(2, contextSource);
         }
         
-        BeanDefinitionBuilder authenticatorBuilder = 
-        	BeanDefinitionBuilder.rootBeanDefinition(BIND_AUTH_CLASS);
+        RootBeanDefinition authenticator = new RootBeanDefinition(BindAuthenticator.class);
         Element passwordCompareElt = DomUtils.getChildElementByTagName(elt, Elements.LDAP_PASSWORD_COMPARE);
         
         if (passwordCompareElt != null) {
-        	authenticatorBuilder = 
-            	BeanDefinitionBuilder.rootBeanDefinition(PASSWD_AUTH_CLASS);
+            authenticator = new RootBeanDefinition(PasswordComparisonAuthenticator.class);
             
             String passwordAttribute = passwordCompareElt.getAttribute(ATT_USER_PASSWORD);
             if (StringUtils.hasText(passwordAttribute)) {
-            	authenticatorBuilder.addPropertyValue("passwordAttributeName", passwordAttribute);
+                authenticator.getPropertyValues().addPropertyValue("passwordAttributeName", passwordAttribute);
             }
             
             Element passwordEncoderElement = DomUtils.getChildElementByTagName(passwordCompareElt, Elements.PASSWORD_ENCODER);
@@ -74,34 +70,33 @@ public class LdapProviderBeanDefinitionParser implements BeanDefinitionParser {
                 if (StringUtils.hasText(hash)) {
                     parserContext.getReaderContext().warning("Attribute 'hash' cannot be used with 'password-encoder' and " +
                             "will be ignored.", parserContext.extractSource(elt));
-                }
+                }                
                 PasswordEncoderParser pep = new PasswordEncoderParser(passwordEncoderElement, parserContext);
-                authenticatorBuilder.addPropertyValue("passwordEncoder", pep.getPasswordEncoder());
+                authenticator.getPropertyValues().addPropertyValue("passwordEncoder", pep.getPasswordEncoder());
                 
                 if (pep.getSaltSource() != null) {
-                    parserContext.getReaderContext().warning("Salt source information isn't valid when used with LDAP", 
-                    		passwordEncoderElement);
+                    parserContext.getReaderContext().warning("Salt source information isn't valid when used with LDAP", passwordEncoderElement);
                 }
             } else if (StringUtils.hasText(hash)) {
                 Class encoderClass = (Class) PasswordEncoderParser.ENCODER_CLASSES.get(hash);
-                authenticatorBuilder.addPropertyValue("passwordEncoder", new RootBeanDefinition(encoderClass));
+                authenticator.getPropertyValues().addPropertyValue("passwordEncoder", new RootBeanDefinition(encoderClass));
             }
-        }
+        } 
         
-        authenticatorBuilder.addConstructorArg(contextSource);
-        authenticatorBuilder.addPropertyValue("userDnPatterns", userDnPatternArray);
+        authenticator.getConstructorArgumentValues().addGenericArgumentValue(contextSource);
+        authenticator.getPropertyValues().addPropertyValue("userDnPatterns", userDnPatternArray);
         
         if (searchBean != null) {
-        	authenticatorBuilder.addPropertyValue("userSearch", searchBean);
+            authenticator.getPropertyValues().addPropertyValue("userSearch", searchBean);
         }
                 
-        BeanDefinitionBuilder ldapProvider = BeanDefinitionBuilder.rootBeanDefinition(PROVIDER_CLASS);
-        ldapProvider.addConstructorArg(authenticatorBuilder.getBeanDefinition());
-        ldapProvider.addConstructorArg(LdapUserServiceBeanDefinitionParser.parseAuthoritiesPopulator(elt, parserContext));
-        ldapProvider.addPropertyValue("userDetailsContextMapper", 
+        RootBeanDefinition ldapProvider = new RootBeanDefinition(LdapAuthenticationProvider.class);
+        ldapProvider.getConstructorArgumentValues().addGenericArgumentValue(authenticator);
+        ldapProvider.getConstructorArgumentValues().addGenericArgumentValue(LdapUserServiceBeanDefinitionParser.parseAuthoritiesPopulator(elt, parserContext));
+        ldapProvider.getPropertyValues().addPropertyValue("userDetailsContextMapper", 
         		LdapUserServiceBeanDefinitionParser.parseUserDetailsClass(elt, parserContext));
         
-        ConfigUtils.getRegisteredProviders(parserContext).add(ldapProvider.getBeanDefinition());
+        ConfigUtils.getRegisteredProviders(parserContext).add(ldapProvider);
 
         return null;
     }

core/src/main/java/org/springframework/security/config/LdapServerBeanDefinitionParser.java

@@ -1,10 +1,6 @@
 package org.springframework.security.config;
 
-import javax.naming.directory.Attribute;
-import javax.naming.directory.Attributes;
-import javax.naming.directory.BasicAttribute;
-import javax.naming.directory.BasicAttributes;
-
+import org.springframework.security.ldap.DefaultSpringSecurityContextSource;
 import org.springframework.beans.factory.xml.BeanDefinitionParser;
 import org.springframework.beans.factory.xml.ParserContext;
 import org.springframework.beans.factory.xml.AbstractBeanDefinitionParser;
@@ -12,6 +8,7 @@ import org.springframework.beans.factory.config.BeanDefinition;
 import org.springframework.beans.factory.support.RootBeanDefinition;
 import org.springframework.beans.factory.support.BeanDefinitionBuilder;
 import org.springframework.beans.factory.support.ManagedSet;
+import org.springframework.ldap.core.DirContextAdapter;
 import org.springframework.util.StringUtils;
 
 import org.w3c.dom.Element;
@@ -23,9 +20,7 @@ import org.apache.commons.logging.LogFactory;
  * @version $Id$
  */
 public class LdapServerBeanDefinitionParser implements BeanDefinitionParser {
-	private static final String CONTEXT_SOURCE_CLASS="org.springframework.security.ldap.DefaultSpringSecurityContextSource";
-	
-    private final Log logger = LogFactory.getLog(getClass());
+    private Log logger = LogFactory.getLog(getClass());
 
     /** Defines the Url of the ldap server to use. If not specified, an embedded apache DS instance will be created */
     private static final String ATT_URL = "url";
@@ -58,8 +53,7 @@ public class LdapServerBeanDefinitionParser implements BeanDefinitionParser {
         if (!StringUtils.hasText(url)) {
             contextSource = createEmbeddedServer(elt, parserContext);
         } else {
-            contextSource = new RootBeanDefinition();
-            contextSource.setBeanClassName(CONTEXT_SOURCE_CLASS);
+            contextSource = new RootBeanDefinition(DefaultSpringSecurityContextSource.class);
             contextSource.getConstructorArgumentValues().addIndexedArgumentValue(0, url);
         }
 
@@ -98,22 +92,17 @@ public class LdapServerBeanDefinitionParser implements BeanDefinitionParser {
      */
     private RootBeanDefinition createEmbeddedServer(Element element, ParserContext parserContext) {
         Object source = parserContext.extractSource(element);
-        BeanDefinitionBuilder configuration = 
-        	BeanDefinitionBuilder.rootBeanDefinition("org.apache.directory.server.configuration.MutableServerStartupConfiguration");
-        BeanDefinitionBuilder partition = 
-        	BeanDefinitionBuilder.rootBeanDefinition("org.apache.directory.server.core.partition.impl.btree.MutableBTreePartitionConfiguration");
+        BeanDefinitionBuilder configuration = BeanDefinitionBuilder.rootBeanDefinition("org.apache.directory.server.configuration.MutableServerStartupConfiguration");
+        BeanDefinitionBuilder partition = BeanDefinitionBuilder.rootBeanDefinition("org.apache.directory.server.core.partition.impl.btree.MutableBTreePartitionConfiguration");
         configuration.setSource(source);
         partition.setSource(source);
-        
-        Attributes rootAttributes = new BasicAttributes("dc", "springsecurity");
-        Attribute a = new BasicAttribute("objectClass");
-        a.add("top");
-        a.add("domain");
-        a.add("extensibleObject");
-        rootAttributes.put(a);
+
+        DirContextAdapter rootContext = new DirContextAdapter();
+        rootContext.setAttributeValues("objectClass", new String[] {"top", "domain", "extensibleObject"});
+        rootContext.setAttributeValue("dc", "springsecurity");
 
         partition.addPropertyValue("name", "springsecurity");
-        partition.addPropertyValue("contextEntry", rootAttributes);
+        partition.addPropertyValue("contextEntry", rootContext.getAttributes());
 
         String suffix = element.getAttribute(ATT_ROOT_SUFFIX);
 
@@ -142,15 +131,15 @@ public class LdapServerBeanDefinitionParser implements BeanDefinitionParser {
 
         String url = "ldap://127.0.0.1:" + port + "/" + suffix;
 
-        BeanDefinitionBuilder contextSource = BeanDefinitionBuilder.rootBeanDefinition(CONTEXT_SOURCE_CLASS);
-        contextSource.addConstructorArg(url);
-        contextSource.addPropertyValue("userDn", "uid=admin,ou=system");
-        contextSource.addPropertyValue("password", "secret");
+        RootBeanDefinition contextSource = new RootBeanDefinition(DefaultSpringSecurityContextSource.class);
+        contextSource.getConstructorArgumentValues().addIndexedArgumentValue(0, url);
+        contextSource.getPropertyValues().addPropertyValue("userDn", "uid=admin,ou=system");
+        contextSource.getPropertyValues().addPropertyValue("password", "secret");
 
         RootBeanDefinition apacheContainer = new RootBeanDefinition("org.springframework.security.config.ApacheDSContainer", null, null);
         apacheContainer.setSource(source);
         apacheContainer.getConstructorArgumentValues().addGenericArgumentValue(configuration.getBeanDefinition());
-        apacheContainer.getConstructorArgumentValues().addGenericArgumentValue(contextSource.getBeanDefinition());
+        apacheContainer.getConstructorArgumentValues().addGenericArgumentValue(contextSource);
 
         String ldifs = element.getAttribute(ATT_LDIF_FILE);
         if (!StringUtils.hasText(ldifs)) {
@@ -168,6 +157,6 @@ public class LdapServerBeanDefinitionParser implements BeanDefinitionParser {
 
         parserContext.getRegistry().registerBeanDefinition(BeanIds.EMBEDDED_APACHE_DS, apacheContainer);
 
-        return (RootBeanDefinition) contextSource.getBeanDefinition();
+        return contextSource;
     }
 }

core/src/main/java/org/springframework/security/config/LdapUserServiceBeanDefinitionParser.java

@@ -1,5 +1,11 @@
 package org.springframework.security.config;
 
+import org.springframework.security.userdetails.ldap.InetOrgPersonContextMapper;
+import org.springframework.security.userdetails.ldap.LdapUserDetailsMapper;
+import org.springframework.security.userdetails.ldap.LdapUserDetailsService;
+import org.springframework.security.userdetails.ldap.PersonContextMapper;
+import org.springframework.security.ldap.search.FilterBasedLdapUserSearch;
+import org.springframework.security.ldap.populator.DefaultLdapAuthoritiesPopulator;
 import org.springframework.beans.factory.xml.ParserContext;
 import org.springframework.beans.factory.support.BeanDefinitionBuilder;
 import org.springframework.beans.factory.support.RootBeanDefinition;
@@ -29,15 +35,9 @@ public class LdapUserServiceBeanDefinitionParser extends AbstractUserDetailsServ
     static final String ATT_USER_CLASS = "user-details-class";
     static final String OPT_PERSON = "person";
     static final String OPT_INETORGPERSON = "inetOrgPerson";
-    
-    public static final String LDAP_SEARCH_CLASS = "org.springframework.security.ldap.search.FilterBasedLdapUserSearch";
-    public static final String PERSON_MAPPER_CLASS = "org.springframework.security.userdetails.ldap.PersonContextMapper";
-    public static final String INET_ORG_PERSON_MAPPER_CLASS = "org.springframework.security.userdetails.ldap.InetOrgPersonContextMapper";
-    public static final String LDAP_USER_MAPPER_CLASS = "org.springframework.security.userdetails.ldap.LdapUserDetailsMapper";
-    public static final String LDAP_AUTHORITIES_POPULATOR_CLASS = "org.springframework.security.ldap.populator.DefaultLdapAuthoritiesPopulator";
 
-    protected String getBeanClassName(Element element) {
-        return "org.springframework.security.userdetails.ldap.LdapUserDetailsService";
+    protected Class getBeanClass(Element element) {
+        return LdapUserDetailsService.class;
     }
 
     protected void doParse(Element elt, ParserContext parserContext, BeanDefinitionBuilder builder) {
@@ -68,7 +68,7 @@ public class LdapUserServiceBeanDefinitionParser extends AbstractUserDetailsServ
             return null;
         }
         
-        BeanDefinitionBuilder searchBuilder = BeanDefinitionBuilder.rootBeanDefinition(LDAP_SEARCH_CLASS);
+        BeanDefinitionBuilder searchBuilder = BeanDefinitionBuilder.rootBeanDefinition(FilterBasedLdapUserSearch.class);
         searchBuilder.setSource(source);
         searchBuilder.addConstructorArg(userSearchBase);
         searchBuilder.addConstructorArg(userSearchFilter);
@@ -96,12 +96,12 @@ public class LdapUserServiceBeanDefinitionParser extends AbstractUserDetailsServ
     static RootBeanDefinition parseUserDetailsClass(Element elt, ParserContext parserContext) {
     	String userDetailsClass = elt.getAttribute(ATT_USER_CLASS);
     	
-    	if (OPT_PERSON.equals(userDetailsClass)) {
-    		return new RootBeanDefinition(PERSON_MAPPER_CLASS, null, null);
+    	if(OPT_PERSON.equals(userDetailsClass)) {
+    		return new RootBeanDefinition(PersonContextMapper.class);
     	} else if (OPT_INETORGPERSON.equals(userDetailsClass)) {
-    		return new RootBeanDefinition(INET_ORG_PERSON_MAPPER_CLASS, null, null);
+    		return new RootBeanDefinition(InetOrgPersonContextMapper.class);
     	}
-    	return new RootBeanDefinition(LDAP_USER_MAPPER_CLASS, null, null);
+    	return new RootBeanDefinition(LdapUserDetailsMapper.class);
     }
     
     static RootBeanDefinition parseAuthoritiesPopulator(Element elt, ParserContext parserContext) {
@@ -118,19 +118,18 @@ public class LdapUserServiceBeanDefinitionParser extends AbstractUserDetailsServ
             groupSearchBase = DEF_GROUP_SEARCH_BASE;
         }
         
-        BeanDefinitionBuilder populator = BeanDefinitionBuilder.rootBeanDefinition(LDAP_AUTHORITIES_POPULATOR_CLASS);
+        BeanDefinitionBuilder populator = BeanDefinitionBuilder.rootBeanDefinition(DefaultLdapAuthoritiesPopulator.class);
         populator.setSource(parserContext.extractSource(elt));
         populator.addConstructorArg(parseServerReference(elt, parserContext));
         populator.addConstructorArg(groupSearchBase);
         populator.addPropertyValue("groupSearchFilter", groupSearchFilter);
-        populator.addPropertyValue("searchSubtree", Boolean.TRUE);
         
         if (StringUtils.hasText(rolePrefix)) {
             if ("none".equals(rolePrefix)) {
                 rolePrefix = "";
             }
             populator.addPropertyValue("rolePrefix", rolePrefix);
-        }
+        }                
         
         if (StringUtils.hasLength(groupRoleAttribute)) {
             populator.addPropertyValue("groupRoleAttribute", groupRoleAttribute);

core/src/main/java/org/springframework/security/config/MethodSecurityInterceptorPostProcessor.java

@@ -23,7 +23,7 @@ public class MethodSecurityInterceptorPostProcessor implements BeanPostProcessor
     private BeanFactory beanFactory;
 
     public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
-        if(!BeanIds.METHOD_SECURITY_INTERCEPTOR.equals(beanName)) {
+        if(!beanName.equals(BeanIds.METHOD_SECURITY_INTERCEPTOR)) {
             return bean;
         }
 

core/src/main/java/org/springframework/security/config/PasswordEncoderParser.java

@@ -35,7 +35,6 @@ public class PasswordEncoderParser {
     static final String ATT_BASE_64 = "base64";
     static final String OPT_HASH_PLAINTEXT = "plaintext";    
     static final String OPT_HASH_SHA = "sha";
-    static final String OPT_HASH_SHA256 = "sha-256";    
     static final String OPT_HASH_MD4 = "md4";
     static final String OPT_HASH_MD5 = "md5";
     static final String OPT_HASH_LDAP_SHA = "{sha}";
@@ -46,7 +45,6 @@ public class PasswordEncoderParser {
         ENCODER_CLASSES = new HashMap();
         ENCODER_CLASSES.put(OPT_HASH_PLAINTEXT, PlaintextPasswordEncoder.class);
         ENCODER_CLASSES.put(OPT_HASH_SHA, ShaPasswordEncoder.class);
-        ENCODER_CLASSES.put(OPT_HASH_SHA256, ShaPasswordEncoder.class);
         ENCODER_CLASSES.put(OPT_HASH_MD4, Md4PasswordEncoder.class);
         ENCODER_CLASSES.put(OPT_HASH_MD5, Md5PasswordEncoder.class);
         ENCODER_CLASSES.put(OPT_HASH_LDAP_SHA, LdapShaPasswordEncoder.class);
@@ -76,11 +74,6 @@ public class PasswordEncoderParser {
         } else {
             Class beanClass = (Class) ENCODER_CLASSES.get(hash);
             RootBeanDefinition beanDefinition = new RootBeanDefinition(beanClass);
-            
-            if (OPT_HASH_SHA256.equals(hash)) {
-            	beanDefinition.getConstructorArgumentValues().addIndexedArgumentValue(0, new Integer(256));
-            }
-            
             beanDefinition.setSource(parserContext.extractSource(element));
             if (useBase64) {
                 if (BaseDigestPasswordEncoder.class.isAssignableFrom(beanClass)) {

core/src/main/java/org/springframework/security/config/RememberMeBeanDefinitionParser.java

@@ -23,14 +23,12 @@ import org.w3c.dom.Element;
  */
 public class RememberMeBeanDefinitionParser implements BeanDefinitionParser {
     static final String ATT_KEY = "key";
-    static final String DEF_KEY = "SpringSecured";
+    static final String DEF_KEY = "doesNotMatter";
 
-	static final String ATT_DATA_SOURCE = "data-source-ref";
-	static final String ATT_SERVICES_REF = "services-ref";
+	static final String ATT_DATA_SOURCE = "data-source";
 	static final String ATT_TOKEN_REPOSITORY = "token-repository-ref";
 	static final String ATT_USER_SERVICE_REF = "user-service-ref";
-	static final String ATT_TOKEN_VALIDITY = "token-validity-seconds";
-
+	
 	protected final Log logger = LogFactory.getLog(getClass());
 
     public BeanDefinition parse(Element element, ParserContext parserContext) {
@@ -39,100 +37,74 @@ public class RememberMeBeanDefinitionParser implements BeanDefinitionParser {
         String key = null;
         Object source = null;
         String userServiceRef = null;
-        String rememberMeServicesRef = null;
-        String tokenValiditySeconds = null;
 
         if (element != null) {
             tokenRepository = element.getAttribute(ATT_TOKEN_REPOSITORY);
             dataSource = element.getAttribute(ATT_DATA_SOURCE);
             key = element.getAttribute(ATT_KEY);
-            userServiceRef = element.getAttribute(ATT_USER_SERVICE_REF);
-            rememberMeServicesRef = element.getAttribute(ATT_SERVICES_REF);
-            tokenValiditySeconds = element.getAttribute(ATT_TOKEN_VALIDITY);
+            userServiceRef = element.getAttribute(ATT_USER_SERVICE_REF);            
             source = parserContext.extractSource(element);
         }
-        
-        if (!StringUtils.hasText(key)) {
-        	key = DEF_KEY;
-        }        
-        
-        RootBeanDefinition services = null;
+
+        RootBeanDefinition filter = new RootBeanDefinition(RememberMeProcessingFilter.class);
+        RootBeanDefinition services = new RootBeanDefinition(PersistentTokenBasedRememberMeServices.class);
+
+        filter.getPropertyValues().addPropertyValue("authenticationManager",
+                new RuntimeBeanReference(BeanIds.AUTHENTICATION_MANAGER));
 
         boolean dataSourceSet = StringUtils.hasText(dataSource);
         boolean tokenRepoSet = StringUtils.hasText(tokenRepository);
-        boolean servicesRefSet = StringUtils.hasText(rememberMeServicesRef);
-        boolean userServiceSet = StringUtils.hasText(userServiceRef);
-        boolean tokenValiditySet = StringUtils.hasText(tokenValiditySeconds);
-        
-        if (servicesRefSet && (dataSourceSet || tokenRepoSet || userServiceSet || tokenValiditySet)) {
-    		parserContext.getReaderContext().error(ATT_SERVICES_REF + " can't be used in combination with attributes " 
-    				+ ATT_TOKEN_REPOSITORY + "," + ATT_DATA_SOURCE + ", " + ATT_USER_SERVICE_REF + " or " + ATT_TOKEN_VALIDITY, source);        	
-        }
-        
+
         if (dataSourceSet && tokenRepoSet) {
-            parserContext.getReaderContext().error("Specify " + ATT_TOKEN_REPOSITORY + " or " + 
-            		ATT_DATA_SOURCE +" but not both", source);
+            parserContext.getReaderContext().error("Specify tokenRepository or dataSource but not both", element);
         }
 
         boolean isPersistent = dataSourceSet | tokenRepoSet;
 
         if (isPersistent) {
             Object tokenRepo;
-            services = new RootBeanDefinition(PersistentTokenBasedRememberMeServices.class);
 
             if (tokenRepoSet) {
                 tokenRepo = new RuntimeBeanReference(tokenRepository);
             } else {
                 tokenRepo = new RootBeanDefinition(JdbcTokenRepositoryImpl.class);
-                ((BeanDefinition)tokenRepo).getPropertyValues().addPropertyValue("dataSource",
+                ((BeanDefinition)tokenRepo).getPropertyValues().addPropertyValue(ATT_DATA_SOURCE,
                         new RuntimeBeanReference(dataSource));
             }
             services.getPropertyValues().addPropertyValue("tokenRepository", tokenRepo);
-        } else if (!servicesRefSet) {
+        } else {
+            isPersistent = false;
             services = new RootBeanDefinition(TokenBasedRememberMeServices.class);
         }
 
-        if (services != null) {
-	        if (userServiceSet) {
-	            services.getPropertyValues().addPropertyValue("userDetailsService", new RuntimeBeanReference(userServiceRef));
-	        }
-	        
-	        if (tokenValiditySet) {
-	        	services.getPropertyValues().addPropertyValue("tokenValiditySeconds", new Integer(tokenValiditySeconds));
-	        }
-	        services.setSource(source);
-	        services.getPropertyValues().addPropertyValue(ATT_KEY, key);
-	        parserContext.getRegistry().registerBeanDefinition(BeanIds.REMEMBER_ME_SERVICES, services);	        
-        } else {
-        	parserContext.getRegistry().registerAlias(rememberMeServicesRef, BeanIds.REMEMBER_ME_SERVICES);
+        if (!StringUtils.hasText(key) && !isPersistent) {
+        	key = DEF_KEY;
         }
-        
-        registerProvider(parserContext, source, key);        
-        
-        registerFilter(parserContext, source);
 
-        return null;
-    }
-    
-    private void registerProvider(ParserContext pc, Object source, String key) {
-        BeanDefinition authManager = ConfigUtils.registerProviderManagerIfNecessary(pc);
+        BeanDefinition authManager = ConfigUtils.registerProviderManagerIfNecessary(parserContext);
         RootBeanDefinition provider = new RootBeanDefinition(RememberMeAuthenticationProvider.class);
-        provider.setSource(source);
-        provider.getPropertyValues().addPropertyValue(ATT_KEY, key);
-        ManagedList providers = (ManagedList) authManager.getPropertyValues().getPropertyValue("providers").getValue();
-        providers.add(provider);    	
-    }
-    
-    private void registerFilter(ParserContext pc, Object source) {
-        RootBeanDefinition filter = new RootBeanDefinition(RememberMeProcessingFilter.class);
+
         filter.setSource(source);
-        filter.getPropertyValues().addPropertyValue("authenticationManager",
-                new RuntimeBeanReference(BeanIds.AUTHENTICATION_MANAGER));        
-        
+        services.setSource(source);
+        provider.setSource(source);
+
+        if (StringUtils.hasText(userServiceRef)) {
+            services.getPropertyValues().addPropertyValue("userDetailsService", new RuntimeBeanReference(userServiceRef));
+        }
+
+        provider.getPropertyValues().addPropertyValue(ATT_KEY, key);
+        services.getPropertyValues().addPropertyValue(ATT_KEY, key);
+
+        ManagedList providers = (ManagedList) authManager.getPropertyValues().getPropertyValue("providers").getValue();
+        providers.add(provider);
+
         filter.getPropertyValues().addPropertyValue("rememberMeServices",
                 new RuntimeBeanReference(BeanIds.REMEMBER_ME_SERVICES));
 
-        pc.getRegistry().registerBeanDefinition(BeanIds.REMEMBER_ME_FILTER, filter);
-        ConfigUtils.addHttpFilter(pc, new RuntimeBeanReference(BeanIds.REMEMBER_ME_FILTER));    	
+        parserContext.getRegistry().registerBeanDefinition(BeanIds.REMEMBER_ME_SERVICES, services);
+        parserContext.getRegistry().registerBeanDefinition(BeanIds.REMEMBER_ME_FILTER, filter);
+        ConfigUtils.addHttpFilter(parserContext, new RuntimeBeanReference(BeanIds.REMEMBER_ME_FILTER));
+
+        return null;
     }
 }

core/src/main/java/org/springframework/security/config/RememberMeServicesInjectionBeanPostProcessor.java

@@ -33,7 +33,7 @@ public class RememberMeServicesInjectionBeanPostProcessor implements BeanPostPro
                 logger.info("Setting RememberMeServices on bean " + beanName);
                 pf.setRememberMeServices(getRememberMeServices());
             }
-        } else if (BeanIds.BASIC_AUTHENTICATION_FILTER.equals(beanName)) {
+        } else if (beanName.equals(BeanIds.BASIC_AUTHENTICATION_FILTER)) {
             // NB: For remember-me to be sent back, a user must submit a "_spring_security_remember_me" with their login request.
             // Most of the time a user won't present such a parameter with their BASIC authentication request.
             // In the future we might support setting the AbstractRememberMeServices.alwaysRemember = true, but I am reluctant to

core/src/main/java/org/springframework/security/config/SessionRegistryInjectionBeanPostProcessor.java

@@ -1,94 +0,0 @@
-package org.springframework.security.config;
-
-import java.util.ArrayList;
-import java.util.List;
-
-import org.springframework.beans.BeansException;
-import org.springframework.beans.factory.BeanFactory;
-import org.springframework.beans.factory.BeanFactoryAware;
-import org.springframework.beans.factory.ListableBeanFactory;
-import org.springframework.beans.factory.config.BeanPostProcessor;
-import org.springframework.security.concurrent.ConcurrentSessionController;
-import org.springframework.security.concurrent.ConcurrentSessionControllerImpl;
-import org.springframework.security.concurrent.SessionRegistry;
-import org.springframework.security.ui.AbstractProcessingFilter;
-import org.springframework.security.ui.SessionFixationProtectionFilter;
-
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-
-/**
- * Registered by the <tt>AuthenticationManagerBeanDefinitionParser</tt> if an external 
- * ConcurrentSessionController is set (and hence an external SessionRegistry). 
- * Its responsibility is to set the SessionRegistry on namespace-registered beans which require access
- * to it.
- * <p>
- * It will attempt to read the registry directly from the registered controller. If that fails, it will look in
- * the application context for a registered SessionRegistry bean.
- * 
- * See SEC-879. 
- * 
- * @author Luke Taylor
- * @since 2.0.3
- */
-class SessionRegistryInjectionBeanPostProcessor implements BeanPostProcessor, BeanFactoryAware {
-    private final Log logger = LogFactory.getLog(getClass());
-    private ListableBeanFactory beanFactory;
-    private SessionRegistry sessionRegistry;
-    private final String controllerBeanName;
-
-    SessionRegistryInjectionBeanPostProcessor(String controllerBeanName) {
-    	this.controllerBeanName = controllerBeanName;
-    }
-    
-	public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
-		if (BeanIds.FORM_LOGIN_FILTER.equals(beanName) || 
-				BeanIds.OPEN_ID_FILTER.equals(beanName)) {
-			((AbstractProcessingFilter) bean).setSessionRegistry(getSessionRegistry());
-		} else if (BeanIds.SESSION_FIXATION_PROTECTION_FILTER.equals(beanName)) {
-			((SessionFixationProtectionFilter)bean).setSessionRegistry(getSessionRegistry());
-		}
-
-		return bean;
-	}	
-	
-	public Object postProcessAfterInitialization(Object bean, String beanName) throws BeansException {
-		return bean;
-	}
-	
-	private SessionRegistry getSessionRegistry() {
-		if (sessionRegistry != null) {
-			return sessionRegistry;
-		}
-		
-		logger.info("Attempting to read SessionRegistry from registered ConcurrentSessionController bean");
-		
-		ConcurrentSessionController controller = (ConcurrentSessionController) beanFactory.getBean(controllerBeanName);
-		
-		if (controller instanceof ConcurrentSessionControllerImpl) {
-			sessionRegistry = ((ConcurrentSessionControllerImpl)controller).getSessionRegistry();
-			
-			return sessionRegistry;
-		}
-
-		logger.info("ConcurrentSessionController is not a standard implementation. SessionRegistry could not be read from it. Looking for it in the context.");
-		
-		List sessionRegs = new ArrayList(beanFactory.getBeansOfType(SessionRegistry.class).values());
-		
-		if (sessionRegs.size() == 0) {			
-			throw new SecurityConfigurationException("concurrent-session-controller-ref was set but no SessionRegistry could be obtained from the application context.");
-		}
-		
-		if (sessionRegs.size() > 1) {
-			logger.warn("More than one SessionRegistry instance in application context. Possible configuration errors may result.");
-		}
-		
-		sessionRegistry = (SessionRegistry) sessionRegs.get(0);
-		
-		return sessionRegistry;
-	}
-
-	public void setBeanFactory(BeanFactory beanFactory) throws BeansException {
-		this.beanFactory = (ListableBeanFactory) beanFactory;
-	}
-}

core/src/main/java/org/springframework/security/config/UserDetailsServiceInjectionBeanPostProcessor.java

@@ -1,139 +0,0 @@
-package org.springframework.security.config;
-
-import java.util.Map;
-
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-import org.springframework.beans.BeanWrapperImpl;
-import org.springframework.beans.BeansException;
-import org.springframework.beans.PropertyValue;
-import org.springframework.beans.factory.BeanFactory;
-import org.springframework.beans.factory.BeanFactoryAware;
-import org.springframework.beans.factory.config.BeanDefinition;
-import org.springframework.beans.factory.config.BeanPostProcessor;
-import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
-import org.springframework.beans.factory.config.RuntimeBeanReference;
-import org.springframework.beans.factory.support.RootBeanDefinition;
-import org.springframework.security.providers.preauth.PreAuthenticatedAuthenticationProvider;
-import org.springframework.security.ui.rememberme.AbstractRememberMeServices;
-import org.springframework.security.userdetails.UserDetailsByNameServiceWrapper;
-import org.springframework.security.userdetails.UserDetailsService;
-import org.springframework.util.Assert;
-
-/**
- * 
- * @author Luke Taylor
- * @since 2.0.2
- */
-public class UserDetailsServiceInjectionBeanPostProcessor implements BeanPostProcessor, BeanFactoryAware {
-    private final Log logger = LogFactory.getLog(getClass());
-    private ConfigurableListableBeanFactory beanFactory;	
-	
-	public Object postProcessBeforeInitialization(Object bean, String beanName) throws BeansException {
-		if (BeanIds.X509_AUTH_PROVIDER.equals(beanName)) {
-			injectUserDetailsServiceIntoX509Provider((PreAuthenticatedAuthenticationProvider) bean);
-		} else if (BeanIds.REMEMBER_ME_SERVICES.equals(beanName)) {
-			injectUserDetailsServiceIntoRememberMeServices((AbstractRememberMeServices)bean);
-		} else if (BeanIds.OPEN_ID_PROVIDER.equals(beanName)) {
-			injectUserDetailsServiceIntoOpenIDProvider(bean);
-		}
-		
-		return bean;
-	}
-	
-	
-	
-	public Object postProcessAfterInitialization(Object bean, String beanName) throws BeansException {
-		return bean;
-	}
-	
-    private void injectUserDetailsServiceIntoRememberMeServices(AbstractRememberMeServices services) {
-        BeanDefinition beanDefinition = beanFactory.getBeanDefinition(BeanIds.REMEMBER_ME_SERVICES);
-        PropertyValue pv = beanDefinition.getPropertyValues().getPropertyValue("userDetailsService");
-
-        if (pv == null) {
-        	services.setUserDetailsService(getUserDetailsService());
-        } else {
-        	UserDetailsService cachingUserService = getCachingUserService(pv.getValue());
-        	
-        	if (cachingUserService != null) {
-        		services.setUserDetailsService(cachingUserService);
-        	}            	
-        }
-    }
-	
-    private void injectUserDetailsServiceIntoX509Provider(PreAuthenticatedAuthenticationProvider provider) {
-        BeanDefinition beanDefinition = beanFactory.getBeanDefinition(BeanIds.X509_AUTH_PROVIDER);
-        PropertyValue pv = beanDefinition.getPropertyValues().getPropertyValue("preAuthenticatedUserDetailsService");
-        UserDetailsByNameServiceWrapper wrapper = new UserDetailsByNameServiceWrapper();
-        
-        if (pv == null) {
-        	wrapper.setUserDetailsService(getUserDetailsService());
-        	provider.setPreAuthenticatedUserDetailsService(wrapper);
-        } else {
-        	RootBeanDefinition preAuthUserService = (RootBeanDefinition) pv.getValue();
-        	Object userService = 
-        		preAuthUserService.getPropertyValues().getPropertyValue("userDetailsService").getValue();
-        	
-        	UserDetailsService cachingUserService = getCachingUserService(userService);
-        	
-        	if (cachingUserService != null) {
-        		wrapper.setUserDetailsService(cachingUserService);
-        		provider.setPreAuthenticatedUserDetailsService(wrapper);
-        	}
-        }
-    }
-    
-    private void injectUserDetailsServiceIntoOpenIDProvider(Object bean) {
-        BeanDefinition beanDefinition = beanFactory.getBeanDefinition(BeanIds.OPEN_ID_PROVIDER);
-        PropertyValue pv = beanDefinition.getPropertyValues().getPropertyValue("userDetailsService");
-
-        if (pv == null) {
-        	BeanWrapperImpl beanWrapper = new BeanWrapperImpl(bean);
-            beanWrapper.setPropertyValue("userDetailsService", getUserDetailsService());
-        }
-    }
-    
-    
-    /**
-     * Obtains a user details service for use in RememberMeServices etc. Will return a caching version
-     * if available so should not be used for beans which need to separate the two. 
-     */
-    UserDetailsService getUserDetailsService() {
-    	Map beans = beanFactory.getBeansOfType(CachingUserDetailsService.class);
-    	
-    	if (beans.size() == 0) {
-    		beans = beanFactory.getBeansOfType(UserDetailsService.class);
-    	}
-    	        
-        if (beans.size() == 0) {
-            throw new SecurityConfigurationException("No UserDetailsService registered.");
-
-        } else if (beans.size() > 1) {
-            throw new SecurityConfigurationException("More than one UserDetailsService registered. Please " +
-                    "use a specific Id in your configuration");
-        }
-
-        return (UserDetailsService) beans.values().toArray()[0];
-    }
-    
-    private UserDetailsService getCachingUserService(Object userServiceRef) {
-    	Assert.isInstanceOf(RuntimeBeanReference.class, userServiceRef, 
-    			"userDetailsService property value must be a RuntimeBeanReference");
-    	
-    	String id = ((RuntimeBeanReference)userServiceRef).getBeanName();
-    	// Overwrite with the caching version if available
-    	String cachingId = id + AbstractUserDetailsServiceBeanDefinitionParser.CACHING_SUFFIX;
-    	
-    	if (beanFactory.containsBeanDefinition(cachingId)) {
-    		return (UserDetailsService) beanFactory.getBean(cachingId);
-    	}
-    	
-    	return null;
-    }
-    
-
-	public void setBeanFactory(BeanFactory beanFactory) throws BeansException {
-		this.beanFactory = (ConfigurableListableBeanFactory) beanFactory;
-	}
-}

core/src/main/java/org/springframework/security/config/UserServiceBeanDefinitionParser.java

@@ -6,6 +6,7 @@ import org.springframework.beans.factory.support.BeanDefinitionBuilder;
 import org.springframework.beans.factory.support.RootBeanDefinition;
 import org.springframework.beans.factory.xml.ParserContext;
 import org.springframework.beans.factory.BeanDefinitionStoreException;
+import org.springframework.security.userdetails.memory.InMemoryDaoImpl;
 import org.springframework.security.userdetails.memory.UserMap;
 import org.springframework.security.userdetails.User;
 import org.springframework.security.util.AuthorityUtils;
@@ -32,8 +33,8 @@ public class UserServiceBeanDefinitionParser extends AbstractUserDetailsServiceB
 	static final String ATT_DISABLED = "disabled";
     static final String ATT_LOCKED = "locked";
 
-    protected String getBeanClassName(Element element) {
-        return "org.springframework.security.userdetails.memory.InMemoryDaoImpl";
+    protected Class getBeanClass(Element element) {
+        return InMemoryDaoImpl.class;
     }
 
     protected void doParse(Element element, ParserContext parserContext, BeanDefinitionBuilder builder) {

core/src/main/java/org/springframework/security/config/X509BeanDefinitionParser.java

@@ -45,8 +45,8 @@ public class X509BeanDefinitionParser implements BeanDefinitionParser {
         }
 
         BeanDefinition provider = new RootBeanDefinition(PreAuthenticatedAuthenticationProvider.class);
+        ConfigUtils.getRegisteredProviders(parserContext).add(provider);
         parserContext.getRegistry().registerBeanDefinition(BeanIds.X509_AUTH_PROVIDER, provider);
-        ConfigUtils.getRegisteredProviders(parserContext).add(new RuntimeBeanReference(BeanIds.X509_AUTH_PROVIDER));
 
         String userServiceRef = element.getAttribute(ATT_USER_SERVICE_REF);
 

core/src/main/java/org/springframework/security/intercept/AbstractSecurityInterceptor.java

@@ -61,7 +61,7 @@ import java.util.Collection;
  * interceptor. It will also implement the proper handling of secure object invocations, namely:
  * <ol>
  * <li>Obtain the {@link Authentication} object from the {@link SecurityContextHolder}.</li>
- * <li>Determine if the request relates to a secured or public invocation by looking up the secure object request
+ * <li>Determine if the request relates to a secured or public invocation by ooking up the secure object request
  * against the {@link ObjectDefinitionSource}.</li>
  * <li>For an invocation that is secured (there is a
  * <code>ConfigAttributeDefinition</code> for the secure object invocation):

core/src/main/java/org/springframework/security/intercept/method/ProtectPointcutPostProcessor.java

@@ -142,7 +142,7 @@ public final class ProtectPointcutPostProcessor implements BeanPostProcessor {
 	}
 
 	public void addPointcut(String pointcutExpression, ConfigAttributeDefinition definition) {
-		Assert.hasText(pointcutExpression, "An AspectJ pointcut expression is required");
+		Assert.hasText(pointcutExpression, "An AspecTJ pointcut expression is required");
 		Assert.notNull(definition, "ConfigAttributeDefinition required");
 		pointcutMap.put(pointcutExpression, definition);
 		

core/src/main/java/org/springframework/security/intercept/web/DefaultFilterInvocationDefinitionSource.java

@@ -78,7 +78,7 @@ public class DefaultFilterInvocationDefinitionSource implements FilterInvocation
     DefaultFilterInvocationDefinitionSource(UrlMatcher urlMatcher) {
         this.urlMatcher = urlMatcher;
     }
-    
+
     /**
      * Builds the internal request map from the supplied map. The key elements should be of type {@link RequestKey},
      * which contains a URL path and an optional HTTP method (may be null). The path stored in the key will depend on 
@@ -252,7 +252,7 @@ public class DefaultFilterInvocationDefinitionSource implements FilterInvocation
         return urlMatcher.requiresLowerCaseUrl();
     }
 
-    public void setStripQueryStringFromUrls(boolean stripQueryStringFromUrls) {
+    protected void setStripQueryStringFromUrls(boolean stripQueryStringFromUrls) {
         this.stripQueryStringFromUrls = stripQueryStringFromUrls;
     }
 }

core/src/main/java/org/springframework/security/ldap/LdapAuthoritiesPopulator.java

@@ -17,6 +17,8 @@ package org.springframework.security.ldap;
 
 import org.springframework.security.GrantedAuthority;
 
+import org.springframework.security.ldap.LdapDataAccessException;
+
 import org.springframework.ldap.core.DirContextOperations;
 
 
@@ -40,6 +42,7 @@ public interface LdapAuthoritiesPopulator {
      *
      * @return the granted authorities for the given user.
      *
+     * @throws LdapDataAccessException if there is a problem accessing the directory.
      */
     GrantedAuthority[] getGrantedAuthorities(DirContextOperations userData, String username);
 }

core/src/main/java/org/springframework/security/ldap/SpringSecurityLdapTemplate.java

@@ -22,7 +22,6 @@ import org.springframework.ldap.core.ContextSource;
 import org.springframework.ldap.core.DirContextAdapter;
 import org.springframework.ldap.core.DirContextOperations;
 import org.springframework.ldap.core.DistinguishedName;
-import org.springframework.ldap.core.LdapEncoder;
 import org.springframework.util.Assert;
 
 import org.apache.commons.logging.Log;
@@ -136,16 +135,9 @@ public class SpringSecurityLdapTemplate extends org.springframework.ldap.core.Ld
      * @return the set of String values for the attribute as a union of the values found in all the matching entries.
      */
     public Set searchForSingleAttributeValues(final String base, final String filter, final Object[] params,
-    		final String attributeName) {
-    	// Escape the params acording to RFC2254
-    	Object[] encodedParams = new String[params.length];
-    	
-    	for (int i=0; i < params.length; i++) {
-    		encodedParams[i] = LdapEncoder.filterEncode(params[i].toString());  
-    	}
-    	
-        String formattedFilter = MessageFormat.format(filter, encodedParams);
-        logger.debug("Using filter: " + formattedFilter);
+        final String attributeName) {
+
+        String formattedFilter = MessageFormat.format(filter, params);
 
         final HashSet set = new HashSet();
 

core/src/main/java/org/springframework/security/ldap/populator/DefaultLdapAuthoritiesPopulator.java

@@ -69,13 +69,13 @@ import java.util.Set;
  * <pre>
  * &lt;bean id="ldapAuthoritiesPopulator"
  *       class="org.springframework.security.providers.ldap.populator.DefaultLdapAuthoritiesPopulator">
- *   &lt;constructor-arg ref="contextSource"/>
- *   &lt;constructor-arg value="ou=groups"/>
- *   &lt;property name="groupRoleAttribute" value="ou"/>
+ *   &lt;constructor-arg>&lt;ref local="contextSource"/>&lt;/constructor-arg>
+ *   &lt;constructor-arg>&lt;value>ou=groups&lt;/value>&lt;/constructor-arg>
+ *   &lt;property name="groupRoleAttribute">&lt;value>ou&lt;/value>&lt;/property>
  * &lt;!-- the following properties are shown with their default values -->
- *   &lt;property name="searchSubTree" value="false"/>
- *   &lt;property name="rolePrefix" value="ROLE_"/>
- *   &lt;property name="convertToUpperCase" value="true"/>
+ *   &lt;property name="searchSubTree">&lt;value>false&lt;/value>&lt;/property>
+ *   &lt;property name="rolePrefix">&lt;value>ROLE_&lt;/value>&lt;/property>
+ *   &lt;property name="convertToUpperCase">&lt;value>true&lt;/value>&lt;/property>
  * &lt;/bean>
  * </pre>
  * A search for roles for user "uid=ben,ou=people,dc=springframework,dc=org" would return the single granted authority
@@ -284,10 +284,6 @@ public class DefaultLdapAuthoritiesPopulator implements LdapAuthoritiesPopulator
         this.groupSearchFilter = groupSearchFilter;
     }
 
-    /**
-     * Sets the prefix which will be prepended to the values loaded from the directory.
-     * Defaults to "ROLE_" for compatibility with <tt>RoleVoter/tt>.
-     */
     public void setRolePrefix(String rolePrefix) {
         Assert.notNull(rolePrefix, "rolePrefix must not be null");
         this.rolePrefix = rolePrefix;

core/src/main/java/org/springframework/security/providers/jaas/JaasAuthenticationProvider.java

@@ -158,7 +158,7 @@ public class JaasAuthenticationProvider implements AuthenticationProvider, Appli
         Assert.hasLength(loginContextName, "loginContextName must be set on " + getClass());
 
         configureJaas(loginConfig);
-        
+
         Assert.notNull(Configuration.getConfiguration(),
               "As per http://java.sun.com/j2se/1.5.0/docs/api/javax/security/auth/login/Configuration.html "
             + "\"If a Configuration object was set via the Configuration.setConfiguration method, then that object is "
@@ -246,9 +246,6 @@ public class JaasAuthenticationProvider implements AuthenticationProvider, Appli
      */
     protected void configureJaas(Resource loginConfig) throws IOException {
         configureJaasUsingLoop();
-
-        // Overcome issue in SEC-760
-        Configuration.getConfiguration().refresh();
     }
 
     /**
@@ -378,9 +375,7 @@ public class JaasAuthenticationProvider implements AuthenticationProvider, Appli
      * @param token The {@link UsernamePasswordAuthenticationToken} being processed
      */
     protected void publishSuccessEvent(UsernamePasswordAuthenticationToken token) {
-        if (applicationEventPublisher != null) {
-        	applicationEventPublisher.publishEvent(new JaasAuthenticationSuccessEvent(token));
-        }
+        applicationEventPublisher.publishEvent(new JaasAuthenticationSuccessEvent(token));
     }
 
     /**

core/src/main/java/org/springframework/security/providers/preauth/PreAuthenticatedAuthenticationProvider.java

@@ -88,6 +88,7 @@ public class PreAuthenticatedAuthenticationProvider implements AuthenticationPro
         result.setDetails(authentication.getDetails());
 
         return result;
+
     }
 
     /**
@@ -122,14 +123,4 @@ public class PreAuthenticatedAuthenticationProvider implements AuthenticationPro
     public void setThrowExceptionWhenTokenRejected(boolean throwExceptionWhenTokenRejected) {
         this.throwExceptionWhenTokenRejected = throwExceptionWhenTokenRejected;
     }
-
-    /**
-     * Sets the strategy which will be used to validate the loaded <tt>UserDetails</tt> object
-     * for the user. Defaults to an {@link AccountStatusUserDetailsChecker}. 
-     * @param userDetailsChecker
-     */
-	public void setUserDetailsChecker(UserDetailsChecker userDetailsChecker) {
-		Assert.notNull(userDetailsChecker, "userDetailsChacker cannot be null");
-		this.userDetailsChecker = userDetailsChecker;
-	}
 }

core/src/main/java/org/springframework/security/ui/AbstractProcessingFilter.java

@@ -21,9 +21,7 @@ import org.springframework.security.AuthenticationException;
 import org.springframework.security.AuthenticationManager;
 import org.springframework.security.util.RedirectUtils;
 import org.springframework.security.util.SessionUtils;
-import org.springframework.security.util.UrlUtils;
 
-import org.springframework.security.concurrent.SessionRegistry;
 import org.springframework.security.context.SecurityContextHolder;
 
 import org.springframework.security.event.authentication.InteractiveAuthenticationSuccessEvent;
@@ -45,6 +43,10 @@ import org.springframework.util.Assert;
 import java.io.IOException;
 
 import java.util.Properties;
+import java.util.Enumeration;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.Map;
 
 import javax.servlet.FilterChain;
 import javax.servlet.ServletException;
@@ -208,18 +210,13 @@ public abstract class AbstractProcessingFilter extends SpringSecurityFilter impl
     private boolean allowSessionCreation = true;
     
     private boolean serverSideRedirect = false;
-    
-    private SessionRegistry sessionRegistry;
 
     //~ Methods ========================================================================================================
 
     public void afterPropertiesSet() throws Exception {
         Assert.hasLength(filterProcessesUrl, "filterProcessesUrl must be specified");
-        Assert.isTrue(UrlUtils.isValidRedirectUrl(filterProcessesUrl), filterProcessesUrl + " isn't a valid redirect URL");        
         Assert.hasLength(defaultTargetUrl, "defaultTargetUrl must be specified");
-        Assert.isTrue(UrlUtils.isValidRedirectUrl(defaultTargetUrl), defaultTargetUrl + " isn't a valid redirect URL");        
 //        Assert.hasLength(authenticationFailureUrl, "authenticationFailureUrl must be specified");
-        Assert.isTrue(UrlUtils.isValidRedirectUrl(authenticationFailureUrl), authenticationFailureUrl + " isn't a valid redirect URL");
         Assert.notNull(authenticationManager, "authenticationManager must be specified");
         Assert.notNull(rememberMeServices, "rememberMeServices cannot be null");
         Assert.notNull(targetUrlResolver, "targetUrlResolver cannot be null");
@@ -358,7 +355,7 @@ public abstract class AbstractProcessingFilter extends SpringSecurityFilter impl
         }
 
         if (invalidateSessionOnSuccessfulAuthentication) {
-            SessionUtils.startNewSessionIfRequired(request, migrateInvalidatedSessionAttributes, sessionRegistry);
+            SessionUtils.startNewSessionIfRequired(request, migrateInvalidatedSessionAttributes, null);
         }
 
         String targetUrl = determineTargetUrl(request);
@@ -570,13 +567,5 @@ public abstract class AbstractProcessingFilter extends SpringSecurityFilter impl
      */	
 	public void setServerSideRedirect(boolean serverSideRedirect) {
 		this.serverSideRedirect = serverSideRedirect;
-	}
-
-	/**
-	 * The session registry needs to be set if session fixation attack protection is in use (and concurrent 
-	 * session control is enabled).
-	 */
-    public void setSessionRegistry(SessionRegistry sessionRegistry) {
-        this.sessionRegistry = sessionRegistry;
-    }
+	}	
 }

core/src/main/java/org/springframework/security/ui/AccessDeniedHandlerImpl.java

@@ -54,7 +54,7 @@ public class AccessDeniedHandlerImpl implements AccessDeniedHandler {
     //~ Methods ========================================================================================================
 
     public void handle(ServletRequest request, ServletResponse response, AccessDeniedException accessDeniedException)
-        	throws IOException, ServletException {
+        throws IOException, ServletException {
         if (errorPage != null) {
             // Put exception into request scope (perhaps of use to a view)
             ((HttpServletRequest) request).setAttribute(SPRING_SECURITY_ACCESS_DENIED_EXCEPTION_KEY,
@@ -80,7 +80,7 @@ public class AccessDeniedHandlerImpl implements AccessDeniedHandler {
      */
     public void setErrorPage(String errorPage) {
         if ((errorPage != null) && !errorPage.startsWith("/")) {
-            throw new IllegalArgumentException("errorPage must begin with '/'");
+            throw new IllegalArgumentException("ErrorPage must begin with '/'");
         }
 
         this.errorPage = errorPage;

core/src/main/java/org/springframework/security/ui/AuthenticationDetailsSourceImpl.java

@@ -58,7 +58,7 @@ public class AuthenticationDetailsSourceImpl implements AuthenticationDetailsSou
 		Constructor constructor = null;
 		for (int i = 0; i < constructors.length; i++) {
 			Class[] parameterTypes = constructors[i].getParameterTypes();
-			if (parameterTypes.length == 1 && (object == null || parameterTypes[0].isInstance(object))) {
+			if (parameterTypes.length == 1 && (object == null || parameterTypes[i].isInstance(object))) {
 				constructor = constructors[i];
 				break;
 			}

core/src/main/java/org/springframework/security/ui/FilterChainOrder.java

@@ -22,7 +22,8 @@ public abstract class FilterChainOrder {
 
     public static final int CHANNEL_FILTER              = FILTER_CHAIN_FIRST;
     public static final int CONCURRENT_SESSION_FILTER   = FILTER_CHAIN_FIRST + INTERVAL * i++;
-    public static final int HTTP_SESSION_CONTEXT_FILTER = FILTER_CHAIN_FIRST + INTERVAL * i++;    
+    public static final int HTTP_SESSION_CONTEXT_FILTER = FILTER_CHAIN_FIRST + INTERVAL * i++;
+    public static final int SESSION_FIXATION_FILTER     = FILTER_CHAIN_FIRST + INTERVAL * i++;    
     public static final int LOGOUT_FILTER               = FILTER_CHAIN_FIRST + INTERVAL * i++;
     public static final int X509_FILTER                 = FILTER_CHAIN_FIRST + INTERVAL * i++;
     public static final int PRE_AUTH_FILTER             = FILTER_CHAIN_FIRST + INTERVAL * i++;
@@ -36,7 +37,6 @@ public abstract class FilterChainOrder {
     public static final int ANONYMOUS_FILTER = FILTER_CHAIN_FIRST + INTERVAL * i++;
     public static final int EXCEPTION_TRANSLATION_FILTER = FILTER_CHAIN_FIRST + INTERVAL * i++;
     public static final int NTLM_FILTER                 = FILTER_CHAIN_FIRST + INTERVAL * i++;
-    public static final int SESSION_FIXATION_FILTER     = FILTER_CHAIN_FIRST + INTERVAL * i++;    
     public static final int FILTER_SECURITY_INTERCEPTOR = FILTER_CHAIN_FIRST + INTERVAL * i++;
     public static final int SWITCH_USER_FILTER          = FILTER_CHAIN_FIRST + INTERVAL * i++;
 
@@ -46,6 +46,7 @@ public abstract class FilterChainOrder {
         filterNameToOrder.put("FIRST", new Integer(Integer.MIN_VALUE));
         filterNameToOrder.put("CHANNEL_FILTER", new Integer(CHANNEL_FILTER));
         filterNameToOrder.put("CONCURRENT_SESSION_FILTER", new Integer(CONCURRENT_SESSION_FILTER));
+        filterNameToOrder.put("SESSION_CONTEXT_INTEGRATION_FILTER", new Integer(HTTP_SESSION_CONTEXT_FILTER));
         filterNameToOrder.put("LOGOUT_FILTER", new Integer(LOGOUT_FILTER));
         filterNameToOrder.put("X509_FILTER", new Integer(X509_FILTER));
         filterNameToOrder.put("PRE_AUTH_FILTER", new Integer(PRE_AUTH_FILTER));
@@ -58,7 +59,6 @@ public abstract class FilterChainOrder {
         filterNameToOrder.put("ANONYMOUS_FILTER", new Integer(ANONYMOUS_FILTER));
         filterNameToOrder.put("EXCEPTION_TRANSLATION_FILTER", new Integer(EXCEPTION_TRANSLATION_FILTER));
         filterNameToOrder.put("NTLM_FILTER", new Integer(NTLM_FILTER));
-        filterNameToOrder.put("SESSION_CONTEXT_INTEGRATION_FILTER", new Integer(HTTP_SESSION_CONTEXT_FILTER));        
         filterNameToOrder.put("FILTER_SECURITY_INTERCEPTOR", new Integer(FILTER_SECURITY_INTERCEPTOR));
         filterNameToOrder.put("SWITCH_USER_FILTER", new Integer(SWITCH_USER_FILTER));
         filterNameToOrder.put("LAST", new Integer(Integer.MAX_VALUE));

core/src/main/java/org/springframework/security/ui/SessionFixationProtectionFilter.java

@@ -6,23 +6,24 @@ import javax.servlet.FilterChain;
 import javax.servlet.ServletException;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
+import javax.servlet.http.HttpServletResponseWrapper;
 
 import org.springframework.security.Authentication;
 import org.springframework.security.AuthenticationTrustResolver;
 import org.springframework.security.AuthenticationTrustResolverImpl;
 import org.springframework.security.concurrent.SessionRegistry;
-import org.springframework.security.context.HttpSessionContextIntegrationFilter;
-import org.springframework.security.context.SecurityContext;
 import org.springframework.security.context.SecurityContextHolder;
 import org.springframework.security.util.SessionUtils;
 
 /**
  * Detects that a user has been authenticated since the start of the request and starts a new session.
  * <p>
- * This is essentially a generalization of the functionality that was implemented for SEC-399. 
- * Additionally, it will update the configured SessionRegistry if one is in use, thus preventing problems when used 
- * with Spring Security's concurrent session control. 
+ * This is essentially a generalization of the functionality that was implemented for SEC-399. Additionally, it will
+ * update the configured SessionRegistry if one is in use, thus preventing problems when used with Spring Security's
+ * concurrent session control.
+ * <p>
+ * If the response has already been committed when the filter checks the authentication state, then it isn't possible 
+ * to create a new session and the filter will print a warning to that effect. 
  * 
  * @author Martin Algesten
  * @author Luke Taylor
@@ -54,17 +55,22 @@ public class SessionFixationProtectionFilter extends SpringSecurityFilter {
         }
         
         request.setAttribute(FILTER_APPLIED, Boolean.TRUE);
-
-        HttpSession session = request.getSession();
-        SecurityContext sessionSecurityContext = 
-            (SecurityContext) session.getAttribute(HttpSessionContextIntegrationFilter.SPRING_SECURITY_CONTEXT_KEY);
-        
-        if (sessionSecurityContext == null && isAuthenticated()) {
-            // The user has been authenticated during the current request, so do the session migration
-            startNewSessionIfRequired(request, response);
+                
+        if (isAuthenticated()) {
+            // We don't have to worry about session fixation attack if already authenticated 
+            chain.doFilter(request, response);
+            return;            
+        }
+        
+        SessionFixationProtectionResponseWrapper wrapper = 
+            new SessionFixationProtectionResponseWrapper(response, request);
+        try {
+            chain.doFilter(request, wrapper);
+        } finally {
+            if (!wrapper.isNewSessionStarted()) {
+                startNewSessionIfRequired(request, response);
+            }
         }
-
-        chain.doFilter(request, response);
     }
     
     private boolean isAuthenticated() {
@@ -86,12 +92,83 @@ public class SessionFixationProtectionFilter extends SpringSecurityFilter {
     }
     
     /**
-     * Called when the a user wasn't authenticated at the start of the request but has been during it
+     * Called when the an initially unauthenticated request completes or a redirect or sendError occurs.
      * <p>
-     * A new session will be created, the session attributes copied to it (if 
-     * <tt>migrateSessionAttributes</tt> is set) and the sessionRegistry updated with the new session information.
+     * If the user is now authenticated, a new session will be created, the session attributes copied to it (if 
+     * <tt>migrateSessionAttributes</tt> is set and the sessionRegistry updated with the new session information.
      */
-    protected void startNewSessionIfRequired(HttpServletRequest request, HttpServletResponse response) {            
-        SessionUtils.startNewSessionIfRequired(request, migrateSessionAttributes, sessionRegistry);
+    protected void startNewSessionIfRequired(HttpServletRequest request, HttpServletResponse response) {
+        if (isAuthenticated()) {
+            if (request.getSession(false) != null && response.isCommitted()) {
+                logger.warn("Response is already committed. Unable to create new session.");
+            }
+            
+            SessionUtils.startNewSessionIfRequired(request, migrateSessionAttributes, sessionRegistry);
+        }
+    }
+    
+    /**
+     * Response wrapper to handle the situation where we need to migrate the session after a redirect or sendError.
+     * Similar in function to Martin Algesten's OnRedirectUpdateSessionResponseWrapper used in 
+     * HttpSessionContextIntegrationFilter.
+     * <p>
+     * Only used to wrap the response if the conditions are right at the start of the request to potentially 
+     * require starting a new session, i.e. that the user isn't authenticated and a session existed to begin with.  
+     */
+    class SessionFixationProtectionResponseWrapper extends HttpServletResponseWrapper {
+        private HttpServletRequest request;
+        private boolean newSessionStarted;
+
+        SessionFixationProtectionResponseWrapper(HttpServletResponse response, HttpServletRequest request) {
+            super(response);
+            this.request = request;
+        }
+        
+        /**
+         * Makes sure a new session is created before calling the
+         * superclass <code>sendError()</code>
+         */
+        public void sendError(int sc) throws IOException {
+            startNewSession();
+            super.sendError(sc);
+        }
+
+        /**
+         * Makes sure a new session is created before calling the
+         * superclass <code>sendError()</code>
+         */
+        public void sendError(int sc, String msg) throws IOException {
+            startNewSession();
+            super.sendError(sc, msg);
+        }
+
+        /**
+         * Makes sure a new session is created before calling the
+         * superclass <code>sendRedirect()</code>
+         */
+        public void sendRedirect(String location) throws IOException {
+            startNewSession();
+            super.sendRedirect(location);
+        }
+        
+        public void flushBuffer() throws IOException {
+            startNewSession();
+            super.flushBuffer();
+        }
+
+        /**
+         * Calls <code>startNewSessionIfRequired()</code>
+         */
+        private void startNewSession() {
+            if (newSessionStarted) {
+                return;
+            }
+            startNewSessionIfRequired(request, this);
+            newSessionStarted = true;
+        }
+
+        boolean isNewSessionStarted() {
+            return newSessionStarted;
+        }
     }
 }

core/src/main/java/org/springframework/security/ui/TargetUrlResolverImpl.java

@@ -25,7 +25,6 @@ import org.springframework.security.ui.savedrequest.SavedRequest;
 import org.springframework.util.Assert;
 import org.springframework.util.StringUtils;
 
-
 /**
  * Default implementation for {@link TargetUrlResolver}
  * <p>
@@ -47,10 +46,11 @@ public class TargetUrlResolverImpl implements TargetUrlResolver {
 	/**
 	 * If <code>true</code>, will only use <code>SavedRequest</code> to determine the target URL on successful
      * authentication if the request that caused the authentication request was a GET.
-     * It will then return null for a POST/PUT request.
-     * Defaults to false.
+     * It will return null for a POST/PUT request.
+	 * In most cases it's meaningless to redirect to a URL generated by a POST/PUT request.
+     * Defaults to true.
 	 */
-	private boolean justUseSavedRequestOnGet = false;
+	private boolean justUseSavedRequestOnGet = true;
 
     /* (non-Javadoc)
 	 * @see org.acegisecurity.ui.TargetUrlResolver#determineTargetUrl(org.acegisecurity.ui.savedrequest.SavedRequest, javax.servlet.http.HttpServletRequest, org.acegisecurity.Authentication)

core/src/main/java/org/springframework/security/ui/basicauth/BasicProcessingFilter.java

@@ -93,7 +93,6 @@ public class BasicProcessingFilter extends SpringSecurityFilter implements Initi
     private AuthenticationManager authenticationManager;
     private RememberMeServices rememberMeServices;
     private boolean ignoreFailure = false;
-    private String credentialsCharset = "UTF-8";
 
     //~ Methods ========================================================================================================
 
@@ -115,8 +114,8 @@ public class BasicProcessingFilter extends SpringSecurityFilter implements Initi
         }
 
         if ((header != null) && header.startsWith("Basic ")) {
-            byte[] base64Token = header.substring(6).getBytes("UTF-8");
-            String token = new String(Base64.decodeBase64(base64Token), getCredentialsCharset(httpRequest));
+            String base64Token = header.substring(6);
+            String token = new String(Base64.decodeBase64(base64Token.getBytes()));
 
             String username = "";
             String password = "";
@@ -173,7 +172,7 @@ public class BasicProcessingFilter extends SpringSecurityFilter implements Initi
         chain.doFilter(httpRequest, httpResponse);
     }
 
-	private boolean authenticationIsRequired(String username) {
+    private boolean authenticationIsRequired(String username) {
         // Only reauthenticate if username doesn't match SecurityContextHolder and user isn't authenticated
         // (see SEC-53)
         Authentication existingAuth = SecurityContextHolder.getContext().getAuthentication();
@@ -236,16 +235,7 @@ public class BasicProcessingFilter extends SpringSecurityFilter implements Initi
         this.rememberMeServices = rememberMeServices;
     }
 
-    public void setCredentialsCharset(String credentialsCharset) {
-    	Assert.hasText(credentialsCharset, "credentialsCharset cannot be null or empty");
-		this.credentialsCharset = credentialsCharset;
-	}
-    
-    protected String getCredentialsCharset(HttpServletRequest httpRequest) {
-		return credentialsCharset;
-	}    
-    
-	public int getOrder() {
+    public int getOrder() {
         return FilterChainOrder.BASIC_PROCESSING_FILTER;
     }
 }

core/src/main/java/org/springframework/security/ui/logout/LogoutFilter.java

@@ -26,7 +26,6 @@ import org.springframework.security.Authentication;
 import org.springframework.security.ui.SpringSecurityFilter;
 import org.springframework.security.ui.FilterChainOrder;
 import org.springframework.security.util.RedirectUtils;
-import org.springframework.security.util.UrlUtils;
 import org.springframework.security.context.SecurityContextHolder;
 import org.springframework.util.Assert;
 import org.springframework.util.StringUtils;
@@ -59,7 +58,6 @@ public class LogoutFilter extends SpringSecurityFilter {
     public LogoutFilter(String logoutSuccessUrl, LogoutHandler[] handlers) {
         Assert.notEmpty(handlers, "LogoutHandlers are required");
         this.logoutSuccessUrl = logoutSuccessUrl;
-        Assert.isTrue(UrlUtils.isValidRedirectUrl(logoutSuccessUrl), logoutSuccessUrl + " isn't a valid redirect URL");
         this.handlers = handlers;
     }
 
@@ -132,7 +130,7 @@ public class LogoutFilter extends SpringSecurityFilter {
         String targetUrl = request.getParameter("logoutSuccessUrl");
 
         if(!StringUtils.hasLength(targetUrl)) {
-            targetUrl = getLogoutSuccessUrl();
+            targetUrl = logoutSuccessUrl;
         }
 
         if (!StringUtils.hasLength(targetUrl)) {
@@ -163,14 +161,9 @@ public class LogoutFilter extends SpringSecurityFilter {
 
     public void setFilterProcessesUrl(String filterProcessesUrl) {
         Assert.hasText(filterProcessesUrl, "FilterProcessesUrl required");
-        Assert.isTrue(UrlUtils.isValidRedirectUrl(filterProcessesUrl), filterProcessesUrl + " isn't a valid redirect URL");
         this.filterProcessesUrl = filterProcessesUrl;
     }
 
-    protected String getLogoutSuccessUrl() {
-        return logoutSuccessUrl;
-    }    
-    
     protected String getFilterProcessesUrl() {
         return filterProcessesUrl;
     }

core/src/main/java/org/springframework/security/ui/preauth/websphere/WASSecurityHelper.java

@@ -24,182 +24,171 @@ import org.apache.commons.logging.LogFactory;
  * @since 2.0
  */
 final class WASSecurityHelper {
-    private static final Log logger = LogFactory.getLog(WASSecurityHelper.class);
+	private static final Log logger = LogFactory.getLog(WASSecurityHelper.class);
 
-    private static final String USER_REGISTRY = "UserRegistry";
+	private static final String USER_REGISTRY = "UserRegistry";
 
-    private static Method getRunAsSubject = null;
+	private static Method getRunAsSubject = null;
 
-    private static Method getGroupsForUser = null;
+	private static Method getWSCredentialFromSubject = null;
 
-    private static Method getSecurityName = null;
+	private static Method getGroupsForUser = null;
 
-    // SEC-803
-    private static Class wsCredentialClass = null;
-    
-    /**
-     * Get the security name for the given subject.
-     * 
-     * @param subject
-     *            The subject for which to retrieve the security name
-     * @return String the security name for the given subject
-     */
-    private static final String getSecurityName(final Subject subject) {
-        if (logger.isDebugEnabled()) {
-            logger.debug("Determining Websphere security name for subject " + subject);
-        }
-        String userSecurityName = null;
-        if (subject != null) {
-            // SEC-803
-            Object credential = subject.getPublicCredentials(getWSCredentialClass()).iterator().next();
-            if (credential != null) {
-                userSecurityName = (String)invokeMethod(getSecurityNameMethod(),credential,null);
-            }
-        }
-        if (logger.isDebugEnabled()) {
-            logger.debug("Websphere security name is " + userSecurityName + " for subject " + subject);
-        }
-        return userSecurityName;
-    }
+	private static Method getSecurityName = null;
 
-    /**
-     * Get the current RunAs subject.
-     * 
-     * @return Subject the current RunAs subject
-     */
-    private static final Subject getRunAsSubject() {
-        logger.debug("Retrieving WebSphere RunAs subject");
-        // get Subject: WSSubject.getCallerSubject ();
-        return (Subject) invokeMethod(getRunAsSubjectMethod(), null, new Object[] {});
-    }
+	/**
+	 * Get the security name for the given subject.
+	 * 
+	 * @param subject
+	 *            The subject for which to retrieve the security name
+	 * @return String the security name for the given subject
+	 */
+	private static final String getSecurityName(final Subject subject) {
+		if (logger.isDebugEnabled()) {
+			logger.debug("Determining Websphere security name for subject " + subject);
+		}
+		String userSecurityName = null;
+		if (subject != null) {
+			Object credential = invokeMethod(getWSCredentialFromSubjectMethod(),null,new Object[]{subject});
+			if (credential != null) {
+				userSecurityName = (String)invokeMethod(getSecurityNameMethod(),credential,null);
+			}
+		}
+		if (logger.isDebugEnabled()) {
+			logger.debug("Websphere security name is " + userSecurityName + " for subject " + subject);
+		}
+		return userSecurityName;
+	}
 
-    /**
-     * Get the WebSphere group names for the given subject.
-     * 
-     * @param subject
-     *            The subject for which to retrieve the WebSphere group names
-     * @return the WebSphere group names for the given subject
-     */
-    private static final String[] getWebSphereGroups(final Subject subject) {
-        return getWebSphereGroups(getSecurityName(subject));
-    }
+	/**
+	 * Get the current RunAs subject.
+	 * 
+	 * @return Subject the current RunAs subject
+	 */
+	private static final Subject getRunAsSubject() {
+		logger.debug("Retrieving WebSphere RunAs subject");
+		// get Subject: WSSubject.getCallerSubject ();
+		return (Subject) invokeMethod(getRunAsSubjectMethod(), null, new Object[] {});
+	}
 
-    /**
-     * Get the WebSphere group names for the given security name.
-     * 
-     * @param securityName
-     *            The securityname for which to retrieve the WebSphere group names
-     * @return the WebSphere group names for the given security name
-     */
-    private static final String[] getWebSphereGroups(final String securityName) {
-        Context ic = null;
-        try {
-            // TODO: Cache UserRegistry object
-            ic = new InitialContext();
-            Object objRef = ic.lookup(USER_REGISTRY);
-            Object userReg = PortableRemoteObject.narrow(objRef, Class.forName ("com.ibm.websphere.security.UserRegistry"));
-            if (logger.isDebugEnabled()) {
-                logger.debug("Determining WebSphere groups for user " + securityName + " using WebSphere UserRegistry " + userReg);
-            }
-            final Collection groups = (Collection) invokeMethod(getGroupsForUserMethod(), userReg, new Object[]{ securityName });
-            if (logger.isDebugEnabled()) {
-                logger.debug("Groups for user " + securityName + ": " + groups.toString());
-            }
-            String[] result = new String[groups.size()];
-            return (String[]) groups.toArray(result);
-        } catch (Exception e) {
-            logger.error("Exception occured while looking up groups for user", e);
-            throw new RuntimeException("Exception occured while looking up groups for user", e);
-        } finally {
-            try {
-                ic.close();
-            } catch (NamingException e) {
-                logger.debug("Exception occured while closing context", e);
-            }
-        }
-    }
+	/**
+	 * Get the WebSphere group names for the given subject.
+	 * 
+	 * @param subject
+	 *            The subject for which to retrieve the WebSphere group names
+	 * @return the WebSphere group names for the given subject
+	 */
+	private static final String[] getWebSphereGroups(final Subject subject) {
+		return getWebSphereGroups(getSecurityName(subject));
+	}
 
-    /**
-     * @return
-     */
-    public static final String[] getGroupsForCurrentUser() {
-        return getWebSphereGroups(getRunAsSubject());
-    }
+	/**
+	 * Get the WebSphere group names for the given security name.
+	 * 
+	 * @param securityName
+	 *            The securityname for which to retrieve the WebSphere group names
+	 * @return the WebSphere group names for the given security name
+	 */
+	private static final String[] getWebSphereGroups(final String securityName) {
+		Context ic = null;
+		try {
+			// TODO: Cache UserRegistry object
+			ic = new InitialContext();
+			Object objRef = ic.lookup(USER_REGISTRY);
+			Object userReg = PortableRemoteObject.narrow(objRef, Class.forName ("com.ibm.websphere.security.UserRegistry"));
+			if (logger.isDebugEnabled()) {
+				logger.debug("Determining WebSphere groups for user " + securityName + " using WebSphere UserRegistry " + userReg);
+			}
+			final Collection groups = (Collection) invokeMethod(getGroupsForUserMethod(), userReg, new Object[]{ securityName });
+			if (logger.isDebugEnabled()) {
+				logger.debug("Groups for user " + securityName + ": " + groups.toString());
+			}
+			String[] result = new String[groups.size()];
+			return (String[]) groups.toArray(result);
+		} catch (Exception e) {
+			logger.error("Exception occured while looking up groups for user", e);
+			throw new RuntimeException("Exception occured while looking up groups for user", e);
+		} finally {
+			try {
+				ic.close();
+			} catch (NamingException e) {
+				logger.debug("Exception occured while closing context", e);
+			}
+		}
+	}
 
-    public static final String getCurrentUserName() {
-        return getSecurityName(getRunAsSubject());
-    }
-    
-    private static final Object invokeMethod(Method method, Object instance, Object[] args)
-    {
-        try {
-            return method.invoke(instance,args);
-        } catch (IllegalArgumentException e) {
-            logger.error("Error while invoking method "+method.getClass().getName()+"."+method.getName()+"("+ Arrays.asList(args)+")",e);
-            throw new RuntimeException("Error while invoking method "+method.getClass().getName()+"."+method.getName()+"("+Arrays.asList(args)+")",e);
-        } catch (IllegalAccessException e) {
-            logger.error("Error while invoking method "+method.getClass().getName()+"."+method.getName()+"("+Arrays.asList(args)+")",e);
-            throw new RuntimeException("Error while invoking method "+method.getClass().getName()+"."+method.getName()+"("+Arrays.asList(args)+")",e);
-        } catch (InvocationTargetException e) {
-            logger.error("Error while invoking method "+method.getClass().getName()+"."+method.getName()+"("+Arrays.asList(args)+")",e);
-            throw new RuntimeException("Error while invoking method "+method.getClass().getName()+"."+method.getName()+"("+Arrays.asList(args)+")",e);
-        }
-    }
+	/**
+	 * @return
+	 */
+	public static final String[] getGroupsForCurrentUser() {
+		return getWebSphereGroups(getRunAsSubject());
+	}
 
-    private static final Method getMethod(String className, String methodName, String[] parameterTypeNames) {
-        try {
-            Class c = Class.forName(className);
-            final int len = parameterTypeNames.length;
-            Class[] parameterTypes = new Class[len];
-            for (int i = 0; i < len; i++) {
-                parameterTypes[i] = Class.forName(parameterTypeNames[i]);
-            }
-            return c.getDeclaredMethod(methodName, parameterTypes);
-        } catch (ClassNotFoundException e) {
-            logger.error("Required class"+className+" not found");
-            throw new RuntimeException("Required class"+className+" not found",e);
-        } catch (NoSuchMethodException e) {
-            logger.error("Required method "+methodName+" with parameter types ("+ Arrays.asList(parameterTypeNames) +") not found on class "+className);
-            throw new RuntimeException("Required class"+className+" not found",e);
-        }
-    }    
+	public static final String getCurrentUserName() {
+		return getSecurityName(getRunAsSubject());
+	}
+	
+	private static final Object invokeMethod(Method method, Object instance, Object[] args)
+	{
+		try {
+			return method.invoke(instance,args);
+		} catch (IllegalArgumentException e) {
+			logger.error("Error while invoking method "+method.getClass().getName()+"."+method.getName()+"("+ Arrays.asList(args)+")",e);
+			throw new RuntimeException("Error while invoking method "+method.getClass().getName()+"."+method.getName()+"("+Arrays.asList(args)+")",e);
+		} catch (IllegalAccessException e) {
+			logger.error("Error while invoking method "+method.getClass().getName()+"."+method.getName()+"("+Arrays.asList(args)+")",e);
+			throw new RuntimeException("Error while invoking method "+method.getClass().getName()+"."+method.getName()+"("+Arrays.asList(args)+")",e);
+		} catch (InvocationTargetException e) {
+			logger.error("Error while invoking method "+method.getClass().getName()+"."+method.getName()+"("+Arrays.asList(args)+")",e);
+			throw new RuntimeException("Error while invoking method "+method.getClass().getName()+"."+method.getName()+"("+Arrays.asList(args)+")",e);
+		}
+	}
 
-    private static final Method getRunAsSubjectMethod() {
-        if (getRunAsSubject == null) {
-            getRunAsSubject = getMethod("com.ibm.websphere.security.auth.WSSubject", "getRunAsSubject", new String[] {});
-        }
-        return getRunAsSubject;
-    }
+	private static final Method getMethod(String className, String methodName, String[] parameterTypeNames) {
+		try {
+			Class c = Class.forName(className);
+			final int len = parameterTypeNames.length;
+			Class[] parameterTypes = new Class[len];
+			for (int i = 0; i < len; i++) {
+				parameterTypes[i] = Class.forName(parameterTypeNames[i]);
+			}
+			return c.getDeclaredMethod(methodName, parameterTypes);
+		} catch (ClassNotFoundException e) {
+			logger.error("Required class"+className+" not found");
+			throw new RuntimeException("Required class"+className+" not found",e);
+		} catch (NoSuchMethodException e) {
+			logger.error("Required method "+methodName+" with parameter types ("+ Arrays.asList(parameterTypeNames) +") not found on class "+className);
+			throw new RuntimeException("Required class"+className+" not found",e);
+		}
+	}
 
-    private static final Method getGroupsForUserMethod() {
-        if (getGroupsForUser == null) {
-            getGroupsForUser = getMethod("com.ibm.websphere.security.UserRegistry", "getGroupsForUser", new String[] { "java.lang.String" });
-        }
-        return getGroupsForUser;
-    }
+	private static final Method getRunAsSubjectMethod() {
+		if (getRunAsSubject == null) {
+			getRunAsSubject = getMethod("com.ibm.websphere.security.auth.WSSubject", "getRunAsSubject", new String[] {});
+		}
+		return getRunAsSubject;
+	}
 
-    private static final Method getSecurityNameMethod() {
-        if (getSecurityName == null) {
-            getSecurityName = getMethod("com.ibm.websphere.security.cred.WSCredential", "getSecurityName", new String[] {});
-        }
-        return getSecurityName;
-    }
-    
-    // SEC-803
-    private static final Class getWSCredentialClass() {
-        if (wsCredentialClass == null) {
-            wsCredentialClass = getClass("com.ibm.websphere.security.cred.WSCredential");
-        }
-        return wsCredentialClass;
-    }
-    
-    private static final Class getClass(String className) {
-        try {
-            return Class.forName(className);
-        } catch (ClassNotFoundException e) {
-            logger.error("Required class " + className + " not found");
-            throw new RuntimeException("Required class " + className + " not found",e);
-        }
-    }    
+	private static final Method getWSCredentialFromSubjectMethod() {
+		if (getWSCredentialFromSubject == null) {
+			getWSCredentialFromSubject = getMethod("com.ibm.ws.security.auth.SubjectHelper", "getWSCredentialFromSubject",
+					new String[] { "javax.security.auth.Subject" });
+		}
+		return getWSCredentialFromSubject;
+	}
+
+	private static final Method getGroupsForUserMethod() {
+		if (getGroupsForUser == null) {
+			getGroupsForUser = getMethod("com.ibm.websphere.security.UserRegistry", "getGroupsForUser", new String[] { "java.lang.String" });
+		}
+		return getGroupsForUser;
+	}
+
+	private static final Method getSecurityNameMethod() {
+		if (getSecurityName == null) {
+			getSecurityName = getMethod("com.ibm.websphere.security.cred.WSCredential", "getSecurityName", new String[] {});
+		}
+		return getSecurityName;
+	}
 
 }

core/src/main/java/org/springframework/security/ui/preauth/websphere/WebSpherePreAuthenticatedAuthenticationDetailsSource.java

@@ -1,7 +1,6 @@
 package org.springframework.security.ui.preauth.websphere;
 
-import java.util.Arrays;
-
+import org.apache.commons.lang.ArrayUtils;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.springframework.beans.factory.InitializingBean;
@@ -69,8 +68,8 @@ public class WebSpherePreAuthenticatedAuthenticationDetailsSource extends Authen
 		String[] webSphereGroups = WASSecurityHelper.getGroupsForCurrentUser();
 		GrantedAuthority[] userGas = webSphereGroups2GrantedAuthoritiesMapper.getGrantedAuthorities(webSphereGroups);
 		if (LOG.isDebugEnabled()) {
-			LOG.debug("WebSphere groups: " + Arrays.asList(webSphereGroups) + " mapped to Granted Authorities: "
-					+ Arrays.asList(userGas));
+			LOG.debug("WebSphere groups [" + ArrayUtils.toString(webSphereGroups) + "] mapped to Granted Authorities: ["
+					+ ArrayUtils.toString(userGas) + "]");
 		}
 		return userGas;
 	}

core/src/main/java/org/springframework/security/ui/rememberme/AbstractRememberMeServices.java

@@ -313,14 +313,7 @@ public abstract class AbstractRememberMeServices implements RememberMeServices,
         this.alwaysRemember = alwaysRemember;
     }
 
-    /**
-     * Sets the name of the parameter which should be checked for to see if a remember-me has been requested
-     * during a login request. This should be the same name you assign to the checkbox in your login form.
-     * 
-     * @param parameter the HTTP request parameter
-     */
     public void setParameter(String parameter) {
-    	Assert.hasText(parameter, "Parameter name cannot be null");
         this.parameter = parameter;
     }
 
@@ -333,7 +326,6 @@ public abstract class AbstractRememberMeServices implements RememberMeServices,
     }
 
     public void setUserDetailsService(UserDetailsService userDetailsService) {
-    	Assert.notNull(userDetailsService, "UserDetailsService canot be null");
         this.userDetailsService = userDetailsService;
     }
 
@@ -356,9 +348,4 @@ public abstract class AbstractRememberMeServices implements RememberMeServices,
     protected AuthenticationDetailsSource getAuthenticationDetailsSource() {
         return authenticationDetailsSource;
     }
-
-	public void setAuthenticationDetailsSource(AuthenticationDetailsSource authenticationDetailsSource) {
-		Assert.notNull(authenticationDetailsSource, "AuthenticationDetailsSource cannot be null");
-		this.authenticationDetailsSource = authenticationDetailsSource;
-	}
 }

core/src/main/java/org/springframework/security/ui/rememberme/TokenBasedRememberMeServices.java

@@ -152,7 +152,7 @@ public class TokenBasedRememberMeServices extends AbstractRememberMeServices {
 		}
 
 		int tokenLifetime = calculateLoginLifetime(request, successfulAuthentication);
-        long expiryTime = System.currentTimeMillis() + 1000L*tokenLifetime;
+        long expiryTime = System.currentTimeMillis() + 1000*tokenLifetime;
 
         String signatureValue = makeTokenSignature(expiryTime, username, password);
 

core/src/main/java/org/springframework/security/ui/webapp/AuthenticationProcessingFilter.java

@@ -22,7 +22,6 @@ import org.springframework.security.providers.UsernamePasswordAuthenticationToke
 
 import org.springframework.security.ui.AbstractProcessingFilter;
 import org.springframework.security.ui.FilterChainOrder;
-import org.springframework.security.util.TextUtils;
 import org.springframework.util.Assert;
 
 import javax.servlet.http.HttpServletRequest;
@@ -73,7 +72,7 @@ public class AuthenticationProcessingFilter extends AbstractProcessingFilter {
         HttpSession session = request.getSession(false);
 
         if (session != null || getAllowSessionCreation()) {
-            request.getSession().setAttribute(SPRING_SECURITY_LAST_USERNAME_KEY, TextUtils.escapeEntities(username));
+            request.getSession().setAttribute(SPRING_SECURITY_LAST_USERNAME_KEY, username);
         }
 
         // Allow subclasses to set the "details" property

core/src/main/java/org/springframework/security/ui/webapp/DefaultLoginPageGeneratingFilter.java

@@ -76,7 +76,8 @@ public class DefaultLoginPageGeneratingFilter extends SpringSecurityFilter {
     protected void doFilterHttp(HttpServletRequest request, HttpServletResponse response, FilterChain chain) throws IOException, ServletException {
         if (isLoginUrlRequest(request)) {
             String loginPageHtml = generateLoginPageHtml(request);
-            response.setContentType("text/html;charset=UTF-8");
+            response.setCharacterEncoding("UTF-8");
+            response.setContentType("text/html");
             response.setContentLength(loginPageHtml.length());
             response.getOutputStream().print(loginPageHtml);            
 

core/src/main/java/org/springframework/security/userdetails/hierarchicalroles/RoleHierarchyImpl.java

@@ -126,7 +126,7 @@ public class RoleHierarchyImpl implements RoleHierarchy {
      * references a set of the reachable lower roles.
      */
     private void buildRolesReachableInOneStepMap() {
-        String parsingRegex = "(\\s*([^\\s>]+)\\s*\\>\\s*([^\\s>]+))";
+        String parsingRegex = "(\\s*(\\w+)\\s*\\>\\s*(\\w+))";
         Pattern pattern = Pattern.compile(parsingRegex);
 
         Matcher roleHierarchyMatcher = pattern.matcher(roleHierarchyStringRepresentation);

core/src/main/java/org/springframework/security/userdetails/jdbc/JdbcUserDetailsManager.java

@@ -15,17 +15,19 @@ import org.springframework.security.userdetails.UserDetails;
 import org.springframework.security.userdetails.UserDetailsManager;
 import org.springframework.security.userdetails.GroupManager;
 import org.springframework.context.ApplicationContextException;
-import org.springframework.dao.IncorrectResultSizeDataAccessException;
-import org.springframework.jdbc.core.PreparedStatementSetter;
-import org.springframework.jdbc.core.RowMapper;
+import org.springframework.jdbc.core.SqlParameter;
+import org.springframework.jdbc.object.MappingSqlQuery;
+import org.springframework.jdbc.object.SqlQuery;
+import org.springframework.jdbc.object.SqlUpdate;
 import org.springframework.util.Assert;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 
-import java.sql.PreparedStatement;
+import javax.sql.DataSource;
 import java.sql.ResultSet;
 import java.sql.SQLException;
+import java.sql.Types;
 import java.util.List;
 
 /**
@@ -114,6 +116,28 @@ public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsMa
     private String groupAuthoritiesSql = DEF_GROUP_AUTHORITIES_QUERY_SQL;
     private String deleteGroupAuthoritySql = DEF_DELETE_GROUP_AUTHORITY_SQL;
 
+    private SqlUpdate insertUser;
+    private SqlUpdate deleteUser;
+    private SqlUpdate updateUser;
+    private SqlUpdate insertAuthority;
+    private SqlUpdate deleteUserAuthorities;
+    private SqlQuery  userExistsQuery;
+    private SqlUpdate changePassword;
+
+    private SqlQuery  findAllGroupsQuery;
+    private SqlQuery  findUsersInGroupQuery;
+    private SqlUpdate insertGroup;
+    private SqlQuery  findGroupIdQuery;
+    private SqlUpdate insertGroupAuthority;
+    private SqlUpdate deleteGroup;
+    private SqlUpdate deleteGroupMembers;
+    private SqlUpdate deleteGroupAuthorities;
+    private SqlUpdate renameGroup;
+    private SqlUpdate insertGroupMember;
+    private SqlUpdate deleteGroupMember;
+    private SqlQuery groupAuthoritiesQuery;
+    private SqlUpdate deleteGroupAuthority;
+
     private AuthenticationManager authenticationManager;
 
     private UserCache userCache = new NullUserCache();
@@ -126,36 +150,43 @@ public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsMa
                     "not be performed.");
         }
 
+        insertUser = new InsertUser(getDataSource());
+        deleteUser = new DeleteUser(getDataSource());
+        updateUser = new UpdateUser(getDataSource());
+        insertAuthority = new InsertAuthority(getDataSource());
+        deleteUserAuthorities = new DeleteUserAuthorities(getDataSource());
+        userExistsQuery = new UserExistsQuery(getDataSource());
+        changePassword = new ChangePassword(getDataSource());
+
+        findAllGroupsQuery = new AllGroupsQuery(getDataSource());
+        findUsersInGroupQuery = new GroupMembersQuery(getDataSource());
+        insertGroup = new InsertGroup(getDataSource());
+        findGroupIdQuery = new FindGroupIdQuery(getDataSource());
+        insertGroupAuthority = new InsertGroupAuthority(getDataSource());
+        deleteGroup = new DeleteGroup(getDataSource());
+        deleteGroupAuthorities = new DeleteGroupAuthorities(getDataSource());
+        deleteGroupMembers = new DeleteGroupMembers(getDataSource());
+        renameGroup = new RenameGroup(getDataSource());
+        insertGroupMember = new InsertGroupMember(getDataSource());
+        deleteGroupMember = new DeleteGroupMember (getDataSource());
+        groupAuthoritiesQuery = new GroupAuthoritiesByGroupNameMapping(getDataSource());
+        deleteGroupAuthority = new DeleteGroupAuthority(getDataSource());
+
         super.initDao();
     }
 
     //~ UserDetailsManager implementation ==============================================================================
 
-    public void createUser(final UserDetails user) {
+    public void createUser(UserDetails user) {
         validateUserDetails(user);
-        getJdbcTemplate().update(createUserSql, new PreparedStatementSetter() {
-			public void setValues(PreparedStatement ps) throws SQLException {
-				ps.setString(1, user.getUsername());
-				ps.setString(2, user.getPassword());
-				ps.setBoolean(3, user.isEnabled());
-			}
-        	
-        });
-
+        insertUser.update(new Object[] {user.getUsername(), user.getPassword(), Boolean.valueOf(user.isEnabled())});
         insertUserAuthorities(user);
     }
 
-    public void updateUser(final UserDetails user) {
+    public void updateUser(UserDetails user) {
         validateUserDetails(user);
-        getJdbcTemplate().update(updateUserSql, new PreparedStatementSetter() {
-			public void setValues(PreparedStatement ps) throws SQLException {
-				ps.setString(1, user.getPassword());
-				ps.setBoolean(2, user.isEnabled());
-				ps.setString(3, user.getUsername());
-			}
-        });
-
-        deleteUserAuthorities(user.getUsername());
+        updateUser.update(new Object[] {user.getPassword(), Boolean.valueOf(user.isEnabled()), user.getUsername()});
+        deleteUserAuthorities.update(user.getUsername());
         insertUserAuthorities(user);
 
         userCache.removeUserFromCache(user.getUsername());
@@ -163,20 +194,15 @@ public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsMa
 
     private void insertUserAuthorities(UserDetails user) {
         for (int i=0; i < user.getAuthorities().length; i++) {
-        	getJdbcTemplate().update(createAuthoritySql, 
-        			new Object[] {user.getUsername(), user.getAuthorities()[i].getAuthority()});
+            insertAuthority.update(user.getUsername(), user.getAuthorities()[i].getAuthority());
         }
     }
 
     public void deleteUser(String username) {
-        deleteUserAuthorities(username);
-        getJdbcTemplate().update(deleteUserSql, new Object[] {username});
+        deleteUserAuthorities.update(username);
+        deleteUser.update(username);
         userCache.removeUserFromCache(username);
     }
-    
-    private void deleteUserAuthorities(String username) {
-    	getJdbcTemplate().update(deleteUserAuthoritiesSql, new Object[] {username});
-    }
 
     public void changePassword(String oldPassword, String newPassword) throws AuthenticationException {
         Authentication currentUser = SecurityContextHolder.getContext().getAuthentication();
@@ -200,7 +226,7 @@ public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsMa
 
         logger.debug("Changing password for user '"+ username + "'");
 
-        getJdbcTemplate().update(changePasswordSql, new String[] {newPassword, username});
+        changePassword.update(new String[] {newPassword, username});
 
         SecurityContextHolder.getContext().setAuthentication(createNewAuthentication(currentUser, newPassword));
 
@@ -218,10 +244,10 @@ public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsMa
     }
 
     public boolean userExists(String username) {
-    	List users = getJdbcTemplate().queryForList(userExistsSql, new Object[] {username});
+        List users = userExistsQuery.execute(username);
 
         if (users.size() > 1) {
-            throw new IncorrectResultSizeDataAccessException("More than one user found with name '" + username + "'", 1);
+            throw new IllegalStateException("More than one user found with name '" + username + "'");
         }
 
         return users.size() == 1;
@@ -230,33 +256,26 @@ public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsMa
     //~ GroupManager implementation ====================================================================================
 
     public String[] findAllGroups() {
-        return (String[]) getJdbcTemplate().queryForList(findAllGroupsSql, String.class).toArray(new String[0]);
+        return (String[]) findAllGroupsQuery.execute().toArray(new String[0]);
     }
 
     public String[] findUsersInGroup(String groupName) {
         Assert.hasText(groupName);
-        return (String[]) getJdbcTemplate().queryForList(findUsersInGroupSql, new String[] {groupName}, String.class).toArray(new String[0]);
+        return (String[]) findUsersInGroupQuery.execute(groupName).toArray(new String[0]);
     }
 
-    public void createGroup(final String groupName, final GrantedAuthority[] authorities) {
+    public void createGroup(String groupName, GrantedAuthority[] authorities) {
         Assert.hasText(groupName);
         Assert.notNull(authorities);
 
         logger.debug("Creating new group '" + groupName + "' with authorities " +
                     AuthorityUtils.authorityArrayToSet(authorities));
 
-        getJdbcTemplate().update(insertGroupSql, new String[] {groupName});
-        
-        final int groupId = findGroupId(groupName);
+        insertGroup.update(groupName);
+        Integer id = (Integer) findGroupIdQuery.findObject(groupName);
 
         for (int i=0; i < authorities.length; i++) {
-        	final String authority = authorities[i].getAuthority(); 
-        	getJdbcTemplate().update(insertGroupAuthoritySql, new PreparedStatementSetter() {
-				public void setValues(PreparedStatement ps) throws SQLException {
-					ps.setInt(1, groupId);
-					ps.setString(2, authority);
-				}
-        	});
+            insertGroupAuthority.update( new Object[] {id, authorities[i].getAuthority()});
         }
     }
 
@@ -264,15 +283,10 @@ public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsMa
         logger.debug("Deleting group '" + groupName + "'");
         Assert.hasText(groupName);
 
-        final int id = findGroupId(groupName);
-        PreparedStatementSetter groupIdPSS = new PreparedStatementSetter() {
-			public void setValues(PreparedStatement ps) throws SQLException {
-				ps.setInt(1, id);
-			}
-        };
-        getJdbcTemplate().update(deleteGroupMembersSql, groupIdPSS);
-        getJdbcTemplate().update(deleteGroupAuthoritiesSql, groupIdPSS);
-        getJdbcTemplate().update(deleteGroupSql, groupIdPSS);
+        int id = ((Integer) findGroupIdQuery.findObject(groupName)).intValue();
+        deleteGroupMembers.update(id);
+        deleteGroupAuthorities.update(id);
+        deleteGroup.update(id);
     }
 
     public void renameGroup(String oldName, String newName) {
@@ -280,90 +294,54 @@ public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsMa
         Assert.hasText(oldName);
         Assert.hasText(newName);
 
-        getJdbcTemplate().update(renameGroupSql, new String[] {newName, oldName});
+        renameGroup.update(newName, oldName);
     }
 
-    public void addUserToGroup(final String username, final String groupName) {
+    public void addUserToGroup(String username, String groupName) {
         logger.debug("Adding user '" + username + "' to group '" + groupName + "'");
         Assert.hasText(username);
         Assert.hasText(groupName);
 
-        final int id = findGroupId(groupName);
-        getJdbcTemplate().update(insertGroupMemberSql, new PreparedStatementSetter() {
-			public void setValues(PreparedStatement ps) throws SQLException {
-				ps.setInt(1, id);
-				ps.setString(2, username);
-			}
-        });
+        Integer id = (Integer) findGroupIdQuery.findObject(groupName);
 
+        insertGroupMember.update(new Object[] {id, username});
         userCache.removeUserFromCache(username);
     }
 
-    public void removeUserFromGroup(final String username, final String groupName) {
+    public void removeUserFromGroup(String username, String groupName) {
         logger.debug("Removing user '" + username + "' to group '" + groupName + "'");
         Assert.hasText(username);
         Assert.hasText(groupName);
 
-        final int id = findGroupId(groupName);
-
-        getJdbcTemplate().update(deleteGroupMemberSql, new PreparedStatementSetter() {
-			public void setValues(PreparedStatement ps) throws SQLException {
-				ps.setInt(1, id);
-				ps.setString(2, username);
-			}
-        });
+        Integer id = (Integer) findGroupIdQuery.findObject(groupName);
 
+        deleteGroupMember.update(new Object[] {id, username});
         userCache.removeUserFromCache(username);
     }
 
     public GrantedAuthority[] findGroupAuthorities(String groupName) {
         logger.debug("Loading authorities for group '" + groupName + "'");
         Assert.hasText(groupName);
-        
-        List authorities = getJdbcTemplate().query(groupAuthoritiesSql, new String[] {groupName}, new RowMapper() {
-			public Object mapRow(ResultSet rs, int rowNum) throws SQLException {
-	             String roleName = getRolePrefix() + rs.getString(3);
-	             GrantedAuthorityImpl authority = new GrantedAuthorityImpl(roleName);
 
-	             return authority;				
-			}        	
-        });
-
-        return (GrantedAuthority[]) authorities.toArray(new GrantedAuthority[0]);
+        return (GrantedAuthority[]) groupAuthoritiesQuery.execute(groupName).toArray(new GrantedAuthority[0]);
     }
 
-    public void removeGroupAuthority(String groupName, final GrantedAuthority authority) {
+    public void removeGroupAuthority(String groupName, GrantedAuthority authority) {
         logger.debug("Removing authority '" + authority + "' from group '" + groupName + "'");
         Assert.hasText(groupName);
         Assert.notNull(authority);
 
-        final int id = findGroupId(groupName);
-        
-        getJdbcTemplate().update(deleteGroupAuthoritySql, new PreparedStatementSetter() {
-
-			public void setValues(PreparedStatement ps) throws SQLException {
-				ps.setInt(1, id);
-				ps.setString(2, authority.getAuthority());
-			}        	
-        });
+        Integer id = (Integer) findGroupIdQuery.findObject(groupName);
+        deleteGroupAuthority.update(new Object[] {id, authority});
     }
 
-    public void addGroupAuthority(final String groupName, final GrantedAuthority authority) {
+    public void addGroupAuthority(String groupName, GrantedAuthority authority) {
         logger.debug("Adding authority '" + authority + "' to group '" + groupName + "'");
         Assert.hasText(groupName);
         Assert.notNull(authority);
 
-        final int id = findGroupId(groupName);
-        getJdbcTemplate().update(insertGroupAuthoritySql, new PreparedStatementSetter() {
-			public void setValues(PreparedStatement ps) throws SQLException {
-				ps.setInt(1, id);
-				ps.setString(2, authority.getAuthority());
-			}
-        });
-    }
-    
-    private int findGroupId(String group) {
-    	return getJdbcTemplate().queryForInt(findGroupIdSql, new Object[] {group});
+        Integer id = (Integer) findGroupIdQuery.findObject(groupName);
+        insertGroupAuthority.update(new Object[] {id, authority.getAuthority()});
     }
 
     public void setAuthenticationManager(AuthenticationManager authenticationManager) {
@@ -433,4 +411,201 @@ public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsMa
             Assert.hasText(authorities[i].getAuthority(), "getAuthority() method must return a non-empty string");
         }
     }
+
+    //~ Inner Classes ==================================================================================================
+
+    private class InsertUser extends SqlUpdate {
+
+        public InsertUser(DataSource ds) {
+            super(ds, createUserSql);
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            declareParameter(new SqlParameter(Types.BOOLEAN));
+            compile();
+        }
+    }
+
+    private class DeleteUser extends SqlUpdate {
+        public DeleteUser(DataSource ds) {
+            super(ds, deleteUserSql);
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+    }
+
+    private class InsertAuthority extends SqlUpdate {
+        public InsertAuthority(DataSource ds) {
+            super(ds, createAuthoritySql);
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+    }
+
+    private class DeleteUserAuthorities extends SqlUpdate {
+        public DeleteUserAuthorities(DataSource ds) {
+            super(ds, deleteUserAuthoritiesSql);
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+    }
+
+    private class UpdateUser extends SqlUpdate {
+        public UpdateUser(DataSource ds) {
+            super(ds, updateUserSql);
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            declareParameter(new SqlParameter(Types.BOOLEAN));
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+    }
+
+    private class ChangePassword extends SqlUpdate {
+        public ChangePassword(DataSource ds) {
+            super(ds, changePasswordSql);
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+    }
+
+
+    private class UserExistsQuery extends MappingSqlQuery {
+        public UserExistsQuery(DataSource ds) {
+            super(ds, userExistsSql);
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+
+        protected Object mapRow(ResultSet rs, int rowNum) throws SQLException {
+            return rs.getString(1);
+        }
+    }
+
+    private class AllGroupsQuery extends MappingSqlQuery {
+        public AllGroupsQuery(DataSource ds) {
+            super(ds, findAllGroupsSql);
+            compile();
+        }
+
+        protected Object mapRow(ResultSet rs, int rowNum) throws SQLException {
+            return rs.getString(1);
+        }
+    }
+
+    private class GroupMembersQuery extends MappingSqlQuery {
+        public GroupMembersQuery(DataSource ds) {
+            super(ds, findUsersInGroupSql);
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+
+        protected Object mapRow(ResultSet rs, int rowNum) throws SQLException {
+            return rs.getString(1);
+        }
+    }
+
+    private class InsertGroup extends SqlUpdate {
+        public InsertGroup(DataSource ds) {
+            super(ds, insertGroupSql);
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+    }
+
+    private class FindGroupIdQuery extends MappingSqlQuery {
+        public FindGroupIdQuery(DataSource ds) {
+            super(ds, findGroupIdSql);
+            declareParameter(new SqlParameter(Types.INTEGER));
+            compile();
+        }
+
+        protected Object mapRow(ResultSet rs, int rowNum) throws SQLException {
+            return new Integer(rs.getInt(1));
+        }
+    }
+
+    private class InsertGroupAuthority extends SqlUpdate {
+        public InsertGroupAuthority(DataSource ds) {
+            super(ds, insertGroupAuthoritySql);
+            declareParameter(new SqlParameter(Types.INTEGER));
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+    }
+
+    protected class DeleteGroup extends SqlUpdate {
+        public DeleteGroup(DataSource ds) {
+            super(ds, deleteGroupSql);
+            declareParameter(new SqlParameter(Types.INTEGER));
+            compile();
+        }
+    }
+
+    private class DeleteGroupMembers extends SqlUpdate {
+        public DeleteGroupMembers(DataSource ds) {
+            super(ds, deleteGroupMembersSql);
+            declareParameter(new SqlParameter(Types.INTEGER));
+            compile();
+        }
+    }
+
+    protected class DeleteGroupAuthorities extends SqlUpdate {
+        public DeleteGroupAuthorities(DataSource ds) {
+            super(ds, deleteGroupAuthoritiesSql);
+            declareParameter(new SqlParameter(Types.INTEGER));
+            compile();
+        }
+    }
+
+    private class RenameGroup extends SqlUpdate {
+        public RenameGroup(DataSource ds) {
+            super(ds, renameGroupSql);
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+    }
+
+    protected class InsertGroupMember extends SqlUpdate {
+        public InsertGroupMember(DataSource ds) {
+            super(ds, insertGroupMemberSql);
+            declareParameter(new SqlParameter(Types.INTEGER));
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+    }
+
+    private class DeleteGroupMember extends SqlUpdate {
+        public DeleteGroupMember(DataSource ds) {
+            super(ds, deleteGroupMemberSql);
+            declareParameter(new SqlParameter(Types.INTEGER));
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+    }
+
+    private class GroupAuthoritiesByGroupNameMapping extends MappingSqlQuery {
+         protected GroupAuthoritiesByGroupNameMapping(DataSource ds) {
+             super(ds, groupAuthoritiesSql);
+             declareParameter(new SqlParameter(Types.VARCHAR));
+             compile();
+         }
+
+         protected Object mapRow(ResultSet rs, int rownum) throws SQLException {
+             String roleName = getRolePrefix() + rs.getString(3);
+             GrantedAuthorityImpl authority = new GrantedAuthorityImpl(roleName);
+
+             return authority;
+         }
+    }
+
+    private class DeleteGroupAuthority extends SqlUpdate {
+        public DeleteGroupAuthority(DataSource ds) {
+            super(ds, deleteGroupAuthoritySql);
+            declareParameter(new SqlParameter(Types.INTEGER));
+            declareParameter(new SqlParameter(Types.VARCHAR));
+            compile();
+        }
+    }
 }

core/src/main/java/org/springframework/security/util/InMemoryXmlApplicationContext.java

@@ -15,7 +15,7 @@ public class InMemoryXmlApplicationContext extends AbstractXmlApplicationContext
                     "    xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance'\n" +
                     "    xsi:schemaLocation='http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.0.xsd\n" +
                     "http://www.springframework.org/schema/aop http://www.springframework.org/schema/aop/spring-aop-2.0.xsd\n" +
-                    "http://www.springframework.org/schema/security http://www.springframework.org/schema/security/spring-security-2.0.2.xsd'>\n";
+                    "http://www.springframework.org/schema/security http://www.springframework.org/schema/security/spring-security-2.0.1.xsd'>\n";
     private static final String BEANS_CLOSE = "</b:beans>\n";
 
     Resource inMemoryXml;

core/src/main/java/org/springframework/security/util/TextUtils.java

@@ -1,33 +0,0 @@
-package org.springframework.security.util;
-
-/**
- * Utilities for working with Strings and text.
- * 
- * @author Luke Taylor
- * @version $Id$
- */
-public abstract class TextUtils {
-
-    public static String escapeEntities(String s) {
-        StringBuffer sb = new StringBuffer();
-        
-        for (int i=0; i < s.length(); i++) {
-            char c = s.charAt(i);
-            
-            if(c == '<') {
-                sb.append("&lt;");
-            } else if (c == '>') {
-                sb.append("&gt;");
-            } else if (c == '"') {
-                sb.append("&#034;");
-            } else if (c == '\'') {
-                sb.append("&#039;");
-            } else {
-                sb.append(c);
-            }
-        }
-        
-        return sb.toString();
-    }
-    
-}

core/src/main/java/org/springframework/security/util/UrlUtils.java

@@ -18,7 +18,6 @@ package org.springframework.security.util;
 import org.springframework.security.intercept.web.FilterInvocation;
 
 import org.springframework.security.ui.savedrequest.SavedRequest;
-import org.springframework.util.StringUtils;
 
 import javax.servlet.http.HttpServletRequest;
 
@@ -42,6 +41,16 @@ public final class UrlUtils {
      * Obtains the full URL the client used to make the request.<p>Note that the server port will not be shown
      * if it is the default server port for HTTP or HTTPS (ie 80 and 443 respectively).</p>
      *
+     * @param scheme DOCUMENT ME!
+     * @param serverName DOCUMENT ME!
+     * @param serverPort DOCUMENT ME!
+     * @param contextPath DOCUMENT ME!
+     * @param requestUrl DOCUMENT ME!
+     * @param servletPath DOCUMENT ME!
+     * @param requestURI DOCUMENT ME!
+     * @param pathInfo DOCUMENT ME!
+     * @param queryString DOCUMENT ME!
+     *
      * @return the full URL
      */
     private static String buildFullRequestUrl(String scheme, String serverName, int serverPort, String contextPath,
@@ -64,6 +73,12 @@ public final class UrlUtils {
     /**
      * Obtains the web application-specific fragment of the URL.
      *
+     * @param servletPath DOCUMENT ME!
+     * @param requestURI DOCUMENT ME!
+     * @param contextPath DOCUMENT ME!
+     * @param pathInfo DOCUMENT ME!
+     * @param queryString DOCUMENT ME!
+     *
      * @return the URL, excluding any server name, context path or servlet path
      */
     private static String buildRequestUrl(String servletPath, String requestURI, String contextPath, String pathInfo,
@@ -102,8 +117,4 @@ public final class UrlUtils {
         return buildRequestUrl(sr.getServletPath(), sr.getRequestURI(), sr.getContextPath(), sr.getPathInfo(),
             sr.getQueryString());
     }
-    
-    public static boolean isValidRedirectUrl(String url) {
-    	return !StringUtils.hasText(url) || url.startsWith("/") || url.toLowerCase().startsWith("http");
-    }
 }

core/src/main/java/org/springframework/security/vote/RoleVoter.java

@@ -25,9 +25,9 @@ import org.springframework.security.GrantedAuthority;
 /**
  * Votes if any {@link ConfigAttribute#getAttribute()} starts with a prefix
  * indicating that it is a role. The default prefix string is <Code>ROLE_</code>,
- * but this may be overridden to any value. It may also be set to empty, which
+ * but this may be overriden to any value. It may also be set to empty, which
  * means that essentially any attribute will be voted on. As described further
- * below, the effect of an empty prefix may not be quite desirable.
+ * below, the effect of an empty prefix may not be quite desireable.
  * <p>
  * Abstains from voting if no configuration attribute commences with the role
  * prefix. Votes to grant access if there is an exact matching
@@ -40,7 +40,7 @@ import org.springframework.security.GrantedAuthority;
  * ConfigAttribute. When there are different categories of ConfigAttributes
  * used, this will not be optimal since the voter will be voting for attributes
  * which do not represent roles. However, this option may be of some use when
- * using pre-existing role names without a prefix, and no ability exists to
+ * using preexisting role names without a prefix, and no ability exists to
  * prefix them with a role prefix on reading them in, such as provided for
  * example in {@link org.springframework.security.userdetails.jdbc.JdbcDaoImpl}.
  * <p>
@@ -62,8 +62,8 @@ public class RoleVoter implements AccessDecisionVoter {
     }
 
     /**
-     * Allows the default role prefix of <code>ROLE_</code> to be overridden.
-     * May be set to an empty value, although this is usually not desirable.
+     * Allows the default role prefix of <code>ROLE_</code> to be overriden.
+     * May be set to an empty value, although this is usually not desireable.
      *
      * @param rolePrefix the new prefix
      */

core/src/main/java/org/springframework/security/wrapper/SavedRequestAwareWrapper.java

@@ -28,17 +28,12 @@ import org.apache.commons.logging.LogFactory;
 import java.text.SimpleDateFormat;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.Enumeration;
-import java.util.HashMap;
-import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
-import java.util.Set;
 import java.util.TimeZone;
-import java.util.Map.Entry;
 
 import javax.servlet.http.Cookie;
 import javax.servlet.http.HttpServletRequest;
@@ -121,6 +116,9 @@ public class SavedRequestAwareWrapper extends SecurityContextHolderAwareRequestW
 
     //~ Methods ========================================================================================================
 
+    /**
+     * The default behavior of this method is to return getCookies() on the wrapped request object.
+     */
     public Cookie[] getCookies() {
         if (savedRequest == null) {
             return super.getCookies();
@@ -131,6 +129,10 @@ public class SavedRequestAwareWrapper extends SecurityContextHolderAwareRequestW
         }
     }
 
+    /**
+     * The default behavior of this method is to return getDateHeader(String name) on the wrapped request
+     * object.
+     */
     public long getDateHeader(String name) {
         if (savedRequest == null) {
             return super.getDateHeader(name);
@@ -152,6 +154,9 @@ public class SavedRequestAwareWrapper extends SecurityContextHolderAwareRequestW
         }
     }
 
+    /**
+     * The default behavior of this method is to return getHeader(String name) on the wrapped request object.
+     */
     public String getHeader(String name) {
         if (savedRequest == null) {
             return super.getHeader(name);
@@ -169,6 +174,9 @@ public class SavedRequestAwareWrapper extends SecurityContextHolderAwareRequestW
         }
     }
 
+    /**
+     * The default behavior of this method is to return getHeaderNames() on the wrapped request object.
+     */
     public Enumeration getHeaderNames() {
         if (savedRequest == null) {
             return super.getHeaderNames();
@@ -177,6 +185,9 @@ public class SavedRequestAwareWrapper extends SecurityContextHolderAwareRequestW
         }
     }
 
+    /**
+     * The default behavior of this method is to return getHeaders(String name) on the wrapped request object.
+     */
     public Enumeration getHeaders(String name) {
         if (savedRequest == null) {
             return super.getHeaders(name);
@@ -185,6 +196,10 @@ public class SavedRequestAwareWrapper extends SecurityContextHolderAwareRequestW
         }
     }
 
+    /**
+     * The default behavior of this method is to return getIntHeader(String name) on the wrapped request
+     * object.
+     */
     public int getIntHeader(String name) {
         if (savedRequest == null) {
             return super.getIntHeader(name);
@@ -199,6 +214,9 @@ public class SavedRequestAwareWrapper extends SecurityContextHolderAwareRequestW
         }
     }
 
+    /**
+     * The default behavior of this method is to return getLocale() on the wrapped request object.
+     */
     public Locale getLocale() {
         if (savedRequest == null) {
             return super.getLocale();
@@ -220,6 +238,10 @@ public class SavedRequestAwareWrapper extends SecurityContextHolderAwareRequestW
         }
     }
 
+    /**
+     * The default behavior of this method is to return getLocales() on the wrapped request object.
+     *
+     */
     public Enumeration getLocales() {
         if (savedRequest == null) {
             return super.getLocales();
@@ -237,6 +259,10 @@ public class SavedRequestAwareWrapper extends SecurityContextHolderAwareRequestW
         }
     }
 
+    /**
+     * The default behavior of this method is to return getMethod() on the wrapped request object.
+     *
+     */
     public String getMethod() {
         if (savedRequest == null) {
             return super.getMethod();
@@ -246,94 +272,80 @@ public class SavedRequestAwareWrapper extends SecurityContextHolderAwareRequestW
     }
 
     /**
-     * If the parameter is available from the wrapped request then either
-     * <ol>
-     * <li>There is no saved request (it a normal request)</li>
-     * <li>There is a saved request, but the request has been forwarded/included to a URL with parameters, either
-     * supplementing or overriding the saved request values.</li>
-     * </ol>
-     * In both cases the value from the wrapped request should be used.
-     * <p>
-     * If the value from the wrapped request is null, an attempt will be made to retrieve the parameter
-     * from the SavedRequest, if available..
+     * The default behavior of this method is to return getParameter(String name) on the wrapped request
+     * object.
      */
     public String getParameter(String name) {
-        String value = super.getParameter(name);
-        
-        if (value != null || savedRequest == null) {
-        	return value;
+/*
+   if (savedRequest == null) {
+       return super.getParameter(name);
+   } else {
+       String value = null;
+       String[] values = savedRequest.getParameterValues(name);
+       if (values == null)
+           return null;
+       for (int i = 0; i < values.length; i++) {
+           value = values[i];
+           break;
+       }
+       return value;
+   }
+ */
+
+        //we do not get value from super.getParameter because there is a bug in Jetty servlet-container
+        String value = null;
+        String[] values = null;
+
+        if (savedRequest == null) {
+            values = super.getParameterValues(name);
+        } else {
+            values = savedRequest.getParameterValues(name);
         }
 
-        String[] values = savedRequest.getParameterValues(name);
-		if (values == null)
-			return null;
-		for (int i = 0; i < values.length; i++) {
-			value = values[i];
-			break;
-		}
+        if (values == null) {
+            return null;
+        }
 
-		return value;
+        for (int i = 0; i < values.length; i++) {
+            value = values[i];
+
+            break;
+        }
+
+        return value;
     }
 
+    /**
+     * The default behavior of this method is to return getParameterMap() on the wrapped request object.
+     */
     public Map getParameterMap() {
-    	if (savedRequest == null) {
+        if (savedRequest == null) {
             return super.getParameterMap();
+        } else {
+            return savedRequest.getParameterMap();
         }
-    	
-    	Set names = getCombinedParameterNames();
-    	Iterator nameIter = names.iterator();
-    	Map parameterMap = new HashMap(names.size());
-    	
-    	while (nameIter.hasNext()) {
-    		String name = (String) nameIter.next();
-    		parameterMap.put(name, getParameterValues(name));
-    	}
-    	
-    	return parameterMap;
-    }
-    
-    private Set getCombinedParameterNames() {
-    	Set names = new HashSet();
-    	names.addAll(super.getParameterMap().keySet());
-    	
-    	if (savedRequest != null) {
-    		names.addAll(savedRequest.getParameterMap().keySet());
-    	}
-    	
-    	return names;
     }
 
+    /**
+     * The default behavior of this method is to return getParameterNames() on the wrapped request object.
+     */
     public Enumeration getParameterNames() {
-    	return new Enumerator(getCombinedParameterNames());
+        if (savedRequest == null) {
+            return super.getParameterNames();
+        } else {
+            return new Enumerator(savedRequest.getParameterNames());
+        }
     }
 
+    /**
+     * The default behavior of this method is to return getParameterValues(String name) on the wrapped request
+     * object.
+     */
     public String[] getParameterValues(String name) {
-    	if (savedRequest == null) {
-    		return super.getParameterValues(name);
-    	}
-    	
-    	String[] savedRequestParams = savedRequest.getParameterValues(name);
-    	String[] wrappedRequestParams = super.getParameterValues(name);
-
-    	if (savedRequestParams == null) {
-    		return wrappedRequestParams;
-    	}
-    	
-    	if (wrappedRequestParams == null) {
-    		return savedRequestParams;
-    	}
-
-    	// We have params in both saved and wrapped requests so have to merge them
-    	List wrappedParamsList = Arrays.asList(wrappedRequestParams);
-    	List combinedParams = new ArrayList(wrappedParamsList);
-
-    	// We want to add all parameters of the saved request *apart from* duplicates of those already added
-    	for (int i = 0; i < savedRequestParams.length; i++) {
-    		if (!wrappedParamsList.contains(savedRequestParams[i])) {
-    			combinedParams.add(savedRequestParams[i]);
-    		}
-    	}
-
-    	return (String[]) combinedParams.toArray(new String[combinedParams.size()]);
+        if (savedRequest == null) {
+            return super.getParameterValues(name);
+        } else {
+            return savedRequest.getParameterValues(name);
+        }
     }
 }

core/src/main/resources/META-INF/spring.schemas

@@ -1,3 +1,3 @@
 http\://www.springframework.org/schema/security/spring-security-2.0.xsd=org/springframework/security/config/spring-security-2.0.xsd
 http\://www.springframework.org/schema/security/spring-security-2.0.1.xsd=org/springframework/security/config/spring-security-2.0.1.xsd
-http\://www.springframework.org/schema/security/spring-security-2.0.2.xsd=org/springframework/security/config/spring-security-2.0.2.xsd
+

core/src/main/resources/org/springframework/security/config/spring-security-2.0.1.rnc

@@ -7,7 +7,7 @@ start = http | ldap-server | authentication-provider | ldap-authentication-provi
 
 hash =
     ## Defines the hashing algorithm used on user passwords. We recommend strongly against using MD4, as it is a very weak hashing algorithm.
-    attribute hash {"plaintext" | "sha" | "sha-256" | "md5" | "md4" | "{sha}" | "{ssha}"}
+    attribute hash {"plaintext" | "sha" | "md5" | "md4" | "{sha}" | "{ssha}"}
 base64 = 
     ## Whether a string should be base64 encoded
     attribute base64 {"true" | "false"}
@@ -34,10 +34,6 @@ cache-ref =
 user-service-ref =
     ## A reference to a user-service (or UserDetailsService bean) Id
     attribute user-service-ref {xsd:string}
-
-data-source-ref = 
-    ## A reference to a DataSource bean
-    attribute data-source-ref {xsd:string}    
     
 password-encoder = 
     ## element which defines a password encoding strategy. Used by an authentication provider to convert submitted passwords to hashed versions, for example.
@@ -57,7 +53,7 @@ system-wide =
 boolean = "true" | "false"
 
 role-prefix =
-    ## A non-empty string prefix that will be added to role strings loaded from persistent storage (e.g. "ROLE_"). Use the value "none" for no prefix in cases where the default is non-empty.
+    ## A non-empty string prefix that will be added to role strings loaded from persistent storage (e.g. "ROLE_").
     attribute role-prefix {xsd:string}
 
 
@@ -255,7 +251,7 @@ intercept-url.attlist &=
     attribute method {"GET" | "DELETE" | "HEAD" | "OPTIONS" | "POST" | "PUT" | "TRACE"}?
 
 intercept-url.attlist &=
-    ## The filter list for the path. Currently can be set to "none" to remove a path from having any filters applied. The full filter stack (consisting of all filters created by the namespace configuration, and any added using 'custom-filter'), will be applied to any other paths.
+    ## The filter list for the path. Currently can be set to "none" to remove a path from having any filters applied. The full filter stack (consisting of all defined filters, will be applied to any other paths).
     attribute filters {"none"}?
 intercept-url.attlist &=
     ## Used to specify that a URL must be accessed over http or https
@@ -335,44 +331,20 @@ concurrent-session-control =
 concurrent-sessions.attlist &=
     attribute max-sessions {xsd:positiveInteger}?
 concurrent-sessions.attlist &=
-    ## The URL a user will be redirected to if they attempt to use a session which has been "expired" by the concurrent session controller.
     attribute expired-url {xsd:string}?
 concurrent-sessions.attlist &=
-    ## Specifies that an exception should be raised when a user attempts to login twice. The default behaviour is to expire the original session.
     attribute exception-if-maximum-exceeded {boolean}?
 concurrent-sessions.attlist &=
     ## Allows you to define an alias for the SessionRegistry bean in order to access it in your own configuration
     attribute session-registry-alias {xsd:string}?
-concurrent-sessions.attlist &=
-    ## A reference to an external SessionRegistry implementation which will be used in place of the standard one. 
-    attribute session-registry-ref {xsd:string}?
+
 
 remember-me =
-    ## Sets up remember-me authentication. If used with the "key" attribute (or no attributes) the cookie-only implementation will be used. Specifying "token-repository-ref" or "remember-me-data-source-ref" will use the more secure, persisten token approach.     
     element remember-me {remember-me.attlist}
 remember-me.attlist &=
-    ## The "key" used to identify cookies from a specific token-based remember-me application. You should set this to a unique value for your application.
-    attribute key {xsd:string}?
-    
-remember-me.attlist &=
-    (token-repository-ref | remember-me-data-source-ref | remember-me-services-ref)
-
+    (attribute key {xsd:string} | (attribute token-repository-ref {xsd:string} | attribute data-source-ref {xsd:string}))
 remember-me.attlist &=
     user-service-ref?
-    
-remember-me.attlist &=
-    ## The period (in seconds) for which the remember-me cookie should be valid. 
-    attribute token-validity-seconds {xsd:positiveInteger}?
-    
-token-repository-ref =
-    ## Reference to a PersistentTokenRepository bean for use with the persistent token remember-me implementation. 
-    attribute token-repository-ref {xsd:string}
-remember-me-services-ref =     
-    ## Allows a custom implementation of RememberMeServices to be used. Note that this implementation should return RememberMeAuthenticationToken instances with the same "key" value as specified in the remember-me element. Alternatively it should register its own AuthenticationProvider. 
-    attribute services-ref {xsd:string}?
-remember-me-data-source-ref =
-    ## DataSource bean for the database that contains the token  
-    data-source-ref
 
 anonymous =
     ## Adds support for automatically granting all anonymous web requests a particular principal identity and a corresponding granted authority.
@@ -412,15 +384,11 @@ x509.attlist &=
     user-service-ref?
 
 authentication-manager =
-    ## If you are using namespace configuration with Spring Security, an AuthenticationManager will automatically be registered. This element allows you to define an alias to allow you to reference the authentication-manager in your own beans. 
+    ## If you are using namespace configuration with Spring Security, an AuthenticationManager will automatically be registered. This element simple allows you to define an alias to allow you to reference the authentication-manager in your own beans. 
     element authentication-manager {authman.attlist}
-authman.attlist &=
     ## The alias you wish to use for the AuthenticationManager bean
-    attribute alias {xsd:ID}
 authman.attlist &=
-    ## Allows the session controller to be set on the internal AuthenticationManager. This should not be used with the <concurrent-session-control /> element
-    attribute session-controller-ref {xsd:string}?
-
+    attribute alias {xsd:ID}
 
 authentication-provider =
     ## Indicates that the contained user-service should be used as an authentication source. 

core/src/main/resources/org/springframework/security/config/spring-security.xsl

@@ -10,7 +10,7 @@
     <xsl:output method="xml" indent="yes"/>
 
     <xsl:variable name="elts-to-inline">
-        <xsl:text>,anonymous,concurrent-session-control,filter-chain,form-login,http-basic,intercept-url,logout,password-encoder,port-mappings,port-mapper,password-compare,protect,protect-pointcut,remember-me,salt-source,x509,</xsl:text>
+        <xsl:text>,intercept-url,form-login,x509,password-encoder,http-basic,logout,concurrent-session-control,remember-me,anonymous,port-mappings,password-compare,salt-source,filter-chain,protect-pointcut,</xsl:text>
     </xsl:variable>
 
     <xsl:template match="xs:element">

core/src/main/resources/org/springframework/security/messages_pl.properties

@@ -1,53 +0,0 @@
-AuthByAdapterProvider.incorrectKey=Podana implementacja AuthByAdapter nie zawiera oczekiwanego klucza
-BasicAclEntryAfterInvocationProvider.noPermission=U\u017cytkownik {0} nie posiada \u017bADNYCH uprawnie\u0144 do obiektu {1}
-BasicAclEntryAfterInvocationProvider.insufficientPermission=U\u017cytkownik {0} nie posiada wymaganych uprawnie\u0144 do obiektu {1}
-ConcurrentSessionControllerImpl.exceededAllowed=Maksymalna liczba sesji ({0}) dla tego u\u017cytkownika zosta\u0142a przekroczona
-ProviderManager.providerNotFound=AuthenticationProvider dla {0} nie zosta\u0142 znaleziony
-AnonymousAuthenticationProvider.incorrectKey=Podany AnonymousAuthenticationToken nie zawiera oczekiwanego klucza
-CasAuthenticationProvider.incorrectKey=Podany CasAuthenticationToken nie zawiera oczekiwanego klucza
-CasAuthenticationProvider.noServiceTicket=Dostarczenie biletu serwisu CAS do walidacji nie powiod\u0142o si\u0119
-NamedCasProxyDecider.untrusted=Najbli\u017cszy serwer po\u015brednicz\u0105cy {0} jest niezaufany
-RejectProxyTickets.reject=Bilety serwera po\u015brednicz\u0105cego zosta\u0142y odrzucone
-AbstractSecurityInterceptor.authenticationNotFound=Obiekt Authentication nie zosta\u0142 odnaleziony w SecurityContext
-AbstractUserDetailsAuthenticationProvider.onlySupports=Tylko UsernamePasswordAuthenticationToken jest obs\u0142ugiwany
-AbstractUserDetailsAuthenticationProvider.locked=Konto u\u017cytkownika jest zablokowane
-AbstractUserDetailsAuthenticationProvider.disabled=Konto u\u017cytkownika jest wy\u0142\u0105czone
-AbstractUserDetailsAuthenticationProvider.expired=Wa\u017cno\u015b\u0107 konta u\u017cytkownika wygas\u0142a
-AbstractUserDetailsAuthenticationProvider.credentialsExpired=Wa\u017cno\u015b\u0107 danych uwierzytelniaj\u0105cych wygas\u0142a
-AbstractUserDetailsAuthenticationProvider.badCredentials=Niepoprawne dane uwierzytelniaj\u0105ce
-X509AuthenticationProvider.certificateNull=Certyfikat jest pusty
-DaoX509AuthoritiesPopulator.noMatching=Nie odnaleziono pasuj\u0105cego wzorca w subjectDN: {0}
-RememberMeAuthenticationProvider.incorrectKey=Podany RememberMeAuthenticationToken nie zawiera oczekiwanego klucza
-RunAsImplAuthenticationProvider.incorrectKey=Podany RunAsUserToken nie zawiera oczekiwanego klucza
-DigestProcessingFilter.missingMandatory=Brakuje wymaganej warto\u015bci skr\u00f3tu; otrzymany nag\u0142\u00f3wek {0}
-DigestProcessingFilter.missingAuth=Brakuje wymaganej warto\u015bci skr\u00f3tu dla 'auth' QOP; otrzymany nag\u0142\u00f3wek {0}
-DigestProcessingFilter.incorrectRealm=Nazwa domeny {0} w odpowiedzi nie jest zgodna z nazw\u0105 domeny {1} w systemie
-DigestProcessingFilter.nonceExpired=Wa\u017cno\u015b\u0107 kodu jednorazowego (nonce) wygas\u0142a
-DigestProcessingFilter.nonceEncoding=Kod jednorazowy (nonce) nie jest zakodowany w Base64; otrzymany kod {0}
-DigestProcessingFilter.nonceNotTwoTokens=Kod jednorazowy (nonce) powinien zawiera\u0107 dwie warto\u015bci {0}
-DigestProcessingFilter.nonceNotNumeric=Pierwsza warto\u015b\u0107 kodu jednorazowego (nonce) nie jest warto\u015bci\u0105 numeryczn\u0105: {0}
-DigestProcessingFilter.nonceCompromised=Niepoprawny kod jednorazowy (nonce) {0}
-DigestProcessingFilter.usernameNotFound=Nazwa u\u017cytkownika {0} nie zosta\u0142a odnaleziona
-DigestProcessingFilter.incorrectResponse=Niepoprawna odpowied\u017a
-JdbcDaoImpl.notFound=Nazwa u\u017cytkownika {0} nie zosta\u0142a odnaleziona
-JdbcDaoImpl.noAuthority=U\u017cytkownik {0} nie posiada \u017cadnych uprawnie\u0144 (GrantedAuthority)
-SwitchUserProcessingFilter.noCurrentUser=\u017baden aktualny u\u017cytkownik nie jest powi\u0105zany z tym zapytaniem
-SwitchUserProcessingFilter.noOriginalAuthentication=Nie mo\u017cna by\u0142o odnale\u017a\u0107 oryginalnego obiektu Authentication
-SwitchUserProcessingFilter.usernameNotFound=Nazwa u\u017cytkownika {0} nie zosta\u0142a odnaleziona
-SwitchUserProcessingFilter.locked=Konto u\u017cytkownika jest zablokowane
-SwitchUserProcessingFilter.disabled=Konto u\u017cytkownika jest wy\u0142\u0105czone
-SwitchUserProcessingFilter.expired=Wa\u017cno\u015b\u0107 konta u\u017cytkownika wygas\u0142a
-SwitchUserProcessingFilter.credentialsExpired=Wa\u017cno\u015b\u0107 danych uwierzytelniaj\u0105cych wygas\u0142a
-AbstractAccessDecisionManager.accessDenied=Dost\u0119p zabroniony
-LdapAuthenticationProvider.emptyUsername=Pusta nazwa u\u017cytkownika jest niedozwolona
-LdapAuthenticationProvider.emptyPassword=Niepoprawne dane uwierzytelniaj\u0105ce
-DefaultIntitalDirContextFactory.communicationFailure=Po\u0142\u0105czenie z serwerem LDAP nie powiod\u0142o si\u0119
-DefaultIntitalDirContextFactory.badCredentials=Niepoprawne dane uwierzytelniaj\u0105ce
-DefaultIntitalDirContextFactory.unexpectedException=Nie mo\u017cna by\u0142o uzyska\u0107 InitialDirContext z powodu nieoczekiwanego wyj\u0105tku
-PasswordComparisonAuthenticator.badCredentials=Niepoprawne dane uwierzytelniaj\u0105ce
-BindAuthenticator.badCredentials=Niepoprawne dane uwierzytelniaj\u0105ce
-BindAuthenticator.failedToLoadAttributes=Niepoprawne dane uwierzytelniaj\u0105ce
-UserDetailsService.locked=Konto u\u017cytkownika jest zablokowane
-UserDetailsService.disabled=Konto u\u017cytkownika jest wy\u0142\u0105czone
-UserDetailsService.expired=Wa\u017cno\u015b\u0107 konta u\u017cytkownika wygas\u0142a
-UserDetailsService.credentialsExpired=Wa\u017cno\u015b\u0107 danych uwierzytelniaj\u0105cych wygas\u0142a

core/src/test/java/org/springframework/security/authoritymapping/SimpleRoles2GrantedAuthoritiesMapperTests.java

@@ -65,7 +65,7 @@ public class SimpleRoles2GrantedAuthoritiesMapperTests extends TestCase {
 		String[] expectedGas = { "ROLE_Role1", "ROLE_Role2", "ROLE_ROLE_Role3" };
 		SimpleAttributes2GrantedAuthoritiesMapper mapper = getDefaultMapper();
 		mapper.setAddPrefixIfAlreadyExisting(true);
-		mapper.setAttributePrefix("ROLE_");
+		mapper.seAttributePrefix("ROLE_");
 		testGetGrantedAuthorities(mapper, roles, expectedGas);
 	}
 
@@ -74,7 +74,7 @@ public class SimpleRoles2GrantedAuthoritiesMapperTests extends TestCase {
 		String[] expectedGas = { "ROLE_Role1", "ROLE_Role2", "ROLE_Role3" };
 		SimpleAttributes2GrantedAuthoritiesMapper mapper = getDefaultMapper();
 		mapper.setAddPrefixIfAlreadyExisting(false);
-		mapper.setAttributePrefix("ROLE_");
+		mapper.seAttributePrefix("ROLE_");
 		testGetGrantedAuthorities(mapper, roles, expectedGas);
 	}
 
@@ -83,7 +83,7 @@ public class SimpleRoles2GrantedAuthoritiesMapperTests extends TestCase {
 		String[] expectedGas = { "ROLE_Role1", "ROLE_Role2", "ROLE_role_Role3" };
 		SimpleAttributes2GrantedAuthoritiesMapper mapper = getDefaultMapper();
 		mapper.setAddPrefixIfAlreadyExisting(false);
-		mapper.setAttributePrefix("ROLE_");
+		mapper.seAttributePrefix("ROLE_");
 		testGetGrantedAuthorities(mapper, roles, expectedGas);
 	}
 
@@ -93,7 +93,7 @@ public class SimpleRoles2GrantedAuthoritiesMapperTests extends TestCase {
 		SimpleAttributes2GrantedAuthoritiesMapper mapper = getDefaultMapper();
 		mapper.setAddPrefixIfAlreadyExisting(false);
 		mapper.setConvertAttributeToUpperCase(true);
-		mapper.setAttributePrefix("ROLE_");
+		mapper.seAttributePrefix("ROLE_");
 		testGetGrantedAuthorities(mapper, roles, expectedGas);
 	}
 
@@ -111,7 +111,7 @@ public class SimpleRoles2GrantedAuthoritiesMapperTests extends TestCase {
 
 	private SimpleAttributes2GrantedAuthoritiesMapper getDefaultMapper() {
 		SimpleAttributes2GrantedAuthoritiesMapper mapper = new SimpleAttributes2GrantedAuthoritiesMapper();
-		mapper.setAttributePrefix("");
+		mapper.seAttributePrefix("");
 		mapper.setConvertAttributeToLowerCase(false);
 		mapper.setConvertAttributeToUpperCase(false);
 		mapper.setAddPrefixIfAlreadyExisting(false);

core/src/test/java/org/springframework/security/config/AuthenticationProviderBeanDefinitionParserTests.java

@@ -1,12 +1,8 @@
 package org.springframework.security.config;
 
-import static org.junit.Assert.*;
-
 import org.springframework.security.providers.ProviderManager;
 import org.springframework.security.providers.UsernamePasswordAuthenticationToken;
 import org.springframework.security.providers.AuthenticationProvider;
-import org.springframework.security.providers.encoding.ShaPasswordEncoder;
-import org.springframework.security.util.FieldUtils;
 import org.springframework.security.util.InMemoryXmlApplicationContext;
 import org.springframework.context.support.AbstractXmlApplicationContext;
 
@@ -75,19 +71,6 @@ public class AuthenticationProviderBeanDefinitionParserTests {
         getProvider().authenticate(bob);
     }
 
-    @Test
-    public void providerWithSha256PasswordEncoderIsSupported() throws Exception {
-        setContext(" <authentication-provider>" +
-                "        <password-encoder hash='sha-256'/>" +
-                "        <user-service>" +
-                "            <user name='bob' password='notused' authorities='ROLE_A' />" +
-                "        </user-service>" +
-                "    </authentication-provider>");
-
-        ShaPasswordEncoder encoder = (ShaPasswordEncoder) FieldUtils.getFieldValue(getProvider(), "passwordEncoder");
-        assertEquals("SHA-256", encoder.getAlgorithm());
-    }
-    
     @Test
     public void passwordIsBase64EncodedWhenBase64IsEnabled() throws Exception {
         setContext(" <authentication-provider>" +
@@ -98,7 +81,7 @@ public class AuthenticationProviderBeanDefinitionParserTests {
                 "    </authentication-provider>");
 
         getProvider().authenticate(bob);
-    }
+    }    
     
     @Test
     public void externalUserServiceAndPasswordEncoderWork() throws Exception {

core/src/test/java/org/springframework/security/config/CustomAfterInvocationProviderBeanDefinitionDecoratorTests.java

@@ -21,7 +21,7 @@ public class CustomAfterInvocationProviderBeanDefinitionDecoratorTests {
     }
     
     @Test
-    public void customAfterInvocationProviderIsAddedToInterceptor() {
+    public void customAuthenticationProviderIsAddedToInterceptor() {
         setContext(
                 "<global-method-security />" +
                 "<b:bean id='aip' class='org.springframework.security.config.MockAfterInvocationProvider'>" +

core/src/test/java/org/springframework/security/config/CustomAuthenticationProviderBeanDefinitionDecoratorTests.java

@@ -1,44 +1,21 @@
 package org.springframework.security.config;
 
-import static org.junit.Assert.*;
-
 import org.junit.Test;
-import org.springframework.security.providers.ProviderManager;
 import org.springframework.security.util.InMemoryXmlApplicationContext;
 
 
 public class CustomAuthenticationProviderBeanDefinitionDecoratorTests {
-
+    
     @Test
-    public void decoratedProviderParsesSuccessfully() {
+    public void decoratorParsesSuccessfully() {
         InMemoryXmlApplicationContext ctx = new InMemoryXmlApplicationContext(
-                "<b:bean class='org.springframework.security.providers.dao.DaoAuthenticationProvider'>" +
-                "  <custom-authentication-provider />" +
-                "  <b:property name='userDetailsService' ref='us'/>" +
-                "</b:bean>" + 
-                "<user-service id='us'>" +
-                " <user name='bob' password='bobspassword' authorities='ROLE_A,ROLE_B' />" +
-                "</user-service>"
+                "<b:bean id='someBean' class='org.springframework.security.config.TestBusinessBeanImpl'>" +
+                "   <intercept-methods>" +
+                "       <protect method='org.springframework.security.config.TestBusinessBean.*' access='ROLE_A' />" +
+                "   </intercept-methods>" +
+                "</b:bean>" + HttpSecurityBeanDefinitionParserTests.AUTH_PROVIDER_XML
         );
-        ProviderManager authMgr = (ProviderManager) ctx.getBean(BeanIds.AUTHENTICATION_MANAGER);
-        assertEquals(1, authMgr.getProviders().size());        
-    }
-	
-	
-    @Test
-    public void decoratedBeanAndRegisteredProviderAreTheSameObject() {
-        InMemoryXmlApplicationContext ctx = new InMemoryXmlApplicationContext(
-                "<b:bean id='myProvider' class='org.springframework.security.providers.dao.DaoAuthenticationProvider'>" +
-                "  <custom-authentication-provider />" +
-                "  <b:property name='userDetailsService' ref='us'/>" +
-                "</b:bean>" + 
-                "<user-service id='us'>" +
-                " <user name='bob' password='bobspassword' authorities='ROLE_A,ROLE_B' />" +
-                "</user-service>"
-        );
-
-        ProviderManager authMgr = (ProviderManager) ctx.getBean(BeanIds.AUTHENTICATION_MANAGER);
-        assertEquals(1, authMgr.getProviders().size());
-        assertSame(ctx.getBean("myProvider"), authMgr.getProviders().get(0));
+        
+        ctx.getBean("someBean");
     }
 }

core/src/test/java/org/springframework/security/config/HttpSecurityBeanDefinitionParserTests.java

@@ -9,7 +9,6 @@ import java.util.List;
 import org.junit.After;
 import org.junit.Test;
 import org.springframework.beans.factory.BeanCreationException;
-import org.springframework.beans.factory.BeanDefinitionStoreException;
 import org.springframework.beans.factory.parsing.BeanDefinitionParsingException;
 import org.springframework.context.support.AbstractXmlApplicationContext;
 import org.springframework.mock.web.MockHttpServletRequest;
@@ -57,7 +56,7 @@ public class HttpSecurityBeanDefinitionParserTests {
     private AbstractXmlApplicationContext appContext;
     static final String AUTH_PROVIDER_XML =
             "    <authentication-provider>" +
-            "        <user-service id='us'>" +
+            "        <user-service>" +
             "            <user name='bob' password='bobspassword' authorities='ROLE_A,ROLE_B' />" +
             "            <user name='bill' password='billspassword' authorities='ROLE_A,ROLE_B,AUTH_OTHER' />" +
             "        </user-service>" +
@@ -83,7 +82,6 @@ public class HttpSecurityBeanDefinitionParserTests {
         List filterList = getFilters("/anyurl");
 
         checkAutoConfigFilters(filterList);
-        assertEquals(true, FieldUtils.getFieldValue(filterList.get(10), "objectDefinitionSource.stripQueryStringFromUrls"));
     }
 
     @Test(expected=BeanDefinitionParsingException.class)
@@ -96,7 +94,8 @@ public class HttpSecurityBeanDefinitionParserTests {
 
         Iterator filters = filterList.iterator();
 
-        assertTrue(filters.next() instanceof HttpSessionContextIntegrationFilter);     
+        assertTrue(filters.next() instanceof HttpSessionContextIntegrationFilter);
+        assertTrue(filters.next() instanceof SessionFixationProtectionFilter);        
         assertTrue(filters.next() instanceof LogoutFilter);
         Object authProcFilter = filters.next();
         assertTrue(authProcFilter instanceof AuthenticationProcessingFilter);
@@ -111,7 +110,6 @@ public class HttpSecurityBeanDefinitionParserTests {
         assertTrue(filters.next() instanceof RememberMeProcessingFilter);
         assertTrue(filters.next() instanceof AnonymousProcessingFilter);
         assertTrue(filters.next() instanceof ExceptionTranslationFilter);
-        assertTrue(filters.next() instanceof SessionFixationProtectionFilter);           
         Object fsiObj = filters.next();
         assertTrue(fsiObj instanceof FilterSecurityInterceptor);
         FilterSecurityInterceptor fsi = (FilterSecurityInterceptor) fsiObj;
@@ -138,9 +136,7 @@ public class HttpSecurityBeanDefinitionParserTests {
                 "    </http>" + AUTH_PROVIDER_XML);
         assertEquals(0, getFilters("/imlowercase").size());
         // This will be matched by the default pattern ".*"
-        List allFilters = getFilters("/ImCaughtByTheUniversalMatchPattern");
-        checkAutoConfigFilters(allFilters);
-        assertEquals(false, FieldUtils.getFieldValue(allFilters.get(10), "objectDefinitionSource.stripQueryStringFromUrls"));
+        checkAutoConfigFilters(getFilters("/ImCaughtByTheUniversalMatchPattern"));
     }
 
     @Test
@@ -173,12 +169,12 @@ public class HttpSecurityBeanDefinitionParserTests {
                 "   <form-login default-target-url='/default' always-use-default-target='true' />" +
                 "</http>" + AUTH_PROVIDER_XML);
         // These will be matched by the default pattern "/**"
-        AuthenticationProcessingFilter filter = (AuthenticationProcessingFilter) getFilters("/anything").get(1);
+        AuthenticationProcessingFilter filter = (AuthenticationProcessingFilter) getFilters("/anything").get(2);
         assertEquals("/default", filter.getDefaultTargetUrl());
         assertEquals(Boolean.TRUE, FieldUtils.getFieldValue(filter, "alwaysUseDefaultTargetUrl"));
     }
 
-    @Test(expected=BeanCreationException.class)
+    @Test(expected=BeanDefinitionParsingException.class)
     public void invalidLoginPageIsDetected() throws Exception {
         setContext(
                 "<http>" +
@@ -186,7 +182,7 @@ public class HttpSecurityBeanDefinitionParserTests {
                 "</http>" + AUTH_PROVIDER_XML);
     }    
     
-    @Test(expected=BeanCreationException.class)
+    @Test(expected=BeanDefinitionParsingException.class)
     public void invalidDefaultTargetUrlIsDetected() throws Exception {
         setContext(
                 "<http>" +
@@ -194,7 +190,7 @@ public class HttpSecurityBeanDefinitionParserTests {
                 "</http>" + AUTH_PROVIDER_XML);
     }    
 
-    @Test(expected=BeanCreationException.class)
+    @Test(expected=BeanDefinitionParsingException.class)
     public void invalidLogoutUrlIsDetected() throws Exception {
         setContext(
                 "<http>" +
@@ -203,7 +199,7 @@ public class HttpSecurityBeanDefinitionParserTests {
                 "</http>" + AUTH_PROVIDER_XML);
     }    
     
-    @Test(expected=BeanCreationException.class)
+    @Test(expected=BeanDefinitionParsingException.class)
     public void invalidLogoutSuccessUrlIsDetected() throws Exception {
         setContext(
                 "<http>" +
@@ -264,12 +260,12 @@ public class HttpSecurityBeanDefinitionParserTests {
         setContext("<http access-denied-page='/access-denied'><http-basic /></http>" + AUTH_PROVIDER_XML);
         List filters = getFilters("/someurl");
         
-        ExceptionTranslationFilter etf = (ExceptionTranslationFilter) filters.get(filters.size() - 3);
+        ExceptionTranslationFilter etf = (ExceptionTranslationFilter) filters.get(filters.size() - 2);
         
         assertEquals("/access-denied", FieldUtils.getFieldValue(etf, "accessDeniedHandler.errorPage"));
     }
     
-    @Test(expected=BeanDefinitionStoreException.class)
+    @Test(expected=BeanDefinitionParsingException.class)
     public void invalidAccessDeniedUrlIsDetected() throws Exception {
         setContext("<http auto-config='true' access-denied-page='noLeadingSlash'/>" + AUTH_PROVIDER_XML);
     }    
@@ -324,7 +320,7 @@ public class HttpSecurityBeanDefinitionParserTests {
         assertEquals(14, filters.size());
         assertTrue(filters.get(0) instanceof MockFilter);        
         assertTrue(filters.get(1) instanceof SecurityContextHolderAwareRequestFilter);
-        assertTrue(filters.get(4) instanceof SecurityContextHolderAwareRequestFilter);
+        assertTrue(filters.get(5) instanceof SecurityContextHolderAwareRequestFilter);
     }
     
     @Test(expected=BeanCreationException.class)
@@ -340,65 +336,23 @@ public class HttpSecurityBeanDefinitionParserTests {
     public void rememberMeServiceWorksWithTokenRepoRef() {
         setContext(
                 "<http auto-config='true'>" +
-                "    <remember-me token-repository-ref='tokenRepo'/>" +
+                "    <remember-me key='doesntmatter' token-repository-ref='tokenRepo'/>" +
                 "</http>" +
                 "<b:bean id='tokenRepo' " +
                         "class='org.springframework.security.ui.rememberme.InMemoryTokenRepositoryImpl'/> " + AUTH_PROVIDER_XML);
         Object rememberMeServices = appContext.getBean(BeanIds.REMEMBER_ME_SERVICES);
-        
+
         assertTrue(rememberMeServices instanceof PersistentTokenBasedRememberMeServices);
     }
 
-    @Test
-    public void rememberMeServiceWorksWithDataSourceRef() {
-        setContext(
-                "<http auto-config='true'>" +
-                "    <remember-me data-source-ref='ds'/>" +
-                "</http>" +
-                "<b:bean id='ds' class='org.springframework.security.TestDataSource'> " +
-                "    <b:constructor-arg value='tokendb'/>" +
-                "</b:bean>" + AUTH_PROVIDER_XML);
-        Object rememberMeServices = appContext.getBean(BeanIds.REMEMBER_ME_SERVICES);
-        
-        assertTrue(rememberMeServices instanceof PersistentTokenBasedRememberMeServices);
-    }    
-    
-    
-    @Test
-    public void rememberMeServiceWorksWithExternalServicesImpl() throws Exception {
-        setContext(
-                "<http auto-config='true'>" +
-                "    <remember-me key='ourkey' services-ref='rms'/>" +
-                "</http>" +
-                "<b:bean id='rms' class='org.springframework.security.ui.rememberme.TokenBasedRememberMeServices'> " +
-                "    <b:property name='userDetailsService' ref='us'/>" +
-                "    <b:property name='key' value='ourkey'/>" +
-                "    <b:property name='tokenValiditySeconds' value='5000'/>" +
-                "</b:bean>" +
-                AUTH_PROVIDER_XML);
-        
-        assertEquals(5000, FieldUtils.getFieldValue(appContext.getBean(BeanIds.REMEMBER_ME_SERVICES), 
-        		"tokenValiditySeconds"));        
-    }
-
-    @Test
-    public void rememberMeTokenValidityIsParsedCorrectly() throws Exception {
-        setContext(
-                "<http auto-config='true'>" +
-                "    <remember-me key='ourkey' token-validity-seconds='10000' />" +
-                "</http>" + AUTH_PROVIDER_XML);
-        assertEquals(10000, FieldUtils.getFieldValue(appContext.getBean(BeanIds.REMEMBER_ME_SERVICES), 
-				"tokenValiditySeconds"));
-    }    
-    
     @Test
     public void rememberMeServiceConfigurationParsesWithCustomUserService() {
         setContext(
                 "<http auto-config='true'>" +
-                "    <remember-me key='somekey' user-service-ref='userService'/>" +
+                "    <remember-me key='doesntmatter' user-service-ref='userService'/>" +
                 "</http>" +
-                "<b:bean id='userService' class='org.springframework.security.userdetails.MockUserDetailsService'/> " +
-                AUTH_PROVIDER_XML);
+                "<b:bean id='userService' " +
+                        "class='org.springframework.security.userdetails.MockUserDetailsService'/> " + AUTH_PROVIDER_XML);
 //        AbstractRememberMeServices rememberMeServices = (AbstractRememberMeServices) appContext.getBean(BeanIds.REMEMBER_ME_SERVICES);
     }    
     
@@ -410,7 +364,7 @@ public class HttpSecurityBeanDefinitionParserTests {
                 "</http>"  + AUTH_PROVIDER_XML);
         List filters = getFilters("/someurl");
 
-        assertTrue(filters.get(2) instanceof X509PreAuthenticatedProcessingFilter);
+        assertTrue(filters.get(3) instanceof X509PreAuthenticatedProcessingFilter);
     }
 
     @Test
@@ -418,7 +372,7 @@ public class HttpSecurityBeanDefinitionParserTests {
         setContext(
                 "<http auto-config='true'>" +
                 "    <concurrent-session-control session-registry-alias='seshRegistry' expired-url='/expired'/>" +
-                "</http>" + AUTH_PROVIDER_XML);
+                "</http>"  + AUTH_PROVIDER_XML);
         List filters = getFilters("/someurl");
         
         assertTrue(filters.get(0) instanceof ConcurrentSessionFilter);        
@@ -426,55 +380,6 @@ public class HttpSecurityBeanDefinitionParserTests {
         assertNotNull(appContext.getBean(BeanIds.CONCURRENT_SESSION_CONTROLLER));
     }    
 
-    @Test
-    public void externalSessionRegistryBeanIsConfiguredCorrectly() throws Exception {
-        setContext(
-                "<http auto-config='true'>" +
-                "    <concurrent-session-control session-registry-ref='seshRegistry' />" +
-                "</http>" +
-                "<b:bean id='seshRegistry' class='org.springframework.security.concurrent.SessionRegistryImpl'/>" +
-                AUTH_PROVIDER_XML);
-        Object sessionRegistry = appContext.getBean("seshRegistry");
-        Object sessionRegistryFromFilter = FieldUtils.getFieldValue(
-        		appContext.getBean(BeanIds.CONCURRENT_SESSION_FILTER),"sessionRegistry");
-        Object sessionRegistryFromController = FieldUtils.getFieldValue(
-        		appContext.getBean(BeanIds.CONCURRENT_SESSION_CONTROLLER),"sessionRegistry");
-        Object sessionRegistryFromFixationFilter = FieldUtils.getFieldValue(
-        		appContext.getBean(BeanIds.SESSION_FIXATION_PROTECTION_FILTER),"sessionRegistry");
-        
-        assertSame(sessionRegistry, sessionRegistryFromFilter);
-        assertSame(sessionRegistry, sessionRegistryFromController);
-        assertSame(sessionRegistry, sessionRegistryFromFixationFilter);
-    }
-
-    @Test(expected=BeanDefinitionParsingException.class)
-    public void concurrentSessionSupportCantBeUsedWithIndependentControllerBean() throws Exception {
-        setContext(
-                "<authentication-manager alias='authManager' session-controller-ref='sc'/>" +
-                "<http auto-config='true'>" +
-                "    <concurrent-session-control session-registry-alias='seshRegistry' expired-url='/expired'/>" +
-                "</http>" +
-                "<b:bean id='sc' class='org.springframework.security.concurrent.ConcurrentSessionControllerImpl'>" +
-                "  <b:property name='sessionRegistry'>" +
-                "    <b:bean class='org.springframework.security.concurrent.SessionRegistryImpl'/>" +
-                "  </b:property>" +
-                "</b:bean>" + AUTH_PROVIDER_XML);
-    }
-
-    @Test(expected=BeanDefinitionParsingException.class)
-    public void concurrentSessionSupportCantBeUsedWithIndependentControllerBean2() throws Exception {
-        setContext(
-                "<http auto-config='true'>" +
-                "    <concurrent-session-control session-registry-alias='seshRegistry' expired-url='/expired'/>" +
-                "</http>" +
-                "<b:bean id='sc' class='org.springframework.security.concurrent.ConcurrentSessionControllerImpl'>" +
-                "  <b:property name='sessionRegistry'>" +
-                "    <b:bean class='org.springframework.security.concurrent.SessionRegistryImpl'/>" +
-                "  </b:property>" +
-                "</b:bean>" +
-                "<authentication-manager alias='authManager' session-controller-ref='sc'/>" + AUTH_PROVIDER_XML);
-    }    
-    
     @Test(expected=ConcurrentLoginException.class)
     public void concurrentSessionMaxSessionsIsCorrectlyConfigured() throws Exception {
         setContext(
@@ -513,7 +418,7 @@ public class HttpSecurityBeanDefinitionParserTests {
                 "<b:bean id='entryPoint' class='org.springframework.security.MockAuthenticationEntryPoint'>" +
                 "    <b:constructor-arg value='/customlogin'/>" +
                 "</b:bean>" + AUTH_PROVIDER_XML);
-        ExceptionTranslationFilter etf = (ExceptionTranslationFilter) getFilters("/someurl").get(8);
+        ExceptionTranslationFilter etf = (ExceptionTranslationFilter) getFilters("/someurl").get(9);
         assertTrue("ExceptionTranslationFilter should be configured with custom entry point", 
                 etf.getAuthenticationEntryPoint() instanceof MockAuthenticationEntryPoint);
     }
@@ -600,22 +505,7 @@ public class HttpSecurityBeanDefinitionParserTests {
                 "        <form-login login-page='/login.jsp' default-target-url='/messageList.html'/>" +
                 "    </http>" + AUTH_PROVIDER_XML);
     }
-
-    @Test
-    public void settingCreateSessionToAlwaysSetsFilterPropertiesCorrectly() throws Exception {
-        // Protected, no anonymous filter configured.
-        setContext("<http auto-config='true' create-session='always'/>" + AUTH_PROVIDER_XML);
-        assertEquals(Boolean.TRUE, FieldUtils.getFieldValue(appContext.getBean(BeanIds.HTTP_SESSION_CONTEXT_INTEGRATION_FILTER), "forceEagerSessionCreation"));
-        assertEquals(Boolean.TRUE, FieldUtils.getFieldValue(appContext.getBean(BeanIds.HTTP_SESSION_CONTEXT_INTEGRATION_FILTER), "allowSessionCreation"));        
-    }    
-
-    @Test
-    public void settingCreateSessionToNeverSetsFilterPropertiesCorrectly() throws Exception {
-        // Protected, no anonymous filter configured.
-        setContext("<http auto-config='true' create-session='never'/>" + AUTH_PROVIDER_XML);
-        assertEquals(Boolean.FALSE, FieldUtils.getFieldValue(appContext.getBean(BeanIds.HTTP_SESSION_CONTEXT_INTEGRATION_FILTER), "forceEagerSessionCreation"));
-        assertEquals(Boolean.FALSE, FieldUtils.getFieldValue(appContext.getBean(BeanIds.HTTP_SESSION_CONTEXT_INTEGRATION_FILTER), "allowSessionCreation"));        
-    }    
+    
     
     private void setContext(String context) {
         appContext = new InMemoryXmlApplicationContext(context);

core/src/test/java/org/springframework/security/config/LdapProviderBeanDefinitionParserTests.java

@@ -38,8 +38,8 @@ public class LdapProviderBeanDefinitionParserTests {
         Authentication auth = provider.authenticate(new UsernamePasswordAuthenticationToken("ben", "benspassword"));
         LdapUserDetailsImpl ben = (LdapUserDetailsImpl) auth.getPrincipal();
 
-        assertEquals(3, ben.getAuthorities().length);
-    }
+        assertEquals(2, ben.getAuthorities().length);
+    }  
     
     @Test(expected = SecurityConfigurationException.class)
     public void missingServerEltCausesConfigException() {

core/src/test/java/org/springframework/security/config/LdapUserServiceBeanDefinitionParserTests.java

@@ -42,7 +42,7 @@ public class LdapUserServiceBeanDefinitionParserTests {
         UserDetails ben = uds.loadUserByUsername("ben");
 
         Set authorities = AuthorityUtils.authorityArrayToSet(ben.getAuthorities());
-        assertEquals(3, authorities.size());
+        assertEquals(2, authorities.size());
         assertTrue(authorities.contains("ROLE_DEVELOPERS"));
     }
 
@@ -88,7 +88,7 @@ public class LdapUserServiceBeanDefinitionParserTests {
         UserDetails ben = uds.loadUserByUsername("ben");
 
         Set authorities = AuthorityUtils.authorityArrayToSet(ben.getAuthorities());
-        assertEquals(3, authorities.size());
+        assertEquals(2, authorities.size());
         assertTrue(authorities.contains(new GrantedAuthorityImpl("ROLE_DEVELOPER")));
         
     }

core/src/test/java/org/springframework/security/config/SessionRegistryInjectionBeanPostProcessorTests.java

@@ -1,66 +0,0 @@
-package org.springframework.security.config;
-
-import static org.junit.Assert.*;
-
-import org.junit.After;
-import org.junit.Test;
-import org.springframework.context.support.AbstractXmlApplicationContext;
-import org.springframework.security.Authentication;
-import org.springframework.security.AuthenticationException;
-import org.springframework.security.concurrent.ConcurrentSessionController;
-import org.springframework.security.util.FieldUtils;
-import org.springframework.security.util.InMemoryXmlApplicationContext;
-
-/**
- * 
- * @author Luke Taylor
- */
-public class SessionRegistryInjectionBeanPostProcessorTests {
-    private AbstractXmlApplicationContext appContext;
-    
-    @After
-    public void closeAppContext() {
-        if (appContext != null) {
-            appContext.close();
-            appContext = null;
-        }
-    }
-
-    private void setContext(String context) {
-        appContext = new InMemoryXmlApplicationContext(context);
-    }
-
-    @Test
-    public void sessionRegistryIsSetOnFiltersWhenUsingCustomControllerWithInternalRegistryBean() throws Exception {
-        setContext(
-                "<http auto-config='true'/>" +
-                "<b:bean id='sc' class='org.springframework.security.concurrent.ConcurrentSessionControllerImpl'>" +
-                "  <b:property name='sessionRegistry'>" +
-                "    <b:bean class='org.springframework.security.concurrent.SessionRegistryImpl'/>" +
-                "  </b:property>" +
-                "</b:bean>" +
-                "<authentication-manager alias='authManager' session-controller-ref='sc'/>" + 
-                HttpSecurityBeanDefinitionParserTests.AUTH_PROVIDER_XML);
-    	assertNotNull(FieldUtils.getFieldValue(appContext.getBean(BeanIds.SESSION_FIXATION_PROTECTION_FILTER), "sessionRegistry"));
-    	assertNotNull(FieldUtils.getFieldValue(appContext.getBean(BeanIds.FORM_LOGIN_FILTER), "sessionRegistry"));    	
-    }
-    
-    @Test
-    public void sessionRegistryIsSetOnFiltersWhenUsingCustomControllerWithNonStandardController() throws Exception {
-        setContext(
-                "<http auto-config='true'/>" +
-                "<b:bean id='sc' class='org.springframework.security.config.SessionRegistryInjectionBeanPostProcessorTests$MockConcurrentSessionController'/>" +
-                "<b:bean id='sessionRegistry' class='org.springframework.security.concurrent.SessionRegistryImpl'/>" +
-                "<authentication-manager alias='authManager' session-controller-ref='sc'/>" + 
-                HttpSecurityBeanDefinitionParserTests.AUTH_PROVIDER_XML);
-    	assertNotNull(FieldUtils.getFieldValue(appContext.getBean(BeanIds.SESSION_FIXATION_PROTECTION_FILTER), "sessionRegistry"));
-    	assertNotNull(FieldUtils.getFieldValue(appContext.getBean(BeanIds.FORM_LOGIN_FILTER), "sessionRegistry"));    	
-    }
-    
-    public static class MockConcurrentSessionController implements ConcurrentSessionController {
-		public void checkAuthenticationAllowed(Authentication request) throws AuthenticationException {
-		}
-		public void registerSuccessfulAuthentication(Authentication authentication) {
-		}    	
-    }
-}

core/src/test/java/org/springframework/security/ldap/SpringSecurityLdapTemplateTests.java

@@ -17,19 +17,13 @@ package org.springframework.security.ldap;
 
 import org.springframework.ldap.UncategorizedLdapException;
 import org.springframework.ldap.core.ContextExecutor;
-import org.springframework.ldap.core.DirContextOperations;
-import org.springframework.ldap.core.DistinguishedName;
-import org.springframework.ldap.core.LdapEncoder;
 import org.junit.Test;
 import static org.junit.Assert.*;
 
 import java.util.Set;
 
-import javax.naming.Context;
 import javax.naming.NamingException;
 import javax.naming.directory.DirContext;
-import javax.naming.directory.SearchControls;
-import javax.naming.ldap.LdapName;
 
 /**
  * @author Luke Taylor
@@ -49,22 +43,22 @@ public class SpringSecurityLdapTemplateTests extends AbstractLdapIntegrationTest
     }
 
     @Test
-    public void compareOfCorrectValueSucceeds() {
+    public void testCompareOfCorrectValueSucceeds() {
         assertTrue(template.compare("uid=bob,ou=people", "uid", "bob"));
     }
 
     @Test
-    public void compareOfCorrectByteValueSucceeds() {
+    public void testCompareOfCorrectByteValueSucceeds() {
         assertTrue(template.compare("uid=bob,ou=people", "userPassword", LdapUtils.getUtf8Bytes("bobspassword")));
     }
 
     @Test
-    public void compareOfWrongByteValueFails() {
+    public void testCompareOfWrongByteValueFails() {
         assertFalse(template.compare("uid=bob,ou=people", "userPassword", LdapUtils.getUtf8Bytes("wrongvalue")));
     }
 
     @Test
-    public void compareOfWrongValueFails() {
+    public void testCompareOfWrongValueFails() {
         assertFalse(template.compare("uid=bob,ou=people", "uid", "wrongvalue"));
     }
 
@@ -79,7 +73,7 @@ public class SpringSecurityLdapTemplateTests extends AbstractLdapIntegrationTest
 //    }
 
     @Test
-    public void namingExceptionIsTranslatedCorrectly() {
+    public void testNamingExceptionIsTranslatedCorrectly() {
         try {
             template.executeReadOnly(new ContextExecutor() {
                     public Object executeWithContext(DirContext dirContext) throws NamingException {
@@ -91,7 +85,7 @@ public class SpringSecurityLdapTemplateTests extends AbstractLdapIntegrationTest
     }
 
     @Test
-    public void roleSearchReturnsCorrectNumberOfRoles() {
+    public void testRoleSearchReturnsCorrectNumberOfRoles() {
         String param = "uid=ben,ou=people,dc=springframework,dc=org";
 
         Set values = template.searchForSingleAttributeValues("ou=groups", "(member={0})", new String[] {param}, "ou");
@@ -110,44 +104,4 @@ public class SpringSecurityLdapTemplateTests extends AbstractLdapIntegrationTest
 
         assertEquals(0, values.size());
     }
-
-    @Test
-    public void roleSearchWithEscapedCharacterSucceeds() throws Exception {
-    	String param = "cn=mouse\\, jerry,ou=people,dc=springframework,dc=org";
-    	
-        Set values = template.searchForSingleAttributeValues("ou=groups", "(member={0})", new String[] {param}, "cn");
-
-        assertEquals(1, values.size());
-    }
-    
-    @Test
-    public void nonSpringLdapSearchCodeTestMethod() throws Exception {
-    	java.util.Hashtable env = new java.util.Hashtable();
-    	env.put(Context.INITIAL_CONTEXT_FACTORY, "com.sun.jndi.ldap.LdapCtxFactory");
-    	env.put(Context.PROVIDER_URL, "ldap://localhost:53389");
-    	env.put(Context.SECURITY_PRINCIPAL, "");
-    	env.put(Context.SECURITY_CREDENTIALS, "");
-
-    	DirContext ctx = new javax.naming.directory.InitialDirContext(env);
-    	SearchControls controls = new SearchControls();
-    	controls.setSearchScope(SearchControls.SUBTREE_SCOPE);
-    	controls.setReturningObjFlag(true);
-    	controls.setReturningAttributes(null);
-    	String param = "cn=mouse\\, jerry,ou=people,dc=springframework,dc=org";   	
-    	
-    	javax.naming.NamingEnumeration results = 
-    		ctx.search("ou=groups,dc=springframework,dc=org", 
-    				"(member={0})", new String[] {param}, 
-    				controls);
-    	
-    	assertTrue("Expected a result", results.hasMore());    	
-    }
-
-    @Test
-    public void searchForSingleEntryWithEscapedCharsInDnSucceeds() {
-        String param = "mouse, jerry";
-
-        DirContextOperations jerry = template.searchForSingleEntry("ou=people", "(cn={0})", new String[] {param});
-    }
-    
 }

core/src/test/java/org/springframework/security/ldap/populator/DefaultLdapAuthoritiesPopulatorTests.java

@@ -131,18 +131,4 @@ public class DefaultLdapAuthoritiesPopulatorTests extends AbstractLdapIntegratio
         assertTrue(roles.contains("ROLE_SUBMANAGER"));
     }
 
-    @Test
-    public void testUserDnWithEscapedCharacterParameterReturnsExpectedRoles() {
-        populator.setGroupRoleAttribute("ou");
-        populator.setConvertToUpperCase(true);        
-        populator.setGroupSearchFilter("(member={0})");
-
-        DirContextAdapter ctx = new DirContextAdapter(new DistinguishedName("cn=mouse\\, jerry,ou=people,dc=springframework,dc=org"));
-
-        GrantedAuthority[] authorities = populator.getGrantedAuthorities(ctx, "notused");
-
-        assertEquals("Should have 1 role", 1, authorities.length);
-        assertEquals("ROLE_MANAGER", authorities[0].getAuthority());
-    }    
-    
 }

core/src/test/java/org/springframework/security/ldap/search/FilterBasedLdapUserSearchTests.java

@@ -60,7 +60,7 @@ public class FilterBasedLdapUserSearchTests extends AbstractLdapIntegrationTests
     @Test
     public void extraFilterPartToExcludeBob() throws Exception {
         FilterBasedLdapUserSearch locator = new FilterBasedLdapUserSearch("ou=people",
-                "(&(cn=*)(!(|(uid={0})(uid=rod)(uid=jerry))))", dirCtxFactory);
+                "(&(cn=*)(!(|(uid={0})(uid=rod))))", dirCtxFactory);
 
         // Search for bob, get back ben...
         DirContextOperations ben = locator.searchForUser("bob");

core/src/test/java/org/springframework/security/providers/jaas/Sec760Tests.java

@@ -1,64 +0,0 @@
-package org.springframework.security.providers.jaas;
-
-import java.net.URL;
-import java.security.Security;
-
-import javax.security.auth.login.LoginContext;
-
-import junit.framework.Assert;
-
-import org.junit.Test;
-import org.springframework.core.io.ClassPathResource;
-import org.springframework.security.Authentication;
-import org.springframework.security.GrantedAuthority;
-import org.springframework.security.GrantedAuthorityImpl;
-import org.springframework.security.providers.UsernamePasswordAuthenticationToken;
-
-/**
- * Tests bug reported in SEC-760.
- * 
- * @author Ben Alex
- *
- */
-public class Sec760Tests {
-
-	public String resolveConfigFile(String filename) {
-        String resName = "/" + getClass().getPackage().getName().replace('.', '/') + filename;
-        return resName;
-	}
-	
-	private void testConfigureJaasCase(JaasAuthenticationProvider p1, JaasAuthenticationProvider p2) throws Exception {
-		p1.setLoginConfig(new ClassPathResource(resolveConfigFile("/test1.conf")));
-		p1.setLoginContextName("test1");
-		p1.setCallbackHandlers(new JaasAuthenticationCallbackHandler[] {new TestCallbackHandler(), new JaasNameCallbackHandler(), new JaasPasswordCallbackHandler()});
-		p1.setAuthorityGranters(new AuthorityGranter[] {new TestAuthorityGranter()});
-		p1.afterPropertiesSet();
-		testAuthenticate(p1);
-
-		p2.setLoginConfig(new ClassPathResource(resolveConfigFile("/test2.conf")));
-		p2.setLoginContextName("test2");
-		p2.setCallbackHandlers(new JaasAuthenticationCallbackHandler[] {new TestCallbackHandler(), new JaasNameCallbackHandler(), new JaasPasswordCallbackHandler()});
-		p2.setAuthorityGranters(new AuthorityGranter[] {new TestAuthorityGranter()});
-		p2.afterPropertiesSet();
-		testAuthenticate(p2);
-	}
-	
-	private void testAuthenticate(JaasAuthenticationProvider p1) {
-        GrantedAuthorityImpl role1 = new GrantedAuthorityImpl("ROLE_1");
-        GrantedAuthorityImpl role2 = new GrantedAuthorityImpl("ROLE_2");
-
-        GrantedAuthority[] defaultAuths = new GrantedAuthority[] {role1, role2,};
-
-        UsernamePasswordAuthenticationToken token = new UsernamePasswordAuthenticationToken("user", "password",
-                defaultAuths);
-
-        Authentication auth = p1.authenticate(token);
-		Assert.assertNotNull(auth);
-	}
-
-	@Test
-	public void testConfigureJaas() throws Exception {
-		testConfigureJaasCase(new JaasAuthenticationProvider(), new JaasAuthenticationProvider());
-	}
-
-}