Discourse/discourse-adplugin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
528 Commits 7 Branches 0 Tags
6f8ff34ffa10170b9aaa036563e9f31edf28e0d0
Commit Graph
528 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Blake EricksonandMartin Brennan 6f8ff34ffa DEV: Convert TL settings to groups (#195) 
* DEV: Convert TL settings to groups

This change converts the TL site settings in this plugin to use groups
instead.

See: https://meta.discourse.org/t/283408

Co-authored-by: Martin Brennan <[email protected]>
 2024-01-31 11:04:24 -07:00
Discourse Translator Bot 19ac017dd4 Update translations (#194) 2024-01-16 14:54:13 +01:00
Jarek Radosz 429c9644de DEV: Update linting (#191) 2024-01-15 11:24:24 +00:00
David Taylor de7d8ce497 DEV: Resolve more link-to deprecations for ember upgrade (#193) 2024-01-09 20:07:04 +00:00
David Taylor 51af568c92 DEV: Resolve link-to deprecation for Ember upgrade (#192) 2023-12-13 14:59:32 +00:00
Martin BrennanandAlexDev 1d39cd8c80 Update plugin.rb metadata (#183) 
Co-authored-by: AlexDev <[email protected]>
 2023-11-08 11:16:53 -08:00
David Taylor 36f4ebc64b DEV: Abort placing adsense if Ember component is destroyed (#190) 
This should avoid surprising error messages being printed to the console
 2023-11-08 10:44:39 +11:00
David Taylor 789be84744 DEV: Log errors from adsense (#189) 2023-11-07 22:44:02 +00:00
David Taylor c88bb59d81 FIX: Fully re-render ads when navigating between pages (#188) 
In the past, the ad plugin relied on two side-effects to achieve this behaviour:

1. Components being fully destroyed/rendered when navigating between pages. This stopped working when Discourse core moved to the more efficient 'loading slider' UI

2. The `listLoading` argument. This was an implementation detail of the old discovery routing infrastructure. Core recently overhauled this and removed the `listLoading` argument, because loading is now handled properly by the Ember router.

Instead of these two properties, we can use the `currentRoute` property of Ember's router service to trigger changes when navigating between pages. A common `{{#each` trick is used to fully destroy/re-render components even if the ad network is unchanged.
 2023-11-07 21:12:30 +00:00
Discourse Translator Bot 5ad841de0b Update translations (#184) 2023-11-07 21:31:35 +01:00
David Taylor 0948d6b19e DEV: Refactor initializer to use RenderGlimmer and registerWidgetShim 2023-11-07 18:37:39 +00:00
David Taylor 3828578d5d DEV: Restructure file locations 
- Colocate components / connectors
- Move admin UI files to `admin/assets` so they are only served to admins
 2023-11-07 18:37:39 +00:00
David Taylor dbafb3b277 DEV: Update tests to use qunit-dom 2023-11-07 18:14:12 +00:00
David Taylor 86ef7da2eb DEV: Apply eslint --fix 2023-11-07 18:14:12 +00:00
David Taylor 32a43a850f DEV: Update linting config 2023-11-07 18:14:12 +00:00
dependabot[bot] 8931e2a07e Bump @babel/traverse from 7.20.10 to 7.23.2 (#182) 
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.10 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-10-18 18:26:49 +02:00
Discourse Translator Bot 44f49725f8 Update translations (#181) 2023-08-29 15:50:11 +02:00
Discourse Translator Bot 3a89fbdd9a Update translations (#180) 2023-08-23 09:28:54 +02:00
Penar Musaraj 8f51e0e4c0 DEV: Pin plugin for Discourse 3.1 stable (#179) 2023-08-22 13:45:25 -05:00
Discourse Translator Bot 30c49eb50d Update translations (#178) 2023-08-08 15:42:08 +02:00
dependabot[bot] 8cb9628f0d Bump word-wrap from 1.2.3 to 1.2.4 (#177) 
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-07-19 01:00:58 +02:00
dependabot[bot] b4aa9a05be Bump semver from 6.3.0 to 6.3.1 (#176) 
Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md)
- [Commits](https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-07-11 10:37:40 +02:00
Discourse Translator Bot db0097b8f8 Update translations (#175) 2023-07-04 18:13:14 +02:00
Discourse Translator Bot bade14daa0 Update translations (#174) 2023-06-27 16:39:17 +02:00
Isaac Janzen 743478d593 DEV: Use angle bracket syntax (#172) 2023-05-26 09:20:47 -05:00
Kris 58205cc9ac UX: introduce min-height for responsive ads (#170) 2023-04-25 16:19:48 -04:00
Discourse Translator Bot d3005f26af Update translations (#169) 2023-04-11 15:44:40 +02:00
Osama Sayegh c2057a5056 FEATURE: Add per-ad visibility settings for anons and logged-in users (#168) 
This commit adds 2 new settings to house ads to control whether an ad is shown to anonymous users and logged in users. Existing ads that were created before this feature will default to true for both settings; i.e., they will remain to be visible to both anonymous and logged-in users, but it will be possible to change the settings. Turning off both settings will effectively disable the ad completely.
 2023-04-07 17:56:22 +03:00
Discourse Translator Bot bfd4438b97 Update translations (#167) 2023-02-21 17:11:00 +01:00
Rishabh 4d2ec950d0 Ensure README images are pointing to discourse/gh-owned repositories (#166) 2023-01-25 17:30:08 +05:30
discoursebotanddiscoursebuild 165ecdefc5 DEV: Update CI workflows (#165) 
Co-authored-by: discoursebuild <[email protected]>
 2023-01-10 18:02:36 +00:00
David Taylor c519b4bc92 DEV: Update eslint-config-discourse, use prettier for hbs (#163) 2023-01-04 13:34:08 +01:00
Discourse Translator Bot dc48bea931 Update translations (#164) 2022-12-30 17:49:25 +01:00
David Taylor c73ac98748 DEV: Introduce syntax_tree for ruby formatting (#161) 2022-12-29 13:29:26 +01:00
Discourse Translator Bot ff6b767796 Update translations (#160) 2022-12-28 13:31:54 +01:00
Discourse Translator Bot 116795aff3 Update translations (#159) 2022-11-29 15:35:21 +01:00
dependabot[bot] fd6ac11ee9 Bump minimatch from 3.0.4 to 3.1.2 (#157) 
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases)
- [Commits](https://github.com/isaacs/minimatch/compare/v3.0.4...v3.1.2)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-11-27 17:33:42 +01:00
Discourse Translator Bot 203eedb915 Update translations (#156) 2022-11-16 11:36:55 +01:00
discoursebotanddiscoursebuild 8ac32a06c3 DEV: Update CI workflows (#155) 
Co-authored-by: discoursebuild <[email protected]>
 2022-11-07 12:45:46 -06:00
Discourse Translator Bot f52ac0775f Update translations (#154) 2022-11-02 15:12:51 +01:00
Penar Musaraj fa2ec23ebc DEV: Use popupAjaxError instead of bootbox (#153) 2022-10-18 13:58:55 -04:00
Discourse Translator Bot f7d9d13de8 Update translations (#152) 2022-10-05 15:31:18 +02:00
David Taylor a647813ce7 DEV: Bump rubocop-discourse (#151) 
* DEV: Bump rubocop-discourse

* Fix rubocop violations
 2022-10-03 21:36:57 +02:00
Discourse Translator Bot a570a46ad2 Update translations (#150) 2022-09-27 19:07:32 +02:00
Discourse Translator Bot 3b50a509f2 Update translations (#149) 2022-07-26 15:20:46 +02:00
Roman Rizzi 4940d0ea19 FIX: Ensure we won't render the connector if there are no ads (#148) 2022-07-14 15:58:29 -03:00
Roman Rizzi d9b739f803 FIX: Don't render the connector when we shouldn't display an ad in the topic list item. (#146) 
We expose the ad-slot logic to determine which ads are potentially available for each slot and don't render the connector when there are none. Leaking the component logic is not ideal, but I don't see a better solution given the
current design.
 2022-07-12 16:13:18 -03:00
Discourse Translator Bot a4aa6332bb Update translations (#147) 2022-07-12 17:25:54 +02:00
Roman Rizzi 469771db1d DEV: Skip assertion temporarily. (#145) 
The code-review plugin overrides the core's topic-list template, which makes all the connectors for the outlets there stop working. I'm temporarily skipping this assertion until we remove the override.
 2022-07-07 15:07:16 -03:00
Arpit JalanJordan VidrinePenar Musarajromanrizzi
 		5901a52dbc FEATURE: support placing ads between topic list for house ads (#143) 
* init

* more

* Pass td and colspan to component

* various fixes for house ads between n topics and add a test

* Make adComponents condition easier to read

Co-authored-by: Jordan Vidrine <[email protected]>
Co-authored-by: Penar Musaraj <[email protected]>
Co-authored-by: romanrizzi <[email protected]>
 2022-07-07 08:53:29 -03:00