DEV: Update linting (#326)

Gemfile.lock

@@ -9,7 +9,7 @@ GEM
       ast (~> 2.4.1)
       racc
     prettier_print (1.2.1)
-    racc (1.7.2)
+    racc (1.7.3)
     rainbow (3.1.1)
     regexp_parser (2.8.2)
     rexml (3.2.6)
@@ -28,7 +28,7 @@ GEM
       parser (>= 3.2.1.0)
     rubocop-capybara (2.19.0)
       rubocop (~> 1.41)
-    rubocop-discourse (3.4.0)
+    rubocop-discourse (3.4.1)
       rubocop (>= 1.1.0)
       rubocop-rspec (>= 2.0.0)
     rubocop-factory_bot (2.24.0)
@@ -55,4 +55,4 @@ DEPENDENCIES
   syntax_tree
 
 BUNDLED WITH
-   2.4.21
+   2.4.13

assets/javascripts/discourse/admin-discourse-ai-personas-route-map.js

@@ -4,9 +4,9 @@ export default {
   path: "/plugins",
 
   map() {
-    this.route("discourse-ai", { path: "discourse-ai" }, function () {
+    this.route("discourse-ai", function () {
       this.route("ai-personas", { path: "ai_personas" }, function () {
-        this.route("new", { path: "/new" });
+        this.route("new");
         this.route("show", { path: "/:id" });
       });
     });

assets/javascripts/discourse/components/ai-command-selector.js

@@ -7,7 +7,7 @@ export default MultiSelectComponent.extend({
   }),
 
   content: computed(function () {
-    return this.attrs.commands.value;
+    return this.commands.value;
   }),
 
   value: "",

assets/javascripts/discourse/components/ai-suggestion-dropdown.gjs

@@ -53,9 +53,13 @@ export default class AISuggestionDropdown extends Component {
   @action
   applyClasses() {
     if (this.showAIButton) {
-      document.querySelector(".composer-fields")?.classList.add("showing-ai-suggestions");
+      document
+        .querySelector(".composer-fields")
+        ?.classList.add("showing-ai-suggestions");
     } else {
-      document.querySelector(".composer-fields")?.classList.remove("showing-ai-suggestions");
+      document
+        .querySelector(".composer-fields")
+        ?.classList.remove("showing-ai-suggestions");
     }
   }
 
@@ -133,14 +137,18 @@ export default class AISuggestionDropdown extends Component {
         this.showMenu = true;
 
         if (this.args.mode === "suggest_category") {
-          document.querySelector(".category-input")?.classList.add("showing-ai-suggestion-menu");
+          document
+            .querySelector(".category-input")
+            ?.classList.add("showing-ai-suggestion-menu");
         }
       });
   }
 
   #closeMenu() {
     if (this.showMenu && this.args.mode === "suggest_category") {
-      document.querySelector(".category-input")?.classList.remove("showing-ai-suggestion-menu");
+      document
+        .querySelector(".category-input")
+        ?.classList.remove("showing-ai-suggestion-menu");
     }
 
     this.suggestIcon = "discourse-sparkles";

assets/javascripts/discourse/components/model-accuracies.js

@@ -1,3 +0,0 @@
-import Component from "@glimmer/component";
-
-export default class ReviewableAIPost extends Component {}

assets/javascripts/discourse/components/reviewable-ai-post.js

@@ -1,3 +0,0 @@
-import Component from "@glimmer/component";
-
-export default class ReviewableAiPost extends Component {}

assets/javascripts/discourse/connectors/admin-dashboard-tabs-after/admin-sentiment-dashbboard.gjs

@@ -1,10 +1,12 @@
 import Component from "@glimmer/component";
 import { LinkTo } from "@ember/routing";
-import I18n from "discourse-i18n";
-
-const i18n = I18n.t.bind(I18n);
+import i18n from "discourse-common/helpers/i18n";
 
 export default class AISentimentDashboard extends Component {
+  static shouldRender(_outletArgs, helper) {
+    return helper.siteSettings.ai_sentiment_enabled;
+  }
+
   <template>
     <li class="navigation-item sentiment">
       <LinkTo @route="admin.dashboardSentiment" class="navigation-link">
@@ -12,8 +14,4 @@ export default class AISentimentDashboard extends Component {
       </LinkTo>
     </li>
   </template>
-
-  static shouldRender(_outletArgs, helper) {
-    return helper.siteSettings.ai_sentiment_enabled;
-  }
 }

assets/javascripts/discourse/connectors/after-search-result-entry/search-result-decoration.gjs

@@ -1,12 +1,13 @@
-import Component from '@glimmer/component';
 import icon from "discourse-common/helpers/d-icon";
 import i18n from "discourse-common/helpers/i18n";
 
+const SearchResultDecoration = <template>
+  <div
+    class="ai-result__icon"
+    title={{i18n "discourse_ai.embeddings.ai_generated_result"}}
+  >
+    {{icon "discourse-sparkles"}}
+  </div>
+</template>;
 
-export default class SearchResultDecoration extends Component {
-  <template>
-    <div class="ai-result__icon" title={{i18n "discourse_ai.embeddings.ai_generated_result"}}>
-      {{icon "discourse-sparkles"}}
-    </div>
-  </template>
-}
+export default SearchResultDecoration;

assets/javascripts/discourse/connectors/full-page-search-below-search-header/semantic-search.gjs

@@ -102,7 +102,10 @@ export default class SemanticSearch extends Component {
     if (!this.searchEnabled) {
       return;
     }
-    if (this.searchPreferencesManager?.sortOrder !== undefined && this.searchPreferencesManager?.sortOrder !== 0) {
+    if (
+      this.searchPreferencesManager?.sortOrder !== undefined &&
+      this.searchPreferencesManager?.sortOrder !== 0
+    ) {
       this.preventAISearch = true;
       return;
     } else {

assets/javascripts/discourse/connectors/post-text-buttons/ai-helper-options-menu.gjs

@@ -6,9 +6,8 @@ import { ajax } from "discourse/lib/ajax";
 import { popupAjaxError } from "discourse/lib/ajax-error";
 import I18n from "I18n";
 import eq from "truth-helpers/helpers/eq";
-import { showPostAIHelper } from "../../lib/show-ai-helper";
 import not from "truth-helpers/helpers/not";
-
+import { showPostAIHelper } from "../../lib/show-ai-helper";
 
 const i18n = I18n.t.bind(I18n);
 
@@ -100,10 +99,12 @@ export default class AIHelperOptionsMenu extends Component {
     if (this.suggestion?.length > 0) {
       navigator.clipboard.writeText(this.suggestion).then(() => {
         this.copyButtonIcon = "check";
-        this.copyButtonLabel = "discourse_ai.ai_helper.post_options_menu.copied"
+        this.copyButtonLabel =
+          "discourse_ai.ai_helper.post_options_menu.copied";
         setTimeout(() => {
           this.copyButtonIcon = "copy";
-          this.copyButtonLabel = "discourse_ai.ai_helper.post_options_menu.copy"
+          this.copyButtonLabel =
+            "discourse_ai.ai_helper.post_options_menu.copy";
         }, 3500);
       });
     }
@@ -180,4 +181,4 @@ export default class AIHelperOptionsMenu extends Component {
       {{/if}}
     </div>
   </template>
-}
+}

assets/javascripts/discourse/routes/admin-plugins-discourse-ai-index.js

@@ -1,7 +1,9 @@
+import { inject as service } from "@ember/service";
 import DiscourseRoute from "discourse/routes/discourse";
 
 export default DiscourseRoute.extend({
+  router: service("router"),
   beforeModel() {
-    this.transitionTo("adminPlugins.discourse-ai.ai-personas");
+    this.router.transitionTo("adminPlugins.discourse-ai.ai-personas");
   },
 });

package.json

@@ -4,9 +4,9 @@
   "author": "Discourse",
   "license": "MIT",
   "devDependencies": {
-    "@discourse/lint-configs": "^1.0.0",
-    "ember-template-lint": "^5.11.2",
-    "eslint": "^8.52.0",
+    "@discourse/lint-configs": "^1.2.0",
+    "ember-template-lint": "^5.13.0",
+    "eslint": "^8.54.0",
     "prettier": "^2.8.8"
   }
 }