Discourse/discourse-table-builder
1
0
Fork 0
mirror of https://github.com/discourse/discourse-table-builder.git synced 2026-09-17 07:12:13 -04:00
Code Issues Packages Projects Releases Wiki Activity
94 Commits 5 Branches 0 Tags
e9cb744f0d346faed8dad3fa35b8d8927a2b83b7
Commit Graph
94 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Discourse Translator Bot e9cb744f0d Update translations (#51) 2023-06-20 17:28:24 +02:00
Penar Musaraj a6b221ddfa FIX: Table editing sometimes not working (#50) 
We were relying on the `event.target`, and sometimes that target was not the button element with the `table-id` data attribute, but the svg. 

This commit makes a few changes: 

- renames `tableId` to `tableIndex`
- passes the index as part of the attributes to the `generateModal` function
 2023-04-25 10:23:28 -04:00
Keegan George eb164d881e UX: Make table builder edit button icon-only (#49) 2023-03-24 13:23:08 -07:00
Keegan George 5d7a126403 FIX: Post height issues (#34) 2023-03-24 12:25:46 -07:00
Selase Krakani 850e31c83d FIX: Remove linebreaks from cell data (#48) 
Pasting text with linebreaks into the table UI results in incorrectly
generated table markdown.

This fix strips linebreaks from text during table markdown generation.
 2023-02-27 15:49:55 +00:00
Penar Musaraj 4c6b020fd8 DEV: Update jSpreadsheet to v4.11.1 (#47) 2023-02-16 21:17:00 -05:00
Penar Musaraj b45ffe48b7 FIX: Allow headings to have the same label (#46) 
Fixes an issue where multiple headings with the same value would remove
columns from displaying.
 2023-02-16 21:16:48 -05:00
Penar Musaraj d754e7a2ec FIX: Screen shaking on mobile view navigation (#45) 
Setting a border on the `fullscreen-table-wrapper` element causes a
small shake in mobile views, especially on topics with multiple tables.

This PR removes the border on the table entirely. This was an almost
invisible visual effect when selecting the table (small border width,
whole table is set to 50% opacity).

It also makes a small refactor, moving the styles of the button outside
of the hover state.
 2023-02-06 10:04:19 -05:00
Discourse Translator Bot f91876f8d3 Update translations (#44) 2023-01-24 16:32:01 +01:00
Keegan George 7e02d17031 DEV: Update vendor assets (#43) 2023-01-19 09:24:45 -08:00
Keegan George 6707473520 DEV: Map Discourse locales to vendor spreadsheet locales (#42) 2023-01-19 09:24:31 -08:00
discoursebotanddiscoursebuild ce3adf0612 DEV: Update CI workflows (#41) 
Co-authored-by: discoursebuild <[email protected]>
 2023-01-10 20:12:30 +00:00
David Taylor 8285be7618 DEV: Update eslint-config-discourse, use prettier for hbs (#40) 2023-01-04 12:54:43 +00:00
Penar Musaraj fdc79d0cbf FIX: do not edit wrong table when post has uploads (#37) 
Previously, the regex was catching uploads as well as tables.

This change ensures only strict tables are matched by requiring that
matches start with the pipe character.

Also adds a unit test for `findTableRegex` to describe the expected
behaviour of the helper.
 2023-01-04 08:06:25 +01:00
dependabot[bot] 38914c6ada Bump json5 from 2.2.1 to 2.2.2 (#39) 
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v2.2.1...v2.2.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-12-30 22:23:38 -05:00
discoursebotanddiscoursebuild 3d20217880 DEV: Update CI workflows (#38) 
Co-authored-by: discoursebuild <[email protected]>
 2022-12-31 04:21:32 +01:00
Discourse Translator Bot 015defed7c Update translations (#36) 2022-11-29 15:42:13 +01:00
Discourse Translator Bot 326acd075d Update translations (#35) 2022-11-02 15:13:40 +01:00
Keegan George 7028ba0660 FIX: Desktop touchscreens and allow edits on mobileView (#32) 2022-10-27 10:52:40 -07:00
Keegan George ae101e3b95 UX: Reduce confusion when editing tables (#33) 2022-10-27 10:02:57 -07:00
Keegan George 213c42eb6b UX: Better contrast context menu text color (#31) 2022-10-13 14:53:04 -07:00
Keegan George 7e65777187 FIX: Misalignment of table after edit (#30) 
See Meta bug report: https://meta.discourse.org/t/table-builder/236016/54
 2022-10-13 14:37:01 -07:00
Keegan George 879140b8ce FIX: Make edit table button text not selectable (#29) 
Making the text of the edit table button not selectable so that when post's contents are copied, the edit table label does not copy over as well.
 2022-10-12 09:49:54 -07:00
Keegan George 55c80ed04f Revert "DEV: Ensure helper or post exist before decorations (#27)" (#28) 
This reverts commit 2896c69a72.
 2022-09-21 10:12:32 -07:00
Keegan George 2896c69a72 DEV: Ensure helper or post exist before decorations (#27) 2022-09-20 18:23:22 -07:00
Discourse Translator Bot c95026fde0 Update translations (#26) 2022-09-13 16:04:32 +02:00
Discourse Translator Bot c4ab77dc00 Update translations (#24) 2022-08-30 20:16:21 +02:00
Discourse Translator Bot dacd41530e DEV: Add Crowdin support (#23) 2022-08-30 13:37:25 +02:00
Keegan George 9528208b8c UX: Improve table modal max width for larger screens (#22) 
* UX: Improve modal width for large screens

* UX: Ensure smaller screen modal does not cut off content
 2022-08-15 13:51:11 -07:00
Keegan George be968d9158 DEV: Add loading spinner (#20) 
* WIP: Add loading spinner

* DEV: Linting fixes

* DEV: Make `loading` a `@tracked` property
 2022-08-15 08:47:33 -07:00
Joffrey JAFFEUX 20bcb38249 FIX: prevents markdown error by using new core parseAsync (#21) 
Prior to this fix markdown-it was not correctly initialised and would cause an error when having to parse an URL for example.
 2022-08-13 15:14:21 +02:00
Keegan George f68a599e87 DEV: Add unique filename for table exports (#19) 2022-08-12 12:10:04 -07:00
Keegan George 52b69453ba COMPATIBILITY: Update site and siteSettings references (#18) 2022-08-12 12:09:39 -07:00
Penar Musaraj 9abd57e5b5 FIX: Strip null characters (#17) 2022-08-12 14:14:01 -04:00
Penar MusarajandKeegan George a8f27d9131 UX: Default to wide tables (#16) 
* UX: Default to 100% wide tables

* DEV: Change default spreadsheet rows/columns

Co-authored-by: Keegan George <[email protected]>
 2022-08-12 11:11:27 -07:00
Keegan George ec42e4a022 FIX: Minimum version should include .beta9 (#15) 2022-08-12 08:12:19 -07:00
kuro282 f3624566fb Add Chinese - Simplified Translation (zh_CN) (#5) 2022-08-11 14:49:44 -07:00
Keegan George b41da81bc4 DEV: Update about information (#14) 2022-08-11 12:58:02 -07:00
Keegan George 388c4a58e5 DEV: Update SpreadsheetEditor to use @glimmer/component (#13) 
Now that all of our singletons have been converted to true Ember Services, we can remove our custom `discourse/component/glimmer` superclass and use explicit injection
 2022-08-11 11:59:08 -07:00
Keegan GeorgeandPenar Musaraj 7b37c6acc1 FIX: Special character alignment issue (#10) 
* DEV: Use alternate fork of `array-to-table`

* DEV: Add unit test for `arrayToTable()` method

* Move `arrayToTable` so it is available for unit tests

* DEV: Add assertion for creating a markdown table with special chars

When a table with special characters (such as `$`) is inserted in a cell to the right of a blank cell. The alignment of the table gets ruined if the table doesn't have surrounding pipes. This check ensures this alignment is correct.

Co-authored-by: Penar Musaraj <[email protected]>
 2022-08-11 11:33:34 -07:00
Keegan George dacdd1cc4e FIX: Edit Table button appearing in all <table> elements (#12) 2022-08-11 11:12:01 -07:00
Keegan George 4289145268 UX: Wrap words instead of dynamic widths and align left (#11) 
* UX: Wrap words instead of dynamic widths and align left

* UX: Improve sticky header on scroll

* DEV: Convert default column text to localizable strings
 2022-08-10 13:50:38 -07:00
Keegan George d25736adad DEV: Remove Table HTML usage (#9) 
* DEV: Remove Table HTML usage

* DEV: Apply ember linting
 2022-08-09 17:14:35 -07:00
Keegan GeorgeandPenar Musaraj 98a9081e25 DEV: Populate table content using raw markdown (#7) 
* Very exploratory MD work

* DEV: Populate table content using raw markdown

* DEV: 💄 Linting Fixes

Co-authored-by: Penar Musaraj <[email protected]>
 2022-08-09 16:51:17 -07:00
Keegan George 69bfac2226 UX: Change edit modal primary button to Save Edit (#8) 
To add consistency with naming used in other areas of the composer, this PR changes the label of the primary button from Update Table to Save Edit
 2022-08-09 16:42:47 -07:00
Keegan George 993a1bbd43 FIX: Use canEdit property rather than comparing user (#6) 
* FIX: Use `canEdit` property rather than comparing user

* DEV: Remove unused currentUser variable
 2022-08-08 12:21:30 -07:00
Keegan George 695980a250 Merge branch 'main' of https://github.com/keegangeorge/discourse-table-builder 2022-07-28 07:43:23 -07:00
Keegan George e56f9eacb6 UX: Allow modal to grow dependant on table size 2022-07-28 07:43:10 -07:00
Keegan George 52710496ed FIX: conflicting class declaration with core (#4) 
* DEV: Remove `fade-in` and use `jsuites.basic.css` instead

* FIX: Linting issues with jspreadsheet-theme

* WIP: Add bash script to handle vendor assets

* FIX: Ember Linting fixes

* DEV: Cleanup comments and commented code
 2022-07-28 07:33:25 -07:00
Keegan George 12e09ebad6 Merge pull request #3 from discourse/fix-csp-issues 
FIX: Use local theme files for external libs
 2022-07-26 12:14:36 -07:00