refactor: dart

modules/@angular/common/src/location/hash_location_strategy.ts

@@ -83,10 +83,7 @@ export class HashLocationStrategy extends LocationStrategy {
     var path = this._platformLocation.hash;
     if (!isPresent(path)) path = '#';
 
-    // Dart will complain if a call to substring is
-    // executed with a position value that extends the
-    // length of string.
-    return (path.length > 0 ? path.substring(1) : path);
+    return path.length > 0 ? path.substring(1) : path;
   }
 
   prepareExternalUrl(internal: string): string {

modules/@angular/compiler/src/directive_normalizer.ts

@@ -215,8 +215,6 @@ class TemplatePreparseVisitor implements html.Visitor {
         this.styleUrls.push(preparsedElement.hrefAttr);
         break;
       default:
-        // DDC reports this as error. See:
-        // https://github.com/dart-lang/dev_compiler/issues/428
         break;
     }
     if (preparsedElement.nonBindable) {

modules/@angular/compiler/src/output/abstract_emitter.ts

@@ -201,7 +201,6 @@ export abstract class AbstractEmitterVisitor implements o.StatementVisitor, o.Ex
       name = this.getBuiltinMethodName(expr.builtin);
       if (isBlank(name)) {
         // some builtins just mean to skip the call.
-        // e.g. `bind` in Dart.
         return null;
       }
     }

modules/@angular/compiler/src/output/output_interpreter.ts

@@ -11,7 +11,6 @@ import {ListWrapper} from '../facade/collection';
 import {BaseException, unimplemented} from '../facade/exceptions';
 import {isPresent} from '../facade/lang';
 
-import {debugOutputAstAsDart} from './dart_emitter';
 import * as o from './output_ast';
 import {debugOutputAstAsTypeScript} from './ts_emitter';
 

modules/@angular/compiler/src/selector.ts

@@ -12,9 +12,7 @@ import {RegExpMatcherWrapper, RegExpWrapper, StringWrapper, isBlank, isPresent}
 
 const _EMPTY_ATTR_VALUE = '';
 
-// TODO: Can't use `const` here as
-// in Dart this is not transpiled into `final` yet...
-var _SELECTOR_REGEXP = RegExpWrapper.create(
+const _SELECTOR_REGEXP = RegExpWrapper.create(
     '(\\:not\\()|' +                          //":not("
     '([-\\w]+)|' +                            // "tag"
     '(?:\\.([-\\w]+))|' +                     // ".class"

modules/@angular/compiler/test/output/dart_imports_spec.ts

@@ -1,64 +0,0 @@
-/**
- * @license
- * Copyright Google Inc. All Rights Reserved.
- *
- * Use of this source code is governed by an MIT-style license that can be
- * found in the LICENSE file at https://angular.io/license
- */
-
-import {beforeEach, ddescribe, describe, expect, iit, inject, it, xit,} from '@angular/core/testing/testing_internal';
-
-import {DartImportGenerator} from '@angular/compiler/src/output/dart_imports';
-
-export function main() {
-  describe('DartImportGenerator', () => {
-    describe('getImportPath', () => {
-      var generator: DartImportGenerator;
-      beforeEach(() => { generator = new DartImportGenerator(); });
-
-      it('should calculate relative paths Dart', () => {
-        expect(generator.getImportPath('asset:somePkg/lib/modPath', 'asset:somePkg/lib/impPath'))
-            .toEqual('impPath');
-      });
-
-      it('should calculate relative paths for different constellations', () => {
-        expect(generator.getImportPath('asset:somePkg/test/modPath', 'asset:somePkg/test/impPath'))
-            .toEqual('impPath');
-        expect(
-            generator.getImportPath('asset:somePkg/lib/modPath', 'asset:somePkg/lib/dir2/impPath'))
-            .toEqual('dir2/impPath');
-        expect(
-            generator.getImportPath('asset:somePkg/lib/dir1/modPath', 'asset:somePkg/lib/impPath'))
-            .toEqual('../impPath');
-        expect(generator.getImportPath(
-                   'asset:somePkg/lib/dir1/modPath', 'asset:somePkg/lib/dir2/impPath'))
-            .toEqual('../dir2/impPath');
-      });
-
-      it('should calculate absolute paths', () => {
-        expect(
-            generator.getImportPath('asset:somePkg/lib/modPath', 'asset:someOtherPkg/lib/impPath'))
-            .toEqual('package:someOtherPkg/impPath');
-      });
-
-      it('should not allow absolute imports of non lib modules', () => {
-        expect(
-            () =>
-                generator.getImportPath('asset:somePkg/lib/modPath', 'asset:somePkg/test/impPath'))
-            .toThrowError(
-                `Can't import url asset:somePkg/test/impPath from asset:somePkg/lib/modPath`);
-      });
-
-      it('should not allow non asset urls as base url', () => {
-        expect(
-            () => generator.getImportPath('http:somePkg/lib/modPath', 'asset:somePkg/test/impPath'))
-            .toThrowError(`Url http:somePkg/lib/modPath is not a valid asset: url`);
-      });
-
-      it('should allow non asset urls as import urls and pass them through', () => {
-        expect(generator.getImportPath('asset:somePkg/lib/modPath', 'dart:html'))
-            .toEqual('dart:html');
-      });
-    });
-  });
-}

modules/@angular/compiler/test/output/output_emitter_codegen_typed.ts

@@ -7,8 +7,6 @@
  */
 
 // ATTENTION: This file will be overwritten with generated code by main()
-import {DartEmitter} from '@angular/compiler/src/output/dart_emitter';
-import {DartImportGenerator} from '@angular/compiler/src/output/dart_imports';
 import * as o from '@angular/compiler/src/output/output_ast';
 import {TypeScriptEmitter} from '@angular/compiler/src/output/ts_emitter';
 

modules/@angular/compiler/test/output/output_emitter_spec.ts

@@ -30,7 +30,7 @@ export function main() {
     // Our generator only works on node.js
     outputDefs.push({'getExpressions': () => typed.getExpressions, 'name': 'typed'});
   } else {
-    // Our generator only works on node.js and Dart...
+    // Our generator only works on node.js
     if (!getDOM().supportsDOMEvents()) {
       outputDefs.push({'getExpressions': () => untyped.getExpressions, 'name': 'untyped'});
     }

modules/@angular/compiler/test/output/ts_emitter_spec.ts

@@ -24,7 +24,7 @@ var externalModuleIdentifier =
     new CompileIdentifierMetadata({name: 'someExternalId', moduleUrl: anotherModuleUrl});
 
 export function main() {
-  // Note supported features of our OutputAstin TS:
+  // Note supported features of our OutputAsti n TS:
   // - real `const` like in Dart
   // - final fields
 

modules/@angular/compiler/test/style_url_resolver_spec.ts

@@ -109,7 +109,6 @@ export function main() {
   });
 }
 
-/// The real thing behaves differently between Dart and JS for package URIs.
 class FakeUrlResolver extends UrlResolver {
   constructor() { super(); }
 

modules/@angular/core/src/console.ts

@@ -9,14 +9,9 @@
 import {Injectable} from './di/decorators';
 import {print, warn} from './facade/lang';
 
-
-// Note: Need to rename warn as in Dart
-// class members and imports can't use the same name.
-let _warnImpl = warn;
-
 @Injectable()
 export class Console {
   log(message: string): void { print(message); }
   // Note: for reporting errors use `DOM.logError()` as it is platform specific
-  warn(message: string): void { _warnImpl(message); }
+  warn(message: string): void { warn(message); }
 }

modules/@angular/core/src/metadata/directives.ts

@@ -884,8 +884,6 @@ export class ComponentMetadata extends DirectiveMetadata implements ComponentMet
    * In CommonJS, this can always be set to `module.id`, similarly SystemJS exposes `__moduleName`
    * variable within each module.
    *
-   * In Dart, this can be determined automatically and does not need to be set.
-
    *
    * ## Simple Example
    *

modules/@angular/core/src/platform_core_providers.ts

@@ -19,8 +19,6 @@ function _reflector(): Reflector {
   return reflector;
 }
 
-var __unused: Type;  // prevent missing use Dart warning.
-
 const _CORE_PLATFORM_PROVIDERS: Array<any|Type|Provider|any[]> = [
   PlatformRef_, {provide: PlatformRef, useExisting: PlatformRef_},
   {provide: Reflector, useFactory: _reflector, deps: []},

modules/@angular/examples/README.md

@@ -1,6 +1,5 @@
 # API Examples
 
 This folder contains small example apps that get in-lined into our API docs.
-These examples are written with idiomatic TypeScript, and are not transpiled to Dart.
 Each example contains tests for application behavior (as opposed to testing Angular's
 behavior) just like an Angular application developer would write.

modules/@angular/platform-browser/src/web_workers/shared/message_bus.ts

@@ -46,7 +46,7 @@ export abstract class MessageBus implements MessageBusSource, MessageBusSink {
 
   /**
    * Returns an {@link EventEmitter} for the given channel
-   * To publish methods to that channel just call next (or add in dart) on the returned emitter
+   * To publish methods to that channel just call next on the returned emitter
    */
   abstract to(channel: string): EventEmitter<any>;
 }
@@ -98,7 +98,7 @@ export interface MessageBusSink {
 
   /**
    * Returns an {@link EventEmitter} for the given channel
-   * To publish methods to that channel just call next (or add in dart) on the returned emitter
+   * To publish methods to that channel just call next on the returned emitter
    */
   to(channel: string): EventEmitter<any>;
 }

modules/@angular/platform-browser/test/browser/bootstrap_spec.ts

@@ -163,7 +163,6 @@ export function main() {
     if (getDOM().supportsDOMEvents()) {
       it('should forward the error to promise when bootstrap fails',
          inject([AsyncTestCompleter], (async: AsyncTestCompleter) => {
-           // Skip for dart since it causes a confusing error message in console when test passes.
            var logger = new _ArrayLogger();
            var exceptionHandler = new ExceptionHandler(logger, false);
 

modules/@angular/platform-browser/test/web_workers/shared/message_bus_spec.ts

@@ -17,7 +17,7 @@ import {createConnectedMessageBus} from './message_bus_util';
 
 export function main() {
   /**
-   * Tests the PostMessageBus in TypeScript and the IsolateMessageBus in Dart
+   * Tests the PostMessageBus
    */
   describe('MessageBus', () => {
     var bus: MessageBus;