feat(core): added afterContentInit, afterViewInit, and afterViewChecked hooks
Closes #3897
This commit is contained in:
@@ -38,7 +38,10 @@ export {
|
||||
} from './src/core/metadata';
|
||||
|
||||
export {
|
||||
AfterContentInit,
|
||||
AfterContentChecked,
|
||||
AfterViewInit,
|
||||
AfterViewChecked,
|
||||
OnChanges,
|
||||
OnDestroy,
|
||||
OnInit,
|
||||
|
||||
@@ -82,12 +82,19 @@ export class AbstractChangeDetector<T> implements ChangeDetector {
|
||||
this.mode === ChangeDetectionStrategy.Checked)
|
||||
return;
|
||||
var s = _scope_check(this.id, throwOnChange);
|
||||
|
||||
this.detectChangesInRecords(throwOnChange);
|
||||
|
||||
this._detectChangesInLightDomChildren(throwOnChange);
|
||||
if (throwOnChange === false) this.callAfterContentChecked();
|
||||
if (!throwOnChange) this.afterContentLifecycleCallbacks();
|
||||
|
||||
this._detectChangesInShadowDomChildren(throwOnChange);
|
||||
if (!throwOnChange) this.afterViewLifecycleCallbacks();
|
||||
|
||||
if (this.mode === ChangeDetectionStrategy.CheckOnce)
|
||||
this.mode = ChangeDetectionStrategy.Checked;
|
||||
|
||||
this.alreadyChecked = true;
|
||||
wtfLeave(s);
|
||||
}
|
||||
|
||||
@@ -156,7 +163,19 @@ export class AbstractChangeDetector<T> implements ChangeDetector {
|
||||
|
||||
hydrated(): boolean { return this.context !== null; }
|
||||
|
||||
callAfterContentChecked(): void { this.dispatcher.notifyAfterContentChecked(); }
|
||||
afterContentLifecycleCallbacks(): void {
|
||||
this.dispatcher.notifyAfterContentChecked();
|
||||
this.afterContentLifecycleCallbacksInternal();
|
||||
}
|
||||
|
||||
afterContentLifecycleCallbacksInternal(): void {}
|
||||
|
||||
afterViewLifecycleCallbacks(): void {
|
||||
this.dispatcher.notifyAfterViewChecked();
|
||||
this.afterViewLifecycleCallbacksInternal();
|
||||
}
|
||||
|
||||
afterViewLifecycleCallbacksInternal(): void {}
|
||||
|
||||
_detectChangesInLightDomChildren(throwOnChange: boolean): void {
|
||||
var c = this.lightDomChildren;
|
||||
|
||||
@@ -63,23 +63,23 @@ export class ChangeDetectorJITGenerator {
|
||||
var ${CHANGES_LOCAL} = null;
|
||||
|
||||
${this.records.map((r) => this._genRecord(r)).join("\n")}
|
||||
|
||||
${this._names.getAlreadyCheckedName()} = true;
|
||||
}
|
||||
|
||||
${this._maybeGenHandleEventInternal()}
|
||||
|
||||
${this._genCheckNoChanges()}
|
||||
|
||||
${this._maybeGenCallAfterContentChecked()}
|
||||
${this._maybeGenAfterContentLifecycleCallbacks()}
|
||||
|
||||
${this._maybeGenAfterViewLifecycleCallbacks()}
|
||||
|
||||
${this._maybeGenHydrateDirectives()}
|
||||
|
||||
${this._maybeGenDehydrateDirectives()}
|
||||
|
||||
${this._genPropertyBindingTargets()};
|
||||
${this._genPropertyBindingTargets()}
|
||||
|
||||
${this._genDirectiveIndices()};
|
||||
${this._genDirectiveIndices()}
|
||||
|
||||
return function(dispatcher) {
|
||||
return new ${this._typeName}(dispatcher);
|
||||
@@ -172,23 +172,26 @@ export class ChangeDetectorJITGenerator {
|
||||
}`;
|
||||
}
|
||||
|
||||
_maybeGenCallAfterContentChecked(): string {
|
||||
var notifications = [];
|
||||
var dirs = this.directiveRecords;
|
||||
|
||||
// NOTE(kegluneq): Order is important!
|
||||
for (var i = dirs.length - 1; i >= 0; --i) {
|
||||
var dir = dirs[i];
|
||||
if (dir.callAfterContentChecked) {
|
||||
notifications.push(
|
||||
`${this._names.getDirectiveName(dir.directiveIndex)}.afterContentChecked();`);
|
||||
}
|
||||
}
|
||||
_maybeGenAfterContentLifecycleCallbacks(): string {
|
||||
var notifications = this._logic.genContentLifecycleCallbacks(this.directiveRecords);
|
||||
if (notifications.length > 0) {
|
||||
var directiveNotifications = notifications.join("\n");
|
||||
return `
|
||||
${this._typeName}.prototype.callAfterContentChecked = function() {
|
||||
${ABSTRACT_CHANGE_DETECTOR}.prototype.callAfterContentChecked.call(this);
|
||||
${this._typeName}.prototype.afterContentLifecycleCallbacksInternal = function() {
|
||||
${directiveNotifications}
|
||||
}
|
||||
`;
|
||||
} else {
|
||||
return '';
|
||||
}
|
||||
}
|
||||
|
||||
_maybeGenAfterViewLifecycleCallbacks(): string {
|
||||
var notifications = this._logic.genViewLifecycleCallbacks(this.directiveRecords);
|
||||
if (notifications.length > 0) {
|
||||
var directiveNotifications = notifications.join("\n");
|
||||
return `
|
||||
${this._typeName}.prototype.afterViewLifecycleCallbacksInternal = function() {
|
||||
${directiveNotifications}
|
||||
}
|
||||
`;
|
||||
|
||||
@@ -183,4 +183,38 @@ export class CodegenLogicUtil {
|
||||
}
|
||||
return res.join("\n");
|
||||
}
|
||||
|
||||
genContentLifecycleCallbacks(directiveRecords: DirectiveRecord[]): string[] {
|
||||
var res = [];
|
||||
// NOTE(kegluneq): Order is important!
|
||||
for (var i = directiveRecords.length - 1; i >= 0; --i) {
|
||||
var dir = directiveRecords[i];
|
||||
if (dir.callAfterContentInit) {
|
||||
res.push(
|
||||
`if(! ${this._names.getAlreadyCheckedName()}) ${this._names.getDirectiveName(dir.directiveIndex)}.afterContentInit();`);
|
||||
}
|
||||
|
||||
if (dir.callAfterContentChecked) {
|
||||
res.push(`${this._names.getDirectiveName(dir.directiveIndex)}.afterContentChecked();`);
|
||||
}
|
||||
}
|
||||
return res;
|
||||
}
|
||||
|
||||
genViewLifecycleCallbacks(directiveRecords: DirectiveRecord[]): string[] {
|
||||
var res = [];
|
||||
// NOTE(kegluneq): Order is important!
|
||||
for (var i = directiveRecords.length - 1; i >= 0; --i) {
|
||||
var dir = directiveRecords[i];
|
||||
if (dir.callAfterViewInit) {
|
||||
res.push(
|
||||
`if(! ${this._names.getAlreadyCheckedName()}) ${this._names.getDirectiveName(dir.directiveIndex)}.afterViewInit();`);
|
||||
}
|
||||
|
||||
if (dir.callAfterViewChecked) {
|
||||
res.push(`${this._names.getDirectiveName(dir.directiveIndex)}.afterViewChecked();`);
|
||||
}
|
||||
}
|
||||
return res;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -9,24 +9,33 @@ export class DirectiveIndex {
|
||||
|
||||
export class DirectiveRecord {
|
||||
directiveIndex: DirectiveIndex;
|
||||
callAfterContentInit: boolean;
|
||||
callAfterContentChecked: boolean;
|
||||
callAfterViewInit: boolean;
|
||||
callAfterViewChecked: boolean;
|
||||
callOnChanges: boolean;
|
||||
callDoCheck: boolean;
|
||||
callOnInit: boolean;
|
||||
changeDetection: ChangeDetectionStrategy;
|
||||
|
||||
constructor({directiveIndex, callAfterContentChecked, callOnChanges, callDoCheck, callOnInit,
|
||||
changeDetection}: {
|
||||
constructor({directiveIndex, callAfterContentInit, callAfterContentChecked, callAfterViewInit,
|
||||
callAfterViewChecked, callOnChanges, callDoCheck, callOnInit, changeDetection}: {
|
||||
directiveIndex?: DirectiveIndex,
|
||||
callAfterContentInit?: boolean,
|
||||
callAfterContentChecked?: boolean,
|
||||
callAfterViewInit?: boolean,
|
||||
callAfterViewChecked?: boolean,
|
||||
callOnChanges?: boolean,
|
||||
callDoCheck?: boolean,
|
||||
callOnInit?: boolean,
|
||||
changeDetection?: ChangeDetectionStrategy
|
||||
} = {}) {
|
||||
this.directiveIndex = directiveIndex;
|
||||
this.callAfterContentInit = normalizeBool(callAfterContentInit);
|
||||
this.callAfterContentChecked = normalizeBool(callAfterContentChecked);
|
||||
this.callOnChanges = normalizeBool(callOnChanges);
|
||||
this.callAfterViewInit = normalizeBool(callAfterViewInit);
|
||||
this.callAfterViewChecked = normalizeBool(callAfterViewChecked);
|
||||
this.callDoCheck = normalizeBool(callDoCheck);
|
||||
this.callOnInit = normalizeBool(callOnInit);
|
||||
this.changeDetection = changeDetection;
|
||||
|
||||
@@ -159,8 +159,6 @@ export class DynamicChangeDetector extends AbstractChangeDetector<any> {
|
||||
isChanged = false;
|
||||
}
|
||||
}
|
||||
|
||||
this.alreadyChecked = true;
|
||||
}
|
||||
|
||||
_firstInBinding(r: ProtoRecord): boolean {
|
||||
@@ -168,17 +166,33 @@ export class DynamicChangeDetector extends AbstractChangeDetector<any> {
|
||||
return isBlank(prev) || prev.bindingRecord !== r.bindingRecord;
|
||||
}
|
||||
|
||||
callAfterContentChecked() {
|
||||
super.callAfterContentChecked();
|
||||
afterContentLifecycleCallbacksInternal() {
|
||||
var dirs = this.directiveRecords;
|
||||
for (var i = dirs.length - 1; i >= 0; --i) {
|
||||
var dir = dirs[i];
|
||||
if (dir.callAfterContentInit && !this.alreadyChecked) {
|
||||
this._getDirectiveFor(dir.directiveIndex).afterContentInit();
|
||||
}
|
||||
|
||||
if (dir.callAfterContentChecked) {
|
||||
this._getDirectiveFor(dir.directiveIndex).afterContentChecked();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
afterViewLifecycleCallbacksInternal() {
|
||||
var dirs = this.directiveRecords;
|
||||
for (var i = dirs.length - 1; i >= 0; --i) {
|
||||
var dir = dirs[i];
|
||||
if (dir.callAfterViewInit && !this.alreadyChecked) {
|
||||
this._getDirectiveFor(dir.directiveIndex).afterViewInit();
|
||||
}
|
||||
if (dir.callAfterViewChecked) {
|
||||
this._getDirectiveFor(dir.directiveIndex).afterViewChecked();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
_updateDirectiveOrElement(change, bindingRecord) {
|
||||
if (isBlank(bindingRecord.directiveRecord)) {
|
||||
super.notifyDispatcher(change.currentValue);
|
||||
|
||||
@@ -52,6 +52,7 @@ export interface ChangeDispatcher {
|
||||
notifyOnBinding(bindingTarget: BindingTarget, value: any): void;
|
||||
logBindingUpdate(bindingTarget: BindingTarget, value: any): void;
|
||||
notifyAfterContentChecked(): void;
|
||||
notifyAfterViewChecked(): void;
|
||||
}
|
||||
|
||||
export interface ChangeDetector {
|
||||
|
||||
@@ -17,8 +17,14 @@ bool hasLifecycleHook(LifecycleEvent e, type, DirectiveMetadata annotation) {
|
||||
interface = OnChanges;
|
||||
} else if (e == LifecycleEvent.OnDestroy) {
|
||||
interface = OnDestroy;
|
||||
} else if (e == LifecycleEvent.AfterContentInit) {
|
||||
interface = AfterContentInit;
|
||||
} else if (e == LifecycleEvent.AfterContentChecked) {
|
||||
interface = AfterContentChecked;
|
||||
} else if (e == LifecycleEvent.AfterViewInit) {
|
||||
interface = AfterViewInit;
|
||||
} else if (e == LifecycleEvent.AfterViewChecked) {
|
||||
interface = AfterViewChecked;
|
||||
} else if (e == LifecycleEvent.DoCheck) {
|
||||
interface = DoCheck;
|
||||
} else if (e == LifecycleEvent.OnInit) {
|
||||
|
||||
@@ -8,8 +8,14 @@ export function hasLifecycleHook(e: LifecycleEvent, type, annotation: DirectiveM
|
||||
if (!(type instanceof Type)) return false;
|
||||
var proto = (<any>type).prototype;
|
||||
switch (e) {
|
||||
case LifecycleEvent.AfterContentInit:
|
||||
return !!proto.afterContentInit;
|
||||
case LifecycleEvent.AfterContentChecked:
|
||||
return !!proto.afterContentChecked;
|
||||
case LifecycleEvent.AfterViewInit:
|
||||
return !!proto.afterViewInit;
|
||||
case LifecycleEvent.AfterViewChecked:
|
||||
return !!proto.afterViewChecked;
|
||||
case LifecycleEvent.OnChanges:
|
||||
return !!proto.onChanges;
|
||||
case LifecycleEvent.DoCheck:
|
||||
|
||||
@@ -216,38 +216,41 @@ export class DirectiveBinding extends ResolvedBinding {
|
||||
|
||||
get changeDetection() { return this.metadata.changeDetection; }
|
||||
|
||||
static createFromBinding(binding: Binding, ann: DirectiveMetadata): DirectiveBinding {
|
||||
if (isBlank(ann)) {
|
||||
ann = new DirectiveMetadata();
|
||||
static createFromBinding(binding: Binding, meta: DirectiveMetadata): DirectiveBinding {
|
||||
if (isBlank(meta)) {
|
||||
meta = new DirectiveMetadata();
|
||||
}
|
||||
|
||||
var rb = binding.resolve();
|
||||
var deps = ListWrapper.map(rb.dependencies, DirectiveDependency.createFrom);
|
||||
var resolvedBindings = isPresent(ann.bindings) ? Injector.resolve(ann.bindings) : [];
|
||||
var resolvedViewBindings = ann instanceof ComponentMetadata && isPresent(ann.viewBindings) ?
|
||||
Injector.resolve(ann.viewBindings) :
|
||||
var resolvedBindings = isPresent(meta.bindings) ? Injector.resolve(meta.bindings) : [];
|
||||
var resolvedViewBindings = meta instanceof ComponentMetadata && isPresent(meta.viewBindings) ?
|
||||
Injector.resolve(meta.viewBindings) :
|
||||
[];
|
||||
var metadata = RenderDirectiveMetadata.create({
|
||||
id: stringify(rb.key.token),
|
||||
type: ann instanceof ComponentMetadata ? RenderDirectiveMetadata.COMPONENT_TYPE :
|
||||
RenderDirectiveMetadata.DIRECTIVE_TYPE,
|
||||
selector: ann.selector,
|
||||
compileChildren: ann.compileChildren,
|
||||
events: ann.events,
|
||||
host: isPresent(ann.host) ? MapWrapper.createFromStringMap(ann.host) : null,
|
||||
properties: ann.properties,
|
||||
type: meta instanceof ComponentMetadata ? RenderDirectiveMetadata.COMPONENT_TYPE :
|
||||
RenderDirectiveMetadata.DIRECTIVE_TYPE,
|
||||
selector: meta.selector,
|
||||
compileChildren: meta.compileChildren,
|
||||
events: meta.events,
|
||||
host: isPresent(meta.host) ? MapWrapper.createFromStringMap(meta.host) : null,
|
||||
properties: meta.properties,
|
||||
readAttributes: DirectiveBinding._readAttributes(deps),
|
||||
|
||||
callOnDestroy: hasLifecycleHook(LifecycleEvent.OnDestroy, rb.key.token, ann),
|
||||
callOnChanges: hasLifecycleHook(LifecycleEvent.OnChanges, rb.key.token, ann),
|
||||
callDoCheck: hasLifecycleHook(LifecycleEvent.DoCheck, rb.key.token, ann),
|
||||
callOnInit: hasLifecycleHook(LifecycleEvent.OnInit, rb.key.token, ann),
|
||||
callOnDestroy: hasLifecycleHook(LifecycleEvent.OnDestroy, rb.key.token, meta),
|
||||
callOnChanges: hasLifecycleHook(LifecycleEvent.OnChanges, rb.key.token, meta),
|
||||
callDoCheck: hasLifecycleHook(LifecycleEvent.DoCheck, rb.key.token, meta),
|
||||
callOnInit: hasLifecycleHook(LifecycleEvent.OnInit, rb.key.token, meta),
|
||||
callAfterContentInit: hasLifecycleHook(LifecycleEvent.AfterContentInit, rb.key.token, meta),
|
||||
callAfterContentChecked:
|
||||
hasLifecycleHook(LifecycleEvent.AfterContentChecked, rb.key.token, ann),
|
||||
hasLifecycleHook(LifecycleEvent.AfterContentChecked, rb.key.token, meta),
|
||||
callAfterViewInit: hasLifecycleHook(LifecycleEvent.AfterViewInit, rb.key.token, meta),
|
||||
callAfterViewChecked: hasLifecycleHook(LifecycleEvent.AfterViewChecked, rb.key.token, meta),
|
||||
|
||||
changeDetection: ann instanceof ComponentMetadata ? ann.changeDetection : null,
|
||||
changeDetection: meta instanceof ComponentMetadata ? meta.changeDetection : null,
|
||||
|
||||
exportAs: ann.exportAs
|
||||
exportAs: meta.exportAs
|
||||
});
|
||||
return new DirectiveBinding(rb.key, rb.factory, deps, resolvedBindings, resolvedViewBindings,
|
||||
metadata);
|
||||
|
||||
@@ -29,9 +29,30 @@ export interface DoCheck { doCheck(): boolean; }
|
||||
*/
|
||||
export interface OnDestroy { onDestroy(): void; }
|
||||
|
||||
/**
|
||||
* Defines lifecycle method
|
||||
* {@link metadata/LifeCycleEvent#AfterContentInit `LifeCycleEvent.afterContentInit`}
|
||||
* called when the bindings of all its content children have been checked the first time.
|
||||
*/
|
||||
export interface AfterContentInit { afterContentInit(): void; }
|
||||
|
||||
/**
|
||||
* Defines lifecycle method
|
||||
* {@link metadata/LifeCycleEvent#AfterContentChecked `LifeCycleEvent.afterContentChecked`}
|
||||
* called when the bindings of all its view children have been changed.
|
||||
* called when the bindings of all its content children have been checked.
|
||||
*/
|
||||
export interface AfterContentChecked { afterContentChecked(): void; }
|
||||
|
||||
/**
|
||||
* Defines lifecycle method
|
||||
* {@link metadata/LifeCycleEvent#AfterViewInit `LifeCycleEvent.afterViewInit`}
|
||||
* called when the bindings of all its view children have been checked the first time.
|
||||
*/
|
||||
export interface AfterViewInit { afterViewInit(): void; }
|
||||
|
||||
/**
|
||||
* Defines lifecycle method
|
||||
* {@link metadata/LifeCycleEvent#AfterViewChecked `LifeCycleEvent.afterViewChecked`}
|
||||
* called when the bindings of all its view children have been checked.
|
||||
*/
|
||||
export interface AfterViewChecked { afterViewChecked(): void; }
|
||||
|
||||
@@ -191,7 +191,10 @@ export class BindingRecordsCreator {
|
||||
this._directiveRecordsMap.set(
|
||||
id, new DirectiveRecord({
|
||||
directiveIndex: new DirectiveIndex(boundElementIndex, directiveIndex),
|
||||
callAfterContentInit: directiveMetadata.callAfterContentInit,
|
||||
callAfterContentChecked: directiveMetadata.callAfterContentChecked,
|
||||
callAfterViewInit: directiveMetadata.callAfterViewInit,
|
||||
callAfterViewChecked: directiveMetadata.callAfterViewChecked,
|
||||
callOnChanges: directiveMetadata.callOnChanges,
|
||||
callDoCheck: directiveMetadata.callDoCheck,
|
||||
callOnInit: directiveMetadata.callOnInit,
|
||||
|
||||
@@ -212,6 +212,10 @@ export class AppView implements ChangeDispatcher, RenderEventDispatcher {
|
||||
}
|
||||
}
|
||||
|
||||
notifyAfterViewChecked(): void {
|
||||
// required for query
|
||||
}
|
||||
|
||||
getDirectiveFor(directive: DirectiveIndex): any {
|
||||
var elementInjector = this.elementInjectors[this.elementOffset + directive.elementIndex];
|
||||
return elementInjector.getDirectiveAtIndex(directive.directiveIndex);
|
||||
|
||||
@@ -961,7 +961,30 @@ export enum LifecycleEvent {
|
||||
DoCheck,
|
||||
|
||||
/**
|
||||
* Notify a directive when the bindings of all its view children have been checked (whether they
|
||||
* Notify a directive when the bindings of all its content children have been checked the first
|
||||
* time (whether they
|
||||
* have changed or not).
|
||||
*
|
||||
* ## Example
|
||||
*
|
||||
* ```
|
||||
* @Directive({
|
||||
* selector: '[class-set]',
|
||||
* lifecycle: [LifecycleEvent.AfterContentInit]
|
||||
* })
|
||||
* class ClassSet {
|
||||
*
|
||||
* afterContentInit() {
|
||||
* }
|
||||
*
|
||||
* }
|
||||
* ```
|
||||
*/
|
||||
AfterContentInit,
|
||||
|
||||
/**
|
||||
* Notify a directive when the bindings of all its content children have been checked (whether
|
||||
* they
|
||||
* have changed or not).
|
||||
*
|
||||
* ## Example
|
||||
@@ -979,7 +1002,50 @@ export enum LifecycleEvent {
|
||||
* }
|
||||
* ```
|
||||
*/
|
||||
AfterContentChecked
|
||||
AfterContentChecked,
|
||||
|
||||
/**
|
||||
* Notify a directive when the bindings of all its view children have been checked the first time
|
||||
* (whether they
|
||||
* have changed or not).
|
||||
*
|
||||
* ## Example
|
||||
*
|
||||
* ```
|
||||
* @Directive({
|
||||
* selector: '[class-set]',
|
||||
* lifecycle: [LifecycleEvent.AfterViewInit]
|
||||
* })
|
||||
* class ClassSet {
|
||||
*
|
||||
* afterViewInit() {
|
||||
* }
|
||||
*
|
||||
* }
|
||||
* ```
|
||||
*/
|
||||
AfterViewInit,
|
||||
|
||||
/**
|
||||
* Notify a directive when the bindings of all its view children have been checked (whether they
|
||||
* have changed or not).
|
||||
*
|
||||
* ## Example
|
||||
*
|
||||
* ```
|
||||
* @Directive({
|
||||
* selector: '[class-set]',
|
||||
* lifecycle: [LifecycleEvent.AfterViewChecked]
|
||||
* })
|
||||
* class ClassSet {
|
||||
*
|
||||
* afterViewChecked() {
|
||||
* }
|
||||
*
|
||||
* }
|
||||
* ```
|
||||
*/
|
||||
AfterViewChecked
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -157,7 +157,10 @@ export class RenderDirectiveMetadata {
|
||||
callOnChanges: boolean;
|
||||
callDoCheck: boolean;
|
||||
callOnInit: boolean;
|
||||
callAfterContentInit: boolean;
|
||||
callAfterContentChecked: boolean;
|
||||
callAfterViewInit: boolean;
|
||||
callAfterViewChecked: boolean;
|
||||
changeDetection: ChangeDetectionStrategy;
|
||||
exportAs: string;
|
||||
hostListeners: Map<string, string>;
|
||||
@@ -169,7 +172,8 @@ export class RenderDirectiveMetadata {
|
||||
|
||||
constructor({id, selector, compileChildren, events, hostListeners, hostProperties, hostAttributes,
|
||||
properties, readAttributes, type, callOnDestroy, callOnChanges, callDoCheck,
|
||||
callOnInit, callAfterContentChecked, changeDetection, exportAs}: {
|
||||
callOnInit, callAfterContentInit, callAfterContentChecked, callAfterViewInit,
|
||||
callAfterViewChecked, changeDetection, exportAs}: {
|
||||
id?: string,
|
||||
selector?: string,
|
||||
compileChildren?: boolean,
|
||||
@@ -184,7 +188,10 @@ export class RenderDirectiveMetadata {
|
||||
callOnChanges?: boolean,
|
||||
callDoCheck?: boolean,
|
||||
callOnInit?: boolean,
|
||||
callAfterContentInit?: boolean,
|
||||
callAfterContentChecked?: boolean,
|
||||
callAfterViewInit?: boolean,
|
||||
callAfterViewChecked?: boolean,
|
||||
changeDetection?: ChangeDetectionStrategy,
|
||||
exportAs?: string
|
||||
}) {
|
||||
@@ -202,14 +209,18 @@ export class RenderDirectiveMetadata {
|
||||
this.callOnChanges = callOnChanges;
|
||||
this.callDoCheck = callDoCheck;
|
||||
this.callOnInit = callOnInit;
|
||||
this.callAfterContentInit = callAfterContentInit;
|
||||
this.callAfterContentChecked = callAfterContentChecked;
|
||||
this.callAfterViewInit = callAfterViewInit;
|
||||
this.callAfterViewChecked = callAfterViewChecked;
|
||||
this.changeDetection = changeDetection;
|
||||
this.exportAs = exportAs;
|
||||
}
|
||||
|
||||
static create({id, selector, compileChildren, events, host, properties, readAttributes, type,
|
||||
callOnDestroy, callOnChanges, callDoCheck, callOnInit, callAfterContentChecked,
|
||||
changeDetection, exportAs}: {
|
||||
callOnDestroy, callOnChanges, callDoCheck, callOnInit, callAfterContentInit,
|
||||
callAfterContentChecked, callAfterViewInit, callAfterViewChecked, changeDetection,
|
||||
exportAs}: {
|
||||
id?: string,
|
||||
selector?: string,
|
||||
compileChildren?: boolean,
|
||||
@@ -222,7 +233,10 @@ export class RenderDirectiveMetadata {
|
||||
callOnChanges?: boolean,
|
||||
callDoCheck?: boolean,
|
||||
callOnInit?: boolean,
|
||||
callAfterContentInit?: boolean,
|
||||
callAfterContentChecked?: boolean,
|
||||
callAfterViewInit?: boolean,
|
||||
callAfterViewChecked?: boolean,
|
||||
changeDetection?: ChangeDetectionStrategy,
|
||||
exportAs?: string
|
||||
}): RenderDirectiveMetadata {
|
||||
@@ -258,7 +272,10 @@ export class RenderDirectiveMetadata {
|
||||
callOnChanges: callOnChanges,
|
||||
callDoCheck: callDoCheck,
|
||||
callOnInit: callOnInit,
|
||||
callAfterContentInit: callAfterContentInit,
|
||||
callAfterContentChecked: callAfterContentChecked,
|
||||
callAfterViewInit: callAfterViewInit,
|
||||
callAfterViewChecked: callAfterViewChecked,
|
||||
changeDetection: changeDetection,
|
||||
exportAs: exportAs
|
||||
});
|
||||
|
||||
@@ -19,6 +19,8 @@ export class Log {
|
||||
return (a1 = null, a2 = null, a3 = null, a4 = null, a5 = null) => { this._result.push(value); }
|
||||
}
|
||||
|
||||
clear(): void { this._result = []; }
|
||||
|
||||
result(): string { return ListWrapper.join(this._result, "; "); }
|
||||
}
|
||||
|
||||
|
||||
@@ -284,13 +284,21 @@ class _DirectiveUpdating {
|
||||
directiveIndex: new DirectiveIndex(0, 0),
|
||||
callOnChanges: true,
|
||||
callDoCheck: true,
|
||||
callAfterContentChecked: true
|
||||
callOnInit: true,
|
||||
callAfterContentInit: true,
|
||||
callAfterContentChecked: true,
|
||||
callAfterViewInit: true,
|
||||
callAfterViewChecked: true
|
||||
}),
|
||||
new DirectiveRecord({
|
||||
directiveIndex: new DirectiveIndex(0, 1),
|
||||
callOnChanges: true,
|
||||
callDoCheck: true,
|
||||
callAfterContentChecked: true
|
||||
callOnInit: true,
|
||||
callAfterContentInit: true,
|
||||
callAfterContentChecked: true,
|
||||
callAfterViewInit: true,
|
||||
callAfterViewChecked: true
|
||||
})
|
||||
];
|
||||
|
||||
@@ -298,7 +306,11 @@ class _DirectiveUpdating {
|
||||
directiveIndex: new DirectiveIndex(0, 0),
|
||||
callOnChanges: false,
|
||||
callDoCheck: false,
|
||||
callAfterContentChecked: false
|
||||
callOnInit: false,
|
||||
callAfterContentInit: false,
|
||||
callAfterContentChecked: false,
|
||||
callAfterViewInit: false,
|
||||
callAfterViewChecked: false
|
||||
});
|
||||
|
||||
/**
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
@@ -88,6 +88,25 @@ main() {
|
||||
});
|
||||
});
|
||||
|
||||
describe("afterContentInit", () {
|
||||
it("should be true when the directive implements AfterContentInit", () {
|
||||
expect(
|
||||
metadata(DirectiveImplementingAfterContentInit, new Directive())
|
||||
.callAfterContentInit).toBe(true);
|
||||
});
|
||||
|
||||
it("should be true when the lifecycle includes afterContentInit", () {
|
||||
expect(metadata(DirectiveNoHooks,
|
||||
new Directive(lifecycle: [LifecycleEvent.AfterContentInit]))
|
||||
.callAfterContentInit).toBe(true);
|
||||
});
|
||||
|
||||
it("should be false otherwise", () {
|
||||
expect(metadata(DirectiveNoHooks, new Directive())
|
||||
.callAfterContentInit).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("afterContentChecked", () {
|
||||
it("should be true when the directive implements AfterContentChecked", () {
|
||||
expect(
|
||||
@@ -106,6 +125,44 @@ main() {
|
||||
.callAfterContentChecked).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("afterViewInit", () {
|
||||
it("should be true when the directive implements AfterViewInit", () {
|
||||
expect(
|
||||
metadata(DirectiveImplementingAfterViewInit, new Directive())
|
||||
.callAfterViewInit).toBe(true);
|
||||
});
|
||||
|
||||
it("should be true when the lifecycle includes afterViewInit", () {
|
||||
expect(metadata(DirectiveNoHooks,
|
||||
new Directive(lifecycle: [LifecycleEvent.AfterViewInit]))
|
||||
.callAfterViewInit).toBe(true);
|
||||
});
|
||||
|
||||
it("should be false otherwise", () {
|
||||
expect(metadata(DirectiveNoHooks, new Directive())
|
||||
.callAfterViewInit).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("afterViewChecked", () {
|
||||
it("should be true when the directive implements AfterViewChecked", () {
|
||||
expect(
|
||||
metadata(DirectiveImplementingAfterViewChecked, new Directive())
|
||||
.callAfterViewChecked).toBe(true);
|
||||
});
|
||||
|
||||
it("should be true when the lifecycle includes afterViewChecked", () {
|
||||
expect(metadata(DirectiveNoHooks,
|
||||
new Directive(lifecycle: [LifecycleEvent.AfterViewChecked]))
|
||||
.callAfterViewChecked).toBe(true);
|
||||
});
|
||||
|
||||
it("should be false otherwise", () {
|
||||
expect(metadata(DirectiveNoHooks, new Directive())
|
||||
.callAfterViewChecked).toBe(false);
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
@@ -128,6 +185,18 @@ class DirectiveImplementingOnDestroy implements OnDestroy {
|
||||
onDestroy() {}
|
||||
}
|
||||
|
||||
class DirectiveImplementingAfterContentInit implements AfterContentInit {
|
||||
afterContentInit() {}
|
||||
}
|
||||
|
||||
class DirectiveImplementingAfterContentChecked implements AfterContentChecked {
|
||||
afterContentChecked() {}
|
||||
}
|
||||
|
||||
class DirectiveImplementingAfterViewInit implements AfterViewInit {
|
||||
afterViewInit() {}
|
||||
}
|
||||
|
||||
class DirectiveImplementingAfterViewChecked implements AfterViewChecked {
|
||||
afterViewChecked() {}
|
||||
}
|
||||
|
||||
@@ -102,6 +102,26 @@ export function main() {
|
||||
});
|
||||
});
|
||||
|
||||
describe("afterContentInit", () => {
|
||||
it("should be true when the directive has the afterContentInit method", () => {
|
||||
expect(metadata(DirectiveWithAfterContentInitMethod, new DirectiveMetadata({}))
|
||||
.callAfterContentInit)
|
||||
.toBe(true);
|
||||
});
|
||||
|
||||
it("should be true when the lifecycle includes afterContentInit", () => {
|
||||
expect(metadata(DirectiveNoHooks,
|
||||
new DirectiveMetadata({lifecycle: [LifecycleEvent.AfterContentInit]}))
|
||||
.callAfterContentInit)
|
||||
.toBe(true);
|
||||
});
|
||||
|
||||
it("should be false otherwise", () => {
|
||||
expect(metadata(DirectiveNoHooks, new DirectiveMetadata()).callAfterContentInit)
|
||||
.toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("afterContentChecked", () => {
|
||||
it("should be true when the directive has the afterContentChecked method", () => {
|
||||
expect(metadata(DirectiveWithAfterContentCheckedMethod, new DirectiveMetadata({}))
|
||||
@@ -121,6 +141,46 @@ export function main() {
|
||||
.toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
describe("afterViewInit", () => {
|
||||
it("should be true when the directive has the afterViewInit method", () => {
|
||||
expect(metadata(DirectiveWithAfterViewInitMethod, new DirectiveMetadata({}))
|
||||
.callAfterViewInit)
|
||||
.toBe(true);
|
||||
});
|
||||
|
||||
it("should be true when the lifecycle includes afterViewInit", () => {
|
||||
expect(metadata(DirectiveNoHooks,
|
||||
new DirectiveMetadata({lifecycle: [LifecycleEvent.AfterViewInit]}))
|
||||
.callAfterViewInit)
|
||||
.toBe(true);
|
||||
});
|
||||
|
||||
it("should be false otherwise", () => {
|
||||
expect(metadata(DirectiveNoHooks, new DirectiveMetadata()).callAfterViewInit).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("afterViewChecked", () => {
|
||||
it("should be true when the directive has the afterViewChecked method", () => {
|
||||
expect(metadata(DirectiveWithAfterViewCheckedMethod, new DirectiveMetadata({}))
|
||||
.callAfterViewChecked)
|
||||
.toBe(true);
|
||||
});
|
||||
|
||||
it("should be true when the lifecycle includes afterViewChecked", () => {
|
||||
expect(metadata(DirectiveNoHooks,
|
||||
new DirectiveMetadata({lifecycle: [LifecycleEvent.AfterViewChecked]}))
|
||||
.callAfterViewChecked)
|
||||
.toBe(true);
|
||||
});
|
||||
|
||||
it("should be false otherwise", () => {
|
||||
expect(metadata(DirectiveNoHooks, new DirectiveMetadata()).callAfterViewChecked)
|
||||
.toBe(false);
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
@@ -143,6 +203,18 @@ class DirectiveWithOnDestroyMethod {
|
||||
onDestroy(_) {}
|
||||
}
|
||||
|
||||
class DirectiveWithAfterContentInitMethod {
|
||||
afterContentInit() {}
|
||||
}
|
||||
|
||||
class DirectiveWithAfterContentCheckedMethod {
|
||||
afterContentChecked() {}
|
||||
}
|
||||
|
||||
class DirectiveWithAfterViewInitMethod {
|
||||
afterViewInit() {}
|
||||
}
|
||||
|
||||
class DirectiveWithAfterViewCheckedMethod {
|
||||
afterViewChecked() {}
|
||||
}
|
||||
|
||||
@@ -9,6 +9,7 @@ import {
|
||||
it,
|
||||
xdescribe,
|
||||
xit,
|
||||
Log,
|
||||
TestComponentBuilder
|
||||
} from 'angular2/test_lib';
|
||||
|
||||
@@ -18,28 +19,26 @@ export function main() {
|
||||
describe('directive lifecycle integration spec', () => {
|
||||
|
||||
it('should invoke lifecycle methods onChanges > onInit > doCheck > afterContentChecked',
|
||||
inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async) => {
|
||||
inject([TestComponentBuilder, Log, AsyncTestCompleter], (tcb: TestComponentBuilder, log: Log,
|
||||
async) => {
|
||||
tcb.overrideView(
|
||||
MyComp,
|
||||
new ViewMetadata(
|
||||
{template: '<div [field]="123" lifecycle></div>', directives: [LifecycleDir]}))
|
||||
{template: '<div [field]="123" lifecycle></div>', directives: [LifecycleCmp]}))
|
||||
.createAsync(MyComp)
|
||||
.then((tc) => {
|
||||
var dir = tc.componentViewChildren[0].inject(LifecycleDir);
|
||||
tc.detectChanges();
|
||||
|
||||
expect(dir.log).toEqual(["onChanges", "onInit", "doCheck", "afterContentChecked"]);
|
||||
expect(log.result())
|
||||
.toEqual(
|
||||
"onChanges; onInit; doCheck; afterContentInit; afterContentChecked; child_doCheck; " +
|
||||
"afterViewInit; afterViewChecked");
|
||||
|
||||
log.clear();
|
||||
tc.detectChanges();
|
||||
|
||||
expect(dir.log).toEqual([
|
||||
"onChanges",
|
||||
"onInit",
|
||||
"doCheck",
|
||||
"afterContentChecked",
|
||||
"doCheck",
|
||||
"afterContentChecked"
|
||||
]);
|
||||
expect(log.result())
|
||||
.toEqual("doCheck; afterContentChecked; child_doCheck; afterViewChecked");
|
||||
|
||||
async.done();
|
||||
});
|
||||
@@ -48,29 +47,43 @@ export function main() {
|
||||
}
|
||||
|
||||
|
||||
@Directive({
|
||||
@Directive({selector: '[lifecycle-dir]', lifecycle: [LifecycleEvent.DoCheck]})
|
||||
class LifecycleDir {
|
||||
constructor(private log: Log) {}
|
||||
doCheck() { this.log.add("child_doCheck"); }
|
||||
}
|
||||
|
||||
@Component({
|
||||
selector: "[lifecycle]",
|
||||
properties: ['field'],
|
||||
lifecycle: [
|
||||
LifecycleEvent.OnChanges,
|
||||
LifecycleEvent.DoCheck,
|
||||
LifecycleEvent.OnInit,
|
||||
LifecycleEvent.AfterContentChecked
|
||||
LifecycleEvent.DoCheck,
|
||||
LifecycleEvent.AfterContentInit,
|
||||
LifecycleEvent.AfterContentChecked,
|
||||
LifecycleEvent.AfterViewInit,
|
||||
LifecycleEvent.AfterViewChecked
|
||||
]
|
||||
})
|
||||
class LifecycleDir {
|
||||
@View({template: `<div lifecycle-dir></div>`, directives: [LifecycleDir]})
|
||||
class LifecycleCmp {
|
||||
field;
|
||||
log: List<string>;
|
||||
constructor(private log: Log) {}
|
||||
|
||||
constructor() { this.log = []; }
|
||||
onChanges(_) { this.log.add("onChanges"); }
|
||||
|
||||
onChanges(_) { this.log.push("onChanges"); }
|
||||
onInit() { this.log.add("onInit"); }
|
||||
|
||||
onInit() { this.log.push("onInit"); }
|
||||
doCheck() { this.log.add("doCheck"); }
|
||||
|
||||
doCheck() { this.log.push("doCheck"); }
|
||||
afterContentInit() { this.log.add("afterContentInit"); }
|
||||
|
||||
afterContentChecked() { this.log.push("afterContentChecked"); }
|
||||
afterContentChecked() { this.log.add("afterContentChecked"); }
|
||||
|
||||
afterViewInit() { this.log.add("afterViewInit"); }
|
||||
|
||||
afterViewChecked() { this.log.add("afterViewChecked"); }
|
||||
}
|
||||
|
||||
@Component({selector: 'my-comp'})
|
||||
|
||||
@@ -389,4 +389,5 @@ class DummyDispatcher implements ChangeDispatcher {
|
||||
notifyOnBinding(bindingTarget, newValue) { throw "Should not be used"; }
|
||||
logBindingUpdate(bindingTarget, newValue) { throw "Should not be used"; }
|
||||
notifyAfterContentChecked() {}
|
||||
notifyAfterViewChecked() {}
|
||||
}
|
||||
|
||||
@@ -27,7 +27,10 @@ Map<String, dynamic> directiveMetadataToMap(RenderDirectiveMetadata meta) {
|
||||
["callDoCheck", meta.callDoCheck],
|
||||
["callOnInit", meta.callOnInit],
|
||||
["callOnChanges", meta.callOnChanges],
|
||||
["callAfterContentInit", meta.callAfterContentInit],
|
||||
["callAfterContentChecked", meta.callAfterContentChecked],
|
||||
["callAfterViewInit", meta.callAfterViewInit],
|
||||
["callAfterViewChecked", meta.callAfterViewChecked],
|
||||
["events", meta.events],
|
||||
["changeDetection", meta.changeDetection == null ? null : meta.changeDetection.index],
|
||||
["version", 1]
|
||||
@@ -57,7 +60,10 @@ RenderDirectiveMetadata directiveMetadataFromMap(Map<String, dynamic> map) {
|
||||
callDoCheck: (map["callDoCheck"] as bool),
|
||||
callOnChanges: (map["callOnChanges"] as bool),
|
||||
callOnInit: (map["callOnInit"] as bool),
|
||||
callAfterContentInit: (map["callAfterContentInit"] as bool),
|
||||
callAfterContentChecked: (map["callAfterContentChecked"] as bool),
|
||||
callAfterViewInit: (map["callAfterViewInit"] as bool),
|
||||
callAfterViewChecked: (map["callAfterViewChecked"] as bool),
|
||||
events: (_cloneIfPresent(map["events"]) as List<String>),
|
||||
changeDetection: map["changeDetection"] == null ? null
|
||||
: ChangeDetectionStrategy.values[map["changeDetection"] as int]);
|
||||
|
||||
@@ -63,7 +63,10 @@ class _DirectiveMetadataVisitor extends Object
|
||||
bool _callOnChange;
|
||||
bool _callOnCheck;
|
||||
bool _callOnInit;
|
||||
bool _callAfterContentInit;
|
||||
bool _callAfterContentChecked;
|
||||
bool _callAfterViewInit;
|
||||
bool _callAfterViewChecked;
|
||||
ChangeDetectionStrategy _changeDetection;
|
||||
List<String> _events;
|
||||
|
||||
@@ -83,7 +86,10 @@ class _DirectiveMetadataVisitor extends Object
|
||||
_callOnChange = false;
|
||||
_callOnCheck = false;
|
||||
_callOnInit = false;
|
||||
_callAfterContentInit = false;
|
||||
_callAfterContentChecked = false;
|
||||
_callAfterViewInit = false;
|
||||
_callAfterViewChecked = false;
|
||||
_changeDetection = null;
|
||||
_events = [];
|
||||
}
|
||||
@@ -100,7 +106,10 @@ class _DirectiveMetadataVisitor extends Object
|
||||
callOnChanges: _callOnChange,
|
||||
callDoCheck: _callOnCheck,
|
||||
callOnInit: _callOnInit,
|
||||
callAfterContentInit: _callAfterContentInit,
|
||||
callAfterContentChecked: _callAfterContentChecked,
|
||||
callAfterViewInit: _callAfterViewInit,
|
||||
callAfterViewChecked: _callAfterViewChecked,
|
||||
changeDetection: _changeDetection,
|
||||
events: _events);
|
||||
|
||||
@@ -274,7 +283,10 @@ class _DirectiveMetadataVisitor extends Object
|
||||
_callOnChange = lifecycleEvents.contains("OnChanges");
|
||||
_callOnCheck = lifecycleEvents.contains("DoCheck");
|
||||
_callOnInit = lifecycleEvents.contains("OnInit");
|
||||
_callAfterContentInit = lifecycleEvents.contains("AfterContentInit");
|
||||
_callAfterContentChecked = lifecycleEvents.contains("AfterContentChecked");
|
||||
_callAfterViewInit = lifecycleEvents.contains("AfterViewInit");
|
||||
_callAfterViewChecked = lifecycleEvents.contains("AfterViewChecked");
|
||||
}
|
||||
|
||||
void _populateEvents(Expression eventsValue) {
|
||||
|
||||
@@ -33,13 +33,34 @@ const _ON_INIT_INTERFACES = const [
|
||||
const ClassDescriptor(
|
||||
'OnInit', 'package:angular2/src/core/compiler/interfaces.dart'),
|
||||
];
|
||||
const _ON_ALL_CHANGES_DONE_INTERFACES = const [
|
||||
const _ON_AFTER_CONTENT_INIT_INTERFACES = const [
|
||||
const ClassDescriptor('AfterContentInit', 'package:angular2/angular2.dart'),
|
||||
const ClassDescriptor(
|
||||
'AfterContentInit', 'package:angular2/metadata.dart'),
|
||||
const ClassDescriptor(
|
||||
'AfterContentInit', 'package:angular2/src/core/compiler/interfaces.dart')
|
||||
];
|
||||
const _ON_AFTER_CONTENT_CHECKED_INTERFACES = const [
|
||||
const ClassDescriptor('AfterContentChecked', 'package:angular2/angular2.dart'),
|
||||
const ClassDescriptor(
|
||||
'AfterContentChecked', 'package:angular2/metadata.dart'),
|
||||
const ClassDescriptor(
|
||||
'AfterContentChecked', 'package:angular2/src/core/compiler/interfaces.dart')
|
||||
];
|
||||
const _ON_AFTER_VIEW_INIT_INTERFACES = const [
|
||||
const ClassDescriptor('AfterViewInit', 'package:angular2/angular2.dart'),
|
||||
const ClassDescriptor(
|
||||
'AfterViewInit', 'package:angular2/metadata.dart'),
|
||||
const ClassDescriptor(
|
||||
'AfterViewInit', 'package:angular2/src/core/compiler/interfaces.dart')
|
||||
];
|
||||
const _ON_AFTER_VIEW_CHECKED_INTERFACES = const [
|
||||
const ClassDescriptor('AfterViewChecked', 'package:angular2/angular2.dart'),
|
||||
const ClassDescriptor(
|
||||
'AfterViewChecked', 'package:angular2/metadata.dart'),
|
||||
const ClassDescriptor(
|
||||
'AfterViewChecked', 'package:angular2/src/core/compiler/interfaces.dart')
|
||||
];
|
||||
|
||||
/// Checks if a given [Annotation] matches any of the given
|
||||
/// [ClassDescriptors].
|
||||
@@ -52,7 +73,10 @@ class InterfaceMatcher extends ClassMatcherBase {
|
||||
..addAll(_ON_DESTROY_INTERFACES)
|
||||
..addAll(_ON_CHECK_INTERFACES)
|
||||
..addAll(_ON_INIT_INTERFACES)
|
||||
..addAll(_ON_ALL_CHANGES_DONE_INTERFACES));
|
||||
..addAll(_ON_AFTER_CONTENT_INIT_INTERFACES)
|
||||
..addAll(_ON_AFTER_CONTENT_CHECKED_INTERFACES)
|
||||
..addAll(_ON_AFTER_VIEW_INIT_INTERFACES)
|
||||
..addAll(_ON_AFTER_VIEW_CHECKED_INTERFACES));
|
||||
}
|
||||
|
||||
/// Checks if an [Identifier] implements [OnChanges].
|
||||
@@ -71,7 +95,19 @@ class InterfaceMatcher extends ClassMatcherBase {
|
||||
bool isOnInit(Identifier typeName, AssetId assetId) =>
|
||||
implements(firstMatch(typeName, assetId), _ON_INIT_INTERFACES);
|
||||
|
||||
/// Checks if an [Identifier] implements [AfterContentInit].
|
||||
bool isAfterContentInit(Identifier typeName, AssetId assetId) => implements(
|
||||
firstMatch(typeName, assetId), _ON_AFTER_CONTENT_INIT_INTERFACES);
|
||||
|
||||
/// Checks if an [Identifier] implements [AfterContentChecked].
|
||||
bool isAfterContentChecked(Identifier typeName, AssetId assetId) => implements(
|
||||
firstMatch(typeName, assetId), _ON_ALL_CHANGES_DONE_INTERFACES);
|
||||
firstMatch(typeName, assetId), _ON_AFTER_CONTENT_CHECKED_INTERFACES);
|
||||
|
||||
/// Checks if an [Identifier] implements [AfterViewInit].
|
||||
bool isAfterViewInit(Identifier typeName, AssetId assetId) => implements(
|
||||
firstMatch(typeName, assetId), _ON_AFTER_VIEW_INIT_INTERFACES);
|
||||
|
||||
/// Checks if an [Identifier] implements [AfterViewChecked].
|
||||
bool isAfterViewChecked(Identifier typeName, AssetId assetId) => implements(
|
||||
firstMatch(typeName, assetId), _ON_AFTER_VIEW_CHECKED_INTERFACES);
|
||||
}
|
||||
|
||||
@@ -271,10 +271,22 @@ class AnnotationsTransformVisitor extends ToSourceVisitor {
|
||||
_ifaceLifecycleEntries.add('${LifecycleEvent.OnInit}');
|
||||
populateImport(name);
|
||||
}
|
||||
if (_interfaceMatcher.isAfterContentInit(name, _assetId)) {
|
||||
_ifaceLifecycleEntries.add('${LifecycleEvent.AfterContentInit}');
|
||||
populateImport(name);
|
||||
}
|
||||
if (_interfaceMatcher.isAfterContentChecked(name, _assetId)) {
|
||||
_ifaceLifecycleEntries.add('${LifecycleEvent.AfterContentChecked}');
|
||||
populateImport(name);
|
||||
}
|
||||
if (_interfaceMatcher.isAfterViewInit(name, _assetId)) {
|
||||
_ifaceLifecycleEntries.add('${LifecycleEvent.AfterViewInit}');
|
||||
populateImport(name);
|
||||
}
|
||||
if (_interfaceMatcher.isAfterViewChecked(name, _assetId)) {
|
||||
_ifaceLifecycleEntries.add('${LifecycleEvent.AfterViewChecked}');
|
||||
populateImport(name);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
|
||||
+19
-14
@@ -143,15 +143,15 @@ class _CodegenState {
|
||||
var $_CHANGES_LOCAL = null;
|
||||
|
||||
${_records.map(_genRecord).join('')}
|
||||
|
||||
${_names.getAlreadyCheckedName()} = true;
|
||||
}
|
||||
|
||||
${_maybeGenHandleEventInternal()}
|
||||
|
||||
${_genCheckNoChanges()}
|
||||
|
||||
${_maybeGenCallAfterContentChecked()}
|
||||
${_maybeGenAfterContentLifecycleCallbacks()}
|
||||
|
||||
${_maybeGenAfterViewLifecycleCallbacks()}
|
||||
|
||||
${_maybeGenHydrateDirectives()}
|
||||
|
||||
@@ -260,19 +260,24 @@ class _CodegenState {
|
||||
'{ $hydrateDirectivesCode $hydrateDetectorsCode }';
|
||||
}
|
||||
|
||||
/// Generates calls to `afterContentChecked` for all `Directive`s that request
|
||||
/// them.
|
||||
String _maybeGenCallAfterContentChecked() {
|
||||
// NOTE(kegluneq): Order is important!
|
||||
var directiveNotifications = _directiveRecords.reversed
|
||||
.where((rec) => rec.callAfterContentChecked)
|
||||
.map((rec) =>
|
||||
'${_names.getDirectiveName(rec.directiveIndex)}.afterContentChecked();');
|
||||
|
||||
String _maybeGenAfterContentLifecycleCallbacks() {
|
||||
var directiveNotifications = _logic.genContentLifecycleCallbacks(_directiveRecords);
|
||||
if (directiveNotifications.isNotEmpty) {
|
||||
return '''
|
||||
void callAfterContentChecked() {
|
||||
${_names.getDispatcherName()}.notifyAfterContentChecked();
|
||||
void afterContentLifecycleCallbacksInternal() {
|
||||
${directiveNotifications.join('')}
|
||||
}
|
||||
''';
|
||||
} else {
|
||||
return '';
|
||||
}
|
||||
}
|
||||
|
||||
String _maybeGenAfterViewLifecycleCallbacks() {
|
||||
var directiveNotifications = _logic.genViewLifecycleCallbacks(_directiveRecords);
|
||||
if (directiveNotifications.isNotEmpty) {
|
||||
return '''
|
||||
void afterViewLifecycleCallbacksInternal() {
|
||||
${directiveNotifications.join('')}
|
||||
}
|
||||
''';
|
||||
|
||||
@@ -26,7 +26,10 @@ main() {
|
||||
callOnChanges: true,
|
||||
callDoCheck: true,
|
||||
callOnInit: true,
|
||||
callAfterContentInit: true,
|
||||
callAfterContentChecked: true,
|
||||
callAfterViewInit: true,
|
||||
callAfterViewChecked: true,
|
||||
events: ["onFoo", "onBar"],
|
||||
changeDetection: ChangeDetectionStrategy.CheckOnce);
|
||||
var map = directiveMetadataToMap(someComponent);
|
||||
@@ -46,7 +49,10 @@ main() {
|
||||
expect(map["callDoCheck"]).toEqual(true);
|
||||
expect(map["callOnChanges"]).toEqual(true);
|
||||
expect(map["callOnInit"]).toEqual(true);
|
||||
expect(map["callAfterContentInit"]).toEqual(true);
|
||||
expect(map["callAfterContentChecked"]).toEqual(true);
|
||||
expect(map["callAfterViewInit"]).toEqual(true);
|
||||
expect(map["callAfterViewChecked"]).toEqual(true);
|
||||
expect(map["exportAs"]).toEqual("aaa");
|
||||
expect(map["events"]).toEqual(["onFoo", "onBar"]);
|
||||
expect(map["changeDetection"]).toEqual(ChangeDetectionStrategy.CheckOnce.index);
|
||||
@@ -67,7 +73,10 @@ main() {
|
||||
["callDoCheck", true],
|
||||
["callOnInit", true],
|
||||
["callOnChanges", true],
|
||||
["callAfterContentInit", true],
|
||||
["callAfterContentChecked", true],
|
||||
["callAfterViewInit", true],
|
||||
["callAfterViewChecked", true],
|
||||
["events", ["onFoo", "onBar"]],
|
||||
["changeDetection", ChangeDetectionStrategy.CheckOnce.index]
|
||||
]);
|
||||
@@ -89,7 +98,10 @@ main() {
|
||||
expect(meta.callDoCheck).toEqual(true);
|
||||
expect(meta.callOnInit).toEqual(true);
|
||||
expect(meta.callOnChanges).toEqual(true);
|
||||
expect(meta.callAfterContentInit).toEqual(true);
|
||||
expect(meta.callAfterContentChecked).toEqual(true);
|
||||
expect(meta.callAfterViewInit).toEqual(true);
|
||||
expect(meta.callAfterViewChecked).toEqual(true);
|
||||
expect(meta.events).toEqual(["onFoo", "onBar"]);
|
||||
expect(meta.changeDetection).toEqual(ChangeDetectionStrategy.CheckOnce);
|
||||
});
|
||||
|
||||
@@ -106,7 +106,10 @@ void allTests() {
|
||||
expect(metadata.callOnChanges).toBe(true);
|
||||
expect(metadata.callDoCheck).toBe(true);
|
||||
expect(metadata.callOnInit).toBe(true);
|
||||
expect(metadata.callAfterContentInit).toBe(true);
|
||||
expect(metadata.callAfterContentChecked).toBe(true);
|
||||
expect(metadata.callAfterViewInit).toBe(true);
|
||||
expect(metadata.callAfterViewChecked).toBe(true);
|
||||
});
|
||||
|
||||
it('should parse events.', () async {
|
||||
|
||||
+4
-1
@@ -17,7 +17,10 @@ void initReflector(reflector) {
|
||||
LifecycleEvent.OnDestroy,
|
||||
LifecycleEvent.OnInit,
|
||||
LifecycleEvent.DoCheck,
|
||||
LifecycleEvent.AfterContentChecked
|
||||
LifecycleEvent.AfterContentInit,
|
||||
LifecycleEvent.AfterContentChecked,
|
||||
LifecycleEvent.AfterViewInit,
|
||||
LifecycleEvent.AfterViewChecked
|
||||
])
|
||||
], const [
|
||||
const []
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user