honeymoose/playwright-java
1
0
Fork 0
mirror of synced 2026-08-05 06:56:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: use try resource in auth tests (#707)

Browse Source
This commit is contained in:
Yury Semikhatsky
2021-11-17 11:52:24 -08:00
committed by GitHub
parent f739ae28e8
commit 16c7b7f25e
2 changed files with 20 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
playwright/src/test/java/com/microsoft/playwright/Server.java
-2
View File
@@ -165,8 +165,6 @@ public class Server implements HttpHandler {
exchange.sendResponseHeaders(401, 0);
try (Writer writer = new OutputStreamWriter(exchange.getResponseBody())) {
writer.write("HTTP Error 401 Unauthorized: Access is denied");
// TODO: notify subscriber?
exchange.getResponseBody().close();
}
return;
}
playwright/src/test/java/com/microsoft/playwright/TestBrowserContextCredentials.java
+20 -22
View File
@@ -32,11 +32,8 @@ public class TestBrowserContextCredentials extends TestBase {
@DisabledIf(value="isChromiumHeadful", disabledReason="fail")
void shouldFailWithoutCredentials() {
server.setAuth("/empty.html", "user", "pass");
BrowserContext context = browser.newContext();
Page page = context.newPage();
Response response = page.navigate(server.EMPTY_PAGE);
assertEquals(401, response.status());
context.close();
}
void shouldWorkWithSetHTTPCredentials() {
@@ -46,34 +43,35 @@ public class TestBrowserContextCredentials extends TestBase {
@Test
void shouldWorkWithCorrectCredentials() {
server.setAuth("/empty.html", "user", "pass");
BrowserContext context = browser.newContext(new Browser.NewContextOptions()
.setHttpCredentials("user", "pass"));
Page page = context.newPage();
Response response = page.navigate(server.EMPTY_PAGE);
assertEquals(200, response.status());
context.close();
try (BrowserContext context = browser.newContext(new Browser.NewContextOptions()
.setHttpCredentials("user", "pass"))) {
Page page = context.newPage();
Response response = page.navigate(server.EMPTY_PAGE);
assertEquals(200, response.status());
}
}
@Test
void shouldFailWithWrongCredentials() {
server.setAuth("/empty.html", "user", "pass");
BrowserContext context = browser.newContext(new Browser.NewContextOptions().setHttpCredentials("foo", "bar"));
Page page = context.newPage();
Response response = page.navigate(server.EMPTY_PAGE);
assertEquals(401, response.status());
context.close();
try (BrowserContext context = browser.newContext(new Browser.NewContextOptions()
.setHttpCredentials("foo", "bar"))) {
Page page = context.newPage();
Response response = page.navigate(server.EMPTY_PAGE);
assertEquals(401, response.status());
}
}
@Test
void shouldReturnResourceBody() {
server.setAuth("/playground.html", "user", "pass");
BrowserContext context = browser.newContext(new Browser.NewContextOptions()
.setHttpCredentials("user", "pass"));
Page page = context.newPage();
Response response = page.navigate(server.PREFIX + "/playground.html");
assertEquals(200, response.status());
assertEquals("Playground", page.title());
assertTrue(new String(response.body()).contains("Playground"));
context.close();
try (BrowserContext context = browser.newContext(new Browser.NewContextOptions()
.setHttpCredentials("user", "pass"))) {
Page page = context.newPage();
Response response = page.navigate(server.PREFIX + "/playground.html");
assertEquals(200, response.status());
assertEquals("Playground", page.title());
assertTrue(new String(response.body()).contains("Playground"));
}
}
}