honeymoose/playwright-java
1
0
Fork 0
mirror of synced 2026-08-04 06:26:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(request): report raw request headers (#83)

Browse Source
This commit is contained in:
Yury Semikhatsky
2020-12-02 13:38:14 -08:00
committed by GitHub
parent 0def0377aa
commit 2c74b33de6
2 changed files with 14 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
playwright/src/main/java/com/microsoft/playwright/impl/ResponseImpl.java
+5 -6
View File
@@ -40,12 +40,11 @@ public class ResponseImpl extends ChannelOwner implements Response {
}
request = connection.getExistingObject(initializer.getAsJsonObject("request").get("guid").getAsString());
// TODO: uncomment when server changes are published.
// request.headers.clear();
// for (JsonElement e : initializer.getAsJsonArray("requestHeaders")) {
// JsonObject item = e.getAsJsonObject();
// request.headers.put(item.get("name").getAsString().toLowerCase(), item.get("value").getAsString());
// }
request.headers.clear();
for (JsonElement e : initializer.getAsJsonArray("requestHeaders")) {
JsonObject item = e.getAsJsonObject();
request.headers.put(item.get("name").getAsString().toLowerCase(), item.get("value").getAsString());
}
}
@Override
playwright/src/test/java/com/microsoft/playwright/TestNetworkRequest.java
+9 -10
View File
@@ -26,6 +26,7 @@ import java.util.List;
import java.util.Map;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Future;
import java.util.stream.Collectors;
import static com.microsoft.playwright.Page.EventType.REQUEST;
import static com.microsoft.playwright.Page.EventType.RESPONSE;
@@ -113,11 +114,10 @@ public class TestNetworkRequest extends TestBase {
writer.write("done");
}
});
// TODO: uncomment when server changes are published
// Response response = page.navigate(server.PREFIX + "/empty.html");
// Map<String, String> expectedHeaders = serverRequest.get().headers.entrySet().stream().collect(
// Collectors.toMap(Map.Entry::getKey, e -> e.getValue().get(0)));
// assertEquals(expectedHeaders, response.request().headers());
Response response = page.navigate(server.PREFIX + "/empty.html");
Map<String, String> expectedHeaders = serverRequest.get().headers.entrySet().stream().collect(
Collectors.toMap(e -> e.getKey().toLowerCase(), e -> e.getValue().get(0)));
assertEquals(expectedHeaders, response.request().headers());
}
@Test
@@ -138,11 +138,10 @@ public class TestNetworkRequest extends TestBase {
" return data.text();\n" +
"}", server.CROSS_PROCESS_PREFIX + "/something");
assertEquals("done", text);
// TODO: uncomment when server changes are published
// Response response = (Response) responsePromise.get().data();
// Map<String, String> expectedHeaders = serverRequest.get().headers.entrySet().stream().collect(
// Collectors.toMap(Map.Entry::getKey, e -> e.getValue().get(0)));
// assertEquals(expectedHeaders, response.request().headers());
Response response = (Response) responsePromise.get().data();
Map<String, String> expectedHeaders = serverRequest.get().headers.entrySet().stream().collect(
Collectors.toMap(e -> e.getKey().toLowerCase(), e -> e.getValue().get(0)));
assertEquals(expectedHeaders, response.request().headers());
}
@Test