fix(driver): set driver instance to null if an exception is thrown du… (#879)

.github/workflows/test.yml

@@ -31,14 +31,18 @@ jobs:
     - name: Build & Install
       run: mvn -B install -D skipTests --no-transfer-progress
     - name: Run tests
-      run: mvn test --no-transfer-progress --fail-at-end
+      run: mvn test -DexcludedGroups=isolated --no-transfer-progress --fail-at-end
       env:
         BROWSER: ${{ matrix.browser }}
     - name: Run tracing tests w/ sources
-      run: mvn test --no-transfer-progress --fail-at-end -D test=*TestTracing*
+      run: mvn test -DexcludedGroups=isolated --no-transfer-progress --fail-at-end -D test=*TestTracing*
       env:
         BROWSER: ${{ matrix.browser }}
         PLAYWRIGHT_JAVA_SRC: src/test/java
+    - name: Run driver throw tests
+      run: mvn test -Dgroups=driverThrowTest --no-transfer-progress --fail-at-end
+      env:
+        BROWSER: ${{ matrix.browser }}
     - name: Test Spring Boot Starter
       shell: bash
       env:
@@ -79,7 +83,12 @@ jobs:
       - name: Build & Install
         run: mvn -B install -D skipTests --no-transfer-progress
       - name: Run tests
-        run: mvn test --no-transfer-progress --fail-at-end
+        run: mvn test -DexcludedGroups=isolated --no-transfer-progress --fail-at-end
+        env:
+          BROWSER: chromium
+          BROWSER_CHANNEL: ${{ matrix.browser-channel }}
+      - name: Run driver throw tests
+        run: mvn test -Dgroups=driverThrowTest --no-transfer-progress --fail-at-end
         env:
           BROWSER: chromium
           BROWSER_CHANNEL: ${{ matrix.browser-channel }}

driver-bundle/src/test/java/com/microsoft/playwright/TestInstall.java

@@ -18,14 +18,14 @@ package com.microsoft.playwright;
 
 import com.microsoft.playwright.impl.Driver;
 import com.microsoft.playwright.impl.DriverJar;
-import org.junit.jupiter.api.BeforeAll;
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.*;
 import org.junit.jupiter.api.io.TempDir;
 
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
 import java.util.concurrent.TimeUnit;
 
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
@@ -43,6 +43,16 @@ public class TestInstall {
     System.clearProperty("playwright.driver.impl");
   }
 
+  @Test
+  @Tags({@Tag("isolated"), @Tag("driverThrowTest")})
+  void shouldThrowWhenBrowserPathIsInvalid() {
+    Map<String,String> env = new HashMap<>();
+    env.put("PLAYWRIGHT_BROWSERS_PATH", "/some/bad/path/that/should/not/exist/i/hope");
+
+    assertThrows(RuntimeException.class, () -> Driver.ensureDriverInstalled(env, true));
+    assertThrows(RuntimeException.class, () -> Driver.ensureDriverInstalled(env, true));
+  }
+
   @Test
   void playwrightCliInstalled() throws Exception {
     Path cli = Driver.ensureDriverInstalled(Collections.emptyMap(), false);

driver/src/main/java/com/microsoft/playwright/impl/Driver.java

@@ -55,8 +55,9 @@ public abstract class Driver {
         instance = createDriver();
         logMessage("initializing driver");
         instance.initialize(env, installBrowsers);
-        logMessage("driver inialized.");
+        logMessage("driver initialized.");
       } catch (Exception exception) {
+        instance = null;
         throw new RuntimeException("Failed to create driver", exception);
       }
     }