chore: trim comments
This commit is contained in:
@@ -110,8 +110,7 @@ class ChannelOwner extends LoggingSupport {
|
||||
return connection.sendMessageAsync(guid, method, params);
|
||||
}
|
||||
|
||||
// Fire-and-forget: the server intentionally never replies to this message,
|
||||
// so silently drop it if the object was collected.
|
||||
// Fire-and-forget: silently drop if the object was collected.
|
||||
void sendMessageNoReply(String method, JsonObject params) {
|
||||
if (wasCollected) {
|
||||
return;
|
||||
|
||||
@@ -136,7 +136,7 @@ public class Connection {
|
||||
return internalSendMessage(guid, method, params, true, true);
|
||||
}
|
||||
|
||||
// Fire-and-forget: the server intentionally never replies to this message.
|
||||
// Fire-and-forget: the server never replies.
|
||||
public void sendMessageNoReply(String guid, String method, JsonObject params) {
|
||||
internalSendMessage(guid, method, params, false, false);
|
||||
}
|
||||
@@ -269,8 +269,6 @@ public class Connection {
|
||||
} else {
|
||||
exception = new DriverException(message.error.error + callLog);
|
||||
}
|
||||
// The server attaches errorDetails to errors of the methods that declare them
|
||||
// in the protocol (currently only Frame.expect and Page.expectScreenshot).
|
||||
if (message.errorDetails != null) {
|
||||
exception = new ServerErrorWithDetails(exception, message.errorDetails, message.log);
|
||||
}
|
||||
|
||||
@@ -122,7 +122,6 @@ class FrameExpectResult {
|
||||
List<String> log;
|
||||
}
|
||||
|
||||
// Sent by the server as `errorDetails` when Frame.expect fails.
|
||||
class FrameExpectErrorDetails {
|
||||
FrameExpectResult.Received received;
|
||||
Boolean timedOut;
|
||||
|
||||
@@ -24,7 +24,6 @@ import com.microsoft.playwright.PlaywrightException;
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
|
||||
// Server error with the structured details declared in the protocol for the failed method.
|
||||
class ServerErrorWithDetails extends PlaywrightException {
|
||||
private final JsonObject errorDetails;
|
||||
private final JsonArray log;
|
||||
@@ -35,7 +34,7 @@ class ServerErrorWithDetails extends PlaywrightException {
|
||||
this.log = log;
|
||||
}
|
||||
|
||||
// Used to rethrow with the stack trace of the calling thread, see WaitableResult.get().
|
||||
// Rethrown with the calling thread's stack trace, see WaitableResult.get().
|
||||
ServerErrorWithDetails(ServerErrorWithDetails cause) {
|
||||
super(cause.getMessage(), cause);
|
||||
this.errorDetails = cause.errorDetails;
|
||||
|
||||
@@ -997,7 +997,7 @@ class Interface extends TypeDefinition {
|
||||
}
|
||||
|
||||
void writeTo(List<String> output, String offset) {
|
||||
// Interfaces with a static factory method delegating to the Impl class, see Method.writeTo.
|
||||
// Interfaces with a static factory method, see Method.writeTo.
|
||||
if (asList("Playwright", "FormData", "RequestOptions").contains(jsonName) && methods.stream().anyMatch(m -> "create".equals(m.jsonName))) {
|
||||
output.add("import com.microsoft.playwright.impl." + jsonName + "Impl;");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user