1
0
mirror of synced 2026-08-05 23:16:54 +00:00

chore: driver-side waitForTimeout (#651)

This commit is contained in:
Yury Semikhatsky
2021-10-22 08:58:00 -07:00
committed by GitHub
parent 9f2b482084
commit d291a64e11
2 changed files with 4 additions and 10 deletions
@@ -972,13 +972,9 @@ public class FrameImpl extends ChannelOwner implements Frame {
}
void waitForTimeoutImpl(double timeout) {
runUntil(() -> {}, new WaitableTimeout<Void>(timeout) {
@Override
public Void get() {
// Override to not throw.
return null;
}
});
JsonObject params = new JsonObject();
params.addProperty("timeout", timeout);
sendMessage("waitForTimeout", params);
}
@Override
@@ -233,7 +233,6 @@ public class TestBrowserTypeConnect extends TestBase {
try {
page.waitForTimeout(10);
} catch (PlaywrightException e) {
assertTrue(e.getMessage().contains("Browser has been closed"));
}
}
assertFalse(remote.isConnected());
@@ -258,7 +257,6 @@ public class TestBrowserTypeConnect extends TestBase {
try {
page.waitForTimeout(10);
} catch (PlaywrightException e) {
assertTrue(e.getMessage().contains("Browser has been closed"));
}
}
assertFalse(browser.isConnected());
@@ -266,7 +264,7 @@ public class TestBrowserTypeConnect extends TestBase {
page.waitForNavigation(() -> {});
fail("did not throw");
} catch (PlaywrightException e) {
assertTrue(e.getMessage().contains("Browser has been closed"));
assertTrue(e.getMessage().contains("Page closed") || e.getMessage().contains("Browser has been closed"), e.getMessage());
}
}