honeymoose/playwright-java
1
0
Fork 0
mirror of synced 2026-05-22 18:53:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: better assertThat error message for isChecked=false (#1221)

Browse Source 
Fixes #1209
This commit is contained in:
Yury Semikhatsky
2023-03-01 08:52:27 -08:00
committed by GitHub
parent 1dc938cc67
commit fe3e3e55dc
2 changed files with 46 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
playwright/src/main/java/com/microsoft/playwright/impl/LocatorAssertionsImpl.java
+10 -5
View File
@@ -288,8 +288,10 @@ public class LocatorAssertionsImpl extends AssertionsBase implements LocatorAsse
@Override
public void isChecked(IsCheckedOptions options) {
String expression = (options != null && options.checked != null && !options.checked) ? "to.be.unchecked" : "to.be.checked";
expectTrue(expression, "Locator expected to be checked", convertType(options, FrameExpectOptions.class));
boolean unchecked = options != null && options.checked != null && !options.checked;
String expression = unchecked ? "to.be.unchecked" : "to.be.checked";
String message = "Locator expected to be " + (unchecked ? "un" : "") + "checked";
expectTrue(expression, message, convertType(options, FrameExpectOptions.class));
}
@Override
@@ -301,7 +303,8 @@ public class LocatorAssertionsImpl extends AssertionsBase implements LocatorAsse
public void isEditable(IsEditableOptions options) {
FrameExpectOptions frameOptions = convertType(options, FrameExpectOptions.class);
boolean editable = options == null || options.editable == null || options.editable == true;
expectTrue(editable ? "to.be.editable" : "to.be.readonly", "Locator expected to be editable", frameOptions);
String message = "Locator expected to be " + (editable ? "editable" : "readonly");
expectTrue(editable ? "to.be.editable" : "to.be.readonly", message, frameOptions);
}
@Override
@@ -313,7 +316,8 @@ public class LocatorAssertionsImpl extends AssertionsBase implements LocatorAsse
public void isEnabled(IsEnabledOptions options) {
FrameExpectOptions frameOptions = convertType(options, FrameExpectOptions.class);
boolean enabled = options == null || options.enabled == null || options.enabled == true;
expectTrue(enabled ? "to.be.enabled" : "to.be.disabled", "Locator expected to be enabled", frameOptions);
String message = "Locator expected to be " + (enabled ? "enabled" : "disabled");
expectTrue(enabled ? "to.be.enabled" : "to.be.disabled", message, frameOptions);
}
@Override
@@ -339,7 +343,8 @@ public class LocatorAssertionsImpl extends AssertionsBase implements LocatorAsse
public void isVisible(IsVisibleOptions options) {
FrameExpectOptions frameOptions = convertType(options, FrameExpectOptions.class);
boolean visible = options == null || options.visible == null || options.visible == true;
expectTrue(visible ? "to.be.visible" : "to.be.hidden", "Locator expected to be visible", frameOptions);
String message = "Locator expected to be " + (visible ? "visible" : "hidden");
expectTrue(visible ? "to.be.visible" : "to.be.hidden", message, frameOptions);
}
private void expectTrue(String expression, String message, FrameExpectOptions options) {
playwright/src/test/java/com/microsoft/playwright/TestLocatorAssertions.java
+36
View File
@@ -673,6 +673,15 @@ public class TestLocatorAssertions extends TestBase {
assertThat(locator).isChecked(new LocatorAssertions.IsCheckedOptions().setChecked(false));
}
@Test
void isCheckedFalseFail() {
page.setContent("<input checked type=checkbox></input>");
Locator locator = page.locator("input");
AssertionFailedError error = assertThrows(AssertionFailedError.class,
() -> assertThat(locator).isChecked(new LocatorAssertions.IsCheckedOptions().setChecked(false).setTimeout(1000)));
assertTrue(error.getMessage().contains("Locator expected to be unchecked"), error.getMessage());
}
@Test
void isDisabledPass() {
page.setContent("<button disabled>Text</button>");
@@ -723,6 +732,15 @@ public class TestLocatorAssertions extends TestBase {
assertTrue(e.getMessage().contains("Locator expected to be editable"), e.getMessage());
}
@Test
void isEditableFalseFail() {
page.setContent("<input></input>");
Locator locator = page.locator("input");
AssertionFailedError error = assertThrows(AssertionFailedError.class,
() -> assertThat(locator).isEditable(new LocatorAssertions.IsEditableOptions().setEditable(false).setTimeout(1000)));
assertTrue(error.getMessage().contains("Locator expected to be readonly"), error.getMessage());
}
@Test
void notIsEditableFail() {
page.setContent("<input></input>");
@@ -839,6 +857,15 @@ public class TestLocatorAssertions extends TestBase {
assertThat(locator).isEnabled(new LocatorAssertions.IsEnabledOptions().setEnabled(false));
}
@Test
void isEnabledFalseFail() {
page.setContent("<button>Text</button>");
Locator locator = page.locator("button");
AssertionFailedError error = assertThrows(AssertionFailedError.class,
() -> assertThat(locator).isEnabled(new LocatorAssertions.IsEnabledOptions().setEnabled(false).setTimeout(1000)));
assertTrue(error.getMessage().contains("Locator expected to be disabled"), error.getMessage());
}
@Test
void isEnabledEventually() {
page.setContent("<button disabled>Text</button>");
@@ -949,6 +976,15 @@ public class TestLocatorAssertions extends TestBase {
assertTrue(e.getMessage().contains("Locator expected to be visible"), e.getMessage());
}
@Test
void isVisibleFalseFail() {
page.setContent("<input></input>");
Locator locator = page.locator("input");
AssertionFailedError error = assertThrows(AssertionFailedError.class,
() -> assertThat(locator).isVisible(new LocatorAssertions.IsVisibleOptions().setVisible(false).setTimeout(1000)));
assertTrue(error.getMessage().contains("Locator expected to be hidden"), error.getMessage());
}
@Test
void notIsVisibleFail() {
page.setContent("<input></input>");