fix(screencast): register AnnotatePosition enum serializer (#1948)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

.github/workflows/test.yml

@@ -30,7 +30,7 @@ jobs:
     steps:
     - uses: actions/checkout@v7
     - name: Set up JDK 1.8
-      uses: actions/setup-java@v5
+      uses: actions/setup-java@v5.6.0
       with:
         distribution: zulu
         java-version: 8
@@ -79,7 +79,7 @@ jobs:
         shell: powershell
         run: Install-WindowsFeature Server-Media-Foundation
       - name: Set up JDK 1.8
-        uses: actions/setup-java@v5
+        uses: actions/setup-java@v5.6.0
         with:
           distribution: zulu
           java-version: 8
@@ -110,7 +110,7 @@ jobs:
     steps:
       - uses: actions/checkout@v7
       - name: Set up JDK 21
-        uses: actions/setup-java@v5
+        uses: actions/setup-java@v5.6.0
         with:
           distribution: adopt
           java-version: 21

CONTRIBUTING.md

@@ -1,5 +1,20 @@
 # Contributing
 
+## Choosing an Issue
+
+To maintain project quality and focus, Playwright **requires a corresponding issue** for every contribution, with the exception of minor documentation fixes.
+
+If you would like to address a bug or feature that isn't currently listed, **please file a new issue first**. This allows the community and maintainers to provide early feedback and facilitates a discussion before you invest time in developing a pull request.
+
+When submitting an issue, please state clearly if you intend to work on it. Once triaged and approved, the maintainers will determine the best path forward—whether the task should be handled by the **core team**, an **automated agent**, or a **community contributor**. If the issue is assigned to you, you may then proceed with your changes and submit a PR.
+
+### Submission Policy
+To ensure the maintainability of the project, please note the following:
+
+* **Unsolicited PRs:** Pull requests submitted without a linked issue or prior approval will be closed.
+* **Low-Quality AI Contributions:** PRs that do not meet our quality standards or lack human oversight (including low-quality agentic submissions) will be closed without explanation.
+* **Approval Required:** Only proceed with a PR once the issue has been officially assigned to you or approved for community contribution.
+
 ## How to Contribute
 
 ### Installing Developer Tools

driver-bundle/pom.xml

@@ -16,6 +16,10 @@
     Node.js is preinstalled on the host (see PLAYWRIGHT_NODEJS_PATH).
   </description>
 
+  <properties>
+    <automatic.module.name>com.microsoft.playwright.driver.bundle</automatic.module.name>
+  </properties>
+
   <build>
     <plugins>
       <!-- The Node.js binaries for all platforms live in src/main/resources and must not

driver/pom.xml

@@ -16,6 +16,10 @@
     package; the Node.js binary comes from the driver-bundle module or a preinstalled Node.js.
   </description>
 
+  <properties>
+    <automatic.module.name>com.microsoft.playwright.driver</automatic.module.name>
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>org.junit.jupiter</groupId>

playwright/pom.xml

@@ -19,6 +19,10 @@
     This is the main package that provides Playwright client.
   </description>
 
+  <properties>
+    <automatic.module.name>com.microsoft.playwright</automatic.module.name>
+  </properties>
+
   <build>
     <plugins>
       <plugin>
@@ -37,6 +41,14 @@
             <goals>
               <goal>test-jar</goal>
             </goals>
+            <configuration>
+              <archive>
+                <manifestEntries>
+                  <!-- A name of its own, so the main jar and the test-jar never claim the same module. -->
+                  <Automatic-Module-Name>com.microsoft.playwright.test</Automatic-Module-Name>
+                </manifestEntries>
+              </archive>
+            </configuration>
           </execution>
         </executions>
       </plugin>

playwright/src/main/java/com/microsoft/playwright/impl/Serialization.java

@@ -45,6 +45,7 @@ class Serialization {
     .registerTypeAdapter(Date.class, new DateSerializer())
     .registerTypeAdapter(LocalDateTime.class, new LocalDateTimeSerializer())
     .registerTypeAdapter(SameSiteAttribute.class, new SameSiteAdapter().nullSafe())
+    .registerTypeAdapter(AnnotatePosition.class, new ToLowerCaseAndDashSerializer<AnnotatePosition>())
     .registerTypeAdapter(BrowserChannel.class, new ToLowerCaseAndDashSerializer<BrowserChannel>())
     .registerTypeAdapter(ColorScheme.class, new ToLowerCaseAndDashSerializer<ColorScheme>())
     .registerTypeAdapter(Contrast.class, new ToLowerCaseAndDashSerializer<Contrast>())

playwright/src/test/java/com/microsoft/playwright/TestScreencast.java

@@ -16,6 +16,7 @@
 
 package com.microsoft.playwright;
 
+import com.microsoft.playwright.options.AnnotatePosition;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
@@ -247,4 +248,21 @@ public class TestScreencast extends TestBase {
       context.close();
     }
   }
+
+  @Test
+  void screencastShowActionsShouldAcceptEveryPosition() throws Exception {
+    BrowserContext context = browser.newContext();
+    Page page = context.newPage();
+    try {
+      page.navigate(server.EMPTY_PAGE);
+      for (AnnotatePosition position : AnnotatePosition.values()) {
+        AutoCloseable disposable = page.screencast().showActions(
+          new Screencast.ShowActionsOptions().setPosition(position));
+        assertNotNull(disposable);
+        disposable.close();
+      }
+    } finally {
+      context.close();
+    }
+  }
 }

pom.xml

@@ -186,12 +186,15 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-jar-plugin</artifactId>
-          <version>3.5.0</version>
+          <version>3.5.1</version>
           <configuration>
             <archive>
               <manifest>
                 <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
               </manifest>
+              <manifestEntries>
+                <Automatic-Module-Name>${automatic.module.name}</Automatic-Module-Name>
+              </manifestEntries>
             </archive>
           </configuration>
         </plugin>

scripts/DRIVER_VERSION

@@ -1 +1 @@
-1.62.0
+1.62.1