Eric Mowry
1127096beb
Setting extendedconfigfile to the name of the VM so that when ESXi makes the vmxf it is named after the VM and ESXi will properly delete the file when the VM gets deleted.
2019-02-28 16:43:47 -05:00
Megan Marsh
49a6436c18
fix wording in changelog
2019-02-28 13:02:19 -08:00
Megan Marsh
7dbd42c7f3
update changelog
2019-02-28 11:50:39 -08:00
Megan Marsh
1e47421ba1
Merge pull request #7351 from hashicorp/move_pause_before_connection
...
move pause to after connection can be established.
2019-02-28 10:56:11 -08:00
Stephen Fox
56c17941fe
Added comment to authorized_keys 'sed' calls per review.
2019-02-28 10:54:14 -05:00
Stephen Fox
856810e82e
Coalesce private key type switch cases per review feedback.
2019-02-28 09:56:11 -05:00
Stephen Fox
672b22bd13
Move 'CreateKeyPairConfig' closer to callers.
...
Per review feedback.
2019-02-28 09:44:25 -05:00
Stephen Fox
302828905d
Move 'FromPrivateKeyConfig' closer to caller.
...
Per review feedback.
2019-02-28 09:42:20 -05:00
Stephen Fox
ed06656613
Update 'authorizedKeysLine' doc per review feedback.
2019-02-28 09:40:00 -05:00
Stephen Fox
415ef26768
Removed TODO about key pair description per review feedback.
2019-02-28 09:30:30 -05:00
Adrien Delorme
22df491c67
mock tty using interfaces to test more easily
2019-02-28 14:40:55 +01:00
Chris Marget
0f1bde760c
Merge pull request #4 from stephen-fox/refactor-ssh-key-pair-logic
...
Initial take on code review feedback from @azr.
2019-02-27 17:05:44 -05:00
Brendan Devenney
328cbf4e42
Merge branch 'master' into feature/7322
2019-02-27 19:29:18 +00:00
Adrien Delorme
7f5c794e5f
add go-tty vendor
2019-02-27 17:01:02 +01:00
Adrien Delorme
239a0c633f
use go-tty in ui.Ask to fix #7299
2019-02-27 16:59:59 +01:00
Adrien Delorme
c588a8a24d
Revert "cheggaaa.pb: try to not open tty at init to see if it causes #7299 "
...
This reverts commit 4e55278839 .
2019-02-27 16:52:55 +01:00
Adrien Delorme
f535464097
up a test
2019-02-27 11:17:56 +01:00
Adrien Delorme
f03cbd8a10
aws: allow to pass nil bool as encryption parameter
...
to retain current encryption settings
this changes the fields :
* ami_config.encrypt_boot
* block_device.encrypted
This also removes StepCreateEncryptedAMICopy as this step is now done in StepAMIRegionCopy
2019-02-27 11:17:56 +01:00
Adrien Delorme
ce8532e94b
aws: document ValidateRegion better
2019-02-27 11:17:08 +01:00
Adrien Delorme
6af621c37a
aws: StepAMIRegionCopy call waitgroup.add only once
2019-02-27 11:17:08 +01:00
Adrien Delorme
0e8afa37d5
Merge pull request #7347 from amphied/master
...
Fix support for aws-us-gov
2019-02-27 10:57:53 +01:00
Michael F
01a0b0c766
kmsArnStartPattern - fix support for aws-us-gov
...
While the `kmsArnStartPattern` regexp supports `us-gov` as a region, it does not take the AWS partition into consideration.
For more info see https://docs.aws.amazon.com/govcloud-us/latest/ug-east/using-govcloud-arns.html
Added test case for AWS partition us-gov as well as a negative test case for a non-existing AWS partition.
2019-02-26 16:54:54 -08:00
Megan Marsh
9db844a807
move pause to after connection can be established.
2019-02-26 12:24:45 -08:00
Megan Marsh
b8510f35fc
Merge pull request #7330 from hashicorp/except_post_processor_tests
...
name a post-processor to it's type when it is not named
2019-02-26 09:26:17 -08:00
Adrien Delorme
cc2e30826b
Merge pull request #7344 from ad-m/patch-1
...
Add hyperone builder to CHANGELOG.md
2019-02-26 16:16:59 +01:00
Adrien Delorme
4e55278839
cheggaaa.pb: try to not open tty at init to see if it causes #7299
2019-02-26 11:55:39 +01:00
Adrien Delorme
b32449cdcc
Merge pull request #7336 from dkuntz2/make-private-ip-fixer-error-more-clearly
...
Make the amazon-private-ip fixer errors more visible
2019-02-26 09:47:31 +01:00
Megan Marsh
674ff489a9
Merge pull request #7343 from hashicorp/fix_6369
...
move snapshot deletion to cleanup; this allows people with tag-specif…
2019-02-25 17:50:14 -08:00
Megan Marsh
026e543b24
move snapshot deletion to cleanup; this allows people with tag-specific permissions to perform snapshot deletion operation
2019-02-25 17:01:19 -08:00
Stephen Fox
2ef6b9247d
Initial take on code review feedback from @azr.
...
Do not use builder pattern or interfaces; stick to structs and
some basic functions.
2019-02-25 17:16:24 -05:00