There is some logic around how EBS mappings are handled / generated depending
on whether an image if from scratch or not. There was no testing around
this behaviour before. This strips that logic out into a separate function,
to enable testing it independentlhy.
Right now, if we have a source image that's PV, and try to build an
image with mount_partition set to not 0, it does not get picked up.
This is because under PV we only had a filesystem, not partitions,
but you can convert a PV image to an HVM image during build time.
At present, when using the packer fix command on a template that has
"ssh_private_ip" set to anything but a boolean value, the fixer will
fail, and appear to fail silently, simply returning a non-zero status
code without any message.
To determine what happened, users have to know to set PACKER_LOG=1 to
make the log message visible.
So far as I can tell, this is the only instance of log.Fatalf being
called, and based on the surrounding code the better solution would be
to return an error, which will then be visible to users of packer fix
without having to look in the logs.
The example and description of pairing `vsphere` and `vsphere-template` in a JSON array is accurate but ought to be more spelled out.
This introduces a change which makes that part of the example and docs more verbose, hopefully mitigating potential confusion.
Megan Marsh
Don Kuntz
Adam Dobrawy
Sargun Dhillon
Adrien Delorme
Adrien Delorme
Miłosz Smółka
Brendan Devenney
gregorybrzeski
lrxcy
bozhi.ch
Joel Lopes
Elijah Caine M. Voigt