build: remove ivy JIT mode (#26863)

PR Close #26863

.circleci/config.yml

@@ -116,21 +116,6 @@ jobs:
             - "~/bazel_repository_cache"
 
   # Temporary job to test what will happen when we flip the Ivy flag to true
-  test_ivy_jit:
-    <<: *job_defaults
-    resource_class: xlarge
-    steps:
-      - checkout:
-          <<: *post_checkout
-      - restore_cache:
-          key: *cache_key
-      - *define_env_vars
-      - *setup_circleci_bazel_config
-      - *yarn_install
-      - *setup_bazel_remote_execution
-
-      - run: yarn test-ivy-jit //...
-
   test_ivy_aot:
     <<: *job_defaults
     resource_class: xlarge
@@ -416,7 +401,6 @@ workflows:
     jobs:
       - lint
       - test
-      - test_ivy_jit
       - test_ivy_aot
       - build-packages-dist
       - test_aio
@@ -454,7 +438,6 @@ workflows:
           requires:
             # Only publish if tests and integration tests pass
             - test
-            - test_ivy_jit
             - test_ivy_aot
             - integration_test
             # Only publish if `aio`/`docs` tests using the locally built Angular packages pass

package.json

@@ -26,8 +26,6 @@
     "update-webdriver": "webdriver-manager update --gecko false $CHROMEDRIVER_VERSION_ARG",
     "check-env": "gulp check-env",
     "commitmsg": "node ./scripts/git/commit-msg.js",
-    "test-ivy-jit": "bazel test --define=compile=jit --build_tag_filters=-no-ivy-jit,-fixme-ivy-jit --test_tag_filters=-no-ivy-jit,-fixme-ivy-jit",
-    "test-fixme-ivy-jit": "bazel test --define=compile=jit --build_tag_filters=-no-ivy-jit --test_tag_filters=-no-ivy-jit",
     "test-ivy-aot": "bazel test --define=compile=aot --build_tag_filters=-no-ivy-aot,-fixme-ivy-aot --test_tag_filters=-no-ivy-aot,-fixme-ivy-aot",
     "test-fixme-ivy-aot": "bazel test --define=compile=aot --build_tag_filters=-no-ivy-aot --test_tag_filters=-no-ivy-aot",
     "bazel": "bazel"
@@ -144,4 +142,4 @@
     "vrsource-tslint-rules": "5.1.1",
     "webpack": "1.12.9"
   }
-}
+}

packages/bazel/test/ng_package/BUILD.bazel

@@ -26,7 +26,6 @@ jasmine_node_test(
     ],
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
 )
 

packages/common/http/test/BUILD.bazel

@@ -21,7 +21,6 @@ jasmine_node_test(
     bootstrap = ["angular/tools/testing/init_node_spec.js"],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",
@@ -33,7 +32,6 @@ ts_web_test_suite(
     name = "test_web",
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/common/test/BUILD.bazel

@@ -23,7 +23,6 @@ jasmine_node_test(
     bootstrap = ["angular/tools/testing/init_node_spec.js"],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",
@@ -35,7 +34,6 @@ ts_web_test_suite(
     name = "test_web",
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/compiler-cli/integrationtest/bazel/injectable_def/app/BUILD.bazel

@@ -13,7 +13,6 @@ ng_module(
     module_name = "app_built",
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
     deps = [
         "//packages/compiler-cli/integrationtest/bazel/injectable_def/lib2",

packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel

@@ -12,7 +12,6 @@ ts_library(
     ),
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
     deps = [
         "//packages/compiler-cli/integrationtest/bazel/injectable_def/app",
@@ -27,7 +26,6 @@ jasmine_node_test(
     bootstrap = ["angular/tools/testing/init_node_spec.js"],
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel

@@ -21,7 +21,6 @@ jasmine_node_test(
     bootstrap = ["angular/tools/testing/init_node_spec.js"],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel

@@ -12,7 +12,6 @@ ng_module(
     node_modules = "@ngdeps//typescript:typescript__typings",
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
     deps = [
         "//packages/core",
@@ -36,6 +35,5 @@ jasmine_node_test(
     data = [":flat_module_index"],
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
 )

packages/compiler-cli/test/BUILD.bazel

@@ -44,7 +44,6 @@ jasmine_node_test(
     ],
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
     deps = [
         ":extract_i18n_lib",
@@ -82,7 +81,6 @@ jasmine_node_test(
     ],
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
     deps = [
         ":ngc_lib",
@@ -117,7 +115,6 @@ jasmine_node_test(
     ],
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
     deps = [
         ":ngtools_api_lib",

packages/compiler-cli/test/diagnostics/BUILD.bazel

@@ -39,7 +39,6 @@ jasmine_node_test(
     ],
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
     deps = [
         ":check_types_lib",
@@ -73,7 +72,6 @@ jasmine_node_test(
     ],
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
     deps = [
         ":expression_diagnostics_lib",

packages/compiler-cli/test/transformers/BUILD.bazel

@@ -27,7 +27,6 @@ jasmine_node_test(
     ],
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/compiler/test/BUILD.bazel

@@ -76,7 +76,6 @@ jasmine_node_test(
     ],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",
@@ -92,7 +91,6 @@ ts_web_test_suite(
     name = "test_web",
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/core/test/BUILD.bazel

@@ -53,7 +53,6 @@ jasmine_node_test(
     bootstrap = ["angular/tools/testing/init_node_spec.js"],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",
@@ -71,7 +70,6 @@ ts_web_test_suite(
     name = "test_web",
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/core/test/bundling/animation_world/BUILD.bazel

@@ -9,7 +9,6 @@ ng_module(
     srcs = ["index.ts"],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     type_check = False,  # see #26462
     deps = [
@@ -30,7 +29,6 @@ ng_rollup_bundle(
     entry_point = "packages/core/test/bundling/animation_world/index.js",
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         ":animation_world",
@@ -45,7 +43,6 @@ js_expected_symbol_test(
     tags = [
         "ivy-aot",
         "ivy-only",
-        "no-ivy-jit",
     ],
 )
 
@@ -60,6 +57,5 @@ http_server(
     ],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
 )

packages/core/test/bundling/hello_world/BUILD.bazel

@@ -9,7 +9,6 @@ ng_module(
     srcs = ["index.ts"],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         "//packages/core",
@@ -27,7 +26,6 @@ ng_rollup_bundle(
     entry_point = "packages/core/test/bundling/hello_world/index.js",
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         ":hello_world",
@@ -41,7 +39,6 @@ ts_library(
     srcs = glob(["*_spec.ts"]),
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         "//packages:types",
@@ -61,7 +58,6 @@ jasmine_node_test(
     ],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [":test_lib"],
 )
@@ -73,7 +69,6 @@ js_expected_symbol_test(
     tags = [
         "ivy-aot",
         "ivy-only",
-        "no-ivy-jit",
     ],
 )
 
@@ -86,6 +81,5 @@ http_server(
     ],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
 )

packages/core/test/bundling/hello_world_r2/BUILD.bazel

@@ -70,7 +70,6 @@ js_expected_symbol_test(
     golden = ":bundle.golden_symbols.json",
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
 )
 
@@ -83,6 +82,5 @@ http_server(
     ],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
 )

packages/core/test/bundling/injection/BUILD.bazel

@@ -11,7 +11,6 @@ ts_library(
     ],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         "//packages/core",
@@ -29,7 +28,6 @@ ng_rollup_bundle(
     entry_point = "packages/core/test/bundling/injection/index.js",
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         ":injection",
@@ -43,7 +41,6 @@ ts_library(
     srcs = glob(["*_spec.ts"]),
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         ":injection",
@@ -58,7 +55,6 @@ jasmine_node_test(
     name = "test",
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [":test_lib"],
 )
@@ -69,6 +65,5 @@ js_expected_symbol_test(
     golden = ":bundle.golden_symbols.json",
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
 )

packages/core/test/bundling/todo/BUILD.bazel

@@ -10,7 +10,6 @@ ng_module(
     srcs = ["index.ts"],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         "//packages/common",
@@ -30,7 +29,6 @@ ng_rollup_bundle(
     entry_point = "packages/core/test/bundling/todo/index.js",
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         ":todo",
@@ -46,7 +44,6 @@ ts_library(
     srcs = glob(["*_spec.ts"]),
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         "//packages:types",
@@ -67,7 +64,6 @@ jasmine_node_test(
     ],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [":test_lib"],
 )
@@ -79,7 +75,6 @@ js_expected_symbol_test(
     tags = [
         "ivy-aot",
         "ivy-only",
-        "no-ivy-jit",
     ],
 )
 
@@ -94,7 +89,6 @@ genrule(
     cmd = "cp $< $@",
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
 )
 
@@ -110,7 +104,6 @@ ts_devserver(
     ],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [":todo"],
 )
@@ -126,6 +119,5 @@ http_server(
     ],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
 )

packages/core/test/bundling/todo_r2/BUILD.bazel

@@ -10,7 +10,6 @@ ng_module(
     srcs = ["index.ts"],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         "//packages/common",
@@ -32,7 +31,6 @@ ng_rollup_bundle(
     entry_point = "packages/core/test/bundling/todo_r2/index.js",
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         ":todo",
@@ -50,7 +48,6 @@ ts_library(
     srcs = glob(["*_spec.ts"]),
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [
         "//packages:types",
@@ -73,7 +70,6 @@ jasmine_node_test(
     ],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [":test_lib"],
 )
@@ -85,7 +81,6 @@ js_expected_symbol_test(
     tags = [
         "ivy-aot",
         "ivy-only",
-        "no-ivy-jit",
     ],
 )
 
@@ -100,7 +95,6 @@ genrule(
     cmd = "cp $< $@",
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
 )
 
@@ -116,7 +110,6 @@ ts_devserver(
     ],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
     deps = [":todo"],
 )
@@ -132,6 +125,5 @@ http_server(
     ],
     tags = [
         "ivy-only",
-        "no-ivy-jit",
     ],
 )

packages/core/test/render3/BUILD.bazel

@@ -61,7 +61,6 @@ jasmine_node_test(
         "angular/packages/core/test/render3/load_domino",
     ],
     tags = [
-        "fixme-ivy-jit",
     ],
     deps = [
         ":render3_node_lib",
@@ -72,7 +71,6 @@ jasmine_node_test(
 ts_web_test_suite(
     name = "render3_web",
     tags = [
-        "fixme-ivy-jit",
     ],
     deps = [
         ":render3_lib",

packages/elements/test/BUILD.bazel

@@ -37,7 +37,6 @@ ts_web_test_suite(
     ],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     # do not sort
     deps = [

packages/forms/test/BUILD.bazel

@@ -20,7 +20,6 @@ jasmine_node_test(
     bootstrap = ["angular/tools/testing/init_node_spec.js"],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",
@@ -32,7 +31,6 @@ ts_web_test_suite(
     name = "test_web",
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/language-service/test/BUILD.bazel

@@ -24,7 +24,6 @@ jasmine_node_test(
     ],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/platform-browser-dynamic/test/BUILD.bazel

@@ -33,7 +33,6 @@ ts_web_test_suite(
     ],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/platform-browser/animations/test/BUILD.bazel

@@ -26,7 +26,6 @@ jasmine_node_test(
     bootstrap = ["angular/tools/testing/init_node_spec.js"],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",
@@ -38,7 +37,6 @@ ts_web_test_suite(
     name = "test_web",
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/platform-browser/test/BUILD.bazel

@@ -31,7 +31,6 @@ jasmine_node_test(
     bootstrap = ["angular/tools/testing/init_node_spec.js"],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",
@@ -46,7 +45,6 @@ ts_web_test_suite(
     ],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/platform-server/test/BUILD.bazel

@@ -27,7 +27,6 @@ jasmine_node_test(
     bootstrap = ["angular/tools/testing/init_node_spec.js"],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/platform-webworker/test/BUILD.bazel

@@ -31,7 +31,6 @@ ts_web_test_suite(
     name = "test_web",
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/private/testing/BUILD.bazel

@@ -18,7 +18,7 @@ ng_module(
 
 ## Controls if Ivy is enabled. (Temporary target until we permanently switch over to Ivy)
 ##
-## This file generates `src/bazel_define_compile_value.ts` file which reexports 
+## This file generates `src/bazel_define_compile_value.ts` file which reexports
 ## `--define=compile` value as `bazelDefineCompileValue` symbols so that runtime can detect
 ## which mode it is running in.
 ##

packages/private/testing/src/bazel_define_compile_value.ts

@@ -0,0 +1,12 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+/**
+ * This variable shows the `blaze --define=compile=` value to make it available to runtime.
+ */
+export const bazelDefineCompileValue = 'legacy';

packages/private/testing/src/fixme.ts

@@ -0,0 +1,22 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+import {bazelDefineCompileValue} from './bazel_define_compile_value';
+
+/**
+ * A global method which is used to conditionally block the execution of tests.
+ *
+ * ```
+ * fixmeIvy('some reason') && describe(...);
+ * ```
+ *
+ * The above will prevent the execution of the test(s) in Ivy mode, until they can be fixed.
+ */
+export function fixmeIvy(reason: string): boolean {
+  return 'aot' !== (bazelDefineCompileValue as string);
+}

packages/router/test/BUILD.bazel

@@ -25,7 +25,6 @@ jasmine_node_test(
     bootstrap = ["angular/tools/testing/init_node_spec.js"],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",
@@ -37,7 +36,6 @@ ts_web_test_suite(
     name = "test_web",
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/router/test/aot_ngsummary_test/BUILD.bazel

@@ -18,7 +18,6 @@ ts_library(
     srcs = ["aot_router_bootstrap.spec.ts"],
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
     deps = [
         ":aot_routing_module",
@@ -34,7 +33,6 @@ jasmine_node_test(
     bootstrap = ["angular/tools/testing/init_node_spec.js"],
     tags = [
         "fixme-ivy-aot",
-        "no-ivy-jit",
     ],
     deps = [
         ":aot_test_lib",

packages/router/upgrade/test/BUILD.bazel

@@ -17,7 +17,6 @@ ts_web_test_suite(
     name = "test_web",
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",

packages/upgrade/test/BUILD.bazel

@@ -24,7 +24,6 @@ ts_web_test_suite(
     ],
     tags = [
         "fixme-ivy-aot",
-        "fixme-ivy-jit",
     ],
     deps = [
         ":test_lib",