builder/azure/arm: Update domain for self-signed certs

remove docs about windows symlinks which are now inaccurage

CHANGELOG.md

@@ -52,6 +52,8 @@
     [GH-8828]
 * builder/vsphere-clone: Fix issue preventing the cloning of VMs with the same
     name in different folders [GH-8938]
+* builder/vsphere-iso: Fix issue preventing the creation of VMs with the same
+    name in different folders [GH-8938]
 * builder/vsphere: Fix network object interface panic. [GH-8753]
 * core/hcl2: Fix crash when an unset variable is used [GH-8837]
 * core/hcl2: Fix logic for parsing literal value variables [GH-8834]

builder/azure/arm/config.go

@@ -463,8 +463,8 @@ func (c *Config) createCertificate() (string, error) {
 		err = fmt.Errorf("Failed to Generate Private Key: %s", err)
 		return "", err
 	}
-
-	host := fmt.Sprintf("%s.cloudapp.net", c.tmpComputeName)
+	normalizedLocation := strings.ToLower(strings.ReplaceAll(c.Location, " ", ""))
+	host := fmt.Sprintf("%s.%s.cloudapp.azure.com", c.tmpComputeName, normalizedLocation)
 	notBefore := time.Now()
 	notAfter := notBefore.Add(24 * time.Hour)
 

common/iso_config.go

@@ -25,11 +25,6 @@ import (
 // * HTTP
 // * Amazon S3
 //
-//
-// \~> On Windows, using a symlink to refer to local files is currently
-// unsupported. Packer will always copy a local iso into the Packer cache
-// directory.
-//
 // Examples:
 // go-getter can guess the checksum type based on `iso_checksum` len.
 //

version/version.go

@@ -9,12 +9,12 @@ import (
 var GitCommit string
 
 // The main version number that is being run at the moment.
-const Version = "1.5.5"
+const Version = "1.5.6"
 
 // A pre-release marker for the version. If this is "" (empty string)
 // then it means that it is a final release. Otherwise, this is a pre-release
 // such as "dev" (in development), "beta", "rc1", etc.
-const VersionPrerelease = ""
+const VersionPrerelease = "dev"
 
 func FormattedVersion() string {
 	var versionString bytes.Buffer

website/source/partials/common/_ISOConfig.html.md

@@ -12,10 +12,6 @@ go-getter supports the following protocols:
 * HTTP
 * Amazon S3
 
-\~> On Windows, using a symlink to refer to local files is currently
-unsupported. Packer will always copy a local iso into the Packer cache
-directory.
-
 Examples:
 go-getter can guess the checksum type based on `iso_checksum` len.